[00:55:10] Reedy, Oh shucks! i just tested the other themes to see if they show the $wgSkinMetaTags metadata, and nope! I even searched through MediaWiki 1.37.1 for instances of wgSkinMetaTags and I only see two matches: HISTORY file and includes/DefaultSettings.php and nothing seems to actually use the variable otherwise. [01:00:46] I have files for skins Citizen, Cosmos, DarkVector, MonoBook, Poncho, Timeless, Vector, and WPTouch and none of them mention the variable [01:02:46] but with statement "Use this setting only if you don't have an extension installed that already provides those meta tags." it probably should not be the responsibility of the theme to handle this variable too, but it's not mentioned anywhere in the codebase other than DefaultSettings.php [01:06:44] Even this shows only 1 match https://github.com/wikimedia/mediawiki/search?q=wgSkinMetaTags [01:18:15] Alternatively, I see includes/skins/Skin.php mentions variable $skinMetaTags [01:18:21] so maybe that is another bug? [01:29:15] Oh actually, $this->getConfig()->get( 'SkinMetaTags' ) // this has the value of $wgSkinMetaTags, so......... [01:34:12] I was just going to say that, haha [01:47:06] Reedy, I found the actual bug! in_array searches for VALUES of array, not the KEYS. Use array_key_exists instead. [01:49:39] ryzenda: I don't think you're correct [01:49:40] >Accepted values are "og:title", "og:type" and "twitter:card". [01:49:50] !wg SkinMetaTags [01:49:50] https://www.mediawiki.org/wiki/Manual:%24wgSkinMetaTags [01:50:16] It doesn't say to use array keys [01:51:24] https://php.net/manual/en/function.in-array.php in_array — Checks if a value exists in an array [01:51:47] in_array(mixed $needle, array $haystack, bool $strict = false): bool [01:51:47] if ( array_key_exists( $key, $skinMetaTags ) ) { [01:52:08] check if $needle ( $key) exists in $haystack ($skinMetaTags) [01:52:14] the $key is one of "og:title" or "twitter:card" or "og:type" but [01:52:49] but in_array checks to see if $key is matching one of the values (not the keys) in $skinMetaTags [01:53:03] array_key_exists() - Checks if the given key or index exists in the array [01:53:06] No [01:53:13] scroll down in https://php.net/manual/en/function.in-array.php [01:53:23] The default is $wgSkinMetaTags = []; [01:53:25] Are you sure? Cuz I just edited the code and verified this myself [01:53:27] if you want to add anything to it, use [01:53:35] $wgSkinMetaTags = [ "og:title" ]; [01:53:47] in_array is the wrong PHP function. It should be array_key_exists [01:53:53] No it shouldn't [01:54:02] Test it to see for yourself? [01:54:12] the array keys for $wgSkinMetaTags are going to be the numeric indexes [01:54:19] if we were telling you to do... [01:54:22] $wgSkinMetaTags = [ "og:title" => true ]; [01:54:24] sure [01:54:28] well then maybe I set the value of the array variable wrong. [01:54:47] That's what it sounds like [01:55:12] cuz I put $wgSkinMetaTags = ['og:title' => 'MOASSpedia','og:type' => 'website']; [01:55:45] The values that get used are defined https://github.com/wikimedia/mediawiki/blame/master/includes%2Fskins%2FSkin.php#L310-L314 [01:56:07] * Reedy looks what $out->getHTMLTitle() uses [01:59:54] Likely something to do with whatever the current page title is [02:00:19] Alright, I changed to use $wgSkinMetaTags = ['og:title','og:type']; and now it works [02:00:29] so I was wrong the wrong way,lol [02:01:08] and to confirm, the DarkVector theme works, unlike what I said earlier [02:01:27] I see the metadata now in DarkVector [02:02:48] as a suggestion, it might be convenient to check for keys too, in case of configuring the variable like I did, but then again, I am probably the only person who made this mistake, [02:05:02] I suspect better documentation is worth it [06:51:18] Can anyone guide me on how to edit the CSS of OOUI widgets? Any documentation or resources? [16:32:35] How do I dewikipediafy these 8,000+ templates/modules so that they don't include Wikipedia things? For example https://dev.moasspedia.org/wiki/Template:Reflist mentions "This template is used on approximately 5,580,000 pages, or roughly 32922% of all pages." and I don't need to include those kinds of things. [16:39:48] Edit the template that's adding it :P [16:43:03] This tutorial has a brief example of editing OOUI CSShttps://doc.wikimedia.org/oojs-ui/master/demos/tutorials/collection/basics1/contents.html and part 2: https://doc.wikimedia.org/oojs-ui/master/demos/tutorials/collection/basics2/contents.html [16:43:54] corrected link: https://doc.wikimedia.org/oojs-ui/master/demos/tutorials/collection/basics1/contents.html [16:50:36] Dewikipediafy: Strip all */doc articles from the export (anything else to exclude also?) [17:04:21] I'm writing a bash script to "dewikipediafy" exports since I can't find any existing dewikipediafication procedures shared by others. Is there a place that would be useful that I can share it later? [17:04:28] You can't dewikipediafy wikipedia templates unless you rewrite them from scratch, or oversimplify them a lot [17:05:17] For example, I am stripping all the */doc articles, as the first step, because I do not need any of those [17:48:18] ryzenda: it's probably not what you want - but rule #1 of dewikipediafying templates is simple: "don't export anything from (a) Wikipedia" [17:49:34] I'm not quite sure even how or why enwikipedia's templates and the like are a thing but chances are that for 99% of reusers -- the regular folks who are looking to build *a* wiki of their own, not to build *a 1:1 mirror of a wikipedia* -- the wikipedia templates are way too complex for no real reason [17:49:58] reflist and such super popular templates will more than likely exist somewhere off-wikipedia in a much more easily reusable format [18:17:06] strongly agreed [18:17:37] if you really have to copy, get the version from prior to the lua transition, and preferably before one of the "template engineers" got to it [19:39:51] dont know if this is the right channel to ask [19:40:13] but is it possible to embed a kiwi irc widget into a wikimedia page? [19:40:32] when i attempt it, the iframe shows as text [19:42:26] oh, nm i need an extension [23:21:16] I submitted a patch to Gerrit, am I supposed to manually add jenkins-bot as a reviewer? [23:22:20] coldstone, the automated tests won't run automatically unless you're on the list of trusted contributors. [23:22:39] I can run them for you though, what's the patch? [23:22:48] Oh [23:22:56] https://gerrit.wikimedia.org/r/c/mediawiki/vagrant/+/768156 [23:23:02] thank you much [23:24:12] they're running now, once it finishes jenkins-bot will report on the task. [23:24:39] awesome