[00:05:49] After testing older and newer version was told to do a bug report. But getting either a oom from php-fpm or gpf_mask oom with the 1.37 version of mw [00:06:06] Wonder how better to trace the php mediawiki bug [00:06:21] Happens anytime I try to save an edit [00:07:21] But saving an edit ramps up and runs the system out of memory until the process crashes out [00:09:03] Nothing in the php error logs. Only in messages. [00:27:42] php 7.3 worked 7.4 did not work [00:28:04] PHP 7.3.33 (cli) (built: Mar 17 2022 01:06:45) ( NTS ) worked [00:28:24] PHP 7.4.28 (cli) (built: Mar 18 2022 20:43:43) ( NTS ) did not work [00:33:29] I had read saying dont use php 7.2 and below use 7.3 and higher, but 28 is well above 2 and 3, did they mean 30 [00:33:45] sorry 7.4.2 7.2.3 [00:33:49] dho [00:34:06] 7.4 version increments 2 were bad, but 3 and above [02:12:22] out until sometime later. [10:55:17] I have mw-content-ltr and dir="ltr" in the code blocks, but they still get text-align: right, if I change to and RTL language: https://wiki.documentfoundation.org/Macros/Basic/Base/fa [10:55:32] Using this extension which I sent patches to https://github.com/InternationalScratchWiki/SyntaxHighlight_PrismJS/pull/4 [10:55:46] What is still missing to make MW stop adding those text-aligns? [11:00:18] I've studied https://www.mediawiki.org/wiki/Directionality_support [11:00:41] I don't have access to the filesystem, so couldn't test by patching directly [11:19:11] buovjaga: where do you see text-align: right applied on those code blocks? I see the text left-aligned, and inspecting the element with the browser developer tool I don't see text-align: right applied [11:26:37] I think it's the Wikitext code editor, trying to submit CSS -> background-color: unset; <- (or "initial" instead of "unset") shows incorrect warning: "Warning: Expected ( | inherit) but found 'unset'." [11:29:14] I think you can ignore the warning and save the edit anyway. That's the library that's not updated in a while [13:02:23] Vulpix: did you change the MW language to Farsi for example? [13:03:08] it's strange because the Pygments-based extension works fine, I can change to Farsi on this page https://www.mediawiki.org/wiki/Extension:SyntaxHighlight and the code blocks don't get any text-align: right [13:06:39] Hmmm, ok, I see it now if adding ?uselang=fa [13:08:47] buovjaga: Looks like documentfoundation wiki is using a different syntaxhighligh version: https://wiki.documentfoundation.org/Special:Version [13:08:51] It uses SyntaxHighlight_PrismJS [13:09:26] Vulpix: yep. Like I said: Using this extension which I sent patches to https://github.com/InternationalScratchWiki/SyntaxHighlight_PrismJS/pull/4 [13:09:39] so I'm just scratching my head on what patch to write next [13:10:12] we discovered Pygments was DoSing our own server, so switched to this nicer one [13:11:55] Ok, so if you submitted a patch, maybe someone needs to update that extension on the server [13:12:20] yeah, it's updated [13:12:39] the addition was mw-content-ltr but it did not help [13:20:19] buovjaga: Ok, the CSS being applied is here: https://github.com/InternationalScratchWiki/SyntaxHighlight_PrismJS/blob/main/resources/prism.css#L14 - see the text-align: left? This gets flipped when content is rtl https://www.mediawiki.org/wiki/ResourceLoader/Architecture#Flipping [13:20:47] aaah so the evil thing is to set that rule at all! thanks! [13:21:36] patching time :) [13:21:41] You'll need to add a /* @noflip */ comment before the text-align, or on the entire rule [13:21:51] *selector [13:22:51] thanks for pointing that out, too [13:26:42] patchy patch https://github.com/InternationalScratchWiki/SyntaxHighlight_PrismJS/pull/7