[04:37:35] <bawolff>	 Woah, a wild ^demon appears :)
[14:27:46] <Lens0021>	 where do I know what version of Node is used for RESTBase of Wikimedia prod?
[14:40:05] <taavi>	 Lens0021: node 10
[14:41:41] <Vulpix>	 Is WMF really using node 10 now for RESTBase? It was using 6.17.1 like a year ago
[14:47:41] <AntiComposite>	 should be, it's on buster now
[14:48:35] <Lens0021>	 um, sorry I had to ask for Mathoid
[14:48:58] <Lens0021>	 though RESTBase is interesting
[14:49:24] <Lens0021>	 (*version of Node RESTBase is on)
[14:52:18] <Vulpix>	 Mathoid is running node 10 last time I checked. However, I haven't been able to complete npm install on it recently. There seems to be some broken dependencies.
[14:53:23] <Lens0021>	 That seems to be what I've faced
[14:54:15] <Lens0021>	 I've given "error commander@9.2.0: The engine "node" is incompatible with this module. Expected version "^12.20.0 || >=14". Got "10.24.1""
[14:55:22] <Vulpix>	 Hopefully, I had an old working install, and I just copied the entire folder to the server
[14:57:17] <Vulpix>	 You can be adventurous and try with node 14
[14:58:26] <Vulpix>	 Although it was failing on node 12 when I last checked, a year ago... https://www.mediawiki.org/w/index.php?title=Manual:Mathoid&diff=4537303&oldid=4123754
[14:58:31] <Lens0021>	 Thank you, I will try out 14 or later versions
[15:00:33] <Lens0021>	 node services seem to have been abandoned for a long time though they are used in production.
[15:00:43] <Lens0021>	 Sad
[15:02:18] <Vulpix>	 indeed
[17:49:55] <ryzenda>	 MediaWiki needs a native way to inject <script type="module">...</script> JS code into a single script statement for scripts that require access to the scope. If I understand correctly, JS script outside of the <script type="module">...</script> container are not able to access or interact with the JS code nor get or set anything
[17:50:41] <ryzenda>	 I am currently using $out->addScript() 
[18:50:12] <ashley>	 ryzenda: what extension/skin/etc./do you have some code I can take a look at?
[19:03:18] <ryzenda>	 ashley, I just prepared a git repo https://github.com/jasonkhanlar/mediawiki-extensions-PhotoSwipe
[19:05:17] <ryzenda>	 Als note that I didn't really prepare documentation to explain the idea I had in mind for implementation, but I'll work on that later
[19:05:38] <ashley>	 PhotoSwipe, eh? ;) wikiHow's using that! (but it's kinda...not a very clean implementation, no)
[19:06:06] <ashley>	 but first questions first: what's wrong with [[mw:Extension:MultimediaViewer]]? it's used on Wikimedia wikis and a lot of other sites
[19:11:48] <ryzenda>	 ashley, I will look at MultimediaViewer again to refresh myself with it, but I think I couldn't use it because on my mediawiki site I have uploads disabled, and am using external hotlinked images and media sources. e.g. typing the URL to an image in wikitext automatically converts it to an <IMG> element
[19:14:45] <ryzenda>	 also, before I stumbled upon PhotoSwipe, I was searching through dozens of JS library gallery scripts besides PhotoSwipe, and trying to find one that I liked, worked as I expected, and had recent developments as well as lots of community following, and that was practically the only one I found so far that matched my criteria
[19:15:45] <ryzenda>	 PhotoSwipe appears to be a bit strange too, not exactly my ideal, but when it works, it seems quite fast and efficient for end user, just a bit difficult for developing with
[19:23:26] <ashley>	 I wonder if Krinkle would have some thoughts on this as the resident JS expert :)
[19:24:29] <Krinkle>	 "If I understand correctly, JS script outside of the <script type="module">...</script> container are not able to access or interact with the JS code"
[19:24:40] <Krinkle>	 To my knowledge and in the way I interpret this - this is incorrect.
[19:25:19] <Krinkle>	 The only thing that type=module does is 1) defer execution to DOMContentLoaded, much like wrapping the contents in $(document).ready(function() { ... } ) would, and 2) it enables use of the `import` keyword as a more declarative way of loading other JS files.
[19:25:31] <Krinkle>	 It in no way sandboxes or reduces scope or visiblity.
[19:27:34] <Krinkle>	 For reasons of performance, correctness (version integrity), and localisation for langauge and skin, MediaWiki has not encouraged the raw and unprocessed loading of code for some time.  One shoudl generally register such code with ResourceLoader as a module bundle instead, and load it with $outputPage->addModules() https://www.mediawiki.org/wiki/ResourceLoader
[19:28:03] <Krinkle>	 This avoids e.g. mixing incompatible versions of scripts and ensures optimal caching and fragmentation/invalidation of that same cache.
[19:28:14] <ryzenda>	 I was looking at addModules quite a bit,however, the PhotoSwipe library is ES6 and requires import statements
[19:28:27] <ryzenda>	 and it appears that addModules does not provide a way to inject a <script> with type="module"
[19:28:31] <Krinkle>	 Ack, we use the CommonJS standard instead.
[19:28:48] <Krinkle>	 When it is code you don't control, there is generally a cjs distribution you can embed instead of the esm distribution.
[19:29:03] <ryzenda>	 generally, yeah, in this case,it seems not
[19:30:52] <Krinkle>	 ryzenda: https://github.com/dimsemenov/PhotoSwipe/issues/1892
[19:31:17] <ryzenda>	 Also, I have not been studying and researching paying attention to the flow of technological development in terms of the standards and destroying the portability and interoperability gradually over time, so I am not really sure if this situation is perhaps related to that or whatnot, but otherwise I haven't delved into exploring whether ES6 is good or bad, or whatnot
[19:36:56] <Krinkle>	 ryzenda: as a workaround, you could check in the dist/esm.js file and run esbuild on it or smth, and use that copy instead.
[19:40:20] <Krinkle>	 `esbuild --bundle --target=es2015 --format=cjs photoswipe-lightbox.esm.js`
[19:40:31] <Krinkle>	 This produces a file that you could require('./') from your module, for example.
[19:40:42] <Krinkle>	 Note that we do support ES6, just not the ES2020 export/import syntax.
[19:46:55] <Krinkle>	 e.g. `curl 'https://raw.githubusercontent.com/dimsemenov/PhotoSwipe/v5.2.2/dist/photoswipe-lightbox.esm.js' | esbuild --target=es2015 --format=cjs --bundle --outfile=modules/ext.photoSwipe/lib/photoswipe-lightbox.cjs.js` from your package.json#scripts.build-lib
[19:47:21] <ryzenda>	 I suppose, however, the order in which I began tinkering with PhotoSwipe to try to get it to work, was using a CDN, and JSDelivr was practically the first I started using, but also there's potentially CDNJS and Unpkg, each of which are probably unable to provide the esbuild variation of the libraries automatically. 
[19:47:30] <Krinkle>	 then import using https://www.mediawiki.org/wiki/ResourceLoader/Package_files
[19:48:27] <Krinkle>	 I'd recommend against using a CDN in the actual code. It's just more privacy/security/availability reduction for no gain other than saving a few seconds the first time you set it up, (althoguh even that depends on what you're used to I guess :) )
[19:48:31] <ryzenda>	 I'm also tinkering with preparing a locally deployed release of the photoswipe js libraries too,so I'll see if I can get it to convert to ES2015
[19:49:11] <Krinkle>	 with the above command you'd be good to go and can `var Photoshipe = require('./lib/photoswipe-lightbox.cjs.js')` from your JS code.
[19:49:32] <Krinkle>	 Good luck :)
[19:50:49] <ryzenda>	 oh, also I've been trying to figure out (asked on Discord) what is the correct place to store downloaded PhotoSwipe JS library files in an extension directory?  I currently am using https://dpaste.org/AX1s5
[19:50:57] <ryzenda>	 oh, actually, it's in the github repo too now
[20:44:43] <ryzenda>	 ashley, I added some documentation to https://github.com/jasonkhanlar/mediawiki-extensions-PhotoSwipe/#mediawiki-extensions-photoswipe that should help to explain a little bit the idea I had in mind when preparing the dev code base environment
[20:59:40] <ashley>	 awesome :D always good to have docs!