[00:05:55] Is this valid CSS? https://github.com/wikimedia/mediawiki/blob/master/resources/lib/ooui/oojs-ui-core-wikimediaui.css#L146 W3C CSS Validator complains about this. [00:06:22] Also I just manually tested trying to use that CSS background-color value and it didn't work [00:06:43] Here is example of errors: https://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Fmoasspedia.org%2Fwiki%2FList_of_ape-made_github_repos%3Fdebug%3Dtrue&profile=css3svg&usermedium=all&warning=1&vextwarning=&lang=en [00:07:25] Same issue with line 168 https://github.com/wikimedia/mediawiki/blob/master/resources/lib/ooui/oojs-ui-core-wikimediaui.css#L155 [00:08:03] Also error on line 1399 https://github.com/wikimedia/mediawiki/blob/master/resources/lib/ooui/oojs-ui-core-wikimediaui.css#L1399 [00:08:41] and the line after [00:10:08] I imgine MW doesn't use the lines directly [00:10:21] It probably will be transformed/minified via ResourceLoader [00:10:31] Which may include doing that math and resolving [00:10:48] My website is returning those values as output to render client-side [00:11:24] Even when I remove the ?debug=true same issues https://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Fmoasspedia.org%2Fwiki%2FList_of_ape-made_github_repos&profile=css3svg&usermedium=all&warning=1&vextwarning=&lang=en [00:12:27] Therefore I believe your imagination is possibly not matching the reality (or otherwise I am wrong and I am not seeing the imagination, lol) [00:13:17] "does it work on wikipedia?" [00:13:19] Perhaps shall I submit this as a bug report on Phabricator? [00:13:21] (I haven't checked) [00:13:27] I'll check there too [00:13:46] Even if it does work on Wikipedia, that doesn't mean that it's not a bug, ofc [00:14:21] No errors found on Wikipedia! https://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Fen.wikipedia.org%2F%3Fdebug%3Dtrue&profile=css3svg&usermedium=all&warning=1&vextwarning=&lang=en [00:14:35] is that CSS being loaded though? [00:14:55] ah right, let me figure out if I can find a way to trigger it. [00:15:03] I don't know how to do this yet, so I'll be a while [00:15:28] wikipedia mainpage does seem to have oo-ui-buttonElement-frameless.oo-ui-widget-enabled in a minified blob [00:16:30] .oo-ui-buttonElement-frameless.oo-ui-widget-enabled > .oo-ui-buttonElement-button:hover{background-color:rgba(0,24,73,7/255);color:#000} [00:16:33] is there verbatim [00:17:56] https://github.com/wikimedia/mediawiki/commit/c3dc0a2d99ed6bb594dec7cd5095085028696588 [00:18:01] It looks like it was done purposely [00:19:40] I tried a few web browsers putting the CSS in dev inspector, and none of the browsers support that syntax. [02:11:41] Yeah, I see comments now suggesting that LESS syntax is being returned to stylesheets evaluated as CSS, but it's LESS. For example snippet https://dpaste.org/6kAVz [02:12:41] which appears from DOM inspector for https://moasspedia.org/wiki/List_of_ape-made_music?debug=true [02:14:01] Also I'm trying to fix a background image issue for my site, and current working solution requires to --> html,body { height: unset; } // to undo the css provided by MediaWiki [05:40:28] I would guess that Volker just plain forgot that a css file isn't less [06:25:40] Mediawiki CSS question: For example in https://en.wikipedia.org/wiki/Main_Page in DOM inspector for body element, adding height: unset; (to undo the html,body rule setting height to 100%, and position: relative; (or putting that on the html tag) that makes the body then have the full height of the containing elements. Is there a reason that this isn't the default CSS used? [06:26:53] css position: is shit to work with [06:27:15] the better layout technology is css grid, which is what Vector is being transitioned to Soon [06:28:37] Nice! The folks in #css pointed out lots of css/html validation errors that I was considering to try to fix all of them, but they are mostly MediaWiki and extension issues. [06:28:54] and skin issues [06:30:52] anyway from memory how Vector does height 100% etc it's basically the way to do it [06:32:21] hmm, I had to unset that cuz it broke the background image from scaling properly,but I fixed it with those two modifications: position: relative and height: unset; [06:32:34] * Izno shrugs [18:53:27] at present does any current version of mediawiki work well with any version of php8? i have been reading about this but i'm still confused by the current situation. [18:55:13] note: the reason i'm asking is that i'm getting a segfault with php7.4-fpm and i wonder if moving to php8 would fix this [18:55:48] hgolden: it's not officially supported yet but unofficially we hear users are using it just fine. you might want to subscribe to https://phabricator.wikimedia.org/T248925 [18:57:17] hgolden: hey, do you have any idea as to your segfault cause [19:02:35] RhinosF1: i just upgraded from mediawiki-1.27 to mediawiki-1.31 as a result of upgrading from ubuntu-18.04 to ubuntu-20.04. that's when the segfaults started. i haven't figured out the cause yet. i need to convert the memory address in the kernel error to what software is there. i haven't done that yet. [19:03:35] i have no experience debugging php code, so i need to read up on how to do it. [19:04:33] ok np [19:04:48] We had issues with php 7.4 [19:05:03] But we just ended up setting tighter resource limits [19:06:13] RhinosF1: did this eliminate the segfaults for you? [19:06:44] hgolden: yep [19:07:00] Or at least significantly mitigated them [19:07:03] mutante: thanks for the suggestion to subscribe to T248925. i just did. [19:07:04] T248925: Make MediaWiki compatible with PHP 8 - https://phabricator.wikimedia.org/T248925 [19:07:55] hgolden: for now you can try to downgrade to 7.2 per https://askubuntu.com/questions/1230869/cant-install-php-7-2-on-ubuntu-20-04 instructions. Wikipedia is on 7.2 fwiw [19:08:29] or of course what RhinosF1 said, alternatively [19:09:42] mutante: spam random setting until it makes php less stupid and have reasonable resources was a fun solution [19:09:52] and took quite a while to find the best point [19:10:31] if you have a link to the miraheze settings that might be helpful for him [19:14:29] mutante: i will look into downgrading to php7.2. thanks for the suggestion. [19:14:44] would be interesting if that makes it go away, ACK [19:14:49] I think it should [20:31:35] mutante: your suggestion to downgrade from php7.4 to php7.2 eliminated the segfault. thanks again! [20:39:42] hgolden: good to know and glad to hear [21:05:55] mutante: everything is in github.com/miraheze/puppet and github.com/miraheze/mw-config [21:06:17] The php config is spread across a few places though in puppet [21:07:56] hgolden: ^ that is if you want to try "php7.3 but with random settings that mostly fixed it" :)