[14:52:19] hi all! [14:52:30] https://www.mediawiki.org/wiki/Special:Contributions/RAdimer-WMF [14:52:39] could I get +autopatrol on my staff account? [14:57:23] (nvm, going through other channels) [19:03:37] hey! I'm a newbie and I'm having an issue with gerrit -- essentially I set up git to hide my email address since it's my real name. That means my commits come from 107272350+TySambar@users.noreply.github.com. I can't use that to make commits to gerrit. I went to add it to my profile and it wants me to verify the email, which is a problem. I tried [19:03:37] using the cli to set it up with $ ssh -p 29418 gerrit.wikimedia.org gerrit set-account --add-email 107272350+TySambar@users.noreply.github.com tysambar and it returns "fatal: modify account not permitted" [19:03:44] I'm at a loss here. Any advice? [19:28:05] tysambar: setup a new email address just for contributing? I think that would be easiest [19:29:05] tysambar: you could even use something like http://www.mytrashmail.com/ to receive mail and verify without really setting up anything [19:29:09] Yeah, that's where I ended up too. [19:29:29] I had a protonmail account I haven't used for anything yet -- already made the changes [19:29:41] ah, yea, protonmail is cool [19:47:09] mmm y'all I was able to just straight up push my changes to the sandbox repo, rather than using git review. It's the sandbox so like nbd, but I don't think I should've been able to do that? I'm used to using git push at work because the upstream is a dev branch that gets extra testing before deployment, but it looks like that's not the case here. [19:47:44] I don't want to test this on the real code for obvious reasons but does anyone know if there are safeguards on the main repositories? I'd be down to help set some up if needed. [19:51:23] tysambar: using "git review" is optional [19:51:31] I personally like it but others do not. [19:51:42] and it's ok to use "regular git commands" instead [19:51:52] I just feel it's a bit less convenient [19:52:50] ah. maybe you did not mean that part. I don't know about the specifics of the sandbox repo. [19:55:43] I'm planning on doing a quick find and replace on mediawiki/core. Are you telling me that git review is optional there? [19:55:54] I'm planning on doing a quick find and replace of a deprecated css tag on mediawiki/core. Are you telling me that git review is optional there? [19:56:15] (Sorry for the double post, assumed I'd be able to edit) [20:04:08] TySambar: regardless of the specific repo. "git review" is just not required. you can achieve the same thing with other (longer) git commands. it's just like a helper trying to make it simpler [20:04:53] it doesn't mean that you would skip the review stage [20:05:13] it would still mean that something sits in Gerrit and waits to be reviewed and merged by somebody [20:06:29] TySambar: https://www.mediawiki.org/wiki/Gerrit/Alternatives_to_git-review#Push_for_review [20:08:13] <3 [20:08:20] Thank goodness [20:08:52] (and don't worry, there *are* safeguards, you won't be able to push directly to `master` on mediawiki core or something :P)