[02:24:13] so did you know one of your en.wikipedia admins is a russian agent abusing admin buttons? [02:28:06] so did you know one of your en.wikipedia admins is a russian agent abusing admin buttons? [07:59:42] I wish i was allowed to merge things after i fix small issues with other people's patches (e.g. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/577615 ) [12:52:05] o/ do we consider MediaWiki 1.39 to be compatible with php8? [12:52:50] dcausse: maybe [12:53:03] We think we fixed all issues in mediawiki core [12:53:13] bawolff: thanks, just read your comment on T248925#8249837 [12:53:13] T248925: Make MediaWiki compatible with PHP 8 - https://phabricator.wikimedia.org/T248925 [12:53:55] At the very least its more compatible than the last release was [12:55:31] * bawolff should mention that I am not actively working on anything other then MW core, and I'm not sure how much anyone else is looking into vendor dependencies or bundled extensions [13:02:56] you should always assume the answer to any question, is in some way ree dy [13:14:10] p858snake|L: If anyone is doing it, it almost certainly is re.edy or james, and i know re.edy did look into that in the past [14:21:10] does anyone know where I can view the output of the $this->getToolbox() array? [14:22:36] Guest13: I'm not sure what you mean? Are you asking where in the interface the results of that message go? [14:22:53] dcausse: As above, I think the answer is "it should". There's potentially a few sharp edges around some extensions and their 3rd party libraries... But in most cases, it shouldn't be much more than some logspam rather than completely broken-ness (though, I do think we have fixed most of those too) [14:22:54] (message is the wrong word here) [14:23:11] dcausse: I've had my dev wiki on 8.1 for a while now, and have been at least filing bugs, if not fixing issues when I spot them [14:23:55] Reedy: thanks! context is https://www.mediawiki.org/w/index.php?title=Topic:X3t4odh8o8fte3e7&topic_showPostId=x3xpyhowc5acgmlq&fromnotif=1#flow-post-x3xpyhowc5acgmlq [14:24:08] 95% of the php8.1 issues in MW core were: unit tests do something stupid that can't happen in real life causing a warning to be issued. [14:24:20] I guess we can't "officially" say we support php8 yet [14:24:43] There's some sites that have been running on PHP 8 for a while AFAIS [14:24:51] bawolff not necessarily, I'm asking if there's any particular place where the output is listed so that I can unset some of the output in a skin i'm creating if that makes sense? So I can chose which links (that getToolbox() outputs) go in different places? [14:25:04] Ah, i see [14:25:06] It wouldn't surprise me if CirrusSearch et al in 1.39 want a backport or two from master [14:25:26] yes [14:26:07] Especially when it was branched around the time you all were getting towards the end, but not quite finishing the upgrade [14:27:05] Guest13: I think if you are a making a custom skin, you can just override the makeToolbox method in your Skin class, call parent::makeToolbox(), then unset the things you want [14:27:19] * bawolff not a skin person, so i'm not sure if that's the official reccomended way or not [14:28:22] Reedy: indeed I already backported few elastic related patches to 1.39 but there might be more [14:29:56] I think we should maybe just say php 8.1 is officially supported. What does official support really mean anyways? Its not like we're garunteeing we are going to fix bugs on php 7. [14:30:40] As they say, MediaWiki's "official" support is worth every penny you pay for it ;) [14:31:11] There's definitely still going to be logspam around, if you have that enabled [14:31:13] bawolff: true, I guess when someone asks me "Has the above been tested to work without issues" I worry to say yes if it's not running on WMF infra [14:31:21] But that doesn't mean anything is actually broken [14:33:41] Reedy: Out of curiosity, how much logspam is in your test wiki now a days [14:33:56] Not that much... I've fixed a lot of it [14:34:04] There's still a few tasks on the 8.1 board [14:36:00] There's a few of the parsoid dependancies we're not testing on 8.1 because of a backlog of phan and other issues [14:38:22] I've also imported numerous large and complex enwiki articles (and all their dependancies)... Very few issues there either [14:39:05] OAuth is one of the few things I know that are probably broken/questionable - https://phabricator.wikimedia.org/T313563 [14:39:07] given that 1.39 will be LTS it's likely we'll put PHP8 in the release notes at some point no? [14:40:14] I doubt all that many people use OAuth outside of WMF [14:41:52] I'm sure there's many other 3rd party extensions in questionable states [14:43:17] I think it's probably worth mentioning in the announcements etc, yeah... Bugs are definitely accepted and fixes will be backported on a best effort (like everything else) [14:43:37] At one point I wanted to get 1.35 PHP 8 supported, but I think that's going to get too painful especially with some of the parsoid tree [14:43:46] Doesn't mean I'm not backporting other fixes etc for those that are running it [14:45:49] I was backporting some things to 1.35, but then just gave up [14:49:55] there's probably PHP 7.4 bugs still in it [16:40:49] huh, is there a user right associated with renaming flow topics you didn't create? [16:42:19] Not obviously... [16:42:32] unless "flow-edit-post" ? [16:42:37] Its like a surprising amount of the spam we get [16:50:09] strangely, on mediawiki.org, anons are not able to edit their own messages, but they can rename random topics [16:50:41] lol [22:17:29] Flow is horrible. [22:21:23] it could have been good [22:21:25] but it ain't [22:53:38] ? [23:02:26] Hi Charly[m].