[03:25:13] https://tenor.com/view/monstersinc-sully-mike-door-put-that-thing-back-gif-4553929 [03:25:31] ...oh right, this is the bridge room [03:50:11] rip [10:30:36] So, how do I get rid of calls to wfGetLB()? I'm not a PHP novice, but I don't know anything much about he MW codebase. [10:31:16] I'd like to fix this so I can submit a PR: https://github.com/JeroenDeDauw/SubPageList/blob/d593af5ace045658cb1a1efa675ce80af0db5020/src/LazyDBConnectionProvider.php#L53-L79 [10:33:16] is it simply MediaWikiServices::getInstance()->getDBLoadBalancer() ? [10:57:27] bootc: I think so [10:57:55] yeah I've been digging around, it looks like that's mostly it [10:58:04] and getConnection() turns into getConnectionRef() [10:58:15] (though it looks like it's the same thing anyway) [11:29:15] bootc: https://github.com/wikimedia/mediawiki/blob/REL1_38/includes/GlobalFunctions.php#L2227-L2237 [11:29:49] Reedy: aha, many thanks [11:34:11] plus the use/import statement [11:34:22] yep, got it working thanks [11:34:39] I now have a different extension blowing up because of a missing "use MediaWiki\MediaWikiServices;" - has that changed? [11:34:49] I'm wondering how it ever worked lol [11:35:20] AFAIK it's always been namespaced [11:36:10] yeah, it has [11:36:12] https://github.com/wikimedia/mediawiki/commit/eb46307b001ad116426b866b506ef49fb21f1e3d#diff-de38ccfc5cbbd77600c37486e5d667c2e0ae9b18e09f12cd5c047a241eaa99f6R2 [11:38:00] It's https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/NSFileRepo/+/refs/heads/REL1_39/includes/NSFileRepoHooks.php#60 [11:38:35] perhaps DefaultSettings.php used to use MediaWiki\MediaWikiServices but doesn't any more? [11:38:48] no idea [11:40:29] Wouldn't make any difference, I think [11:40:33] but that's a really weird code pattern [11:41:23] I can fix that one in gerrit for you though [11:44:31] that would be fantastic if you don't mind :-) [11:44:59] also if you have 5 mins, a quick sanity-check over https://github.com/JeroenDeDauw/SubPageList/pull/66/files would be much appreciated... [11:46:59] gj duesen https://github.com/wikimedia/mediawiki-extensions-NSFileRepo/commit/dd4e6fc8f41f55c1fcaf2ca06ea3ef0f621cdaa9 [11:47:05] Though, tbf he did say "untested" :) [11:48:48] oh REL1_35 didn't have that... that explains it [11:50:49] yeah it would [11:51:43] I dunno why they have CI enabled if they're just gonna force changes through anyway [11:53:06] I see your fix in Git already; many thanks [12:02:14] "Error: Call to a member function getConnectionRef() on null" ffs lol :-) [12:03:24] (silly typo on my part) [12:04:24] NSFileRepo works now though; thanks again Reedy [12:06:06] Now it looks like Cargo is broken :-( [12:06:50] * Reedy pretends not to be surprised [12:08:45] maybe we really are being a bit too early on this upgrade ... [12:25:37] ah no, I should be using Cargo's master branch / tags which already have a fix for the thing I ran into [12:29:26] I think extensions are automatically branched with the new release when core is branched, but some extension maintainers forget about backporting fixes in master into the branch [12:29:52] The support policy for Cargo suggests master should probably be used [12:30:08] (though in reality, tags from master) [18:17:36] Hello, I installed Media Wiki today. I am trying to setup a local LDAP connection. I believe all that is setup as the maintenance scripts work correctly. However, now I don't have a username and password field. Just a login button and the error The supplied credentials could not be authenticated. [19:22:58] CindyCicaleseWMF: maybe you can help bkaustin? [19:23:53] Reedy: I guess I shouldn't try to make helpful suggestions on extensions I have no intention of installing and testing... [19:24:37] duesen, I do that all the time! 😄 [23:09:27] hi