[01:30:04] Is it possible to have an extension introduce hooks that use the new hook system (i.e. with the interface and HookRunner thing)? Or should we just use the legacy Hooks::run in extensions that introduce hooks? [01:30:33] I think it should be doable [01:30:43] I think AF has [01:31:13] Hmm, you're right, looks like AF is doing something like that [01:31:14] thanks :) [01:31:41] probably need a bit more wiring than just using Hooks::run() but shouldn't be too much (though maybe the first has a bit more) [01:33:17] Does actually look like quite a bit of wiring. At least compared to 1 line Hooks::run [01:33:44] oh wait, looking at wrong file [01:34:20] Mistyped FilterRunner and was like, oh this file looks really wrong [01:34:22] *long [01:36:19] i guess if i don't care about the wiring part, I could just call $this->hookContainer->run directly [13:55:30] Hi, I upgraded to 1.39 from 1.38 and using PHP 8.0 but now I'm constantly getting the following error: "MediaWiki 1.39 requires PHP 7.4.3 or higher; you are using PHP 7.3.33." and in the browser devtool I'm getting "x-powered-by: PHP/7.3.33" but I'm not using PHP 7.3 so why MediaWiki showing this error? [13:56:46] x-powered-by isn't a header from MW, its from your webserver [13:56:59] it would look like your webserver is using PHP 7.3 [13:57:32] Oh so how I can check the PHP version of my webserver? [13:59:37] Depends on what webserver you're using [13:59:43] But in my webserver I have set up 8.0 for my mediawiki installation. [13:59:51] I'm using CentOS Linux [14:00:01] that's an OS, not a webserver [14:00:47] I'm so sorry sir, I'm not well aware of these technical terms. [14:01:15] I have the site on Cloudflare is it possible that's causing the issue? [14:05:09] I just checked webserver software on iplocation and it's showing cloudflare. [14:10:38] And I'm using Apache with varnish. [14:12:49] @Reedy sir I got it Apache is my webserver so is it possible to upgrade it's php version? [14:13:36] It's likely to be one of two issues... [14:13:49] One, apache hasn't been restarted after you upgraded/installed a new PHP version [14:14:03] or two, the apache config hasn't been updated (and possibly not restarted) to use the new php version [14:14:23] something like [14:14:30] a2dismod php7.3 && a2enmod php8.0 && service apache2 restart [14:14:45] Apache was restarted by me today only but gives no result. [14:14:52] `a2dismod` and `a2enmod` are debian specific IIRC [14:15:21] pfft [14:15:47] taavi: Though, I did say "something like" ;) [14:16:31] Let me check if I can find the exact comment to use for apache to use the latest php version. [14:22:34] No luck can't find the exact command for apache. Can someone please help how to update the php version on apache? [14:41:04] Sorry I got disconnected. I was asking if someone can help me update the php version for apache? On my MediaWiki I'm getting the php error. [19:27:56] Hi all, I don't know if I have a bug in mediawiki/firefox or if I just don't understand how unicode should be used. I have some example (bash) code in a wiki. It looks like mediawiki is converting some spaces to  ! (aka U+00a0). [19:28:37] If a visitor copies the code on the page (in or 
), it adds in these spaces and the code wont execute
[19:29:33] 	 chrome gives this to the clipboard as a normal space and does not reproduce the issue.  Some older versions of firefox also do the same and intepret this as a space, but the latest firefox brings over the troublesome unicode character
[19:31:53] 	 This is a page with an example:
[19:31:54] 	 https://docs.embeddedts.com/Bookworm_armhf_cross_compile_kernel_docker
[19:31:54] 	 if [ ! -e "/.dockerenv" ]; then
[19:31:55] 	 The unicode space is just after the [ in that line.  There are a few others on that page too
[19:32:14] 	 Did you verify in the source that it's actually a space and not in fact the Unicode space?
[19:33:04] 	 Yes, if i go to the edit page, and view page source, its not there.  If I render it and view page source, it is there
[19:33:14] 	 not what I asked
[19:33:21] 	 did you actually attempt to change the character
[19:33:36] 	 and/or the surrounding characters
[19:33:51] 	 I have not, I can experiment with that
[19:33:55] 	 just to verify that there's no chance whatsoever that it's not an input erorr
[19:33:57] 	 that's a common thing we need to do
[19:34:02] 	 on en
[19:35:09] 	 that space may be added by the syntax highlight
[19:35:17] 	 I can replace it with "x" and that gives the correct character.  Going back to a space brought it back
[19:35:26] 	 I can also reproduce with 
[19:37:50] 	 hmmm, it's MediaWiki adding it, before the !
[19:38:04] 	 I just tested, this seems to be the minimal string to reproduce it "[ ! -"
[19:38:38] 	 a ! - reproduces it too, so you're right it seems to be the !
[19:39:16] 	 Adding multiple spaces before ! also makes multiple of the weird character
[19:39:45] 	 I can file a bug report at this point if thats what this sounds like, I just have no idea how this typsetting character is supposed to be used/interpreted
[19:42:06] 	 that's a non-breaking space. Prevents it from breaking the line if the text needs to wrap
[19:42:40] 	 I could understand it possibly wanting that for source code, but I might expect it to be almost every space in that block in that case?
[19:43:21] 	 that's probably done only after punctuation
[19:43:54] 	 I would also expect it to be added after a number, to prevent "10 km" or similar from wrapping
[19:45:59] 	 I did attempt changing characters all around it, and even made a simpler test page that reproduces it that I typed in just now:
[19:45:59] 	 https://docs.embeddedts.com/Test_page
[19:46:17] 	 looks like it has been a problem before :) T13874
[19:46:18] 	 T13874: Enforced   breaks inline CSS with !important - https://phabricator.wikimedia.org/T13874
[19:46:27] 	 It reproduces before ? as well, but not .
[19:47:41] 	 found another that might be related as well:
[19:47:41] 	 https://phabricator.wikimedia.org/T279494
[19:51:46] 	 At very least this sounds not obvious, so I'll likely make a bug report for discussion there.  It sounds like these space replacements before special characters probably shouldn't apply to source or pre blocks
[19:51:55] 	 Thanks!
[19:52:27] 	 I agree it shouldn't happen on 
 or  blocks
[19:53:15] 	 and here's the function that does the replacement https://gerrit.wikimedia.org/r/c/mediawiki/core/+/393256/16/includes/parser/Sanitizer.php
[19:57:05] 	 mrpenguin50: As an ugly workaround, you can replace problematic spaces with   
[19:58:02] 	 the replacement occurs on spaces before ? : ; ! %
[19:58:56] 	 Interesting, I'll look into changing that for now
[20:00:52] 	 thanks, that did work :)
[20:01:13] 	 my wiki is more code than anything else so I'm ok with it wrapping for now.  I'll make a bug report.
[20:51:22] 	 Hello!
[20:54:53] 	 Im having an issue, despite having VisualEditor preinstalled and enabled, it doesn't work. There is an option to edit, it starts loading VisualEditor but then abruptly stops and switches to the regular markdown editor. Im running MediaWiki 1.38.4, PHP 7.4.33
[20:55:43] 	 VisualEditor used to work fine, then one day it just stopped working, im unsure why. There are no errors in php-fpm or nginx logs.
[20:59:29] 	 mrpenguin50: that's a feature to prevent punctuation wrapping away from the rest of the sentence in French, since that language precedes question marks and exclamation points with spaces
[21:00:57] 	 if you search phabricator for "space armoring" you'll find a bunch more tasks about it