[00:06:39] * Platonides +2 it
[00:07:18] <CosmicAlpha>	 Awesome! Thanks!
[00:10:38] <CosmicAlpha>	 Platonides: mind forcing it? PHP 8.1 failure that should be a follow-up patch probably?
[00:19:48] <Platonides>	 00:08:10 Build step 'Execute shell' marked build as failure
[00:21:15] <Platonides>	 I don't find _what_ failed :(
[00:21:45] <Platonides>	 let's see if it magically works now
[00:23:24] <Platonides>	 it passed now
[00:24:20] <Reedy>	 https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php81-noselenium-docker/3362/console
[00:24:30] <Reedy>	 00:08:08 1) SpecialPageFatalTest::testSpecialPageDoesNotFatal
[00:24:30] <Reedy>	 00:08:08 htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated
[00:24:30] <Reedy>	 00:08:08 
[00:24:30] <Reedy>	 00:08:08 /workspace/src/extensions/ProtectSite/includes/ProtectSiteForm.php:189
[00:29:22] <Platonides>	 I don't see how textbox can get passed a null $value :/
[00:30:06] <Platonides>	 there are isset()s clearly to avoid that
[00:30:48] <Platonides>	 (and it doesn't make sense that it randomly passes or not...)
[00:31:03] <Reedy>	 it doesn't pass randomly
[00:31:07] <Reedy>	 PHP 8.1 is only done on gate
[00:31:18] <Platonides>	 ah
[00:31:26] <Platonides>	 right
[00:31:29] <Platonides>	 sorry
[00:31:50] <Reedy>	 and it's probably a null from higher up the stack
[00:32:00] <Reedy>	 Being a special page.. I'm guessing it's a "subpage"
[00:33:23] <Reedy>	 00:08:08 /workspace/src/extensions/ProtectSite/includes/ProtectSiteForm.php:189
[00:33:23] <Reedy>	 00:08:08 /workspace/src/extensions/ProtectSite/includes/ProtectSiteForm.php:283
[00:33:23] <Reedy>	 00:08:08 /workspace/src/extensions/ProtectSite/includes/ProtectSiteForm.php:48
[00:33:23] <Reedy>	 00:08:08 /workspace/src/extensions/ProtectSite/includes/ProtectSite.php:58
[00:35:09] <Platonides>	 there seems to be an html injection in the protection comment
[00:37:14] <Platonides>	 this whole extension should get a review to get with the times
[00:38:28] <ashley>	 ProtectSite is kinda old and it includes an ancient version of HTMLForm from like MediaWiki 1.10 :D
[01:26:30] <p858snake>	 Platonides: It sounds like your offering >.>
[02:25:40] <Izno>	 lol Platonides , the task you filed turned your #mediawiki into the project link for #MediaWiki-General
[10:09:31] <CosmicAlpha>	 Platonides: https://gerrit.wikimedia.org/r/876296 should fix that PHP 8.1 failure on gate and submit also.