[17:48:19] Hello! I'm hoping someone can point me in the direction of a piece of documentation I've found once and am unable to remember what I put into google to find it. I need to apply the javascript in Common.js to my Special:UserLogin page because there are significant skin modifications I've made that need to be applied everywhere. I know it's a bad idea to do so but it's the best worst option [17:48:19] I have available. Does anyone know where I could find information on how to apply JS to that page? [17:49:15] Special:UserLogin doesn't run JS, end of story [17:49:48] it's prevented because of how it's a bad idea, not just that it is one [17:51:40] there's a config to allow sitewide CSS on those pages, but not JS [17:52:15] if your skin modifications are significant enough, chances are it should be part of the skin itself anyway, at which point you'd have no such limitations because all of the css/js would be defined by the backend files [17:54:52] You're not at all wrong, however I'm dealing with a website that's being designed by comittee and it's much easier to modify common.js. I'm not asking for common.js to execute on the page. I know there's documentation on how to add javascript to an existing skin [17:58:15] like, I'm able to modify the skin files myself, I just don't know where the hooks are located or how I go about adding what I've written locally. [17:58:38] Modifying the files directly is going to cause yourself a world of maintenance pain [17:59:47] Oh I know. Trust me, I know. Unfortunately I can't ask for more time to do this correctly, so I need a quick and dirty fix in the immediate term so I can have that time later [18:04:49] https://github.com/wikimedia/mediawiki/blob/master/includes/specialpage/AuthManagerSpecialPage.php#L104 [18:04:57] Potentially just commenting out that line [18:05:23] I wouldn't like to even guess what world of side effects and other (security) issues you're opening yourself upto though [18:06:14] If it's a locked down wiki with three people who have edit permissions, only one of whom should be editting common.js at all are the risks that huge? [18:06:32] Depends if they have any bad intentions :) [18:06:37] I'm not being facetious here, I'm trying to gauge risk factors [18:06:51] The only people I have bad intentions for are the lawyers who seem to make a hobby of making my life hell [18:07:13] I mean, you're certainly right, the risk factor of this on the English Wikipedia is much higher than your probably private wiki [18:08:42] oh, for sure. I wouldn't dream of that. Nor do I intend to actually leave this that way. I just need to get this going for a couple days so I can breahte lol [18:09:50] had a full year for development time on this project. then the negotiations took 10 months longer than expected. and I did not get my 10 months back [18:12:10] tbh this sounds like you didn't properly communicate the risk to your stakeholder [18:12:22] "I can do that. Here's the tradeoff." [18:14:31] Oh I tried to get that across. Unfortunately the people in charge aren't developers and don't really get it. Personally I didn't see the problem with not having branding on one page people look at for a few seconds [18:15:14] I thought as much, hence why I framed it as "pretty sure there was a managing client expectation" fail :P [18:16:06] well I kinda need to be honest, and they were like if you do this, what are the bad things that might happen. and I couldn't really come up without requiring massively compromised security to as a precondition [18:16:37] they clearly don't have any sort of security team :joy: [18:16:48] any security team member would have said "nope nuh uh no way" [18:17:06] oh no, I've got two! both of whom are unfamiliar with mediawiki and only care about the risk scores that come back from their reports. [18:17:17] what you really should set up is making MediaWiki an OAuth client or other sort of SSO client [18:17:25] then they never see login [18:17:32] idk how hard that is [18:17:35] Guess what I had set up initially! [18:17:40] that very solution [18:17:42] smh [18:17:48] only now they need two options to pick from [18:18:43] Oh, and it was a nightmare to set up lol. SAML is so finnicky [18:19:57] Reedy, thank you very much for your help with finding that line. I genuinely appreciate it! [22:33:12] After I update to 1.39.3, the error of the psr/http-message leads to white screen of death. However, after I apply the patch and ran composer update, doesn't solve the situation (see https://wikisp.org/wiki) [22:33:34] (ah, and hi everyone!) [22:35:23] How's Avalon doing? [22:42:57] Prettier as usual