[10:38:05] <Guest91>	 Hopefully somebody is able to help. I am tring to upgrade MediaWiki 1.31 to 1.35
[10:38:24] <Guest91>	 Everything works except for editing.
[10:39:02] <Guest91>	 This is the error I am getting:
[10:39:04] <Guest91>	 Wikimedia\Rdbms\DBQueryError from line 1713 of /../w/includes/libs/rdbms/database/Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
[10:39:18] <Guest91>	 Error 1364: Field 'old_comment' doesn't have a default value (localhost)
[10:39:18] <Guest91>	 Function: MediaWiki\Storage\SqlBlobStore::storeBlob
[10:39:45] <Guest91>	  Query: INSERT INTO `text` (old_id,old_text,old_flags) VALUES (NULL,'Die Software des wird bis voraussichtlich 14 Uhr aktualisiert. Daher kann das Wiki nicht bearbeitet werden.','utf-8')
[10:39:59] <Guest91>	 What could this possibly be?
[10:40:33] <Guest91>	 I ran update.php, cleanupUsersWithNoId.php etc.
[10:41:07] <Reedy>	 I don't think it should be trying to insert an old_id of null
[10:41:09] <Guest91>	 Why would the field "old_comment" be missing. I can look at revisions etc.
[10:42:10] <Guest91>	 Is there a way to fix this.
[10:43:02] <Guest91>	 This is apparently an ancient instance. It started out with MW 1.6 or even earlier.
[10:44:24] <Guest91>	 I have read that upgrading to 1.35 is a disaster for a lot of people however this specific error never appears to have occurred. At least google does not show results for it.
[10:46:11] <Reedy>	 Did it work fine on 1.31?
[10:46:46] <Guest91>	 No problems at all with 1.31 The update to 1.31 was done in 2020
[10:47:43] <Reedy>	 Unless this is from some extension..
[10:47:51] <Reedy>	 old_comment is referenced in so few places
[10:47:58] <Reedy>	 https://github.com/wikimedia/mediawiki/blame/REL1_35/includes/installer/MysqlUpdater.php#L634
[10:48:29] <Reedy>	 but the page table has been there since 1.5... So it's unclear how/why it's even running that apparent code
[10:48:49] <Reedy>	 Is there a full stack?
[10:48:52] <Reedy>	 use a pastebin
[10:49:02] <Guest91>	 Hmm, only checkuser comes to my mind here. Will disable it for now
[10:50:04] <Guest91>	 https://pastebin.com/X1BzS3gU
[10:51:17] <Guest91>	 No, it was not Checkuser
[10:52:55] <Reedy>	 I don't think the text table has ever had an old_comment column though...
[10:53:24] <Guest91>	 hmm, unsure about how to proceed.
[10:53:57] <Reedy>	 can you get the schema of the text table?
[10:54:06] <Reedy>	 Is it possible someone has made modifications?
[10:54:30] <Guest91>	 not in the past 10 years
[10:54:42] <Reedy>	 the old table did have an old_comment table... but that's been gone for aaages
[10:55:24] <Guest91>	 Acutally were were changes made due to invalid character issues about 10 years ago.
[11:02:31] <Guest91>	 Took me a while to upload the file: https://imgur.com/a/5SZZjEu
[11:07:53] <Guest91>	 This is the schema of 1.31: https://imgur.com/a/BaCEhgA old_comment was in there too.
[11:09:28] <bawolff>	 old_id of null is not as crazy as it sounds, mysql will take that to mean next autoincrement id, i think
[11:09:29] <Guest91>	 > Acutally were changes made due to invalid character issues about 10 years ago.
[11:09:30] <Guest91>	 This did not touch the structure of the tables.
[11:12:50] <Guest91>	 The wiki used $wgDBmysql5 = true; before. When trying to switch this to false where were issues as far as I remeber.
[11:13:56] <Guest91>	 This is an encoding parameter though. The wiki does not have encoding issues now this setting is gone.
[11:15:15] <Reedy>	 The old table isn't in https://github.com/wikimedia/mediawiki/blob/REL1_31/maintenance/tables.sql
[11:15:21] <Reedy>	 https://www.mediawiki.org/wiki/Manual:Old_table
[11:15:28] <Reedy>	 >After running the updater when updating from MediaWiki 1.4 or older to a newer version, all fields in the text table except old_id, old_text and old_flags are not needed anymore and can be safely deleted.
[11:21:53] <Guest91>	 Reedy This means that if I delete all these fields it should work?
[11:22:14] <Reedy>	 Yeah... in theory, they haven't been used for years
[11:22:18] <Reedy>	 please backup first, just in case ;)
[11:23:00] <Guest91>	 Ok. Just to make sure. the ones I marked here: https://imgur.com/a/R55i5j1
[11:23:14] <Guest91>	 8 fields in total.
[11:24:02] <Guest91>	 I have cold sweat on my forehead
[11:26:00] <Guest91>	 dump currently in progress
[11:27:46] <Guest91>	 wow, just looked at the structure of another wiki installed a couple of years ago. All of these fields: gone..
[11:27:52] <Reedy>	 they've been gone for...
[11:28:14] <Reedy>	 nearly 19 years
[11:28:20] <Guest91>	 This particular wiki started out with UseMod.
[11:31:15] <Guest91>	 Not it was PmWiki. They switchted to MW end of 2004
[11:33:54] <Guest91>	 Wow, this is amazing. After dropping the 8 fields I can edit again, i.e. I successfully made my first edit without database issues.
[11:34:01] <Guest91>	 You are my lifesaver.
[11:34:39] <Reedy>	 update.php runs cleanly?
[11:34:42] <Reedy>	 Make a backup again ;)
[11:34:48] <Reedy>	 Noting 1.35 goes EOL in a few months too
[11:36:15] <Guest91>	 Will test. Currently dumping again.
[11:38:10] <Guest91>	 yes, update.php runs without issues. See https://pastebin.com/CDDsXfUX
[11:39:51] <Guest91>	 I am currently planning to go 1.39 as soon as EOl for 1.35 is being announced, i.e. 3 months form now. I guess we should enjoy 1.35 after we made it ot this version.
[11:40:16] <Reedy>	 no reason you couldn't upgrade sooner
[11:40:47] <Guest91>	 You are cool. Will share my experience on mediawiki.org for others to have a reference in case they run into the same issue.
[11:41:59] <Guest91>	 !!!THANK YOU I am so happy. THANK YOU!!!
[11:42:26] <Reedy>	 np
[11:43:33] <Guest91>	  ___
[11:43:34] <Guest91>	 (o,o)
[11:43:34] <Guest91>	 < . >
[11:43:35] <Guest91>	 --"-"---
[11:43:35] <Guest91>	 You have been awarded my personal wiki owl award. Hoot, hoot!
[11:43:58] <Guest91>	 looks nicer on a wiki. :)
[13:22:04] <Nikhil61>	 is there any plan to upgrade webdriverio (wdio) from version 7 to version 8?
[13:22:50] <Reedy>	 https://phabricator.wikimedia.org/T324766
[13:29:11] <Nikhil61>	 oh thanks
[16:32:59] <Reedy>	 ffs mailman
[16:33:40] <bawolff>	 Woo!
[16:34:01] <Reedy>	 tarballs are up
[16:34:02] <Reedy>	 tags are pushed
[16:34:08] <Reedy>	 emails not fully sent
[16:34:08] <Reedy>	 ffs
[16:47:08] <taavi>	 1.40 is out?
[16:48:40] <sky2042[m]>	 It's been out?
[16:49:03] <sky2042[m]>	 Pretty sure we're working on 41
[16:49:13] <Reedy>	 taavi: waiting on CI
[17:37:11] <Reedy>	 oops, I should upload the tarballs
[18:11:49] <fifo_f[m]>	 TIME TO UPGRADE
[18:24:33] <Vulpix>	 huh, images are now wrapped by <span typeof="mw:File"></span>
[19:34:25] <sky2042[m]>	 Parsoid is coming.
[20:58:44] <legoktm>	 damn, no one has ever given me a wiki owl award for helping them
[20:58:52] <legoktm>	 https://bash.toolforge.org/quip/S_gZDokBGiVuUzOdJAMG now saved for eternity
[21:15:11] <sky2042[m]>	 Hoot hoot
[21:51:14] <bd808>	 legoktm: here's an IRC owl as a consolation prize: 🦉