[11:36:15] Good morning everyone! Do anyone know if there is a good way to enable autosave when editing the page? Extension:Drafts doesn't seem to be working. I have a team of people who are working on some very long articles which some time take hours to edit, and sometime they forget to click on Save button during the work, hence if something unexpected [11:36:15] happens like power outage etc, they lost all of their edits [12:05:19] Guest51: wouldn't you instead prefer we fix Drafts? [12:05:43] qchris: hi! thanks for the super swift repo creation, much appreciated! :) [12:08:48] ashley of course if it can be fixed! [12:09:24] It is exactly what I wanted, but the extension seems have not be maintained for many years [12:11:19] it's sorta quasi-maintained-ish by yours truly and was sorta working the last time I checked, which was a while ago :D looks like a simple (okay, well, not *that* simple but simple enough once you know what's going on) JavaScript issue, though I'm not sure how long it's been there -- I know for a fact that the autosaving *was* working at some point not /that/ long time ago, but the error is definitely an error [12:15:20] give it a few minutes to (hopefully) pass CI and land, and then update your local copy to hopefully see the fix in action (may need to purge local caches, especially that of your browser's): [12:15:21] (CR) Jack Phoenix: [C: +2] Fix draft auto-saving [extensions/Drafts] - https://gerrit.wikimedia.org/r/965855 (owner: Jack Phoenix) [12:18:42] ashley Thank you! [12:19:08] ashley: yw :-) [12:19:13] BTW, what does "pass CI and land" mean? :) [12:19:21] had to force-merge that (yay for pre-existing phan failures <____<) but there you go, do let me know if it works [12:20:18] CI = Continuous Integration = a bunch of automated scripts that check for various things (and usually complain about irrelevant nitpicks which have no relation to functionality whatsoever, e.g. your // code comment is 121 characters long when the maximum allowed is 120) [12:20:30] giving a patch +2 merely triggers a bunch of CI checks to run [12:20:53] if those checks run and pass, then and only then will the jenkins-bot system account actually merge the change [12:21:10] but sometimes us humans have to be '''bold''' and know that we know more than the rustbuckets do :-) [12:36:14] ashley just did a quick testing and it seems working in Wikieditor! [12:36:24] But seems not working in VisualEditor? [12:38:53] I'm not aware of how it works with VE nor have I ever tested it w/ VE nor am I aware of ever anyone prior to you testing it with VE :-) (but I suspect it's hardly *the* only thing that's not working w/ VE) I strongly encourage you to file a ticket on Phabricator about this so that it doesn't get lost; I know someone who worked on VE and knows more about that in general than I do, I'll try to catch 'em one of these days and see if they have any idea on what [12:38:53] might be going on there and how we could potentially address the situation [12:39:35] I see, thank you for that info! [12:41:40] yw; thank *you* for taking the time and effort to test out these things and above all, report 'em -- it's the only way how developers can become aware of the problems and hopefully one day fix 'em as well :) [12:42:32] just found two things in wikieditor, 1) when switching from VE back to wikieditor, got this error: https://pasteboard.co/0E8xhpm9XTvV.png [12:42:57] 2), when click on the draft in the Special:Drafts page, it opens in a blank window [12:47:07] hm, mighty fascinating! there's some super duper weird logic (or the lack of thereof!) going on in DraftHooks... [12:50:17] :) [13:03:21] CI *will* fail (since I've not fixed that yet), so pay no attention to that, but can you give this a go: [13:03:22] (PS1) Jack Phoenix: Maybe fix weird fatal related to there not being a valid Title object [extensions/Drafts] - https://gerrit.wikimedia.org/r/965858 [13:03:55] it's still more of a hack than a true fix but *perhaps* it can introduce some of that much-needed robustness into that particular code path, at least enough to make it not fail for your use case(s) :) [13:07:16] Switching from VE to wikieditor works now! [13:07:54] But page in Special:Drafts still opens in blank window [13:11:18] > Fatal error: Cannot access non-public property EditPage::$scrolltop in /var/www/html/139/includes/debug/DeprecationHelper.php on line 235 [13:11:21] hm, how cute [13:29:27] Guest51: I've updated the aforementioned patch on gerrit, it should now address the issue of loading a draft via Special:Drafts as well, please do give it a(nother) try :) [13:41:25] You are the fastest "bug fixer" I have ever seen! Sorry I am not very familiar with Gerrit, could you point me to the modified files? [13:43:28] or is the change in the same file "includes/DraftHooks.php"? [15:09:56] I just updated DraftHooks.php with the latest version you created and works! You are the heroļ¼@ashley [22:24:40] is ElasticSearch required for Cirrcusearch to work? [22:29:20] what does the extension page say [22:30:56] never mind just got it working (: