[00:55:08] pain [00:55:08] https://cdn.discordapp.com/attachments/615786602454581249/892212795628724284/unknown.png [00:59:11] if we get to level 7, certain roles can get custom icons next to their nams [00:59:15] names* [09:44:24] But that is aesthetic [15:33:56] So until the new i18n gets applied, Apply theme button in Evelution skin will look as this: [15:33:57] https://cdn.discordapp.com/attachments/615786602454581249/892433954613895188/unknown.png [15:34:47] @HM100: it's applied [15:35:06] Then why it shows up as this? I have cleared cache and nothing [15:35:12] https://mylothecat.miraheze.org/wiki/Special:CPEThemeDesigner [15:35:13] 16:20:27 !log [rhinos@mw11] finished deploy of {'world': True, 'l10n': True, 'gitinfo': True} to all - SUCCESS in 852s [15:35:14] [url] No such special page - Mylopedia | mylothecat.miraheze.org [15:35:58] It happens at https://mylothecat.miraheze.org/wiki/Special:CPEThemeDesigner?uselang=el When using the greek language. English is fine [15:35:59] [url] Δεν υπάρχει τέτοια ειδική σελίδα - Mylopedia | mylothecat.miraheze.org [15:36:23] I'm getting no such special page [15:36:38] seems to only load if ?useskin=evelution [15:37:37] https://mylothecat.miraheze.org/wiki/Special:CPEThemeDesigner?useskin=evelution&uselang=el Giving link again [15:37:38] [url] Δεν υπάρχει τέτοια ειδική σελίδα - Mylopedia | mylothecat.miraheze.org [15:38:06] Special:CPEThemeDesigner only works inside Evelution [15:38:29] If I click refresh I can see it load [15:38:36] That's not normal [15:38:56] For what? [15:39:28] https://mylothecat.miraheze.org/wiki/Special:CPEThemeDesigner?useskin=evelution&uselang=el [15:39:29] [url] Δεν υπάρχει τέτοια ειδική σελίδα - Mylopedia | mylothecat.miraheze.org [15:39:53] I'm going to review that [15:39:59] OK [15:40:00] I'm not sure the page is registered right [15:40:29] It is not currently registered as it won't work on other skins but it is planned by CosmicAlpha someday to make that page registerable [15:40:49] Also, that special page relies on elements not foundable on other skins as well [15:41:22] That's not acceptable [15:41:28] Pages shouldn't load like that [15:42:12] I know but I don't plan to make this easily workable on other skins. Fortunately, there's at least a way to make other skins understand those elements [15:42:47] * RhinosF1 is wondering how this passed review [15:42:54] CosmicAlpha: ^ [15:43:04] Code that resides in https://github.com/AWikia/ExtensionIvilution/blob/main/resources/Ivilution.css will at least make CPE elements work in other skins [15:43:05] [url] ExtensionIvilution/Ivilution.css at main · AWikia/ExtensionIvilution · GitHub | github.com [15:43:10] Pages rendering like that should be blocking [15:43:40] This page is blocked on other skins fortunately [15:43:54] Yeah that's not how it should work [15:44:12] My initial thought looking at the skin is it shouldn't have been installed [15:44:29] We all know this 😛 [15:45:00] And Evelution is not an extension currently [15:45:09] If you're admitting it shouldn't have been installed [15:45:15] Then my thought is to disable it [15:45:21] lul [15:45:50] i think you should split this designer function into a separate extension [15:46:24] It can be and it can also at least make that special page display something about requiring Evelution skin if that it is possible [15:46:24] @HM100: that's serious [15:46:28] because we have some skin-specific extensions [15:46:31] like collapsible vector [15:46:38] (obviously only works on vector) [15:46:46] A page shouldn't flash not exists [15:46:46] I do not have enough knowledge on transforming the TD into an extension [15:47:40] Yeah but it unfortunately uses JS and not something else. Once we find a solution about not flashing at least not exists, it could go a lot better [15:48:58] This was discussed (At least about registering that page) on the Evelution Discord [15:49:15] you could then do it like Cosmos and make the options on LocalSettings [15:50:30] Found that in Cosmos Skin [15:50:47] I will try to make this available in Version 12.1.0 but will still rely on JS for some code [15:51:14] Yeah you're not loading pages via JS [15:51:43] Yes but also with PHP [15:52:04] I can fix the no such special page flashing [15:52:18] * RhinosF1 is not happy with the extension so I've reopened the task to speak to reviewers [15:52:26] Extension also meaning skin [15:55:08] Why is that UBN! though? [15:55:09] This will not be discussed here but rather at my Evelution Support Server [15:55:59] what's ubn? [15:56:20] The Phab priority [15:56:29] oh, i see, thanks [15:56:30] @Redmin: because it shouldn't have been installed in the first place in my opinion [15:56:42] If I can get a +1 then it can go [15:57:09] I can make the Special Page behave much differently [15:57:18] But this will require help from the Evelution Support Server Members [15:58:03] A quick scan of the code looks like a pile of tech debt [15:58:30] It's trouble waiting to happen [15:59:01] I do not have a lot of knowledge in PHP, only a basic one [15:59:27] But I will rely on some code from Cosmos skin [16:00:10] My concern is your knowledge of php poses far too much risk [16:00:27] It's too low to make something of appropiate standard [16:00:31] Unless I do something that will fix some of the issues [16:03:08] #deleted-channel This thread from my Evelution Server is the key for making theme Designer a bit better [16:06:06] I can't do anything better about this 😿 [16:06:37] I can remove ThemeDesigner now [16:07:10] Will removing Theme Designer be okay? [16:08:49] I have done https://github.com/AWikia/SkinEvelution/commit/1c3337df7cec2510975faddcdb25e30fbc46d2f1. This only removes the Theme Designer applet from Evelution because of Serious issues founud [16:08:50] [url] Update Designer.js · AWikia/SkinEvelution@1c3337d · GitHub | github.com [16:09:03] Will this be acceptable? Keeping the skin but not the applet [16:10:56] Evelution without the applet will be much better [16:10:56] https://cdn.discordapp.com/attachments/615786602454581249/892443262932123699/unknown.png [16:12:00] RhinosF1: ^ [16:12:12] @RhinosF1 Will bumbing Evelution to https://github.com/AWikia/SkinEvelution/commit/221cb84d59bdbb700e6068d17115fe90ab265e62 also help? Because I removed the ThemeDesigner Applet from public [16:12:12] [url] Remove theme designer · AWikia/SkinEvelution@221cb84 · GitHub | github.com [16:12:24] This will at least help the skin be keeped [16:14:30] https://github.com/AWikia/SkinEvelution/commit/41a2b98e4d1f6b9f61aee942172044ce1e776534 [16:14:30] [url] Remove Designer link from toolbar · AWikia/SkinEvelution@41a2b98 · GitHub | github.com [16:46:10] @HM100: when I have time tonight, I will create an issue for every problem I have with the code [16:46:19] OK [16:46:31] ThemeDesigner won't come back in Base Evelution skin [16:47:03] There's a good few other issues [16:47:55] Yes [16:48:20] Yes. Now that the issues have been reduced thanks to this big change, it won't be now a problem keeping it [16:48:39] I can help other users making themes for their wikis [16:48:41] It will [16:48:51] There are far too many issues [16:49:10] Which? [16:50:00] Are those JS based issues [16:51:18] Anyone can fix issues in Evelution and I'm happy to apply them [16:51:22] From things in skin.json to your php [16:51:28] I'll send PRs later [16:51:31] OK [16:51:35] Today is my busy evening [16:51:41] You can send them and I will form Evelution 12.1.0 [16:52:01] I think we'll want to call it a major version [16:52:11] It is a major ones [16:52:18] Versions are seasonal.major.minor [16:52:28] No [16:52:35] You can call whatever you want [16:52:35] That's not how semver works [16:52:39] Yeah [16:52:43] Please follow semver [16:52:50] ok [16:53:42] It can also be done as 13.0.0 (Beginning Great Wendi Evelution codename) as the 12.x.x branch is short-lived [16:54:05] Yes [17:01:18] And minor Evelution releases will be limited to 9 [17:01:38] So every time version is x.9.0 (Like 13.9.0) it will go to 14.0.0 automatically [17:01:43] Or whenever it is needed [17:08:43] No [17:08:44] No [17:08:45] No [17:09:52] Then I shoudl make it 100% semver compliant I can do this [17:10:54] This will start from version 13.0.0 and will go such way from now on [17:12:57] https://semver.org/ for more info [17:12:57] [url] Semantic Versioning 2.0.0 | Semantic Versioning | semver.org [17:14:51] Yes [17:15:01] * RhinosF1 just created some issues [17:16:19] When an Evelution release makes API changes that won't be compatible, a new Major release will happen When an Evelutiion release adds features that will still be compatible under the same layout, it will result in a minor release [17:17:58] Yep [17:21:17] Solved many of your issues [17:21:22] * RhinosF1 gips at the commit messages [17:25:06] Fortuantely, Visual Styles & Colors.css has been renamed to Visual_Styles.css to fix this [17:27:27] Only four issues you made are unsolved [17:28:15] I'm going to restric & disable until a new code review is done [17:29:39] OK [17:29:44] You can do whatever you want. [17:29:54] Doing a new code review will be the best solution [17:30:12] For now, I'll browse Miraheze using the timeless skin [17:30:25] ok [17:34:41] It's off [17:35:19] OK [17:35:29] Let's keep it off until those issues can get fixed [17:41:24] https://github.com/AWikia/SkinEvelution/blob/main/SkinEvelution.php#L96 doesn't look needed to me [17:41:25] [url] SkinEvelution/SkinEvelution.php at main · AWikia/SkinEvelution · GitHub | github.com [17:42:48] This is used for the configuration option Evelution uses [17:42:54] Nothing else [17:43:08] Yes but why not call config->get() when needed [17:43:31] Unless there's a performance benefit to that, it seems like an extra hook [17:43:40] It also calles config->get() but those config values are being used via JS [17:43:47] Not PHP [17:43:54] Otherwise it would look redundant [17:46:08] Most are only used at https://github.com/AWikia/SkinEvelution/blob/42934250bf251f6d413b78d7e47446a16303a142/resources/config.js#L22 [17:46:09] [url] SkinEvelution/config.js at 42934250bf251f6d413b78d7e47446a16303a142 · AWikia/SkinEvelution · GitHub | github.com [17:46:21] Why not just call the function there [17:46:30] Compared to using a hook [18:03:07] CosmicAlpha will take a look into this [18:18:55] https://github.com/AWikia/SkinEvelution/pull/34 at least removes the hook. But PackageFiles may be a better option to be honest. I've only done that once (with Cosmos) so I'd have to remember how to use PackageFiles. But this at least provides a little bit better code and method. Untested, you should test first though. [18:18:56] [url] Use JS Config vars instead of hook by Universal-Omega · Pull Request #34 · AWikia/SkinEvelution · GitHub | github.com [18:20:20] @HM100, RhinosF1: ^ [18:22:31] Merging soon [18:28:36] The hook for evelution config has been successfully removed [18:49:26] As a result, I have made a new project to help tracking the remaining issues for the Evelution Skin https://github.com/AWikia/SkinEvelution/projects/1 Once this project gets closed, Evelution 13.0.0 will be released [18:49:27] [url] Refactoring Evelution · GitHub | github.com [18:49:44] New issues and PRs can be added to increase the time required [19:00:20] not to sound mean but offtopic channel now feels like 90% evelution talk [19:02:21] We had a seriuos conversation about it. That's why [19:05:55] is there dedicated server? [19:05:58] Yes [19:06:18] Check DM [19:18:09] hey, off topic is off topic 🤷‍♂️ [19:18:18] can't complain [19:19:14] Things should come back to normal after a few days [19:34:03] I guess I'll better mute it again [19:38:42] You don't mute things and just look upon random interest? :p [19:44:59] @HM100: can https://github.com/AWikia/SkinEvelution/issues/29 be high [19:45:00] [url] Implement Security & Contributing policies · Issue #29 · AWikia/SkinEvelution · GitHub | github.com [19:45:58] You can use https://github.com/AWikia/SkinEvelution/security/policy for security [19:45:59] [url] Security Policy · AWikia/SkinEvelution · GitHub | github.com [19:46:49] thanks [19:46:56] https://github.com/AWikia/SkinEvelution/community is also good [19:46:56] [url] Community · GitHub | github.com [19:47:35] Doing it now [19:50:59] Did it [19:51:54] https://github.com/AWikia/SkinEvelution/blob/main/SECURITY.md [19:51:54] [url] SkinEvelution/SECURITY.md at main · AWikia/SkinEvelution · GitHub | github.com [19:53:50] Sec issues shouldn't be public [19:54:29] I don't have a phabricator instance [19:54:58] And yes those shouldn't be public [19:55:59] Fixed!!!! [19:57:28] Sending security issues to https://github.com/AWikia/SkinEvelution/security/advisories/new will be much better since those aren't public but private [19:57:28] [url] Page not found · GitHub · GitHub | github.com [19:58:24] That's not for non repo admins [19:58:27] Have an email [19:58:37] Or special:EmailUser on mediawiki.org [19:58:50] Or at least advertise a GPG key so issues can be encrypted [20:01:07] I have an email but I won't reveal it here. Rather I will at your DM [20:10:30] Special:EmailUser on mediawiki.org also suffaces [20:11:35] You can also use https://www.mediawiki.org/wiki/Special:EmailUser/Giorgos456 to report security issues [20:11:35] [url] No send address - MediaWiki | www.mediawiki.org [20:46:10] @HM100: you need to enable it [20:46:50] Enabled it [20:47:24] Try again https://www.mediawiki.org/wiki/Special:EmailUser/Giorgos456 [20:47:25] [url] No send address - MediaWiki | www.mediawiki.org [20:48:31] But unfortunately GlobalPreferencing on MW.org are not acting as they should [20:51:12] Lgtm [20:53:01] Does https://www.mediawiki.org/wiki/Special:EmailUser/Giorgos456 work now [20:53:02] [url] No send address - MediaWiki | www.mediawiki.org [20:55:07] Yes [20:55:21] CI is the next most important thing [20:55:35] I have added it (Node JS) but it always fails [20:55:42] I also added Code Scanning as a bonus [20:56:04] So the only thing is to make it work [20:58:46] Yeah I see the error [21:02:00] will work on i [21:02:27] ok [21:08:32] So I should close https://github.com/AWikia/SkinEvelution/issues/28 then [21:08:33] [url] Enable CI · Issue #28 · AWikia/SkinEvelution · GitHub | github.com [21:09:09] no [21:09:22] CosmicAlpha: can you do mediawiki-tests [21:11:19] Pinned and re-opened again [21:12:03] why did you merge [21:12:56] https://github.com/AWikia/SkinEvelution/pull/37 finishes my PR [21:12:57] [url] More fixes by RhinosF1 · Pull Request #37 · AWikia/SkinEvelution · GitHub | github.com [21:13:05] that makes it run [21:13:37] OK [21:14:04] Are you ready? If so, I will fix it [21:14:22] yes [21:17:22] https://github.com/AWikia/SkinEvelution/edit/main/.eslintrc.json This requires editing because it can't access to MediaWiki and jQuery JSJ [21:17:23] [url] Sign in to GitHub · GitHub | github.com [21:18:32] yeah CosmicAlpha will know bettter [21:24:35] https://gerrit.wikimedia.org/r/c/translatewiki/+/724385 [22:27:46] @Stewards could a Steward possibly process rename requests whenever they have time? A few users have been asking about when they would be processed [22:35:33] RhinosF1: I will do mediawiki-tests for it, but first I want to finish doing those for miraheze, as technically the CI script should work for external repos also, I'm not 100% certain. It also has a few hard-coded checks on CreateWiki dependencies (which can be removed for the skin, but not 100% necessary to, or shouldn't be anyways), and uses my own python script [22:35:33] https://github.com/Universal-Omega/scripts/blob/master/mediawiki/resolve_dependencies.py for dependencies. I'm not sure it will all be compatible with the skin. Worth a try I guess though. [22:35:33] [url] scripts/resolve_dependencies.py at master · Universal-Omega/scripts · GitHub | github.com