[00:50:47] <MacFanBot>	 [02ManageWiki] 07OAuthority created 03oapatch-1 (+1 new commit) 13https://github.com/miraheze/ManageWiki/commit/9ac583b602bf
[00:50:47] <MacFanBot>	 02ManageWiki/03oapatch-1 07OriginalAuthority 039ac583b Remove first error message
[00:51:14] <MacFanBot>	 [02ManageWiki] 07OAuthority opened pull request #523: Fix duplicated error messages (03master...03oapatch-1) 13https://github.com/miraheze/ManageWiki/pull/523
[00:52:10] <MacFanBot>	 [02ManageWiki] 07coderabbitai[bot] commented on pull request #523: --- […] 13https://github.com/miraheze/ManageWiki/pull/523#issuecomment-2537507692
[00:52:38] <MacFanBot>	 [02ManageWiki] 07github-actions[bot] pushed 1 new commit to 03oapatch-1 13https://github.com/miraheze/ManageWiki/commit/c91b30d7d6c6a4a6d4af7961fda9b12ba791af53
[00:52:38] <MacFanBot>	 02ManageWiki/03oapatch-1 07github-actions 03c91b30d CI: lint code to MediaWiki standards…
[00:56:15] <miraheze-github>	 miraheze/ManageWiki - OAuthority the build passed.
[01:28:53] <MirahezeRelay>	 <paladox> BlankEclair hi, I’m wondering if you know how to fix the search engine tests on https://github.com/SemanticMediaWiki/SemanticMediaWiki/actions/runs/12285879420/job/34284862048
[01:29:13] <BlankEclair>	 i'm here like "please, i just fixed an xss"
[01:29:23] <BlankEclair>	 but sure
[01:29:27] <BlankEclair>	 after i check the phorge backlog
[01:29:35] <BlankEclair>	 (or, i guess frontlog?)
[01:30:05] <MirahezeRelay>	 <paladox> Thanks!!! I looked earlier and just could not figure it out
[01:30:28] <BlankEclair>	 i'm here like "oh my god how do we have so many extensions installed if i keep finding XSSes on new ones"
[01:30:36] <MirahezeRelay>	 <paladox> I saw the comment that changed the identifier but that didn’t help much with fixing the test https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/phpunit/MediaWiki/Search/ExtendedSearchEngineTest.php#L63
[01:30:36] <MacFanBot>	 [GitHub] [SemanticMediaWiki/SemanticMediaWiki] tests/phpunit/MediaWiki/Search/ExtendedSearchEngineTest.php @ master | L63: 		$connection->expects( $this->any() )
[01:30:45] <MirahezeRelay>	 <paladox, replying to BlankEclair> Oh
[01:30:49] <BlankEclair>	 ?
[01:31:34] <MirahezeRelay>	 <paladox, replying to BlankEclair> That’s where it starts for one of the test.
[01:31:37] <MirahezeRelay>	 <paladox> > TypeError: SearchEngineFactory::getSearchEngineClass(): Argument #1 ($dbProvider) must be of type Wikimedia\Rdbms\IConnectionProvider, Mock_Database_7bf253ed given, called in /var/www/html/extensions/SemanticMediaWiki/src/Services/mediawiki.php on line 148
[01:31:45] <BlankEclair>	 gg
[01:31:50] <BlankEclair>	 glad to be a rubberduck?
[01:34:53] <MirahezeRelay>	 <paladox> Spent the entire day trying to fix the tests
[01:35:09] <MirahezeRelay>	 <paladox> So they pass on 1.41/1.42
[01:35:19] <MirahezeRelay>	 <paladox> I progressed significantly
[01:36:01] <BlankEclair>	 do you still need my help btw?
[01:36:19] <MirahezeRelay>	 <paladox> Yeh for the search engine thing
[01:36:24] <MirahezeRelay>	 <paladox> It’s driving me mad!
[01:36:38] <BlankEclair>	 oh yeah, you up to +2-ing a security fix? xD
[01:37:01] <MirahezeRelay>	 <paladox> Sure
[01:37:25] <MirahezeRelay>	 <paladox> I need to get https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/phpunit/MediaWiki/Search/ExtendedSearchEngineTest.php#L58 to be IConnectionProvider
[01:37:25] <MacFanBot>	 [GitHub] [SemanticMediaWiki/SemanticMediaWiki] tests/phpunit/MediaWiki/Search/ExtendedSearchEngineTest.php @ master | L58: 		$connection = $this->getMockBuilder( '\Wikimedia\Rdbms\Database' )
[01:39:04] <BlankEclair>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ArticleFeedbackv5/+/1102463
[01:39:57] <MirahezeRelay>	 <paladox> Test failure
[01:40:19] <BlankEclair>	 h
[01:42:40] <BlankEclair>	 wait what
[01:42:46] <BlankEclair>	 do we not have array spreading syntax?
[01:42:55] <BlankEclair>	 > return mw.message( fulltext, ...parameters ).parse();
[01:43:00] <BlankEclair>	 > 01:39:27   2073:32  error  Parsing error: Unexpected token .
[01:47:09] <MirahezeRelay>	 <paladox> No, I don’t think that’s enabled
[01:47:21] <MirahezeRelay>	 <paladox> Not sure tho
[01:47:21] <BlankEclair>	 wow okay
[01:47:24] <BlankEclair>	 anyway, i used .call()
[01:47:30] <MirahezeRelay>	 <paladox> Oh wait
[01:47:34] <BlankEclair>	 er, i meant .apply()
[01:47:42] <MirahezeRelay>	 <paladox> Shouldn’t it be {…}
[01:47:52] <BlankEclair>	 huh?
[01:48:17] <MirahezeRelay>	 <paladox> I mean {…parameters}
[01:48:29] <BlankEclair>	 no?
[01:48:55] <MirahezeRelay>	 <paladox> Or […parameters]
[01:49:02] <BlankEclair>	 nope, that just copies the array
[01:49:18] <BlankEclair>	 to put it in python terms, mw.message(fulltext, *parameters)
[01:49:26] <MirahezeRelay>	 <paladox> Ah ok
[01:49:40] <BlankEclair>	 anyway, i now got verified+2
[01:50:12] <MirahezeRelay>	 <paladox> +2’d
[01:50:15] <BlankEclair>	 ty
[01:51:31] <BlankEclair>	 i suppose we should backport it as well?
[01:51:36] <MirahezeRelay>	 <paladox> Yeh
[01:52:16] <BlankEclair>	 REL_1_4{1..3}?
[01:53:03] <MirahezeRelay>	 <paladox> Yeh
[01:53:25] <MirahezeRelay>	 <paladox> I’m not sure about 1.39 tho. Think it’s still supported (lts)?
[01:54:42] <BlankEclair>	 i... have no idea what the conventions are ^^;
[01:55:26] <BlankEclair>	 eh, why not
[01:55:39] <BlankEclair>	 merge conflicts
[01:58:23] <BlankEclair>	 REL1_42 tests for it failed
[01:58:36] <BlankEclair>	 is uh... is it my fault?
[01:59:35] <BlankEclair>	 nope lol
[01:59:47] <MirahezeRelay>	 <paladox> Not sure. I’m also going to be heading off in just a minute to bed
[01:59:49] <BlankEclair>	 paladox: what should i do if REL1_42 tests are failing but not because of code i touched
[01:59:50] <BlankEclair>	 oh lol okay
[02:00:27] <BlankEclair>	 +2 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ArticleFeedbackv5/+/1102469 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ArticleFeedbackv5/+/1102471?
[02:05:05] <MirahezeRelay>	 <paladox> https://github.com/wikimedia/mediawiki-extensions-ArticleFeedbackv5/commit/ca97a63bf14de98fab9dc2391cf1a1f998393ab2
[02:05:06] <MacFanBot>	 [GitHub] [wikimedia/mediawiki-extensions-ArticleFeedbackv5] libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 45.0.0… | 10 changes in 4 files | Authored 1 month, 9 days ago | Committed 1 month, 3 days ago
[02:05:15] <MirahezeRelay>	 <paladox> Maybe this should be backported
[02:05:16] <MirahezeRelay>	 <paladox> Dunno
[02:05:48] <BlankEclair>	 hmm yeah
[02:05:54] <BlankEclair>	 do i cherry that as well?
[02:06:46] <MirahezeRelay>	 <paladox> I tried and it has merge conflicts
[02:07:12] <MirahezeRelay>	 <paladox> I guess you could just apply (string) to it
[02:07:32] <BlankEclair>	 let's see how easy it is to reconcile that
[02:13:00] <MirahezeRelay>	 <paladox> Remove the null check as well
[02:13:07] <MirahezeRelay>	 <paladox> But I’m going to head off
[02:14:41] <BlankEclair>	 oh oki
[02:59:37] <MacFanBot>	 [02ssl] 07MacFan4000 pushed 1 new commit to 03master 13https://github.com/miraheze/ssl/commit/dee58992ca080ee2a181ce70d3dc1d85760cd445
[02:59:37] <MacFanBot>	 02ssl/03master 07MacFan4000 03dee5899 remove expired/non-pointed domains
[03:00:09] <MacFanBot>	 [02dns] 07MacFan4000 pushed 1 new commit to 03master 13https://github.com/miraheze/dns/commit/525f25bc72d007015583588e8969a2f7ae957b79
[03:00:10] <MacFanBot>	 02dns/03master 07MacFan4000 03525f25b Delete zones/hyperscandev.us.kg
[03:01:11] <miraheze-github>	 miraheze/dns - MacFan4000 the build passed.
[09:46:33] <icinga-miraheze>	 PROBLEM - opendatascot.org - LetsEncrypt on sslhost is WARNING: WARNING - Certificate 'opendatascot.org' expires in 14 day(s) (Fri 27 Dec 2024 09:44:26 AM GMT +0000).
[09:46:45] <MacFanBot>	 [02ssl] 07WikiTideSSLBot pushed 1 new commit to 03master 13https://github.com/miraheze/ssl/commit/d27156fa5df4b8d285578773d2483dcf99c8c8fa
[09:46:45] <MacFanBot>	 02ssl/03master 07WikiTideSSLBot 03d27156f Bot: Update SSL cert for opendatascot.org
[10:16:14] <icinga-miraheze>	 RECOVERY - opendatascot.org - LetsEncrypt on sslhost is OK: OK - Certificate 'opendatascot.org' will expire on Wed 12 Mar 2025 08:48:09 AM GMT +0000.
[12:11:44] <MacFanBot>	 [02MatomoAnalytics] 07translatewiki pushed 1 new commit to 03master 13https://github.com/miraheze/MatomoAnalytics/commit/43c8ed6e21c0cb3c1ffe36ee94801aa731e732a6
[12:11:44] <MacFanBot>	 02MatomoAnalytics/03master 07translatewiki.net 0343c8ed6 Localisation updates from https://translatewiki.net.
[12:16:54] <miraheze-github>	 miraheze/MatomoAnalytics - translatewiki the build passed.
[12:28:17] <icinga-miraheze>	 PROBLEM - ping6 on ns2 is CRITICAL: PING CRITICAL - Packet loss = 16%, RTA = 140.97 ms
[12:32:24] <icinga-miraheze>	 RECOVERY - ping6 on ns2 is OK: PING OK - Packet loss = 0%, RTA = 140.91 ms
[13:45:08] <icinga-miraheze>	 PROBLEM - ping6 on ns2 is CRITICAL: PING CRITICAL - Packet loss = 16%, RTA = 140.93 ms
[13:47:09] <icinga-miraheze>	 RECOVERY - ping6 on ns2 is OK: PING OK - Packet loss = 0%, RTA = 140.87 ms
[14:20:53] <icinga-miraheze>	 PROBLEM - ping6 on ns2 is CRITICAL: PING CRITICAL - Packet loss = 16%, RTA = 140.85 ms
[14:22:54] <icinga-miraheze>	 RECOVERY - ping6 on ns2 is OK: PING OK - Packet loss = 0%, RTA = 140.90 ms
[14:39:50] <icinga-miraheze>	 PROBLEM - amps.wiki.gd - Cloudflare on sslhost is CRITICAL: Name or service not knownHTTP CRITICAL - Unable to open TCP socket
[15:37:50] <icinga-miraheze>	 RECOVERY - amps.wiki.gd - Cloudflare on sslhost is OK: OK - Certificate 'amps.wiki.gd' will expire on Sun 26 Jan 2025 02:05:54 PM GMT +0000.
[16:14:08] <icinga-miraheze>	 PROBLEM - swiftobject161 Disk Space on swiftobject161 is CRITICAL: DISK CRITICAL - free space: / 80124MiB (5% inode=85%);
[17:26:15] <MacFanBot>	 [02dns] 07MacFan4000 pushed 1 new commit to 03master 13https://github.com/miraheze/dns/commit/f85c301d0d45daf06de7903b1e8dbc69a19bade7
[17:26:15] <MacFanBot>	 02dns/03master 07MacFan4000 03f85c301 Create lotr.su
[17:27:20] <MacFanBot>	 [02ssl] 07WikiTideSSLBot pushed 1 new commit to 03master 13https://github.com/miraheze/ssl/commit/2370dca92183c645cc169256beb9781f86e9f904
[17:27:20] <MacFanBot>	 02ssl/03master 07WikiTideSSLBot 032370dca Bot: Add SSL cert for lotr.su…
[17:27:20] <miraheze-github>	 miraheze/dns - MacFan4000 the build passed.
[17:48:25] <icinga-miraheze>	 PROBLEM - lotr.su - LetsEncrypt on sslhost is CRITICAL: CRITICAL - Certificate '*.miraheze.org' expired on Mon 18 Nov 2024 11:59:59 PM GMT +0000.
[17:49:29] <RhinosF1>	 Huh
[18:13:32] <MacFan4000>	 somehow it initially uses the old sectigo cert, but then fixes itself
[18:17:34] <icinga-miraheze>	 RECOVERY - lotr.su - LetsEncrypt on sslhost is OK: OK - Certificate 'lotr.su' will expire on Wed 12 Mar 2025 04:28:42 PM GMT +0000.
[18:18:07] <MacFanBot>	 [02ssl] 07MacFan4000 pushed 1 new commit to 03master 13https://github.com/miraheze/ssl/commit/5f00d78b08868ed1da8aba09622aa343187bc241
[18:18:07] <MacFanBot>	 02ssl/03master 07MacFan4000 035f00d78 add wiki.lightningwizards.com
[18:28:01] <MacFan4000>	 https://github.com/miraheze/puppet/blob/master/modules/varnish/templates/mediawiki.conf.erb#L101
[18:28:02] <MacFanBot>	 [GitHub] [miraheze/puppet] modules/varnish/templates/mediawiki.conf.erb @ master | L101: 	ssl_certificate /etc/ssl/localcerts/wildcard.miraheze.org-2020-2.crt;
[18:28:27] <MacFan4000>	 ^ cp* still serves the sectigo cert by default
[20:05:24] <RhinosF1>	 MacFan4000: ooops
[20:05:38] <RhinosF1>	 I think that should be the thingy one
[20:05:50] <RhinosF1>	 The cf one
[20:05:54] <RhinosF1>	 I forgot its name
[20:05:56] <RhinosF1>	 Origin!
[20:07:35] <RhinosF1>	 I think the wildcard can be deleted now if it's expired
[20:19:09] <MacFanBot>	 [02puppet] 07MacFan4000 opened pull request #4119: switch cp* default ssl to CF origin cert (07miraheze:03master...07MacFan4000:03patch-58) 13https://github.com/miraheze/puppet/pull/4119
[20:19:17] <MacFanBot>	 [02puppet] 07coderabbitai[bot] commented on pull request #4119: --- […] 13https://github.com/miraheze/puppet/pull/4119#issuecomment-2539939177
[20:30:25] <MacFanBot>	 [02puppet] 07paladox left a file comment in pull request #4119 0339d971e: This will break custom domains using varnish. Cloudflare cert can only be used with Cloudflare. 13https://github.com/miraheze/puppet/pull/4119#discussion_r1882844373
[20:39:01] <MacFanBot>	 [02puppet] 07RhinosF1 left a file comment in pull request #4119 0339d971e: No it won't - they'll use their block - it's an expired cert anyway, we don't need a default block at all tbh though. We should only be serving domains which have explicit configuration. We could remove the miraheze.org & default blocks altogether. 13https://github.com/miraheze/puppet/pull/4119#discussion_r1882854416
[20:43:18] <MacFanBot>	 [02puppet] 07paladox merged 07MacFan4000's pull request #4119: switch cp* default ssl to CF origin cert (07miraheze:03master...07MacFan4000:03patch-58) 13https://github.com/miraheze/puppet/pull/4119
[20:43:20] <MacFanBot>	 [02puppet] 07paladox pushed 1 new commit to 03master 13https://github.com/miraheze/puppet/commit/3f34b32cf8d4e9ae3ab9213a4d5bc163225c3445
[20:43:22] <MacFanBot>	 02puppet/03master 07MacFan4000 033f34b32 switch cp* default ssl to CF origin cert (#4119)…
[22:22:16] <MacFanBot>	 [02ssl] 07MacFan4000 pushed 1 new commit to 03master 13https://github.com/miraheze/ssl/commit/b47366bbbc0e3cbb9d46076171b3effc2bb43e30
[22:22:16] <MacFanBot>	 02ssl/03master 07MacFan4000 03b47366b Delete certificates/wildcard.miraheze.org-2020-2.crt…
[22:22:54] <MacFan4000>	 ^ with that the sectigo cert is completly gone
[23:35:58] <MacFanBot>	 [02mw-config] 07BlankEclair opened pull request #5769: T12992: Set custom footer images for aceistanwiki (07miraheze:03master...07BlankEclair:03T12992) 13https://github.com/miraheze/mw-config/pull/5769
[23:36:51] <miraheze-github>	 miraheze/mw-config - BlankEclair the build passed.
[23:37:39] <miraheze-github>	 miraheze/mw-config - BlankEclair the build passed.
[23:56:54] <MacFanBot>	 [02mw-config] 07MacFan4000 pushed 1 new commit to 03master 13https://github.com/miraheze/mw-config/commit/467f01884860decbf7772e3b37a7ca5ab3dd9ee8
[23:56:56] <MacFanBot>	 02mw-config/03master 07Claire 03467f018 T12992: Set custom footer images for aceistanwiki (#5769)…
[23:56:58] <MacFanBot>	 [02mw-config] 07MacFan4000 merged 07BlankEclair's pull request #5769: T12992: Set custom footer images for aceistanwiki (07miraheze:03master...07BlankEclair:03T12992) 13https://github.com/miraheze/mw-config/pull/5769
[23:57:31] <MacFanBot>	 [02mw-config] 07MacFan4000 merged 07BlankEclair's pull request #5767: T12980: Set custom footer images for utgwiki (07miraheze:03master...07BlankEclair:03T12980) 13https://github.com/miraheze/mw-config/pull/5767
[23:57:31] <MacFanBot>	 [02mw-config] 07MacFan4000 pushed 1 new commit to 03master 13https://github.com/miraheze/mw-config/commit/c38e56a4780aa7ac61d6b20187e0c32bf708643e
[23:57:31] <MacFanBot>	 02mw-config/03master 07Claire 03c38e56a T12980: Set custom footer images for utgwiki (#5767)…
[23:57:53] <miraheze-github>	 miraheze/mw-config - MacFan4000 the build passed.
[23:58:09] <miraheze-github>	 miraheze/mw-config - MacFan4000 the build passed.
[23:58:29] <miraheze-github>	 miraheze/mw-config - MacFan4000 the build passed.
[23:59:40] <miraheze-github>	 miraheze/mw-config - lihaohong6 the build passed.