[00:43:51] Within loadInputFromParameters it's caused by 'parent' @originalauthority [07:30:39] Updated https://discord.com/channels/407504499280707585/1006789349498699827/1166241421964083260 [07:31:13] Also removing another settings that are died at upstreams [11:48:53] bingo @originalauthority [11:48:55] i found it [11:48:59] it's the bloody type [11:51:58] Easy fix? [11:52:21] well to get it work i just remove the type htmlform [11:52:43] [1/3] > public static function loadInputFromParameters( $fieldname, $descriptor, [11:52:44] [2/3] > HTMLForm $parent = null [11:52:44] [3/3] > ) [11:52:44] to [11:52:49] > public static function loadInputFromParameters( $fieldname, $descriptor, $parent = null) [12:02:04] is this in ManageWiki, or MW Core? [12:03:49] hmm [12:03:58] it doesn't work now, wtf??? [12:04:10] i did reset the HtmlForm file back [12:06:32] i can try on my end to see if it works? [12:07:36] sure, although i don't know how i got it to work and then it just now fails. [12:07:43] it's $parent anyways (so $this). [12:09:24] [1/4] that breaks things even more for me: [12:09:24] [2/4] ``` [12:09:25] [3/4] Fatal error: Declaration of VFormHTMLForm::loadInputFromParameters($fieldname, $descriptor, ?HTMLForm $parent = null) must be compatible with HTMLForm::loadInputFromParameters($fieldname, $descriptor, $parent = null) in /var/www/html/mediawiki2/mediawiki/includes/htmlform/VFormHTMLForm.php on line 45 [12:09:25] [4/4] ``` [12:09:37] yeh you have to change it in that file as well [12:09:43] oh lol let me do it now [12:12:37] yeah, not working for me either [12:25:38] this is definitely giving me reinforcement for rewriting ManageWiki eventually [12:51:15] ohhh [12:51:31] well i'm out of ideas :/ [14:13:58] what version of php 8.2 do you use @originalauthority [14:15:04] not even 8.2, 8.1.2, so it must be an issue with php 8 overall? [14:15:16] oh [14:15:30] well there's a fix in 8.2.8 for array_merge_recursive [14:15:33] dunno if that fixes it tho [14:15:38] debian uses .7 [14:16:40] hmmm maybe that will fix it? [14:17:13] I need to switch to fpm so I can change the php version of just my 1.40 install [14:19:33] wikitide uses 8.2.11 and It works so I presume that it's fixed post 8.2.8 [14:24:19] Didn't fix it 😦 [14:26:07] grrrrrr [14:26:35] I wonder what's happening [16:03:58] i have no idea how to fix this lol [16:12:02] I'm partially tempted to revert the core change for HTMLForm just as a temporary fix [16:14:45] well array_merge_recursive to array_merge but i dunno if it breaks that thingy;. [19:49:02] UO had some alternatives that worked around this issue for ManageWiki, Agent can share those if that's of interest. [19:54:38] you hacked it? [19:55:03] That's my understanding, yes. [19:59:08] Oh [20:15:47] An easier hack would just be to revert the breaking change between 1.39 and 1.40 as above, but really it should be fixed upstream. [23:36:31] @paladox — I ended up just reverting https://github.com/wikimedia/mediawiki/commit/4727ed1a9ccb6c321e536f0249dafc1f4d160d88#diff-aa3fa1318f09ff43435c322bdd8ee1a5414bff900f31de6ddc5ff607b6d7f741 and it works as expected now; obviously not ideal, but [23:37:09] Probably want to do it on Gerrit as well @originalauthority [23:37:38] I doubt they'll merge it, though, if MW is the only extension experiencing the issue? [23:38:23] Could just use uo workaround