[13:11:44] <MirahezeRelay>	 <jph2> [1/3] WikiCreate seems to be acting up again. The last two wikis created did not get the main page boiler plate and their requestors were not given bureau rights.
[13:11:44] <MirahezeRelay>	 <jph2> [2/3] scpsecretlabde
[13:11:45] <MirahezeRelay>	 <jph2> [3/3] thetrawlerproject
[13:21:19] <MirahezeRelay>	 <pixldev> Huh
[13:21:22] <MirahezeRelay>	 <pixldev> > [03c60b088c3360eb1dc6faa7] 2024-01-07 13:20:57: Fatal exception of type "MediaWiki\Revision\RevisionAccessException"
[13:21:28] <MirahezeRelay>	 <pixldev> https://meta.miraheze.org/wiki/Meta:Wiki_creators?diff=prev&oldid=349789
[13:30:44] <MirahezeRelay>	 <pixldev> Do we no longer use https://cvt.miraheze.org/wiki/CVT_action_log?
[13:31:23] <MirahezeRelay>	 <rhinosf1> @reception123 I'm picking up train ticket then python
[14:31:41] <MirahezeRelay>	 <reception123, replying to rhinosf1> thanks!
[14:31:54] <MirahezeRelay>	 <reception123, replying to pixldev> We _should_ but given that there's not really been much CVT activity since June...
[14:32:12] <MirahezeRelay>	 <reception123, replying to jph2> For some reason that seems to ocasionally happen and no one has really figured out how to fix
[14:32:49] <MirahezeRelay>	 <pixldev, replying to reception123> Hm
[14:32:57] <MirahezeRelay>	 <pixldev> Good to know if
[14:33:26] <MirahezeRelay>	 <reception123> If the four nominations for Steward are succesful this will hopefully change
[14:33:37] <MirahezeRelay>	 <pixldev> Hopefully
[14:34:10] <MirahezeRelay>	 <jph2, replying to reception123> I know there was discussion about running a script later today? Should we wait until after that before creating any more wikis?
[14:34:22] <MacFan4000>	 (Technically there is a successful steward request, but it can’t close till NDA is done)
[14:34:33] <MirahezeRelay>	 <reception123, replying to jph2> I'm not sure which script? If you mean the deletion script that's been running for a while already and is unrelated
[14:35:39] <MirahezeRelay>	 <pixldev> [1/2] Im also hoping to try migrate one of fandoms anti vandalism rc tool things here(compared edits to a model feed on edits to score how likely it’s vandalism and notify CVT
[14:35:40] <MirahezeRelay>	 <pixldev> [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1193563607284334704/image0.jpg?ex=65ad2bbb&is=659ab6bb&hm=f52cf10005d3363c61523ab663cc8c376aaa6320a6bb1717c2177461d2ffdc07&
[14:35:55] <MirahezeRelay>	 <pixldev> Might be somewhat useful
[14:35:57] <MirahezeRelay>	 <pixldev> No ide
[14:36:00] <MirahezeRelay>	 <reception123, replying to pixldev> oh that's great! We definitely need better CVN tools
[14:36:10] <MirahezeRelay>	 <reception123> and easier reporting for users is exactly one aspect
[14:36:43] <MirahezeRelay>	 <pixldev, replying to reception123> You wouldn’t happen to know how to brutal wrangle python libraries? I’ve run docker build more times than I care to admit
[14:37:30] <MirahezeRelay>	 <pixldev> Lol
[14:37:59] <MirahezeRelay>	 <pixldev> Eh I’ll probably get there eventually
[14:38:15] <MirahezeRelay>	 <pixldev> May not be much but I wanna help out, and python is the only language I know so may as well use it
[14:38:26] <MirahezeRelay>	 <reception123> I'm no python expert though maybe RhinosF1 will be able to help
[14:38:32] <MirahezeRelay>	 <pixldev> And discord bots happen to be one of my worked areas
[14:38:44] <MirahezeRelay>	 <pixldev, replying to reception123> I’ll ask him once I get the base code to work
[14:38:54] <MirahezeRelay>	 <pixldev> Currently it’s a matter of dependencies
[14:39:22] <MirahezeRelay>	 <pixldev> Than I can take a look at the code to see how to change it from fandom to Mira
[14:39:23] <MirahezeRelay>	 <rhinosf1> I'm here
[14:39:45] <MirahezeRelay>	 <pixldev> Morning
[14:41:18] <MirahezeRelay>	 <rhinosf1> What python you need help with
[14:43:50] <MirahezeRelay>	 <pixldev> Rn its less code and getting libraries installed
[14:43:54] <MirahezeRelay>	 <pixldev> I’ll get the repo rq
[14:44:14] <MirahezeRelay>	 <pixldev> This is what fandom uses, was hoping to adapt it for us https://github.com/soap-team/cynthia
[14:44:16] <MirahezeRelay>	 <jph2, replying to reception123> [1/2] Ok. I thought CosmicAlpha was going to do something after he got some sleep.
[14:44:17] <MirahezeRelay>	 <jph2, replying to reception123> [2/2] Should I reopen the phab task?
[14:45:11] <MirahezeRelay>	 <pixldev> I have a wip dockerfile for this, and also had to loosen some stuff in requirements.txt. It’s… very messy
[14:46:11] <MirahezeRelay>	 <theoneandonlylegroom, replying to jph2> it was a problem w/ special page on a single wiki
[14:46:12] <MirahezeRelay>	 <rhinosf1, replying to pixldev> Is this not the code I said I wouldn't let anywhere near production
[14:46:33] <MirahezeRelay>	 <rhinosf1> When some fandom person offered to help with it at Miraheze
[14:46:38] <MirahezeRelay>	 <pixldev> Was it? Was that to me or some else
[14:48:27] <MirahezeRelay>	 <rhinosf1> Someone involved in the soap team
[14:49:04] <MirahezeRelay>	 <theoneandonlylegroom> huh
[14:49:19] <MirahezeRelay>	 <rhinosf1> Yes
[14:50:02] <MirahezeRelay>	 <rhinosf1> When they offered it to us, I said I wouldn't let code of that poor standard anywhere near a production Miraheze server
[14:50:11] <MirahezeRelay>	 <rhinosf1> @pixldev
[14:51:58] <MirahezeRelay>	 <pixldev> Ah, well good to know ahead of time
[14:54:19] <MirahezeRelay>	 <pixldev> Shame, could have been a useful asset
[14:55:05] <MirahezeRelay>	 <pixldev> And I am in no way qualified to improve it
[14:55:28] <MirahezeRelay>	 <pixldev> I’ve made it substantially worse trying to get it to run
[15:19:43] <MirahezeRelay>	 <rhinosf1> @reception123 why has X-Debug broken?
[15:20:47] <MacFan4000>	 @rhinosf1 CA made some changes to MHDebug yesterday
[15:21:22] <MirahezeRelay>	 <rhinosf1> He may have broke it
[15:21:30] <MirahezeRelay>	 <rhinosf1> as CI for puppt is complaining
[15:23:41] <MirahezeRelay>	 <reception123> Hmm yeah, we'll probably have to wait for CA to fix that
[15:27:07] <MirahezeRelay>	 <rhinosf1> @reception123 I am currently working on rename-wiki
[15:40:50] <MirahezeRelay>	 <rhinosf1> ok that was a stupid bug
[15:43:20] <MirahezeRelay>	 <pixldev> Hm?
[15:43:25] <MirahezeRelay>	 <rhinosf1> me
[15:43:28] <MirahezeRelay>	 <rhinosf1> i made a bug
[15:44:29] <MirahezeRelay>	 <pixldev> Smh take a look at my development process and then tell me what you wrote was a stupid bug
[15:48:25] <MirahezeRelay>	 <rhinosf1> just need to fix modules/mediawiki/files/cookbooks/rename-wiki.py:36: error: Incompatible return value type (got "object", expected "str")  [return-value]
[15:59:34] <MirahezeRelay>	 <reception123> @cosmicalpha not sure what happened with PageProperties but it's causing some wikis to be completely down -  https://phabricator.miraheze.org/T11636
[15:59:40] <MirahezeRelay>	 <reception123> and even insering SQL doesn't fix
[16:18:06] <MirahezeRelay>	 <rhinosf1> @reception123 is passing CI
[16:18:07] <MirahezeRelay>	 <rhinosf1> https://github.com/miraheze/puppet/pull/3589/files
[16:18:18] <MirahezeRelay>	 <rhinosf1> be very careful testing
[16:18:34] <MirahezeRelay>	 <rhinosf1> there is a guard up so you need to press c and then enter to allow a command
[16:18:37] <MirahezeRelay>	 <rhinosf1> or s/a
[16:34:57] <MirahezeRelay>	 <reception123> Nice! Thanks!
[16:35:04] <MirahezeRelay>	 <reception123> I'll get to it later today
[16:57:47] <MirahezeRelay>	 <pixldev, replying to rhinosf1> If I may ask, what parts in particular do you take issues with the quality? (Im not an exceptionally adept python developer by any means so curious)
[16:58:08] <MirahezeRelay>	 <rhinosf1, replying to pixldev> the utter lack of CI
[17:09:00] <MirahezeRelay>	 <pixldev, replying to rhinosf1> So your issue is with the development process, not the codebase?
[17:09:33] <MirahezeRelay>	 <rhinosf1> poor process leads to poor code
[17:10:59] <MirahezeRelay>	 <pixldev, replying to rhinosf1> Understandable
[17:11:13] <MirahezeRelay>	 <pixldev> oh well
[17:11:19] <MirahezeRelay>	 <pixldev> was worth a shot at least
[17:12:37] <MirahezeRelay>	 <rhinosf1> CI is there for a reason
[17:12:50] <MirahezeRelay>	 <rhinosf1> It can catch a lot
[17:13:17] <MirahezeRelay>	 <rhinosf1> From security issues to unexpected error conditions to things that'll change in future versions
[17:18:17] <MirahezeRelay>	 <pixldev, replying to rhinosf1> yeah the last one is a big one, I spend a good hour trying to get requirements.txt to work probably cause the code is a few years old
[17:18:32] <MirahezeRelay>	 <pixldev> I might clone the repo and try to set up CI for the heck of it
[17:19:14] <MirahezeRelay>	 <rhinosf1> Steal what's in puppet for Python
[17:19:34] <MirahezeRelay>	 <rhinosf1> That will have you meet my standard of what's good
[17:21:22] <MirahezeRelay>	 <pixldev, replying to rhinosf1> Sure thing
[17:21:49] <MirahezeRelay>	 <pixldev> ill let ya know how it goes
[17:40:25] <RhinosF1>	 MacFan4000: wm-bot is dead in #mediawiki
[17:43:15] <MirahezeRelay>	 <cosmicalpha, replying to reception123> oh... that extension needs disabled pending another security review, I forgot about that. New version of it completely rewrote the extension and even changed the functionality of what the extension is to be something a lot more complex. Not saying it isn't safe but it needs a new review...
[17:43:42] <RhinosF1>	 MacFan4000: problem is a user error
[17:46:32] <MacFan4000>	 RhinosF1: looking at channel logs, I see a restricted phab ticket was linked
[17:46:47] <RhinosF1>	 MacFan4000: yes
[17:46:50] <RhinosF1>	 User error
[19:52:09] <MirahezeRelay>	 <reception123> @rhinosf1 salt syntax isn't fully right, as salt doesn't like "", only '' it seems
[19:52:21] <MirahezeRelay>	 <reception123> so I think we'll have to use `'` twice and escape it
[19:52:32] <MirahezeRelay>	 <rhinosf1> Okay
[19:52:44] <MirahezeRelay>	 <rhinosf1> What's the exact command at the execute line?
[19:57:20] <MirahezeRelay>	 <rhinosf1> @reception123
[20:03:28] <MirahezeRelay>	 <pixldev> is there a role to ping for #New wiki - no permissions issues?
[20:03:38] <MirahezeRelay>	 <pixldev> To grant rights
[20:05:18] <MirahezeRelay>	 <rhinosf1> If it's just permissions then stewards
[20:07:52] <MirahezeRelay>	 <reception123> hmm, looks like it actually doesn't like it permissions wise either
[20:07:54] <MirahezeRelay>	 <reception123> `    ERROR 1045 (28000): Access denied for user 'root'@'localhost' (using password: NO)`
[20:18:45] <MirahezeRelay>	 <rhinosf1> @reception123 that doesn't surprise me
[20:19:02] <MirahezeRelay>	 <rhinosf1> But what does have access
[20:25:46] <MirahezeRelay>	 <pixldev, replying to reception123> access denied… to root
[20:29:29] <MirahezeRelay>	 <reception123> @paladox is that intentional? (salt not having access to mysql commands)
[20:32:17] <MirahezeRelay>	 <paladox> No
[21:33:09] <MirahezeRelay>	 <reception123> @rhinosf1 fixed thanks to CA's help but now it's being stupid
[21:33:11] <MirahezeRelay>	 <reception123> [1/4] `reception@puppet141:~$ sudo salt-ssh -E 'db131' cmd.run 'sudo -i mysql -e "SELECT wiki_dbcluster FROM mhglobal.cw_wikis WHERE wiki_dbname = 'surpisenerdswiki';"'
[21:33:12] <MirahezeRelay>	 <reception123> [2/4] db131.miraheze.org:
[21:33:12] <MirahezeRelay>	 <reception123> [3/4]     ERROR 1054 (42S22) at line 1: Unknown column 'surpisenerdswiki' in 'where clause'
[21:33:12] <MirahezeRelay>	 <reception123> [4/4] `
[21:33:21] <MirahezeRelay>	 <reception123> that makes no sense... and the command copy/pasted exactly works directly on db131
[21:34:38] <MirahezeRelay>	 <reception123> ah, must be escaping
[21:35:55] <MirahezeRelay>	 <reception123> Final command: `sudo salt-ssh -E 'db131' cmd.run 'sudo -i mysql -e "SELECT wiki_dbcluster FROM mhglobal.cw_wikis WHERE wiki_dbname = '\''surpisenerdswiki'\'';"' `
[21:36:17] <MirahezeRelay>	 <reception123> so once the escaping is done in the script we should be good to test again
[21:40:00] <MirahezeRelay>	 <rhinosf1> @reception123 okay feel free to do that
[21:42:17] <MirahezeRelay>	 <rhinosf1> @reception123 feel free to apply your suggestion
[21:48:35] <MirahezeRelay>	 <reception123> Ok, I'll try that tomorrow as I should be more awake for stuff like this
[23:00:09] <MirahezeRelay>	 <orduin, replying to reception123> Hmm, if that misbehaves, you can always use c-style strings for cleaner escaping. eg: `salt-ssh -E 'db131' cmd.run $'sudo -i mysql -e "SELECT wiki_dbcluster FROM mhglobal.cw_wikis WHERE dbname = \'surpisenerdswiki\';"'`