[00:24:58] https://phabricator.wikimedia.org/T355442#9474008 ah another classic example of "WMF or else" and who cares about everybody else. [00:52:59] :( [00:53:01] oh well [01:00:25] Sad. "we broke it for you. sucks to be you." [01:01:44] [1/2] Especially if it's as simple as leaving a parameter for others to use that WMF never uses. [01:01:45] [2/2] I mean, it's like just a line of code. [08:04:46] I mean tbh they have a task for auto login improvements [12:25:14] @rhinosf1 if you're around this weekend maybe we can solve the rename script mess with only the third line being needed for the result [12:32:10] I began working on a new notif system [12:32:23] I am dubbing it....notiheze [12:41:06] Tomorrow [13:15:07] @reception123 is request_source missing from the sql [13:15:17] it's in the sqlite file but not mysql [13:15:43] Eh, I feel there’s a missed opportunity for a bee pun here [13:16:57] Ah, that should be customdomain. Source was what ID used [13:16:57] Throw me any other names you can think of [13:17:05] it's in table.json [13:17:47] The correct one would be the one in mysql/tables generated [13:18:18] looks like just needs the sql files to be regenerated [13:18:42] (which i'm not sure how to do). Anyways the repo has running tests [13:18:56] request_source is used in the tests as well [13:21:40] Its a maintenance script iirc but idk which one [13:23:47] buzz [13:23:53] Buzzer [13:32:32] Was just trying to correlate that with MH but then realised the logo [13:33:20] Lol [13:33:27] maybe "bee" in another language lol [13:33:30] We need more bee branding ngl [13:34:19] https://cdn.discordapp.com/attachments/1006789349498699827/1198259213026209792/image0.jpg?ex=65be40da&is=65abcbda&hm=112556392f1441aa789017098d7d8ec2ee0db775ea546562b2b058333e39facc& [13:34:32] I fucking love German compound nouns [14:01:52] (totally not what a russian cell network operator did in the 90s) [15:16:06] Did you auto generate the sql? [15:24:30] Hey Orange_Star [15:24:55] hi [15:25:00] was looking at the CI [15:29:55] So, tests need to be modified [15:30:13] and tables.json also needs some attention to make it match the generated SQL [15:36:27] tables.json should never differ from the sql [15:36:39] The sql should not under any circumstance be manually edited [15:36:55] yeah, but the extension is designed around the sql, so it's easier to make tables.json adapt to this [15:37:26] Hmm [15:42:07] besides, fields like "source" make no sense in the context of RequestSSL [15:42:15] "customdomain" makes much more sense [15:55:09] death by indent: https://github.com/miraheze/RequestSSL/actions/runs/7595361667/job/20687836008?pr=13 [15:57:39] what does it even want me to do here? [15:57:55] I can't control what people do in the NPM packages [15:59:43] Orange_Star: no need to run CI [15:59:54] Just exclude vendor [16:01:29] Need to fix table.json to remove any unused columns and then regenerate sql [16:02:40] RhinosF1: Tutorial 4 dummies? [16:04:01] ^ remove whatever fields aren't being used and run generateSchemaSql.php should do it [16:05:09] how is that going to affect npm-test? [16:06:27] Copy https://github.com/miraheze/ImportDump/blob/master/.eslintrc.json [16:07:03] thx paladox [16:09:31] Orange_Star: I did https://github.com/redbluegreenhat/RequestSSL/pull/1 per https://eslint.org/docs/latest/use/configure/ignore [16:09:35] But no idea if that's right [16:09:40] Paladox might be correct [16:10:06] Ye [16:10:10] What Paladox said [16:15:38] Copy https://github.com/miraheze/ImportDump/blob/master/.stylelintrc.json [16:15:53] And copy https://github.com/miraheze/ImportDump/blob/master/.phpcs.xml [16:22:54] finally, we're getting further [16:22:57] thanks for the assist [16:52:05] just notices that the term source is still used in RequestSSLManager [16:52:11] I'll fix it after I'm done with the CI [17:48:27] UO managed to get the CI to pass in PHP 8.2 in MW 1.41 and master [17:49:08] 1.40 with PHP 8.1 returning cryptic errors [17:49:37] Oh [17:49:41] UO found it