[18:06:10] I guess there's a first time for everything after all [18:06:30] (talking about trying to do hooks and jobs for the first time, CI is tearing apart my code hehehe) [18:08:12] granted, some of it is my fault like trying to new RequestSSLManager with no params [18:10:25] (more like all of it actually) [18:18:00] ez, first try :p [18:34:29] Reception123: if you have any questions about my vision of RequestSSL, I'm here to answer them [18:45:20] Orange_Star: a bit confused about your answer [18:45:28] you said 5 would go before 4 [18:45:59] but yeah, I do get that it's tricky making it non-Miraheze specific [18:46:34] What I mainly wonder is whether the point check will be done twice [18:46:54] Shut up @MirahezeRelay [18:46:55] or whether we can just add NS automatically even before the request is processed (though if it's processed instantly without intervention needed that shouldn't make a difference) [18:47:02] ? [18:47:27] I just think the relay is a little annoying sometimes [18:47:59] it's not the relay, we're Miraheze users commentating like anyone from Discord [18:48:15] I don't see what you mean as even if we were on Discord we'd still be communicating the same amount [18:49:23] Well there's actually nothing stopping from going in your order [18:49:52] it doesn't really matter anyway because the generation of the certificate will be done after the request is marked as handled [18:50:34] Oh, I thought it would be marked as completed only after it's generated [18:50:43] as what if generation fails for some reason? then it would get added to managewiki without it having worked [18:50:47] ie: Puppet will see the POST requesting the new certificate and will return 200 immediatelly and deal with the cert later [18:50:56] though unlike ImportDump where some SRE oversight is needed I was thinking RequestSSL can be completely automatic [18:51:12] (when it's fully finished of course) [18:51:18] It can be [18:51:37] It's just when it fails, like Puppet fails to generate the cert, it will need manual assistance [18:52:55] since the extension will now have a way to know if the domain is pointed, it can handle the request on it's own actually [18:53:12] in my PR it doesn't do that right now, but will in the future [18:53:50] but yeah, for the puppet part we'll need to see what CosmicAlpha figues out, unless you want to try your luck for the puppet API endpoint :D [18:55:00] rn I don't know how the API would look like exactly [18:55:31] just hoping I did the Job and Hook stuff correctly [18:58:01] I'll let CA have a look at that too as that's beyond my knowledge [19:46:00] I already had a preliminary API for puppet but haven't been able to test yet. [19:55:03] I'm a bit confused about how RequestSSL will interact with the domain check part that would be on puppet181 as currently the plan was to integrate that into ssl-certificate.py