[07:23:18] [1/19] Reporting of wikis with errors: [07:23:19] [2/19] * https://tagpedia.miraheze.org [07:23:19] [3/19] > MediaWiki internal error. [07:23:19] [4/19] > [07:23:20] [5/19] > Original exception: [4c7bbf88f9a308b237c382a9] 2024-02-06 07:04:15: Fatal exception of type "ArgumentCountError" [07:23:20] [6/19] > [07:23:20] [7/19] > Exception caught inside exception handler. [07:23:21] [8/19] > [07:23:21] [9/19] > Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information. [07:23:21] [10/19] * https://tanukipedia.miraheze.org [07:23:22] [11/19] > MediaWiki internal error. [07:23:22] [12/19] > [07:23:23] [13/19] > Original exception: [40caa8c6c3de1772f7249d7c] 2024-02-06 07:07:15: Fatal exception of type "Error" [07:23:23] [14/19] > [07:23:24] [15/19] > Exception caught inside exception handler. [07:23:24] [16/19] > [07:23:25] [17/19] > Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information. [07:23:25] [18/19] These were all reported by some user [07:23:26] [19/19] Impact of MediaWiki upgrade? [10:16:39] > Too few arguments to function MediaWiki\Extension\MultimediaViewer\Hooks::__construct(), 1 passed in /srv/mediawiki/1.41/extensions/RatePage/includes/RatePageMmvHooks.php on line 21 and exactly 2 expected [10:17:19] Second one is from AuthorProtect. [10:17:54] https://gitlab.com/nonsensopedia/extensions/ratepage/-/merge_requests/134 but i doubt it's gonna get merged, doesn't seem very active [10:19:23] Can temporarily disable the extension, @reception123 / @cosmicalpha / @originalauthority up to you. [10:37:31] i've disabled it temporarily https://github.com/miraheze/mw-config/pull/5463 [10:43:15] authorprotect is unfortunate but ratepage I've hardly ever seen used meaningfully in the wild [10:46:20] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AuthorProtect/+/997776 [17:00:15] I'm looking at T11798 for funsies [17:00:27] so far I have one question, why is upsert used at all? [17:01:15] creating a new wiki request and updating one should be independent [17:02:24] It introduces a bit of code duplication, but SELECTs and INSERTs are way easier to wrap your head around than "upserts". [17:04:05] *INSERTs and UPDATEs [17:15:47] Orange_Star: we are using upsert? [17:15:50] Please no [17:15:54] yes we are [17:15:55] Like no no and no [17:16:05] They waste auto_increment values [17:16:30] do a select & insert [17:16:40] Upsert should be a code sniff [17:17:23] Looks like John did it so that the WikiRequest class could be used for both new requests not yet in the DB and for existing requests [17:17:43] but it really should not and should do this like ImportDump and RequestSSL [17:17:57] Ye [17:18:07] I have no idea why that was thought a good idea [17:18:09] It is not [17:18:20] I did it differently for ImportDump because I hated upsert [17:18:26] * RhinosF1 suggests burning upsert with fire [17:18:29] CosmicAlpha: good [17:18:35] You should hate upsert [17:18:42] It's a really bad idea [17:18:54] I'm throwing all that upsert stuff straight to the garbage and rewriting that [17:19:05] I think CW has been wrong for a very long time, it is just finally actually 'broken' now. [17:19:28] Orange_Star: can you burn it with fire and a lot of petrol? [17:19:45] Orange_Star: up for a bit of PM conversation, as our new MW SE, I want to share a lot of my ideas I had for CW [17:20:25] sure, hop on IRC [17:20:37] Cosmic is connected [17:20:40] Yep, I'm here [17:22:20] I forgot who said but I guess WCs are on vacation until upsert is blown up and RequestWiki fixed [17:22:33] Ye [17:22:54] oof [17:25:08] lol [17:25:53] My wiki images is not that small so, @agentisai we may have to send it somewhere else [17:56:06] If RequestWiki isn't fixed soon, time to have a [[February 2024 Temporary Wiki Requests]] page [17:56:07]

[17:56:27] that's if WCs start enjoying their vacation too much 😄 [18:05:39] in the meantime I've added a note to the i18n messages asking people to come back tomorrow (hopefully they do!) [18:32:25] I think I got the bandaid ready [18:32:54] ready for bandaid testing? [18:33:02] when CI passes [18:36:36] I'm rewriting WikiRequest.php after this, man [18:37:56] not a patient person are we agent? [18:38:07] we don't care for 1.40 anymore [18:38:51] fingers crossed everyone! [18:39:59] https://meta.miraheze.org/wiki/Special:RequestWikiQueue/40764 [18:40:06] seems it worked! [18:40:59] [1/3] Error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE cw_id = '40764'' at line 1 [18:40:59] [2/3] Function: Miraheze\CreateWiki\RequestWiki\WikiRequest::save [18:40:59] [3/3] Query: UPDATE `cw_requests` SET Array WHERE cw_id = '40764' [18:41:07] well now [18:41:14] oops [18:41:16] I see the error [18:43:18] change merged and ready for testingh [18:44:48] not a patient person are we? [18:46:02] you got me there :p [18:46:27] it worked \:) [18:46:34] will deploy on production now [18:46:39] well, I guess that's that crisis done for then