[00:40:49] <MirahezeRelay>	 <pixldev, replying to originalauthority> Complex or simple fix?
[00:52:25] <MirahezeRelay>	 <originalauthority> Not sure, i would assume if it was simple it might have been fixed by now
[00:53:55] <MirahezeRelay>	 <pixldev, replying to originalauthority> Agreed
[00:54:06] <MirahezeRelay>	 <pixldev> But also this is software development
[00:54:09] <MirahezeRelay>	 <pixldev> cant assume shit
[02:32:14] <MirahezeRelay>	 <rodejong> [1/3] You guys probably know all this, but thought I'd share it anyway. In case you didn't know.
[02:32:14] <MirahezeRelay>	 <rodejong> [2/3] Tools collection:
[02:32:15] <MirahezeRelay>	 <rodejong> [3/3] https://wiki.gamedetectives.net/index.php?title=ARG_Toolbox
[03:30:35] <MirahezeRelay>	 <cosmicalpha> https://github.com/miraheze/ImportDump/pull/66
[03:32:51] <MirahezeRelay>	 <cosmicalpha> [1/2] `212 | WARNING | Line exceeds 120 characters; contains 121
[03:32:51] <MirahezeRelay>	 <cosmicalpha> [2/2]      |         | characters (Generic.Files.LineLength.TooLong)` REALLY? 1 character more lol
[03:33:23] <MirahezeRelay>	 <cosmicalpha> [1/5] happens on 2 lines actually lol
[03:33:23] <MirahezeRelay>	 <cosmicalpha> [2/5] ` 212 | WARNING | Line exceeds 120 characters; contains 121
[03:33:24] <MirahezeRelay>	 <cosmicalpha> [3/5]      |         | characters (Generic.Files.LineLength.TooLong)
[03:33:24] <MirahezeRelay>	 <cosmicalpha> [4/5]  742 | WARNING | Line exceeds 120 characters; contains 121
[03:33:24] <MirahezeRelay>	 <cosmicalpha> [5/5]      |         | characters (Generic.Files.LineLength.TooLong)` another is 123
[03:37:21] <MirahezeRelay>	 <lichmaster98> Sorry my terminal is only 120 characters exactly
[09:06:59] <MirahezeRelay>	 <.labster> [1/2] I don't understand a lot of this PR, but this change worries me, adding a value in the middle of an enum
[09:06:59] <MirahezeRelay>	 <.labster> [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1208701184576069692/image.png?ex=65e43db2&is=65d1c8b2&hm=bf519dd2cd7e5b23dfd1f436e6f5f81937083e72e3a05ee7d165243e160a5cfd&
[09:26:27] <MirahezeRelay>	 <rhinosf1, replying to .labster> Why are we using ENUMs?
[09:33:05] <MirahezeRelay>	 <.labster> Don't ask me, I didn't write it.
[09:34:03] <MirahezeRelay>	 <.labster> Presumably because someone thought saving 0.2µs compared to a text index was worth the maintenance cost
[09:36:57] <MirahezeRelay>	 <rhinosf1> WMF deployed code shouldn't use them
[09:37:02] <MirahezeRelay>	 <rhinosf1> See the very old https://phabricator.wikimedia.org/T119173
[09:37:14] <MirahezeRelay>	 <rhinosf1> And it would be nice to have consistent code standards
[10:47:43] <MirahezeRelay>	 <bluemoon0332> good thing this ain't WMF code
[10:49:05] <MirahezeRelay>	 <bluemoon0332> 😉
[10:54:43] <MirahezeRelay>	 <bluemoon0332> @cosmicalpha found a nitpick in the PR, left a reviewe
[10:54:56] <MirahezeRelay>	 <bluemoon0332> *mistake
[10:55:02] <MirahezeRelay>	 <bluemoon0332> not really a nitpick
[11:23:19] <MirahezeRelay>	 <rhinosf1, replying to bluemoon0332> The reasoning behind it is valid
[11:23:23] <MirahezeRelay>	 <rhinosf1> For once
[11:30:40] <MirahezeRelay>	 <bluemoon0332, replying to bluemoon0332> Nevermind! https://www.php.net/manual/en/language.references.pass.php
[11:31:27] <MirahezeRelay>	 <bluemoon0332> can't say I really like that, but it is what it is
[16:23:21] <MirahezeRelay>	 <mrrist> [1/2] hello, how can I insert a YouTube video into the gallery?
[16:23:21] <MirahezeRelay>	 <mrrist> [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1208810999717826560/fab77baa748e8888.png?ex=65e4a3f8&is=65d22ef8&hm=2d12f5731b04021a8c4202641a6f7be0690e7a6273cd0f039366138197f277cb&
[16:30:31] <MirahezeRelay>	 <rodejong> You need an extension for that
[16:31:12] <MirahezeRelay>	 <rodejong> Your wiki.miraheze.org/wiki/Special:ManageWiki/extensions#mw-section-parserhooks
[16:31:37] <MirahezeRelay>	 <rodejong> [1/2] or search YouTube in the search bar of 
[16:31:38] <MirahezeRelay>	 <rodejong> [2/2] Your wiki.miraheze.org/wiki/Special:ManageWiki/extensions
[16:41:48] <MirahezeRelay>	 <theoneandonlylegroom, replying to mrrist> [1/2] you can't insert embedded videos in gallery, you can only add them in a section separately
[16:41:48] <MirahezeRelay>	 <theoneandonlylegroom, replying to mrrist> [2/2] YouTube extension is enough if it's just Youtube
[16:42:24] <MirahezeRelay>	 <theoneandonlylegroom> also please ask support questions in #general or #support
[17:32:09] <MirahezeRelay>	 <mrrist, replying to theoneandonlylegroom> Ok, sorry
[19:06:05] <MirahezeRelay>	 <cosmicalpha, replying to rhinosf1> I'll probably phase out enum eventually but for now just left it how it was originally done, which I probably shouldn't have to begin with...
[21:05:03] <MirahezeRelay>	 <cosmicalpha> @bluemoon0332 I tested ImportDump and it seems to work. Do you want to do another review before I add more complexity with notifications or wait till I finish completely?
[21:06:55] <MirahezeRelay>	 <.labster> Did you change the enum thing? Enums are append-only.
[21:07:33] <MirahezeRelay>	 <.labster> If you put a value in the middle it changes the meaning of previous rows
[21:07:52] <MirahezeRelay>	 <pixldev> wat
[21:08:06] <MirahezeRelay>	 <pixldev> i don’t entirely understand but that seems very goofy ah silly
[21:08:13] <MirahezeRelay>	 <.labster> Or has this not been deployed yet so there’s no data?
[21:08:40] <MirahezeRelay>	 <rhinosf1> Current version of import dump uses enums
[21:08:45] <MirahezeRelay>	 <rhinosf1> So ye it would cause data loss
[21:08:53] <MirahezeRelay>	 <rhinosf1> @cosmicalpha
[21:09:04] <MirahezeRelay>	 <rhinosf1, replying to pixldev> ENUMs are a mess for many reasons
[21:09:11] <MirahezeRelay>	 <rhinosf1> I have no idea why we are using them
[21:09:26] <MirahezeRelay>	 <cosmicalpha, replying to .labster> I changed it on beta and it worked fine without loss
[21:09:59] <MirahezeRelay>	 <cosmicalpha> But I plan to get rid of ENUM completely anyway
[21:12:21] <MirahezeRelay>	 <pixldev, replying to rhinosf1> :pepenotes:
[21:12:26] <MirahezeRelay>	 <.labster> It’s possible it will be fine because of how PHP executes the statements. As long as you don’t recreate the table and put old data into it it might be fine
[21:13:55] <MirahezeRelay>	 <cosmicalpha> [1/5] I just ran
[21:13:55] <MirahezeRelay>	 <cosmicalpha> [2/5] ```sql
[21:13:55] <MirahezeRelay>	 <cosmicalpha> [3/5] ALTER TABLE importdump_requests
[21:13:56] <MirahezeRelay>	 <cosmicalpha> [4/5] MODIFY request_status ENUM('complete', 'declined', 'failed', 'inprogress', 'pending') NOT NULL;
[21:13:56] <MirahezeRelay>	 <cosmicalpha> [5/5] ```
[21:13:59] <MirahezeRelay>	 <pixldev> got it- side note, which software installs extension repos/actually used the mediawiki-repos repository
[21:14:10] <MirahezeRelay>	 <cosmicalpha> Puppet
[21:14:31] <MirahezeRelay>	 <pixldev> It’s always back to puppet
[21:14:45] <MirahezeRelay>	 <rhinosf1> Well technically puppet installs the staging version
[21:15:01] <MirahezeRelay>	 <rhinosf1> Which isn't technically meant to be a usable mediawiki install
[21:15:05] <MirahezeRelay>	 <rhinosf1> But kinda is
[21:15:18] <MirahezeRelay>	 <rhinosf1> Then deploy-tool deploys it
[21:15:29] <MirahezeRelay>	 <cosmicalpha> It also auto-deploys MirahezeMagic updates
[21:16:12] <MirahezeRelay>	 <.labster> Enums are a good idea in principle, mapping common values to integers for less storage and value validation. But the costs of changing the schema to add new values is high, and with modern (>2000ad) storage and processors, the speed and storage are less costly than programmer time spent on Enums
[21:16:31] <MirahezeRelay>	 <cosmicalpha> Tbh though it's probably the most complex and messy code I've ever made with loops in loops, etc... for mediawiki-repos, but functional wise I like it better than submodules
[21:16:54] <MirahezeRelay>	 <cosmicalpha, replying to .labster> Ah yeah it didn't seem to hard for me this time though but maybe should just do away with them.
[21:17:24] <MirahezeRelay>	 <rhinosf1, replying to .labster> Enums not in MariaDB are
[21:17:30] <MirahezeRelay>	 <rhinosf1> The concept is great
[21:17:36] <MirahezeRelay>	 <rhinosf1> The implementation is garbage
[21:18:01] <MirahezeRelay>	 <pixldev, replying to rhinosf1> Got it
[21:18:17] <MirahezeRelay>	 <pixldev> mostly but thats the case with most puppet related stuff
[21:18:34] <MirahezeRelay>	 <.labster> If you really want value validation just use a foreign key
[21:19:36] <MirahezeRelay>	 <cosmicalpha> It wasn't about the validation as much as it looked nice to have a place where you can find all the possible statuses, but thats the reason I now added a ImportDumpStatus interface to replace the original reason I chose ENUMs.
[21:20:40] <MirahezeRelay>	 <cosmicalpha> Now I'm just worried about changing them if it'd cause issues or not...
[21:21:02] <MirahezeRelay>	 <cosmicalpha> *changing off them
[21:23:12] <MirahezeRelay>	 <.labster> Even my worst schema migrations only had three steps tops
[21:23:28] <MirahezeRelay>	 <cosmicalpha> Although tbf, the likelihood of yet another status type later on is very low
[21:23:54] <MirahezeRelay>	 <.labster> Famous last words
[21:24:04] <MirahezeRelay>	 <pixldev> Incredibly so
[21:24:18] <MirahezeRelay>	 <pixldev> It’ll probably be fine™️
[21:30:35] <MirahezeRelay>	 <.labster> [1/6] 1. I am learning databases
[21:30:35] <MirahezeRelay>	 <.labster> [2/6] 2. What is this ENUM type? That sounds nice
[21:30:36] <MirahezeRelay>	 <.labster> [3/6] 3. This is a perfect use case for trying ENUM
[21:30:36] <MirahezeRelay>	 <.labster> [4/6] 4. Changing the schema to add a value was harder than I thought, but this will be the last change
[21:30:36] <MirahezeRelay>	 <.labster> [5/6] 5. Arrgh
[21:30:37] <MirahezeRelay>	 <.labster> [6/6] 6. Fine, alter table varchar it is
[21:31:35] <MirahezeRelay>	 <.labster> I think all backend programmers go through this cycle
[21:37:27] <MirahezeRelay>	 <cosmicalpha> Lol yeah I do regret using it but there was a discussion about it initially also and no one was truly against using it so it ended up being used...
[23:56:38] <MirahezeRelay>	 <serverlessharej> I think I use integers and then infer their meaning as a convention
[23:56:44] <MirahezeRelay>	 <serverlessharej> Which incidentally is how MediaWiki does namespaces
[23:59:32] <MirahezeRelay>	 <pixldev> :ThinkerMH: