[10:21:17] @bluemoon0332 https://github.com/miraheze/puppet/pull/3883 [10:21:31] Cause I can't purge by hostname NOT [10:22:57] might also want to add it to the server block at https://github.com/miraheze/puppet/blob/bc942347c1ff051034966421b304de597847a9d3/modules/mediawiki/templates/mediawiki.conf.erb#L360 [10:23:06] since custom domains will also use CF in the future [10:23:13] Eh [10:23:15] Not yet [10:23:18] Though [10:23:28] I can just manually purge custom domains for this time [10:23:45] merged then [10:23:47] For future, we'll add some actual ones so we can purge specific things [10:23:50] Cool [12:18:51] Was looking at the global file feed [12:19:24] Some files apparently have Special:CentralAuth in place of their uploaded user? [12:19:48] cursed [12:33:46] this might be a phorge worthy bug (ext is maintained by mh), i'll probably make a task and subscribe you [12:39:21] https://issue-tracker.miraheze.org/T12339 [12:40:07] Thanks [12:40:42] @bluemoon0332 can you see what the database says for both the actual file and in the gnf database for ^? [12:53:08] BlankEclair: I have a thought [12:53:12] BlankEclair: $services->getActorStore()->getUnknownActor() [12:53:21] I assume that doesn't generate a username [12:53:26] Or gives an invalid ID [12:53:40] https://github.com/miraheze/GlobalNewFiles/blob/master/includes/jobs/GlobalNewFilesInsertJob.php#L27 [12:54:03] I wonder if that's inserting rows where username returns '' [12:55:00] https://github.com/miraheze/GlobalNewFiles/blob/master/includes/GlobalNewFilesPager.php#L71 is where the link breaks [12:55:04] Is made [12:56:39] BlankEclair: I also wonder if https://github.com/miraheze/GlobalNewFiles/blob/master/maintenance/PopulateUploaderCentralIds.php didn't work for some users [14:24:47] [[Special:GlobalNewFiles]] [14:24:48] [14:26:17] Usernames that did not return a valid central ID during the migration should've been dropped from the GlobalNewFiles tables [14:27:35] Were they [14:27:45] But also why didn't they have a valid central id [14:27:47] All should [14:27:57] because this extension used to store usernames [14:28:02] rather than IDs [14:29:04] Every username should have a central ID though [14:29:22] The two examples I found definitely did [14:29:22] if someone got renamed in the time between they uploaded a file and the migration to using IDs happened, we can't find the ID [14:29:44] https://github.com/miraheze/GlobalNewFiles/blob/master/maintenance/PopulateUploaderCentralIds.php#L63C6-L73C7 [14:29:47] But the file locally still has the ID [14:29:50] You can recover that [14:30:00] You know what wiki the file is from [14:30:16] And you know what the file is called [14:30:23] Should be possible to find the data [14:31:23] should be able to run a script on all wikis that looks for rows with no valid central ID and relocates it [14:39:24] @rhinosf1, indeed, there's some users with a central ID of zero in the database for GlobalNewFiles [14:40:17] that's whats causing the links to Special:CentralAuth [14:46:11] Yes which might be fixable [14:46:39] yeah, but this is rather low priority tbh [14:47:12] Absolutely [14:52:26] Oh ye