[02:50:32] [1/3] I'll help the first 10 people interested on how to  start earning $100k or more within a week, but you will reimburse me 10% of your profits when you receive it. Note: only interested people should send  a friend request or send me a dm! ask me (HOW) via Telegram username @mark_brian81 [02:50:33] [2/3] ‎ [02:50:33] [3/3] ‎Or message me via telegram link in my BIO [04:04:02] I'm assuming that's already been handled? ^ [07:49:26] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/1146890 [07:55:42] [1/2] @cosmicalpha lone process tree on mwtask181 [07:55:42] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1372844947887226880/1747382139493.png?ex=682840fd&is=6826ef7d&hm=bb724a4fc84d01b507e7ae44a3650a8a31841c3a4f0de938cdd5758479f2ab95& [07:56:23] lol I suspended that script on accident rather than killing it. [07:56:27] gg [07:56:40] you even suspended the tail lol [07:56:48] I already ran it properly on all wikis so it can be killed [07:56:53] lol what [07:57:00] tail -f [07:57:05] i mean, i can _try_ [07:57:08] want me to? [07:58:04] Sure [07:58:34] Honestly no idea how this happened lol [07:59:03] bash is now a zombie [07:59:12] at least the php script was picked up [07:59:33] now it's up to you to `fg`, because i don't have any root LPEs for better or for worse [08:01:07] [1/2] agent: my motivations are beyond your understanding [08:01:07] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1372846310071472128/1747382464817.png?ex=68284242&is=6826f0c2&hm=2bc0222758fe24e695592eea87c6a674aeaeced21a43c1798f81034555a2ca35& [08:04:09] I ran `pkill -TERM -g 2948755` [08:04:25] works ig [08:04:36] just to kill the whole screen lol [08:05:46] Did I kiss something or is that a screen in a screen? [08:05:48] *miss lol [08:05:55] it sure looks like it [13:05:52] I mean kissing a unix process is interesting, so is the screen ception [18:02:32] [1/2] How does ManageWiki define the load order of extensions and skins, and is there a way to change it? Because it seems that on some wikis, like , the section editing icons for visual and source editing are the same, which, according to an [issue comment]( [2/2] issues/938#issuecomment-2305303982>) in citizen's repository, and me testing it locally, is caused by VE being loaded after Citizen [18:09:00] I didn't know that could even matter lol. But no it can't really be changed without changing the entire extensions are loader, adding some option to ManageWikiExtensions IE load-before which definitely complicates the whole a lot more. [18:12:46] [1/2] Neither did I, and I haven't seen anything related to it documented anywhere... [18:12:46] [2/2] Maybe a solution would be to load skins after all extensions by default? [18:13:11] I guess I'm going to tell the user affected by this to open a task for now, maybe some time in the future a fix for this can be implemented in ManageWiki [18:14:06] Extensions and skins in ManageWiki are not differentiated. It doesnt use wfLoadExtension/wfLoadSkin it just loads them all with the paths directly using ExtensionRegistry->queue but that actually is something I want to change to differentiate them more... [18:15:30] Extension & Skin loading order can definitely matter [18:17:18] I didn't think it could with ExtensionRegistry because I thought it technically loaded them all at once from what I assumed based on what I've seen how it works but that actually doesnt seem to be the case now and I mustve misunderstood it lol. But it is a bit odd. [20:34:49] I don't understand how that issue can be caused by Citizen being loaded after VisualEditor? Since all extensions are loaded at the same time irregardless of where they are defined (since wfLoadExtension just adds it to the queue like ManageWiki does) [20:34:59] Seems like bad code on Citizens part [20:37:49] Shot in the dark guess is it has to do with Citizen overriding other extension styles? [20:38:45] it's not a CSS issue, both icons just have the same class set by citizen [20:39:07] Maybe citizen set a different class then? 🤔 [20:45:45] [1/3] I feel like this is the cause: [20:45:45] [2/3] [20:45:45] [3/3] If VE is loaded before citizen, its hook for `onSkinEditSectionLinks` is ran before the citizen one, so the element is in the array. If the load order is incorrect, it isn't in the array at the point when the hook is ran for citizen [20:46:20] this is assuming that the hooks are run in the load order [21:21:26] Hooks in general are being run in load order, there are nothing that I can do in my part [21:22:00] https://phabricator.wikimedia.org/T287622 [21:22:51] Vector 2022 is also affected by this, they circumvent it by introducing another hook into MW core [21:25:41] If VE is loaded after Citizen, the VE edit section links are not added when Citizen runs the hook. So Citizen is unable to tag the VE link with the right icon class [21:29:03] My general suggestion is to load skins after extensions in load order if possible, since skins should be resposible for the final output [21:40:21] Hmm that might have changed in 1.43, I might be able to fix it [22:14:05] Okay I have patched it in the latest main branch, should no longer be an issue [22:14:28] There is a newer SkinMustache method introduced after 1.39 that I wasn't able to use before [22:18:20] Thanks! [22:44:32] Iirc im sure ive seen a recommendation on mw.org somewhere that says if you need your hook to run last then fire it from onSetupAfterCache or something, but ive never tried it myself (and dont even know if its possible in modern mw) [22:46:45] But this is also an issue with global user pages and social profile/upv2 in which both the ArticleTitle hooks are fighting one another lol