[01:29:36] I merged and deployed to Miraheze now btw [07:44:28] @cosmicalpha could you review my PR for MobileFrontend again please? I ran the tests on mirabeta and the commands all seem to work and their default values are all correctly reported by ManageWiki. [08:32:38] Did you test changing them too and make sure the format works IE proper true not "true" (with quotes) or 1 etcc [08:33:35] no.... [08:33:48] I guess I'll do that after testing RPCS3. [08:34:36] I'm mostly wondering if the list-multi-bool ones work properly as that type has some odd behavior sometimes and it's not used much so has less testing for the type itself too. [08:35:13] It has worked for me in the past afaik, but I did think to myself why am I using list-multi-bool when I can probably just use integers right? [08:35:32] I dont think so [08:35:44] bool and integers are different [08:36:32] I was thinking of list-multi-integers for a moment. [08:37:42] Thats a new type which is basically just list but typecasted to integers so they dont become string values in db due to ManageWiki using strict typing now. [09:29:37] I like Portal 2 👍 [11:07:12] I changed the values through ManageWiki, and shell reports them as unchanged? [11:07:42] Nevermind, I closed shell and reopened it and it was fine? [11:11:25] We're you using eval.php? [11:11:37] pretty sure it loads $GLOBALS into memory on init, so that would explain why [11:12:01] No? [11:12:20] I'm using shell, as in `shell metawikibeta`. [11:13:53] [1/17] This isn't getting enabled when `$wgMFAutodetectMobileView` is `true` for some reason? [11:13:53] [2/17] ```php [11:13:54] [3/17] 'wgMFShowMobileViewToTablets' => [ [11:13:54] [4/17] 'name' => 'MobileFrontend Show Mobile View To Tablets', [11:13:54] [5/17] 'from' => 'mobilefrontend', [11:13:55] [6/17] 'type' => 'check', [11:13:55] [7/17] 'overridedefault' => true, [11:13:55] [8/17] 'section' => 'styling', [11:13:55] [9/17] 'help' => 'Controls whether tablets should be shown the mobile site or the desktop site.', [11:13:56] [10/17] 'requires' => [ [11:13:56] [11/17] 'settings' => [ [11:13:57] [12/17] 'setting' => 'wgMFAutodetectMobileView', [11:13:57] [13/17] 'value' => true, [11:13:58] [14/17] ] [11:13:58] [15/17] ], [11:13:59] [16/17] ], [11:13:59] [17/17] ``` [11:14:09] It stays disabled when it's `true`. [11:14:40] probably same thing shell is just improved eval.php [18:14:41] [1/8] It isnt set in ManageWikiSettings: [18:14:41] [2/8] ```ps [18:14:42] [3/8] > $mwSettings = MediaWiki\MediaWikiServices::getInstance()->get( 'ManageWikiSettingsFactory' )->newInstance( 'metawikibeta' ); $mwSettings->list( 'wgMFAutodetectMobileView' ); [18:14:42] [4/8] = null [18:14:42] [5/8] > $wgMFAutodetectMobileView [18:14:42] [6/8] = true [18:14:43] [7/8] ``` [18:14:43] [8/8] Issue seems to be that requires -> settings doesn't support to check for the default only if it's been changed. [18:19:31] https://github.com/miraheze/ManageWiki/pull/690 [18:25:18] [1/5] ```ps [18:25:18] [2/5] > $mwSettings = MediaWiki\MediaWikiServices::getInstance()->get( 'ManageWikiSettingsFactory' )->getInstance( $wgDBname ); $mwSettings->list( 'wgMFAutodetectMobileView' ); [18:25:19] [3/5] = true [18:25:19] [4/5] ``` [18:25:19] [5/5] works now so that should requires work now also.