[00:18:40] I will take a look more at it tomorrow [04:23:13] do i need to request? [04:24:41] create a task on phorge [04:28:16] https://issue-tracker.miraheze.org/T14052 [04:46:29] Thanks seen will get to it tomorrow if connection else does [04:46:41] how did no one autocorrect to connection lol [04:46:51] like how does that even happen. [05:06:20] is that even doable? [05:06:25] I'm rather surprised [05:53:26] [1/3] hovering over the go to top bar in citizen's dark mode seems to goof it up [05:53:26] [2/3] this also happens on safemode and a bit after the 1.44 update. does not appear on a 1.43 wiki so its probably something with 1.44 and the citizen skin [05:53:27] [3/3] https://cdn.discordapp.com/attachments/1006789349498699827/1398906106171887706/image_2025-07-27_144850018.png?ex=68871056&is=6885bed6&hm=4623b34bf039314aae13d0a85e5e2311cc7ef87347d6ee2286db023497de6002& [06:12:14] what wiki is this [06:12:41] https://thechurchofthestatue.miraheze.org/ [06:13:12] @atxatx [06:14:11] [1/2] forgot to mention that the fonts in the infoboxes work a bit jank [06:14:11] [2/2] one page it could work fine and display jetbrains and the other it doesnt [14:58:14] @atxatx @cosmicalpha hmm i found https://phabricator.wikimedia.org/T342259 [14:58:23] https://github.com/wikimedia/mediawiki/commit/406b844a427aa2306bf715dea19645b9c6012c34 [14:58:42] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/paladox-patch-3/tests/phpunit/SMWIntegrationTestCase.php#L163 [16:04:06] That might be it, I moved part of the run function to initialize test environment and it moved the 1.44 CI forward [16:04:58] maybe, i'm not sure if the tests broke in MW 1.41. All we ran was the code coverage. But yeh i guess it could. [16:05:54] Idk if anyone is sure all the tests are up and running in SMW tbh [16:07:08] With the amount of middle layers that we have in the tests, some tests might have failed silently [16:08:06] although only in MW 1.42 did the use of ChangedTablesTracker::startTracking(); start. So idk. [16:25:01] although there was no errors thrown, so possible MW 1.41 had the problem... just wasn't shown because it didn't have ChangedTablesTracker [16:29:53] https://github.com/SemanticMediaWiki/SemanticMediaWiki/commit/2bf5348e6002c8979d5204618b32b37df8d12ccb introduced SMWInt test @atxatx which added depndency on MediaWikiIntegrationTestCase. [16:30:30] anyways i'll wait for @cosmicalpha since i'm just lost lol. Dunno how to fix this [16:40:38] Yeah gesinn refactored the CI and tests back then for 5.0 since the tests were broken before [16:41:47] Many of these tests are written before MediaWikiIntegrationTest is a thing. Or rather, much of the SMW codebase is written before MW and PHP become more streamlined [16:43:25] I'll look into it today shortly. [17:19:04] @atxatx @paladox try adding `fwrite( STDERR, 'run: ' . spl_object_id( $this ) . "\n" );` to both run() and setup() methods in SMWIntegrationTestCase [17:20:28] at the end or top? [17:21:12] at the very top [17:22:24] im trying to find out if it's being called twice (which seems to be the case and this will just confirm that for sure) [17:23:05] @cosmicalpha https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/6179 [17:23:35] before parent::setUp(); [17:24:16] done [17:24:31] thanks [17:25:16] iirc it uses a docker image if you want to pull it up locally [17:25:19] make ci [17:28:15] Doesn’t GitHub have draft PRs [17:28:26] it does [17:28:52] the change i'm doing has no intention of being merged. It's just to do it for CI. [17:30:21] PRs that are named like they're bombs 🩷 [17:33:57] @cosmicalpha it's finished running [17:39:26] [1/46] ``` [17:39:27] [2/46] curl -s "https://productionresultssa10.blob.core.windows.net/actions-results/f01d6aab-c273-4756-a4fc-ebef3b719883/workflow-job-run-0ab858b3-f68a-5e1c-aeb4-d30a11178f2e/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-07-27T17%3A41%3A53Z&sig=et3%2B1diPnt4o%2FGxwsc9%2FsixAAdFrAJWfVlgt5o6DFLM%3D&ske=2025-07-28T03%3A42%3A19Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f8 [17:39:27] [3/46] 4eb&sks=b&skt=2025-07-27T15%3A42%3A19Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-05-05&sp=r&spr=https&sr=b&st=2025-07-27T17%3A31%3A48Z&sv=2025-05-05" | [17:39:27] [4/46] > grep -i 'run:' | [17:39:28] [5/46] > grep -oE '\b[0-9]{4}\b' | [17:39:28] [6/46] > sort | [17:39:28] [7/46] > uniq -c | [17:39:28] [8/46] > awk '$1 > 2' [17:39:29] [9/46] 1392 2025 [17:39:29] [10/46] 4 2095 [17:39:29] [11/46] 4 2296 [17:39:30] [12/46] 4 2298 [17:39:30] [13/46] 4 2342 [17:39:31] [14/46] 3 2382 [17:39:31] [15/46] 3 2398 [17:39:32] [16/46] 3 2400 [17:39:32] [17/46] 3 2414 [17:39:33] [18/46] 3 2480 [17:39:33] [19/46] 3 2484 [17:39:34] [20/46] 3 2486 [17:39:34] [21/46] 3 2488 [17:39:35] [22/46] 3 2494 [17:39:35] [23/46] 3 2500 [17:39:36] [24/46] 3 2512 [17:39:36] [25/46] 3 2514 [17:39:37] [26/46] 3 2532 [17:39:37] [27/46] 3 2534 [17:39:38] [28/46] 3 2596 [17:39:38] [29/46] 3 2598 [17:39:39] [30/46] 3 2604 [17:39:39] [31/46] 3 2606 [17:39:40] [32/46] 3 2612 [17:39:40] [33/46] 3 2614 [17:39:41] [34/46] 3 2618 [17:39:41] [35/46] 3 2620 [17:39:42] [36/46] 3 2706 [17:39:42] [37/46] 3 2708 [17:39:43] [38/46] 3 2714 [17:39:43] [39/46] 3 2716 [17:39:44] [40/46] 3 2722 [17:39:44] [41/46] 3 2724 [17:39:45] [42/46] 3 2728 [17:39:45] [43/46] 3 2730 [17:39:46] [44/46] 4 3122 [17:39:46] [45/46] 4 3131 [17:39:47] [46/46] ``` [17:41:32] anyway i have to go for now will look more in a bit [20:11:23] https://github.com/SemanticMediaWiki/SemanticMediaWiki/actions/runs/16507416814/job/46681502365 is from the 5.1.0 release for MW 1.43. [20:11:36] which the user errors was fixed with https://github.com/SemanticMediaWiki/SemanticMediaWiki/commit/2ac8dd792186f1fac90ce3d04b14e299e4683afd [20:11:51] MW 1.42 has different errors. it seems? [20:20:16] I'll look more now. [21:19:55] @atxatx looks like you can uncross the user test thing you crossed out [21:20:25] at least the test didn't fail with a user error when i uncrossed it out (fails with the same error as it crossed out (request tracking etc)) [21:26:52] hmm we're calling classes in https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/paladox-patch-6/tests/phpunit/JSONScriptServicesTestCaseRunner.php that extends MediaWikiIntegration alongside extending SMWIntegration which extends MediaWikiIntegration. [21:27:03] dunno if that's just a rabit hole or unrelated. [21:27:12] i guess maybe idk [21:32:16] tbf i saw this tracking error in the scribunto semantic extension when trying to migrate its CI to match others as it was failing. https://github.com/SemanticMediaWiki/SemanticScribunto/pull/105 [21:47:27] That's weird since I removed it to fix the user database issue. Though it doesn't seem the code is being used by other tests [23:10:29] Can somebody verify whether is still up to date? I've updated the rest of the article, but can't verify that this section is still up to date, so I've moved the outdated notice to it [23:28:27] @cosmicalpha any progress?