[00:54:43] @atxatx i wonder if splitting out the run. Using @before and @after. or trying it in setup/teardown but idk. [02:05:06] Probably drop the whole run function, anything that goes before `parent::run()` goes to setup, and anything after goes to teardown [02:24:39] @atxatx hmm, doesn’t seem to fix it [02:24:41] https://github.com/SemanticMediaWiki/SemanticMediaWiki/actions/runs/16558497150/job/46823688579?pr=6180 [02:30:33] I think things got worse or something, [04:55:44] I ended up giving up after a bit of no progress on it. Can look more again though if needed later. [08:00:12] DPL4 is almost 20,000 lines changed now lol [08:00:57] to be exact, 18,129 [08:01:38] oh @posix_memalign does it work on beta now btw or do I still need to fix that. I can't remember if I did lol [08:41:34] regarding [T14052](https://issue-tracker.miraheze.org/T14052), it seems that transl:Crossroads:fr works, which isnt intended as i want transl:fr:Crossroads [09:47:17] @abaddriverlol @pskyechology [09:51:38] you got exactly what you wanted smh [09:53:17] you have the opportunity of making the easiest PR ever unless I get around to it first [10:21:36] https://github.com/miraheze/mw-config/pull/6038 [10:26:17] merged and deployed. [10:26:31] now I really need to sleep. Its 4:30AM lol [10:26:50] goodnightt [10:27:06] not really night anymore lol. [10:28:01] oh yeah true... [10:28:01] I have to wake up at 6AM today [10:28:06] good morning ❤️ [10:28:59] owch, someone get him some more sleep [12:40:46] Can be considered, as I don't think they will initiate a convo without something to say, besides, in that case, not just me will receive the mail... but all the volunteers in my wiki projects [13:25:28] Yes please! But also oh. Hmm [13:27:19] [1/6] does anyone know what's causing my images to appear really big in discord embeds? [13:27:20] [2/6] pic 1: how i want it to be [13:27:20] [3/6] pic 2: actual result [13:27:20] [4/6] the discord devs server said that it depends on the Twitter SEO image size on whether it's "summary" or "summary large image", but i've always set it to "summary" [13:27:21] [5/6] https://cdn.discordapp.com/attachments/1006789349498699827/1399382718265036932/image0.jpg?ex=6888cc37&is=68877ab7&hm=9e99a1d853f96f10e1e348694f9d67aed0255b917c87aee10b639c9281471e92& [13:27:21] [6/6] https://cdn.discordapp.com/attachments/1006789349498699827/1399382718575280158/image1.jpg?ex=6888cc37&is=68877ab7&hm=01d18ca6768c708d3e3b56feac1fbc5302836da8ecfa8bac265d91f6162fcf9e& [14:48:53] [1/2] Still looks like this on mirabeta with DPL3 not showing up on [Special:Version](https://exttest.mirabeta.org/wiki/Special%3AVersion). [14:48:53] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1399403243821338764/image.png?ex=6888df54&is=68878dd4&hm=7eaef6def55a38e3eb9b350c065e6422638b75f873f429cfd1b7712068fff555& [17:30:19] The error is slightly different now, so I guess it is a plus [17:32:46] I think it might be the TestDatabaseTableBuilder: https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/1274243e91b05c0eefe16eef94c3e6b0d719629f/tests/phpunit/Utils/Connection/TestDatabaseTableBuilder.php#L19 [18:20:45] hmm [19:15:59] @atxatx i get different errors now https://github.com/SemanticMediaWiki/SemanticMediaWiki/actions/runs/16578001725/job/46886973848?pr=6185 (although fails in the first test now) [19:26:13] i don't understand why the failures are in the classes that don't use SMWIntegration that i touched [19:37:30] i removed :unit to see the errors from integration: https://github.com/SemanticMediaWiki/SemanticMediaWiki/actions/runs/16578356688/job/46888148257?pr=6185 [19:37:33] @atxatx ^ [19:40:26] oh i guess you need to make search compatible maybe? idk. I know that 1.42 broke it i think? We never fixed the test for it i think? But anyways i'm going leave it at that as idk how to move further then this lol [19:49:28] @paladox unrelated but when I was looking it reminded me MW has been moving things towards PHPUnit 10 lately it looks like a ton of tests in SMW will be somewhat (or mostly) incompatible with that. Its mocking stuff in dataProviders. In the future dataProviders can only be static and returning data the actual tests have to handle everything else. [19:49:45] whoops didn't mean to both ping and reply lol [19:55:08] [1/2] things like `Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'wiki.unittest_smw_ft_search' doesn't exist` are likely caused by not using ->tableName btw. ->tableName is needed when not using query builder and other things to support table prefixes. Sometimes to avoid the quote errors you need to pass 'raw' as the second parameter also. I haven't confirmed tha [19:55:08] [2/2] ts the exact issue here though. [19:56:52] [1/3] query shows its running without the prefix ```sql [19:56:53] [2/3] SELECT s_id FROM `unittest_smw_ft_search` `smw_ft_search` WHERE s_id = 1 AND p_id = 1 LIMIT 1 [19:56:53] [3/3] ``` so I do think thats likely the issue [21:27:30] dunno how you'd fix that [21:28:09] it seems to me a legitimate failure not a failure with the tests alone. [21:29:55] @cosmicalpha https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/update-class-import/src/SQLStore/QueryEngine/Fulltext/SearchTableUpdater.php#L209 [21:29:56] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/update-class-import/src/SQLStore/QueryEngine/Fulltext/SearchTableRebuilder.php#L133 [21:30:03] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/update-class-import/src/MediaWiki/Jobs/FulltextSearchTableRebuildJob.php#L50 [21:30:16] is where it elads [21:31:46] maybe this https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/SQLStore/QueryEngine/Fulltext/SearchTable.php#L19 ? idk [21:37:56] [1/2] there's also https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/SQLStore/QueryEngine/FulltextSearchTableFactory.php#L165 which is created with https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/520908e7f05a00a705fe8b366d0b71866a8eb525/src/Setup.php#L208 https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/MediaWiki/MwCollaboratorFactory. [21:37:56] [2/2] php#L143 https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/MediaWiki/Connection/ConnectionProvider.php#L94 [21:39:01] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/MediaWiki/Connection/Database.php [21:55:21] little confused why it's calling flushTables anyways [21:55:32] oh [21:55:33] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/paladox-patch-4/tests/phpunit/MediaWiki/Jobs/FulltextSearchTableRebuildJobTest.php#L85 [21:55:38] maybe the first aray is why [21:55:45] well idk how to fix this lol [22:06:33] It is even worse in SMW because it is using a compat layer to work for PHPUnit 9... [22:06:35] Or 8 [22:07:29] Regarding the tests, I also have no idea where to start fixing it either. The way that it is set up in SMW looks arcane to me and I might not be able to look into it deeply until some time next month [22:28:05] using tableName didn't work @cosmicalpha [22:28:24] https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/6185/commits/08eb84907d2898c6b08c89efb3c31c20af993c95 [22:29:07] @atxatx is this table supposed to be created somewhere in SMW? [22:29:13] is it done on install? [22:41:39] [1/16] im gonna cry [22:41:39] [2/16] ``` [22:41:40] [3/16] Error 1264: Out of range value for column 'us_image_bits' at row 1 [22:41:40] [4/16] Function: UploadStash::stashFile [22:41:40] [5/16] Query: INSERT INTO `uploadstash` (us_user,us_key,us_orig_path,us_path,us_props,us_size,us_sha1,us_mime,us_media_type,us_image_width,us_image_height,us_image_bits,us_source_type,us_timestamp,us_status) VALUES (179,'1bysuiw257r0.dsbhmx.179.mp4','/tmp/php2vCRo2','mwrepo://local/temp/4/4b/20250728213803!php2vCRo2.mp4','a:12:{s:8:\"metadata\";a:3:{s:8:\"duration\";s:8:\"2.100000\";s: [22:41:41] [6/16] 5:\"codec\";s:4:\"h264\";s:8:\"bitdepth\";s:1:\"8\";}s:5:\"width\";i:1280;s:6:\"height\";i:720;s:4:\"bits\";s:6:\"806712\";s:10:\"fileExists\";b:1;s:4:\"size\";i:216098;s:9:\"file-mime\";s:9:\"video/mp4\";s:10:\"major_mime\";s:5:\"video\";s:10:\"minor_mime\";s:3:\"mp4\";s:4:\"mime\";s:9:\"video/mp4\";s:4:\"sha1\";s:31:\"nhcxpstg3clsy518vwwxg0l4ub90klz\";s:10:\"media_type\";s:5:\ [22:41:41] [7/16] "VIDEO\";}',216098,'nhcxpstg3clsy518vwwxg0l4ub90klz','video/mp4','VIDEO',1280,720,'806712','file','20250728213803','finished') [22:41:41] [8/16] from /srv/mediawiki/1.43/includes/libs/rdbms/database/Database.php(1198) [22:41:41] [9/16] #0 /srv/mediawiki/1.43/includes/libs/rdbms/database/Database.php(1182): Wikimedia\Rdbms\Database->getQueryException(string, int, string, string) [22:41:42] [10/16] #1 /srv/mediawiki/1.43/includes/libs/rdbms/database/Database.php(1156): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, int, string, string) [22:41:42] [11/16] #2 /srv/mediawiki/1.43/includes/libs/rdbms/database/Database.php(647): Wikimedia\Rdbms\Database->reportQueryError(string, int, string, string, bool) [22:41:43] [12/16] #3 /srv/mediawiki/1.43/includes/libs/rdbms/database/Database.php(1476): Wikimedia\Rdbms\Database->query(Wikimedia\Rdbms\Query, string) [22:41:43] [13/16] #4 /srv/mediawiki/1.43/includes/libs/rdbms/database/DBConnRef.php(127): Wikimedia\Rdbms\Database->insert(string, array, string, array) [22:41:44] [14/16] #5 /srv/mediawiki/1.43/includes/libs/rdbms/database/DBConnRef.php(407): Wikimedia\Rdbms\DBConnRef->__call(string, array) [22:41:44] [15/16] ... [22:41:45] [16/16] ``` [22:42:43] whole trace in txt file cause i dont feel like making a bigger wall [22:42:51] https://cdn.discordapp.com/attachments/1006789349498699827/1399522522235670638/message.txt?ex=68894e6b&is=6887fceb&hm=1a7c67dc8c1c8a49c58a778842a5884817a2653dac39121fa2b9776d185d172f& [22:44:00] BlankEclair ^ i saw you run into this a while ago, did you ever figure out what's going on [23:11:15] oh maybe the test was a failure to begin with @atxatx [23:11:28] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/9969290b68bead742643dc7ac8b8f396d1c1e830/src/SQLStore/TableBuilder/TableSchemaManager.php#L276 [23:11:33] that option isn't enabled by default [23:25:08] hmm [23:25:19] https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/6185/commits/20fed90ae353e9806bd8e74212547f82663c507a didn't fix it. [23:29:12] @tango_man @songngu.xyz PWA should be good to go now, lmk if there's any issues [23:37:29] got it [23:48:06] > [29/07/2025 08:44] BlankEclair ^ i saw you run into this a while ago, did you ever figure out what's going on [23:48:06] no T_T [23:48:15] LMAO [23:48:17] fair enough [23:48:30] > [29/07/2025 08:41] [1/16] im gonna cry [23:48:34] me too, skye, me too [23:48:49] sigma move to hear the lounge pop sound and respond on discord ngl [23:49:28] lmfao [23:51:02] BlankEclair ok since you're here, can you do https://meta.miraheze.org/wiki/Tech:CirrusSearch for babelreduxwiki (see #miraheze) [23:51:04] wtf, the bitarray is only 5 bits long?? [23:51:11] o [23:51:14] cool :3 [23:51:23] you needed more than 5? lol, lmao even [23:51:35] it's fucking 0b11110110001100000110000 [23:53:50] I have no idea, I'm new to the project too haha [23:56:17] anygay the solution to my out of range value upload issue was [23:56:17] 1. lmao their upload is low quality and wouldnt be accepted anyway [23:56:17] 2. fuck moderation and upload it for them [23:56:57] ah yes xD [23:57:05] ok i love how it reversed the order on discord [23:57:47] h o w [23:58:11] [1/2] idk you tell me [23:58:11] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1399541479084523684/image.png?ex=68896012&is=68880e92&hm=ce40d7dd813c9c822c113311dc30ffa8b5338bb1b9522ae3815956bd108aaf77&