[03:11:24] <MirahezeRelay>	 <pixldev> hoping to get off my ass and finish the fast track deletion tommorow or sunday
[03:11:46] <MirahezeRelay>	 <pixldev> https://github.com/miraheze/CreateWiki/pull/605/ can someone rerun tests to see if anything has broken in uh
[03:12:03] <MirahezeRelay>	 <pixldev> https://cdn.discordapp.com/attachments/1006789349498699827/1401039819789963396/image.png?ex=688ed383&is=688d8203&hm=e144879a91cb62f31cd2eb07e8aa7a86bc6190398f4f35bee5e56330a7326e43&
[03:14:23] <MirahezeRelay>	 <pixldev> also someone needs to explain mediawiki tests to me
[03:20:54] <MirahezeRelay>	 <originalauthority> it failed
[03:20:58] <MirahezeRelay>	 <originalauthority> but I don't think its your fault
[03:21:16] <MirahezeRelay>	 <cosmicalpha> CW is intentional failing until 1.44 is required by it.
[03:21:43] <MirahezeRelay>	 <cosmicalpha> I removed the install scripts to not run the risk of modifying global tables by running update.php on other wikis.
[03:22:09] <MirahezeRelay>	 <originalauthority> that's not why it's failing
[03:22:12] <MirahezeRelay>	 <originalauthority> its failing for composer
[03:22:17] <MirahezeRelay>	 <cosmicalpha> same reason
[03:22:33] <MirahezeRelay>	 <cosmicalpha> I removed it but didn't remove the use statement IIRC
[03:23:17] <MirahezeRelay>	 <pixldev, replying to cosmicalpha> can we use 44 on CI?
[03:23:34] <MirahezeRelay>	 <originalauthority> its not very helpful if the CI is just disabled every time we're going to update
[03:23:40] <MirahezeRelay>	 <originalauthority> that defeats the whole purpose of having tests
[03:23:51] <MirahezeRelay>	 <cosmicalpha, replying to pixldev> Won't fix it until https://github.com/miraheze/CreateWiki/pull/749 is merged.
[03:23:58] <MirahezeRelay>	 <cosmicalpha, replying to originalauthority> only this time
[03:24:42] <MirahezeRelay>	 <pixldev, replying to cosmicalpha> so much for productivity
[03:24:56] <MirahezeRelay>	 <pixldev> is there anything besides tests left on your review here?
[03:25:09] <MirahezeRelay>	 <cosmicalpha> I mean I can push something to just let it pass for now. Skipping the only affected test and removing that use.
[03:26:02] <MirahezeRelay>	 <cosmicalpha> I just didn't as I hoped it wouldnt need to be removed for that long...
[03:29:12] <MirahezeRelay>	 <cosmicalpha> Only test that fails is https://github.com/miraheze/CreateWiki/blob/4ed82c079ca00d0e1322d8288a21968c22b501cd/tests/phpunit/Maintenance/ListDatabasesTest.php#L38 since no database gets created immediately right now.
[03:47:27] <MirahezeRelay>	 <posix_memalign, replying to cosmicalpha> [1/2] Thanks. Is DPL4 supposed to [show embeds like these](https://exttest.mirabeta.org/wiki/DynamicPageList3)? Once I have some more time, I can take a deeper look to figure out which NS these come from and whether some other extension is interfering with DPL4.
[03:47:27] <MirahezeRelay>	 <posix_memalign, replying to cosmicalpha> [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1401048726692429917/image.png?ex=688edbce&is=688d8a4e&hm=d5ecc8d607f609d0884fcefdf14ca3c29d6b786f4e0882da77f81e76b72e2fad&
[03:47:45] <MirahezeRelay>	 <cosmicalpha> uh hmm...
[03:47:52] <MirahezeRelay>	 <cosmicalpha> where?
[03:48:01] <MirahezeRelay>	 <cosmicalpha> oh you linked it
[03:51:17] <MirahezeRelay>	 <cosmicalpha> oh lol this is caused by thr Video extension @posix_memalign (it seems anyway)
[03:52:54] <MirahezeRelay>	 <cosmicalpha> I guess I need to handle [[:Video:]] like [[:File:]]? I assume this issue existed in DPL3 with Video also.
[03:52:56] <MirahezeRelay>	 <Wiki-Bot#2998> <https://meta.miraheze.org/wiki/Video:?action=edit&redlink=1>
[03:53:47] <MirahezeRelay>	 <posix_memalign> Ah I see. Supposedly any file-related extension with a custom NS could have this problem.
[03:54:00] <MirahezeRelay>	 <cosmicalpha> yep
[03:54:07] <MirahezeRelay>	 <posix_memalign> Yeah it's gone after Video is disabled.
[03:54:17] <MirahezeRelay>	 <cosmicalpha> I do think it probably happened with the old DPL3 also.
[03:55:28] <MirahezeRelay>	 <cosmicalpha> Video overwrite [[Video:]] to he <video> in the background. You can debug the actual wikitext output by using debug=5 parameter in DPL and just previewing btw @posix_memalign
[03:55:29] <MirahezeRelay>	 <Wiki-Bot#2998> <https://meta.miraheze.org/wiki/Video:?action=edit&redlink=1>
[03:58:05] <MirahezeRelay>	 <posix_memalign, replying to cosmicalpha> Oh nice. That'll be very handy.
[04:14:13] <MirahezeRelay>	 <pixldev, replying to cosmicalpha> should i wait or go on to try and bully someone to explain test making to me
[04:15:02] <MirahezeRelay>	 <cosmicalpha> ill fix the failing tests on main tomorrow so its up to you
[04:16:12] <MirahezeRelay>	 <pixldev> gotcha
[04:16:35] <MirahezeRelay>	 <pixldev> im not sure how to test the tests without a CW enviorment but ill bullshit a way through
[04:21:00] <MirahezeRelay>	 <cosmicalpha> Honestly I really do need to push that docker for CreateWiki/ManageWiki
[04:22:16] <MirahezeRelay>	 <pixldev, replying to cosmicalpha> if you still have it, would be much helpful ❤️
[21:42:13] <MirahezeRelay>	 <cosmicalpha> @posix_memalign FYI I added compatability for the Video extension in DPL4
[22:20:16] <MirahezeRelay>	 <posix_memalign, replying to cosmicalpha> Nice! It's working as expected on mirabeta.
[22:21:56] <MirahezeRelay>	 <posix_memalign> [1/2] @abaddriverlol Were you able to get EmbedSpotify to work? I keep seeing `no healthy upstream` (or similar errors) and am not sure if that applies to anyone else.
[22:21:56] <MirahezeRelay>	 <posix_memalign> [2/2] https://exttest.mirabeta.org/wiki/EmbedSpotify
[22:24:30] <MirahezeRelay>	 <posix_memalign> [1/2] Looks like it's not the extension's fault. Spotify messed something up and I'm seeing similar complaints elsewhere. It'll hopefully go away in a few hours/days.
[22:24:30] <MirahezeRelay>	 <posix_memalign> [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1401329843295092817/image.png?ex=688fe19e&is=688e901e&hm=87feea6957eb8a0b64262402bb669d3fda9042081ce4263a457ec332ddc6b9a4&
[22:27:09] <MirahezeRelay>	 <abaddriverlol, replying to posix_memalign> We forked EmbedSpotify and it should be fixed now, although I've only tested whether it creates the embed, not if the embed still works on Spotify's side
[22:28:52] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> Yeah I saw the checkbox but couldn't get the extension to function properly. This problem doesn't have anything with the MW upgrade, though, since wikis on 1.43 will have the same issues.
[22:30:35] <MirahezeRelay>	 <pskyechology> EmbedNoHealthyUpstream :3