[07:40:38] <MirahezeRelay>	 <posix_memalign> [1/2] Apparently this is all you need to (unsafely) support `LIKE` and `RLIKE` operators in Bucket. I just don't know how to do this without leaving a big security hole in the software. This `RawSQLExpression` looks very dangerous lol.
[07:40:38] <MirahezeRelay>	 <posix_memalign> [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1414153374584012810/image.png?ex=68be8876&is=68bd36f6&hm=3bc83314abe4f751709ba3566ee8eb9cc70a01f941ec0672c4ed27454d23ebb5&
[07:52:30] <MirahezeRelay>	 <rhinosf1> @blankeclair @abaddriverlol
[07:56:19] <MirahezeRelay>	 <blankeclair, replying to posix_memalign> i'm fairly sure there's smth like buildLike?
[08:05:39] <MirahezeRelay>	 <posix_memalign, replying to blankeclair> I couldn't get it to work somehow. Maybe I should give it another try.
[08:08:07] <MirahezeRelay>	 <posix_memalign> [1/2] Oh I remember. `buildLike` returns a string, but the SQL statement builder expects a `LikeValue` and throws this error `⧼Value for &#039;LIKE&#039; expression must be of LikeValue type⧽.`. 
[08:08:07] <MirahezeRelay>	 <posix_memalign> [2/2] Passing `LikeValue` was what I tried originally, but that would get escaped.
[08:09:29] <MirahezeRelay>	 <posix_memalign> Anyways I should probably not get too curious on this front where I have no idea what I'm doing and go back to writing CSS grid guides.
[08:10:37] <BlankEclair>	 til RLIKE is a thing
[08:10:42] <BlankEclair>	 immediate thought is redos
[09:11:20] <MirahezeRelay>	 <rhinosf1, replying to posix_memalign> Maybe raise this with Amir
[10:43:13] <MirahezeRelay>	 <originalauthority, replying to posix_memalign> You have `IExpression::LIKE` and `new LikeValue()` which is prolly in the realm of what you're after
[12:50:54] <MirahezeRelay>	 <abaddriverlol, replying to posix_memalign> [1/5] something like
[12:50:54] <MirahezeRelay>	 <abaddriverlol, replying to posix_memalign> [2/5] ```php
[12:50:55] <MirahezeRelay>	 <abaddriverlol, replying to posix_memalign> [3/5] $dbw->expr( $fieldName, IExpression::LIKE, new LikeValue( $dbw->anyString(), $value, $dbw->anyString() ) );
[12:50:55] <MirahezeRelay>	 <abaddriverlol, replying to posix_memalign> [4/5] ```
[12:50:55] <MirahezeRelay>	 <abaddriverlol, replying to posix_memalign> [5/5] should probably work for LIKE (not sure about RLIKE)
[12:51:59] <MirahezeRelay>	 <abaddriverlol> On that note, why is Bucket using the primary DB for select queries
[16:50:35] <MirahezeRelay>	 <pixldev> @cosmicalpha was the medik issue resolved
[16:50:57] <MirahezeRelay>	 <abaddriverlol> medik is fixed
[16:50:59] <MirahezeRelay>	 <cosmicalpha> I believe so, yes
[16:51:18] <MirahezeRelay>	 <abaddriverlol> WikibaseRepository, CommentStreams, SemanticDrilldown and SemanticScribunto are currently broken afaik
[16:51:22] <MirahezeRelay>	 <abaddriverlol> I'll patch the two latter ones
[17:16:34] <MirahezeRelay>	 <abaddriverlol> SemanticDrilldown and SemanticScribunto should now be fixed on beta and prod
[17:52:16] <MirahezeRelay>	 <originalauthority> Didn't WMF Abandon comment streams?
[17:52:27] <MirahezeRelay>	 <originalauthority> It was a terrible idea from the get go but
[17:52:51] <MirahezeRelay>	 <pixldev, replying to originalauthority> I thought it was a third party extension
[17:53:21] <MirahezeRelay>	 <originalauthority> I could've sworn it was a WMF thing
[17:53:25] <MirahezeRelay>	 <originalauthority> Maybe I'm misremembering
[17:54:18] <MirahezeRelay>	 <originalauthority> Oh looks like one of the authors used to work for WMF so maybe that's where I got confused
[18:00:18] <MirahezeRelay>	 <kockaadmiralac> wiki.gg did recently switch away from CommentStreams so I would assume they are not as updated as they should be
[18:02:13] <MirahezeRelay>	 <cosmicalpha, replying to originalauthority> StructuredDiscussions/Flow they did
[18:02:49] <MirahezeRelay>	 <cosmicalpha> Wikibase is fixed on 1.44 now also btw.
[18:04:47] <MirahezeRelay>	 <cosmicalpha> Seems we may have gotten CommentStreams working as well.
[18:42:41] <MirahezeRelay>	 <paladox, replying to originalauthority> was done by a wmf staffer
[18:42:55] <MirahezeRelay>	 <paladox> but as far as i'm aware it was a personal extension or rather not connect to the WMF
[18:56:16] <MirahezeRelay>	 <yonic_soseki> [1/2] How bad is it to release an extension without tests?
[18:56:16] <MirahezeRelay>	 <yonic_soseki> [2/2] Normally I would but Scribunto's testing tools are borked/never got updated: https://phabricator.wikimedia.org/T403432
[18:57:52] <MirahezeRelay>	 <abaddriverlol, replying to yonic_soseki> that error kinda looks like the test is supposed to be run  as an integration test but it isn't
[19:08:11] <MirahezeRelay>	 <originalauthority> Yeah UnitTests are not allowed to access MediaWikiServices
[19:16:10] <MirahezeRelay>	 <yonic_soseki> [1/4] Hmm, seems that way. Although I did specify the test to inherit from `LuaEngineUnitTestBase`. Seems like it could be some sort of outdated behavior. 
[19:16:10] <MirahezeRelay>	 <yonic_soseki> [2/4] Anyway, running it as if it were to be an integration test spits this though:
[19:16:10] <MirahezeRelay>	 <yonic_soseki> [3/4] ```1) LuaStandalone: BigIntegerTest[1]: Verify the lib is loaded and exists
[19:16:11] <MirahezeRelay>	 <yonic_soseki> [4/4] RuntimeException: Database backend disabled```
[19:19:18] <MirahezeRelay>	 <yonic_soseki> I'm running this on Docker, I'm not sure if I'm meant to do something else
[19:21:42] <MirahezeRelay>	 <abaddriverlol, replying to yonic_soseki> try adding it to `@group Database`
[19:22:09] <MirahezeRelay>	 <abaddriverlol> like e.g. <https://github.com/miraheze/RottenLinks/blob/09b632b71e3be3e8c81351c7d67d78b260a08fe1/tests/phpunit/integration/RottenLinksParserFunctionsTest.php#L12>
[19:32:19] <MirahezeRelay>	 <yonic_soseki> Niice, it's working! Although it seems like it's skipping 1 test out of 3? But I only have a single test from Lua
[23:38:32] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [1/30] Thank you! I think I got `LIKE` and `NOT LIKE` working. I had to build a custom query parsing function to find all the `%` and `_`. I didn't bother to code escaping (e.g. `\%` or `\_`), though.
[23:38:32] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [2/30] ```
[23:38:33] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [3/30] private static function constructLikePattern( $dbw, $pattern ): array {
[23:38:33] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [4/30]     $result = [];
[23:38:33] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [5/30]     $currentString = '';
[23:38:34] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [6/30]     $length = strlen( $pattern );
[23:38:34] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [7/30]     $escapeChar = [
[23:38:34] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [8/30]         '%' => $dbw->anyString(),
[23:38:34] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [9/30]         '_' => $dbw->anyChar(),
[23:38:35] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [10/30]     ];
[23:38:35] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [11/30]     for ( $i = 0; $i < $length; $i++ ) {
[23:38:35] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [12/30]         $char = $pattern[$i];
[23:38:36] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [13/30]         if ( isset( $escapeChar[$char] ) ) {
[23:38:36] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [14/30]             if ( $currentString !== '' ) {
[23:38:37] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [15/30]                 $result[] = $currentString;
[23:38:37] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [16/30]                 $currentString = '';
[23:38:38] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [17/30]             }
[23:38:38] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [18/30]             $result[] = $escapeChar[$char];
[23:38:39] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [19/30]         } else {
[23:38:39] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [20/30]             $currentString .= $char;
[23:38:40] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [21/30]         }
[23:38:40] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [22/30]     }
[23:38:41] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [23/30]     if ( $currentString !== '' ) {
[23:38:41] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [24/30]         $result[] = $currentString;
[23:38:42] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [25/30]     }
[23:38:42] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [26/30]     return $result;
[23:38:43] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [27/30] }
[23:38:43] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [28/30] ```
[23:38:44] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [29/30] https://cdn.discordapp.com/attachments/1006789349498699827/1414394436233990365/image.png?ex=68bf68f7&is=68be1777&hm=673241eb77d6714bef1edae2e692528f09aecbf63894de7ef7f5199aa1c9ed0f&
[23:38:44] <MirahezeRelay>	 <posix_memalign, replying to abaddriverlol> [30/30] https://cdn.discordapp.com/attachments/1006789349498699827/1414394436712005764/image.png?ex=68bf68f7&is=68be1777&hm=0b3f945f968516d0f0bb497eea689d4a9ee2077ddb980c0086873a87ea7b3129&
[23:58:22] <MirahezeRelay>	 <mariosinmobile> [1/2] had this happen on my miraheze and the meta miraheze
[23:58:22] <MirahezeRelay>	 <mariosinmobile> [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1414399427514339459/image.png?ex=68bf6d9d&is=68be1c1d&hm=8698b35ecf369d3f4579a2aaed0e8c68f5296bebd222c4470f62f9e2ebd231df&