[01:19:58] @orduin see dm please 🙂 [11:09:00] discord.com/invite/YDMeaDQM [18:28:55] Just some note, can we pull Citizen? The last pull happened more than a month ago [18:46:51] I don't really think they make many major updat [18:49:07] From a cursory glance at least AGENTS.md and CLAUDE.md were added in the past month. [18:50:47] [1/2] I did a git reset to `e6033a325b8b3ea225e67266effb3b9f79fa5328`. From then until now even the summary of changes is too long to include in a single message. [18:50:47] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1481001389957054736/message.txt?ex=69b1b987&is=69b06807&hm=9f4e49a7ec018109c8ff008a58adacdf5087f4d2affcdbcfafbdfedb891287af& [18:52:36] that means we aint upgrading this shit under no fucking circumstances [18:52:54] thats a bit like asking to willing allow the insertion of a bomb [18:53:26] If you only count `includes/` and `resources/` it's `139 files changed, 6719 insertions(+), 7414 deletions(-)`. No way anyone will be able to audit so many changes. [18:54:26] TBH I'm probably guilty of not checking the extension when I resolved https://issue-tracker.miraheze.org/T14728. Maybe another sec vulnerability got slipped into Cargo without anything noticing. [19:01:48] iirc 3.13.0 introduces breaking CSS changes that will cause issues with cached HTML, so we need to figure out how to address that first [19:02:21] additionally, there were so many changes that it will probably need a need security review, which I won't be able to do until next week probably [19:53:34] [1/5] Most of the files are test files, cleaning up CI. We did also remove the old search module, but that change hasn't been tagged into a release yet. [19:53:34] [2/5] We have been tracking the issues that it caused on Miraheze in past deployments, so now we have been more careful on introducing potentially breaking changes. [19:53:34] [3/5] > iirc 3.13.0 introduces breaking CSS changes that will cause issues with cached HTML, so we need to figure out how to address that first [19:53:35] [4/5] It is partially true, the breaking part is the HTML. What happened is that HTML are cached for a much longer time than CSS/JS. The desync can cause breaking layout sometimes. It is not unique to Citizen, but it also applies for any extensions and skins too. [19:53:35] [5/5] Speaking of which, is there anything that I can do to help to smoothen out the deployment? [19:55:01] [1/3] > Speaking of which, is there anything that we can do to help to smoothen out the deployment? [19:55:01] [2/3] I think I suggested this somewhere else before (but I don't remember where), but if the changes were in two separate commits, one of them introducing the new HTML + CSS that is backward compatible with the old cached HTML, and the second one removing the extra/old CSS, we could deploy the first commit, wait for 24 hours until the caches have expired, and then deploy the second [19:55:02] [3/3] one [19:57:54] Yes I believe that was how WMF usually do with Vector. I will do that next time if we make changes to HTML that are cached into parser or file cache [19:58:39] Thanks! [19:58:46] Which specific commit caused the breaking changes in 3.14.0? [20:03:04] https://github.com/StarCitizenTools/mediawiki-skins-Citizen/commits/v3.14.0/templates?since=2026-02-03&until=2026-03-10 [20:03:40] You can track the `templates` directory. Those are the HTML that are saved in the parser or file cache [20:08:06] We have some other HTML changes that are implemented in `main` and will be released with `3.15.0`. It might be less work to jump to this commit instead of `3.14.0`, there won't be more HTML change for the release: https://github.com/StarCitizenTools/mediawiki-skins-Citizen/commit/12b41aceb6f2062f397264bd03f1955f3de3affc [20:55:44] Hm, is there a GitHub PR equivalent to a -1 besides just leaving a comment? [20:56:02] I think it has a feature to say no good to a PR but only for members of the org [20:57:21] i dont think reviewing is limited to just collaborators [20:58:38] Oh, yeah that's it [20:58:54] I don't really know what specific code is the problem soooo [20:59:07] you dont have to [20:59:26] oh, I thought reviews are attached to lines [20:59:31] Learning! [21:02:20] hm [21:02:29] didnt mirabeta used to have a pink favicon [21:03:50] [1/2] https://meta.mirabeta.org/wiki/Special:Log?logid=1145 [21:03:51] [2/2] https://meta.mirabeta.org/wiki/Special:Log?logid=1289 [21:04:14] did mac bin it [21:04:15] :( [21:06:01] Also, to confirm I'm not crazy, locking a RW request never left a log right? [21:06:24] ? [21:07:15] https://cdn.discordapp.com/attachments/1006789349498699827/1481035732247384155/image.png?ex=69b1d982&is=69b08802&hm=5c5e13382df37ce6c0f50307202b3ff34e94bbf00d4779b089e32f55607df959& [21:07:35] im not sure if that's logged tbh [21:08:13] I had presumed so, but seems not [21:08:40] https://cdn.discordapp.com/attachments/1006789349498699827/1481036090495471737/image.png?ex=69b1d9d8&is=69b08858&hm=b7a58426a7371f4f2b4f60738158ab99298da0dd0134dd0433a7cc29fc37b799& [21:08:47] and not going to request history [21:08:52] oh well [21:08:55] prob should but [21:09:30] yup [21:14:28] you can always win a prize of making it happen [21:18:11] mayhaps [21:18:22] i have zero local setup for CW/MW rn thou lol [21:18:28] among other things [22:01:35] Now that you have access to test151 you can test on mirabeta lol. [22:06:01] True, though pushing a commit each time I want to see my changes is a bit tedious, better than nothing [22:06:22] Or just dev on beta directly ig [22:18:46] TEST IN PROD WOOO [22:18:46] [1/2] Average C++ dev experience lol. The program takes so long to compile that you need to be fairly confident you got it right before trying to run it. If you have the repo setup right it's just `git commit -am t && git push` and then running `git pull && mwdeploy ... --no-log` on test151. [22:18:47] [2/2] You could use vim or scp your preferred terminal text editor. I do wonder if VSCode/PHPStorm remote development works on beta, but I definitely won't try it since they have built-in telemetry which might leak prod secrets. [22:19:35] VSCodium has no telemetry although idk if it has that feature [22:22:23] c++ the goat [22:23:03] Zed is significantly better than VSCode/any of the forks I've found; very fast - but I've just had to go back to PHPStorm because although I bought a license for Intelephense, it just doesn't work reliably in Zed for some reason [22:24:36] I thought there were some C++ hacks that allowed you to recompile it without needing to close the executable [22:25:26] my parents always tell me about when they were doing C in the 80s and 90s and they'd have to write the program, wait for 30 minutes for the mainframe to compile it, only to find out they missed a semicolon lol [22:27:45] Remote dev on VS Code seems to be a proprietary extension. Typical big tech tactic: FOSS base with proprietary add-ons essential to the dev experience. [22:28:49] embrace, extend, and extinguish [22:29:00] _fandom ethos_ [22:31:24] tbh if I'm only changing a few lines in one file I don't mind using vim, and I should probably learn how to actually use vim rather than my current VSCode + vim keybindings setup