[17:01:31] after getting the infamous hcaptcha "missing response" myself im starting to think we should explode hcaptcha [17:11:01] Is there anything in our stack we haven’t said that about [17:22:35] oh my goddddddddddddddddddddddddd https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmEdit/+/1305873 [17:22:52] the workaround is creating a blank page and then doing your edit [18:25:56] [1/3] I have seen many users report that workaround after getting frustrated. [18:25:56] [2/3] And I think at some point we need to decide among: making CVT unhappy, making our users unhappy, or making tech unhappy (by forcing someone to fix this). [18:25:57] [3/3] For a while we only had simple numeric captchas, which were reverted. Did that lead to excessive spam? [18:26:27] the real solution is to backport the change I linked [18:29:00] Oh that shouldn't be too bad then. The only issue being DreamyJazz creating many commits after 1.47 branching and we need to backport all of them. [19:43:54] No [19:44:20] @kostajh was working on CAPTCHA stuff if you need any support [20:02:56] I want to explode mediawiki [20:03:01] the 1.45.4 patch is killing me [20:03:08] I have to repatch all the extensions I wrote hacky patches for [20:05:21] having multiple app servers is the bane of my life [20:05:23] I hate deploying stuff [20:05:28] I prefer to just fuck around in mediawiki prod [20:14:41] why do you need so many patches [20:14:45] did you consider upstreaming stuff [20:31:44] there's some weird return type stuff [20:31:57] no clue why it happens tbh [20:34:06] ?? [20:34:13] do you have an exmaple [20:34:58] [1/2] ```Maps\ParserHookSetup::__construct(): Argument #2 ($enableCoordinatesFunction) must be of type bool, null given, called in /srv/mediawiki/versions/1.45/extensions/Maps/src/MapsFactory.php on line 278 [20:34:58] [2/2] Backtrace:``` [20:43:42] did you upgrade the composer dependency? [20:44:09] or what did you set `$egMapsEnableCoordinateFunction` to [20:44:23] oh that might be why lmao [20:44:43] i think the error is rather that the config var is wrong [20:46:30] ok but tbf [20:46:44] there is a composer dependencies issue which I should probably upstream [20:46:49] the rest is one to look at again [22:11:37] ```Compile Error: Declaration of MWCallbackStream::write($string) must be compatible with Psr\Http\Message\StreamInterface::write(string $string): int``` this is probably a better example from /includes/http/MWCallbackStream.php [22:12:41] these psr issues are mostly why I have hacky patches [22:13:09] the library was only upgraded on master [22:13:24] you should probably use an older version [22:13:37] gerrit is down lmao [22:13:37] like the one that's presumably enforced by composer.json [22:13:51] gg [22:14:15] https://github.com/wikimedia/mediawiki/commit/33f80b08b957bf0e50b482a0bfc495fac7b4c8d7 [22:14:28] I'll just bump it to 2.0 for now fwiw [22:14:43] bump what to 2.0 [22:14:45] psr [22:15:03] why? [22:15:11] the error indicates you're already using psr 2 [22:15:14] uh [22:15:15] while you should be using 1 [22:15:16] it's using 1.1 [22:15:20] wtf [22:15:32] sentry reports it using 1.1 as well [22:15:47] only one is http-message on 2.0 [22:15:48] [1/6] psr/http-client [22:15:49] [2/6] 1.0.3 [22:15:49] [3/6] psr/http-factory [22:15:49] [4/6] 1.1.0 [22:15:50] [5/6] psr/http-message [22:15:50] [6/6] 2.0 [22:16:22] http-message is the problematic one [22:16:27] that was upgraded in the commit I linked [22:16:29] but only on master [22:16:44] (and 1.46 which was branched afterwards) [22:16:57] I'll just pin it to some 1x version for now then [22:17:29] and then wait for 1.46 [22:17:53] the urge to push rc0 as default beckons [22:18:07] why can you even have 2.0 installed if the composer.json says 1.1 [22:18:14] tbh not sure [22:18:22] (not a composer version stuff expert tbh but that doesn't make a lot of sense) [22:18:29] the only thing I can think of is that sentry sdk requires 2.0 [22:19:32] yeah it is sentry sdk [22:20:49] probably a backport job but icba [22:21:29] ok I think it's pinned to 1.1 [22:22:01] and now sentry sdk will probably start whining but [22:22:15] I can live without sentry until 1.46 if I have to