[03:05:48] RandomSelection is fine though :stare: [03:13:41] I'm not sure what it uses a magic word for since it's not in the docs. Maybe it's nothing important. [03:17:32] There's no magic words there, only parser tab, so yes [03:34:08] Also, could you set this ```$wgLinkTargetParentClasses = [ 'foo', 'bar' ];``` in LocalSettings.php? This is for LinkTarget extension lol [06:06:28] I can do that [06:26:01] Done [06:56:34] [1/6] Also, LinkTarget has around 5 wikis that are actually using it (has a config in mw-config), so its priority is very low. Here's an auto-generated list of untested extensions by popularity. Note that it may be problematic but should provide some guidance on which extensions need to be prioritized. [06:56:34] [2/6] ``` [06:56:34] [3/6] TextExtracts, WikiSEO, SyntaxHighlight?, UrlShortener, GlobalUserPage, MobileFrontend, PortableInfobox, TemplateSandbox, MultimediaViewer, TemplateData, UploadWizard, TimedMediaHandler, TemplateStylesExtender, PDFHandler, NewestPages, ImageMap, Disambiguator, Moderation, Theme, DisplayTitle, SandboxLink, TemplateWizard, JsonConfig, NoTitle, DynamicPageList4, ProtectSite, 3D, M [06:56:35] [4/6] assEditRegex, TimeMachine, PageForms, Report, RelatedArticles, Video, UniversalLanguageSelector, WebChat, Maps, Capiunto, MassMessage, PagedTiffHandler, LastModified, FontAwesome, PDFEmbed, WikiLove, PageNotice, LabeledSectionTransclusion, LogoFunctions, DynamicSidebar, HeaderTabs, UnusedRedirects, TocTree, VoteNY, RSSfeed?, AuthorProtect, DataTransfer, UserFunctions, Variable [06:56:35] [5/6] sLua, Translate, WikibaseClient?, GroupsSidebar, UserPageEditProtection, Share, UserProfileV2, RevisionSlider, UploadsLink, MagicNoCache, DynamicPageList, WikidataPageBanner, Skinperpage, GoogleDocs4MW, ArticleCreationWorkflow, InteractiveDataMaps?, DPLforum, ThemeToggle, OrphanedTalkPages, SubpageList3, Description2, SubpageFun? [06:56:35] [6/6] ``` [07:21:18] [1/2] For duplicating our `` rules for `bingbot` in robots.txt https://discord.com/channels/407504499280707585/1006789349498699827/1519779357453717625. I'm thinking of ditching the robots.txt file completely and generating the whole thing with PHP. The alternative is to record all the rules in `` and then `echo` them in bingbot's ruleset, which I think overcomplicates things. [07:21:18] [2/2] Any thoughts on this? [12:32:31] I see, I'l try to test some of these soon. [15:55:08] @posix_memalign I'm guessing MobileFrontend removed the `hidden-mobile` class? It doesn't appear to be getting hidden anymore on the mobile skin. [15:55:18] Unless it means, hidden unless on the mobile skin? [16:00:33] Initially I was like, oh CategoryExplorer still works, but then of course I thought about it and checked its Source Code, it's very basic, and also abandoned? [16:01:08] Actually, `use Skin;` is deprecated is it not? [16:01:49] Yeah, it's `use MediaWiki\Skin\Skin;` now. [16:14:23] there's a configuration setting for what stuff gets hidden [16:15:15] Yeah, I just found it. I searched up "Mobilefrontend" and it didn't popup, until I searched for class. [16:17:33] yeah the prefix is mf rather than mobilefrontend [16:33:37] I hate trying to install git-review on Windows, it doesn't even work after installing Python3, and then pip installing git-review with Git Bash. [16:34:27] "git: 'review' is not a git command.", ughghg [16:34:40] maybe try git-review instead of git review [16:34:49] or use WSL [16:35:12] Same thing, not a command. [16:35:22] What is WSL? [16:35:29] windows subsystem for linux [16:35:32] linux in windows, basically [16:35:48] makes it a lot easier to do mw development [16:35:50] Yeah no, I'll just use my Linux Server then. [16:36:03] if that's easier to set up with your ide [16:36:45] Why even have instructions for Windows if they don't work? [16:37:16] I assume they do work most of the time [16:37:30] but I guess not in all cases / setups [16:37:52] Well, I follow the instructions, and they didn't work. Not to mention, installing from the .msix doesn't even ask you if you want to add python.exe to PATH. [16:38:07] Although, I'm not sure that matters. [16:42:33] Hey, turns out they meant the executable, not the MSI nor the .msix, guess I gotta update those instructions. [17:02:06] And now Gerrit is rejecting my attempts to amend a patch set. [17:02:57] did you do git amend and then git review [17:03:17] while making sure that the change ID is the same as in the initial commit [17:04:08] Yes. [17:04:28] so what's the error [17:05:15] [remote rejected] HEAD -> refs/for/master (change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CategoryExplorer/+/1309258 closed) [17:05:33] did you amend it to the wrong commit? [17:05:37] what does "git show" display [17:05:43] it's trying to update the patch you abandoned [17:06:32] I deleted the branch, so I'm not sure how to get it pointing back to the right commit. [17:06:52] [1/5] - git review -d 1309256 [17:06:52] [2/5] - make your changes [17:06:52] [3/5] - git add . [17:06:53] [4/5] - git amend [17:06:53] [5/5] - git review [17:07:04] ("git review -d " downloads a patchset on a separate branch) [17:09:19] This just made another change. [17:10:23] it shouldn't do that if you amend to the commit that was downloaded [17:10:52] git amend is not a command [17:11:20] Do you mean `git commit --amend`? [17:12:11] IT worked now. [17:28:47] @abaddriverlol I'm very confused with Gerrit right now, I'm cherry-picking the `REL1_45` branch for this change I' [17:29:33] I'm assuming the cherrypick for REL1_45 is copying the addition of LinkRenderer which is present in `REL1_46`/`master`? [17:29:58] Because it's not present in the `REL1_45`, but it is trying to add it, but MediaWikiServices is not present in the `REL1_46`/`master` branch? [17:31:23] I'm just gonna publish the patch without LinkRenderer. [17:35:17] Its also weird that no author is specified for this extension? [17:50:51] I don't think it needs to be backported because the class is only used in the documentation anyways [17:50:58] so it wouldn't break anything [17:51:32] also the class alias still exists in older versions [17:53:24] Yeah I know that, I just thought with REL1_45 being the latest branch other than master, it would make sense for it to be using it since I'm assuming that's not how they want it from now and onwards. [17:53:45] REL1_46 is the latest branch [17:53:54] but there's no point in backporting it [17:54:02] Oh, that's right they did release REL1_46. [17:54:10] nobody really cares about release branches in unmaintained extensions [17:54:17] Well, I already made the cherrypick. [17:54:32] ive +2ed the master patch [17:54:34] With a test that fails for some unrelated reason. [17:54:53] Thanks for the help. [17:55:11] the node job is broken on release branches in most extensions unfortunately [17:55:46] Yeah, that's what I thoght. [17:55:58] I'm still wondering about this though. [17:56:01] I wonder if there's a reason. [17:56:04] [17:56:23] per the author is hashar [17:58:02] Looks like there's patches being done to Wikibase currently.