[02:49:08] for cases like https://issue-tracker.miraheze.org/T15868 is it worth toggling cirrus on and off [02:49:14] off and on ig [03:09:06] https://we.phorge.it/T16763 hm, how da fuc do we add new custom files to a given path with puppet [03:17:47] [1/3] the login_1x and login_2x files [03:17:48] [2/3] https://cdn.discordapp.com/attachments/1006789349498699827/1539473428837437590/Miraheze56x56.png?ex=6a8671db&is=6a85205b&hm=00c28ba156659b8e70669d81e81f947504377367a0eabf938e1854d98b753c28& [03:17:48] [3/3] https://cdn.discordapp.com/attachments/1006789349498699827/1539473429147820082/Miraheze28x28.png?ex=6a8671db&is=6a85205b&hm=ff6421b5df389e9d81e1fbf96b61c0f76190fbe16203662e3d956aaff88258ed& [03:51:17] I can probably handle this this weekend if you want? [03:56:31] if mean if you can show me how to add the files where they need to be I can manage the rest for the logo [04:10:21] is https://issue-tracker.miraheze.org/badges/view/7/ net lines added or just liens added [04:35:09] I will look this weekend. [04:37:11] honestly, maybe it makes sense to open the badge edit policies to acl*security [04:46:04] Maybe but not for now until I have a little more time to review that a bit more. [04:46:24] I am going to sleep for now. [05:20:17] @pixldev I really don't see why we can't add it to that path but upstream [05:20:21] They haven't said no [05:20:52] We requested not what we wanted and solutionised and they've told us no to that [05:21:03] They haven't said no [10:40:23] might as well try it [10:40:51] search is already broken so you wouldn't be breaking anything new [11:19:39] Any @Technology Team around as db161 died? [11:20:20] I'll depool [11:20:41] i can restart it [11:21:19] @rhinosf1 do we restart the vm or just restart mariadb? [11:21:41] Restart MariaDB is fine [11:21:44] 👍 [11:21:50] Although you'll have to kill -9 if it's stalled [11:22:22] done [11:22:32] db161 mariadb successfully restarted [11:22:45] Repooling [14:40:12] My understanding was they said we should patch our install but if you wanna try asking nicely to be added upstream go ahead [15:56:13] fwiw: the ticket was reopened (not by me) [16:39:02] can anyone with prod access rerun https://issue-tracker.miraheze.org/T15862#316733 limiting down to wiks that aren't hard/soft deleted [16:39:20] Actually does hard deleting a wiki drop the mw_settings row [17:32:48] [1/18] @rhinosf1 given https://we.phorge.it/T16763#36366, think this should prooooobably maybe work? [17:32:48] [2/18] ```git [17:32:48] [3/18] diff --git a/src/oauth/PhabricatorMediaWikiAuthProvider.php b/src/oauth/PhabricatorMediaWikiAuthProvider.php [17:32:49] [4/18] --- src/oauth/PhabricatorMediaWikiAuthProvider.php [17:32:49] [5/18] +++ src/oauth/PhabricatorMediaWikiAuthProvider.php [17:32:49] [6/18] @@ -119,8 +119,13 @@ [17:32:49] [7/18] protected function getLoginIcon() { [17:32:50] [8/18] return 'MediaWiki'; [17:32:50] [9/18] } [17:32:50] [10/18] + public function newIconView() { [17:32:51] [11/18] + return id(new PHUIIconView()) [17:32:51] [12/18] + ->setImage('/file/data/favxwmnsedvx3kkpokqy/PHID-FILE-spdbknnch4l2y4h6dhry/Miraheze_login2x.png'); [17:32:52] [13/18] + } [17:32:52] [14/18] + [17:32:53] [15/18] private function isSetup() { [17:32:53] [16/18] return !$this->getProviderConfig()->getID(); [17:32:54] [17/18] } [17:32:54] [18/18] ``` [17:33:43] I think I'm at the theatre for now you see me live [17:33:45] So go for it [17:33:46] I'm not totally sure but I think it's the login_2x size [17:34:02] hold up uo just commented on the task lemme see [17:34:09] go theatre [17:34:28] okay smt else [17:34:34] ill put it up for PR [17:34:45] what's the worst that can happen [17:38:19] https://github.com/miraheze/phorge-extensions/pull/73 [17:47:00] There is some formatting issues with that, but I can fix that myself after I test if you want? [17:51:39] I’m not familiar with the formatting standards so maybe I can learn from you doing ityeah [17:52:06] It's just a couple spacing and tab issues. Same formatting as MediaWiki stuff. [19:03:01] Looks like MacFan4000 left a review for exactly what I meant. [19:03:27] Except for some spacing issues [19:03:59] Aren't there automated linting tools for this [19:04:13] yeah also run `composer fix` [19:04:27] Only if the PR is done in the same repo does it automatically fix. [19:04:27] idk about indentation though [19:04:32] So from forks it doesn't fix. [19:05:24] I usually fix indentation with neovim `=` because it doesn't seem that composer does it automatically? [19:05:43] It does. Sometimes. It isn't extremely great at it. [19:38:57] * dmehus prefers nano. He likes the idea of neovim and vim, but believes there's something to be said for nano's simplicity [19:45:57] nano requires me to read the instructions which I can't be bothered to do [19:46:32] whereas vim I'm familiar with the basic keybindings so it's really easy to use [19:49:25] my problem is that i've been using nano for 20 years and changing to something else is too much work [20:07:53] that is impressive in its own right, those are pretty comprehensive from what I can tell [20:09:40] eh it's basically like learning 20 keyboard shortcuts [20:10:17] many many features I've never used, and I mainly edit in vscode anyway where the vim extension doesn't even include all features of vim [20:13:52] @thewwrnerdguy: oh, okay. I guess my problem is I'm not used to keyboard shortcuts. I just memorize my workflows and rely heavily on the mouse, sometimes to my wrist's chagrin [20:15:05] speaking of VScode, how many here use VScode and how many use VScodium and how many rarely or never use either [20:15:15] [20:15:58] I've never used VScode and never heard of VScodium before now lol [20:16:19] I use PHPStorm [20:16:35] I use Notepad++ for coding and have for years lol [20:16:37] VSCode sometimes but not that often [20:16:58] I used to main VSCode for scripts and stuff as a default, and Jetbrain for more dedicated projects [20:17:09] I tried codium a bit once I think [20:17:21] [1/2] @dmehus: I variously switch between mouse and keyboard (e.g. any non-citizen skin is really annoying to search on because I can't open a search result in a new tab without unfocusing the search box). [20:17:22] [2/2] I find vim keybindings make more niche operations significantly faster. e.g. I want to delete everything inside the current function I can do that in 3 keypresses [20:18:34] +1 to Notepad++. Before that, I used TextPad [20:18:48] Never heard of PHPStorm, @cosmicalpha. Neat :) [20:18:56] I use mainly use vscode on windows and kinda switch between neovim/vscodium on linux. vscodium's slightly annoying with not being able to support some proprietary extensions e.g. pylance the python lsp (I've never found any good alternatives) [20:19:18] @thewwrdnerdguy: ah, interesting re: vscodium [20:19:34] I tried setting up lsp on neovim but I had too much of a skill issue to get it to work how I wanted it so gave up [20:19:49] > I find vim keybindings make more niche operations significantly faster. e.g. I want to delete everything inside the current function I can do that in 3 keypresses [20:19:49] fair point [20:20:39] MacFan4000: what's your text and/or code editor of choice? [20:22:16] ive always used nano [20:28:45] cool [20:29:58] I use both nano and vim sometimes. Though I use nano most. [20:30:16] I would but I make most config changes on github.dev so I don't have a working cli [20:30:44] For these 5 liners at least [20:30:50] github.dev has a cli. I use it a lot. Just open in a workspace. [20:30:53] If it was something bigger I'd cloen locally [20:31:03] oh right that's an option too [20:31:16] I just don't like number to go down or smt [20:35:22] also in any case I don't think it's that hard to indent things properly lmao [20:36:28] true im just not familiar with formatting standards by hand [20:37:01] so what you do is use your eyes and if it looks like stuff's on the correct level it's probably fine [20:37:29] I changed my github settings so that tabs were 8 characters so it's really easy to spot indentation errors [20:38:26] grunts in caveman [20:40:10] [1/6] ```php [20:40:10] [2/6] public function newIconView() { [20:40:10] [3/6] return id(new PHUIIconView()) [20:40:11] [4/6] ->setImage('/file/data/favxwmnsedvx3kkpokqy/PHID-FILE-spdbknnch4l2y4h6dhry/Miraheze_login2x.png'); [20:40:11] [5/6] } [20:40:11] [6/6] ``` [20:42:48] uh oh is that not having a space inside the brackets [20:45:56] MediaWiki and Wikimedia is the only setting I've seen where people use spaces with brackets and braces [20:46:47] honestly it's easier to read [20:50:17] um [20:50:20] no ma'am [20:52:39] `composer fix` your life smh [20:52:55] composer needs to fix itself first [20:53:14] codespaces runs php 8.0.3 so bud just says nuh uh [20:54:06] [1/15] ```shell [20:54:06] [2/15] @pixDeVl ➜ /workspaces/phorge-extensions (patch-1) $ composer fix src/oauth/PhabricatorMediaWikiAuthProvider.php [20:54:07] [3/15] PHP Parse error: syntax error, unexpected identifier "AnsiColorMode" in /workspaces/phorge-extensions/vendor/symfony/console/Output/AnsiColorMode.php on line 20 [20:54:07] [4/15] Script minus-x fix . handling the fix event returned with error code 255 [20:54:07] [5/15] @pixDeVl ➜ /workspaces/phorge-extensions (patch-1) $ composer update [20:54:08] [6/15] Loading composer repositories with package information [20:54:08] [7/15] Updating dependencies [20:54:08] [8/15] Your requirements could not be resolved to an installable set of packages. [20:54:08] [9/15] Problem 1 [20:54:09] [10/15] - Root composer.json requires mediawiki/mediawiki-codesniffer 52.0.0 -> satisfiable by mediawiki/mediawiki-codesniffer[v52.0.0]. [20:54:09] [11/15] - mediawiki/mediawiki-codesniffer v52.0.0 requires php >=8.3.0 -> your php version (8.0.30) does not satisfy that requirement. [20:54:10] [12/15] Problem 2 [20:54:10] [13/15] - Root composer.json requires mediawiki/minus-x 2.0.1 -> satisfiable by mediawiki/minus-x[2.0.1]. [20:54:11] [14/15] - mediawiki/minus-x 2.0.1 requires php >=8.2 -> your php version (8.0.30) does not satisfy that requirement. [20:54:11] [15/15] @pixDeVl ➜ /workspaces/phorge-extensions (patch-1) $ ``` [20:55:51] interesting [20:57:25] sillyhub [20:59:11] hm [20:59:27] anyone think it's kinda like messed up that the WMF has more silly phorge badges than we do [21:01:46] be the change you want to see girlboss [21:01:58] eg https://phabricator.wikimedia.org/badges/view/14/ https://phabricator.wikimedia.org/badges/view/15/ [21:02:02] honestly [21:02:16] [[User:PixDeVl/Phorge Pin Collection]] coming soon? [21:02:16]

[21:02:50] (Give me ideas please or I will resort to plagiarism) [21:02:57] that just means we need more silly phorge badges [21:03:15] stealing from wikimedia is a time-honored miraheze tradition [21:04:18] Actually I feel with how much we’ve joked about it, it would be a disgrace not to have a badge called North Korean General [21:04:53] I think we're unlikely to offend any actual North Koreans with it. Very few of them can access the Internet. [21:04:54] pixdevl badge when [21:05:16] Could probably have one for The Cursed (Claire and SRD finding XSS in every piece of software they touch) [21:05:19] miraheze logo and the badge name is "hegaxons or smth" [21:05:52] jjk cursed finger (might be some copyright issues with that one though) [21:06:12] the wikipedia logo and the badge name is "v" [21:06:12] Apparently our logo is the paragraph separator character in Amharic [21:06:41] https://www.wikidata.org/wiki/Q87506871 [21:07:02] that's a bunch of dots, not hexagons [21:07:13] I've seen a hexagony variant of it [21:08:17] Can’t upload custom images sadly [21:32:22] https://meta.miraheze.org/wiki/User:PixDeVl/Phorge_Pin_Board @wikitideharej @thewwrnerdguy toss your bad ideas. [21:32:29] if you feel like it maybe even some good oens [21:47:17] @pixldev https://github.com/miraheze/phorge-extensions/pull/73#issuecomment-5348384702 [21:47:33] hmmm [21:48:10] ill see if i check it out more later, again the patch was mostly copied from avivery so will see what to do 🤷‍♂️ [21:49:03] not if I'd have time to do some digging, I can try [21:49:23] did you deploy to prod [21:49:48] I did. [21:50:05] I patched it locally on phorge171. Though I reverted it now. [21:51:49] for my later ref https://we.phorge.it/source/phorge/browse/master/src/applications/auth/provider/PhabricatorAuthProvider.php#L403 [21:52:14] may be worth trying to ask avivery on phorge.it [21:52:22] about to head out so will see later [21:54:38] Wonder if there’s a Phorge docker container for local dev [21:58:53] https://codeberg.org/muke/phorge-docker-setup [21:58:54] Huh [22:25:07] Is there a ticket for "the login problem" (need to log in at meta to be able to log in locally)? [22:29:43] [1/3] On Phorge we have: https://issue-tracker.miraheze.org/T15258 [22:29:43] [2/3] There's is an upstream one as well: https://phabricator.wikimedia.org/T419096 [22:29:43] [3/3] I was able to reproduce this on Wikipedia as well, though it probably had a different underlying cause. [22:40:57] Cool. I don't need to add one then. 🙂