[00:19:00] back now lol [00:19:18] Anyway time for me to start the 1.46 upgrade [00:29:18] Good luck with that lol, I'll be selling people their 10am morning goon. [00:29:23] Goon = alcohol. [01:09:04] The final phase of the 1.46 upgrade will be at the end of this week into next week, for the next few days I will be upgrading individual wikis based on the amount of files (which for 1.46 due to the imagelinks migration take the longest). [01:47:39] @prabhasxd you added !in_array( $title->getPrefixedDBkey(), [ 'Legacy:Wiki', 'Dev:Wiki' ], true ) again lol [01:47:44] Don't need that [01:48:35] [1/6] ```php [01:48:35] [2/6] if (!$title?->isMainPage()) { [01:48:35] [3/6] return; [01:48:36] [4/6] } [01:48:36] [5/6] ``` [01:48:36] [6/6] should be enough there. [02:08:34] Lol [02:19:27] Dude [02:19:29] Oh my god bruh [02:25:02] @cosmicalpha yeah removed it [02:26:13] [1/2] i literally copied this part from the gist how did i place the dev:wiki crap [02:26:13] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1551781637111549992/image.png?ex=6ab338c4&is=6ab1e744&hm=c33a12b96f5f24bfa6048b57a53d56638013dfc83205a70c8d47a3c825790558& [02:30:25] Made one last review then I can merge..Thanks for bearing with this. [02:30:52] yeah man ofc [02:59:13] @cosmicalpha done with the changes you requested [02:59:30] its really hard to tell how many tabs i had to add or whatever it is you called it (indents im pretty sure) [03:00:20] You could just click apply suggestions, mind if I just edit it myself to get it mergeable? [03:00:29] You deleted the wrong line also lol [03:00:34] wait i can just do that [03:00:35] wtf [03:00:39] omg [03:00:44] yknow what sure you can, edit it [03:01:07] this is what years of not using github does to a man [03:04:34] alr lets see [03:04:46] https://itemasylum.wiki/?v=2 [03:05:04] Hasn't been fully deployed just yet. [03:05:11] oh mb lol [03:05:14] Has now though [03:05:25] https://itemasylum.wiki/?v=2 [03:05:31] Use ?v=3 [03:05:35] thought this v=2 purcges cache [03:05:36] oh [03:05:38] https://itemasylum.wiki/?v=3 [03:05:45] Still same thing [03:05:48] hey, maybe 4 will be lucky [03:06:00] nvm1 [03:07:41] yeah idk whats wrong with this ✌️ [03:11:06] I can do some testing later this week and attempt to fix it [03:11:50] 👍 [03:13:02] Do note that is consitional on if I have time, I am also doing the full 1.46 upgrade throughout this week and early next week so it may be next week before I can. [03:14:35] Take your time man [03:14:37] It's fine [08:57:00] apparently the problem is because of the embed thing at the very bottom [09:11:37] [1/6] And 2 more sec vulnerabilities were found after the first one by Random: [09:11:37] [2/6] https://github.com/ProfessionalWiki/Maps/security/advisories/GHSA-rg4f-xvhj-mw22 [09:11:37] [3/6] https://github.com/ProfessionalWiki/Maps/security/advisories/GHSA-56p2-6jwm-mvfc [09:11:38] [4/6] A new setting was created which would squash concerns about SSRF. It's quite unfortunate that LLMs have made commits like https://github.com/ProfessionalWiki/Maps/commit/241df87c667233bdb1d004348e7a3b63ef15a36b possible because it is definitely not an ideal solution, even if the IP blacklist has no omissions (for now). +1000 lines for a bug like this [09:11:38] [5/6] is a huge maintenance burden. [09:11:38] [6/6] Not sure how it does on the XSS end of things. [09:13:25] [1/3] @cosmicalpha apparently the fix is this: [09:13:25] [2/3] `components` changed to `component` (the first mention of it) [09:13:26] [3/3] and the removal of `"embeds": []` [09:15:21] [1/2] if there's no, so to speak, 'map' on resolution, then it might be good to just say it is indefinitely suspended outright and probably not coming back in order for people to plan around any alternative solutions. If its already so (in a more definite way than 'but someone might be working on it' as a backdoor if that's not actively the case) then ignore me and [09:15:21] [2/2] I missed it [09:16:03] short of it taking on surprise maintainers that both overhaul it and also proof against claude shenanigans that might exacerbate it [09:16:15] [1/2] submitted another pr: https://github.com/miraheze/mw-config/pull/6562 [09:16:15] [2/2] feel free to merge it whenever ur free 👍 [09:53:06] I don't think ManageWiki/permissions is working properly since our wiki as updated to REL1_46. [12:16:40] it's funnier if you don't clarify [12:18:33] Maybe, [13:30:18] [1/15] fyi this is supposed to be the standard format for the discord custom embeds: [13:30:19] [2/15] ``` [13:30:19] [3/15] { [13:30:19] [4/15] "component": { [13:30:19] [5/15] "type": 17, [13:30:20] [6/15] "accent_color": 5793266, [13:30:20] [7/15] "components": [ [13:30:20] [8/15] { [13:30:21] [9/15] "type": 10, [13:30:21] [10/15] "content": "# Patch Notes\n- Fixed a bug where certain treasure chests wouldn't open properly\n- Improved server stability during peak hours\n- Added a new type of gravity that will randomly apply when the moon is full\n- Every third thursday the furniture will scream its darkest secrets to nearby npcs" [13:30:21] [11/15] } [13:30:22] [12/15] ] [13:30:22] [13/15] } [13:30:23] [14/15] } [13:30:23] [15/15] ``` [13:30:43] [1/2] this square bracket is wrong [13:30:43] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1551948864540385365/image.png?ex=6ab3d483&is=6ab28303&hm=f7b2bd679b42c4e8f3349f02e3f94e1dc83af017631615a972c070b5119b0e3d& [13:31:44] https://discord-anthony-embed-unfurl-components.mintlify.site/developers/link-previews/component-embeds [13:34:24] Read the dang doc a billion times today oh my god [13:34:31] Time for pr number one million [19:10:33] These custom Discord embeds look cool - is the only way to do them right now a PR to git? (And did I read correctly that WMF is planning to add support for it eventually?)