[11:56:56] <Guest82>	 Hi, I'm using php8.0 and noticed a compatibility issue in the smtp mailer: externals/phpmailer/class.smtp.php line 388: "while(list(,$line) = @each($lines))" should become something like "foreach ($lines as $line)"
[12:05:52] <Guest82>	 Also on line 417 (also in externals/phpmailer/class.smtp.php): "while(list(,$line_out) = @each($lines_out))" -> "foreach($lines_out as $line_out)"
[12:06:01] <Guest82>	 Now we can sane emails again :-)
[12:13:59] <Guest82>	 Can somebody make a ticket or fix for this please? I don't have the access rights
[12:22:25] <Krinkle>	 The @ suggests someone specifically took effect to silence instead of migrate. Might be a caveat lurking on that each() call
[12:24:03] <Guest82>	 I think it was to suppress depreciation warnings in php 7.2 https://www.php.net/manual/en/function.each.php
[12:39:11] <Krinkle>	 It's possible. I personally would have gone straight for foreach given that that isn't a new construct so wouldn't have a compat reason against. Unless there's something non trivial etc. Worth looking at the commit that did it just in case
[12:48:30] <Guest82>	 https://we.phorge.it/source/phorge/history/master/externals/phpmailer/class.smtp.php - It was created in 2012 and hasn't been edited since
[12:57:18] <Krinkle>	 1/3 isn't @'ed. maybe it's tolerating invalid input in those 2 cases but I don't see it. Seems a simple array indeed