[07:29:18] I caught up with cloud-l and replied, I had forgotten that back in 2013 DaB gave everyone on the Toolserver literally one month to move over to SGE [09:07:11] legoktm: thanks! [09:49:14] dcaro: in the different repos, when merging a version bump, the readme instructions say to ask for a review. In practice, we've been self-merging these. Should we update the instructions, or our behavior? :)) [09:50:58] *more accurately, "self-approving" or really, just skipping approval (which is optional) [09:51:20] ideally the behavior, specially if the version bumps include more than one change (that currently we allow) [09:51:56] but given that we are short of reviews and if the change is small it's an ok tradeoff to self-merge [09:52:16] (would be great if we had a set of functional tests, but I have not gotten around yet to write something like that) [09:52:40] also nowadays the version bump is quite easy to make without mistakes [09:54:08] might be ok to change the docs to specify so, something in the lines of "if the change is small, feel free to self-merge, if there's more than one change going in, look for reviews" [09:54:21] sounds good [09:55:22] and at least the builds-cli docs need updating anyway, because committing and tagging now happen automatically too [09:55:22] we might want to add something somewhere about adding a note in the changelog page if it's something that affects users: https://wikitech.wikimedia.org/wiki/Portal:Toolforge/Changelog [09:55:26] like the quota subcommand :) [09:56:28] ah yes, good point. actually, I'll create a task because I feel I'll not do this right away and will just forget about it xd [09:58:02] related question: the clis are supposed to be pushed to PyPI nowadays? [09:58:04] would be nice if we automated something like that (ex. adding a `USER NOTICE:` line in the commit message ends up creating an entry in the changelog there), but well, time :) (might be an interesting project) [09:58:33] they should yes, I think it's automated though, isn't it? (when you create the tag) [09:59:17] (might be an interesting silent week project in general to do some general house-keeping in that sense) [09:59:50] ah is there a ci pipeline for that? I'm not up to date with all of the improvements [10:00:35] there's one that given a new tag, deploys to pypi [10:00:59] I was working on having one that on a version bump creates a release (that in turn creates a tag, and would then deploy to pypi I think) [10:01:30] but for now you have to manually create the tag and release (you can try creating the release directly, see if that triggers the pypi deploy) [10:03:02] is that a different tag than the one created with `git tag "debian/$new_version"` in `utils/bump_version.sh`? [10:03:10] no, should be the same [10:03:51] (you can also select an existing tag when creating the release, it's what I've been doing) [10:12:33] created T352964 [10:12:33] T352964: [docs] Update Toolforge component README's - https://phabricator.wikimedia.org/T352964 [10:13:00] additions welcome [10:30:25] dcaro: do we still have to publish the deb packages manually to the build server? [10:30:34] yep [10:36:41] ok. will do it a bit later today, will take early lunch because I have an appointment [11:14:22] taavi: hey, quick one I was looking at some outstanding reviews assigned, I think we can abandon this one? [11:14:23] https://gerrit.wikimedia.org/r/c/operations/puppet/+/929740 [11:14:42] I didn't deep-dive into it but I think we covered it off in other patches - if you're unsure I can take a closer look [12:32:05] * dcaro lunch [13:54:56] dcaro: https://sal.toolforge.org/log/eBpoRIwBGiVuUzOdYunI uh, did you upgrade that to bullseye or newer? [13:55:23] it was bullseye already [13:55:24] :) [13:55:39] oh [14:25:40] Rook: I merged patches last night to stabilize the credential key so that things won't break on re-image in the future. I also confirmed that the opentofu stuff still worked before and after... [14:26:20] BUT, I only checked that in eqiad1. I foolishly only did the 'after' test in codfw1dev, and the creds don't work there. [14:26:33] So I don't know if I broke 'em or if they were already broken :/ [14:27:43] taavi: ^ possibly of interest to you too, just in case you were planning to demo things in codfw1dev [14:28:21] Awesome! Codfw1dev hasn't worked for me for awhile so sounds good [14:29:09] ok, that's what I figured [14:36:48] Thanks for the email legoktm! [15:35:30] legoktm: thank you for the mailing list followup. Walking the line between providing a sense of urgency and acknowledging that all volunteers deserve time to actually do the work is difficult as you know. :) [18:07:11] Yay! [18:07:14] https://www.irccloud.com/pastebin/abAZuAmH/ [18:07:34] I was able to build it with buildpacks :) [18:09:33] dcaro: Nice! [18:10:18] I broke the apt one though xd, but it's a good progress [18:36:10] fixed :) [18:36:20] * dcaro off