[01:37:39] * bd808 off [07:36:33] dcaro: the pods are up and running now, it's just that they were stuck in ContainerCreating for an unusually long time (1+ hour) 🙏 [09:45:13] quick review if anyone is around https://gitlab.wikimedia.org/repos/cloud/toolforge/envvars-cli/-/merge_requests/16 [09:47:48] looking [09:51:23] dcaro: lgtm [09:52:07] thanks! [10:14:12] * blancadesal is taking early lunch to run an errand [11:38:42] * dcaro lunch [13:18:13] quick review (it's blocking ci) https://gitlab.wikimedia.org/repos/cloud/cicd/gitlab-ci/-/merge_requests/25 [13:33:00] on ot [13:33:02] it [13:33:51] dcaro: 👍 [13:35:10] thanks! [13:37:34] hmpf... that did not work :/ [13:42:12] ouch [13:53:01] dcaro mypy is failing on envvars-cli since I rebased on top of the latest version a moment ago, is it related? [13:54:52] should not, this failure happens on CI only, as a pre-step [13:55:03] before mypy or anything [13:55:24] hmm, weird. it worked just before rebasing, now it fails both on main and my branch [13:56:05] https://gitlab.wikimedia.org/repos/cloud/cicd/gitlab-ci/-/merge_requests/26 second try, I tested this one locally as much as I could [13:56:18] let me check the mypy thing [13:57:20] seems to work for me [13:57:38] https://www.irccloud.com/pastebin/DefNq0qK/ [13:57:48] did you run it via tox? [13:58:03] yep, also cleaned up my pre-commit stuff right before [13:58:03] did you run it via tox? utils/run_ci_locally.sh [13:58:12] not the script, just tox [13:58:23] it's been a while since I used the script [13:58:48] ok, as I have it now the script works on main but not tox, and both tox and the script fail on my branch 😓 [13:58:55] as we don't use the gerrit ci anymore, the image on gitlab is different, so the script might need updating [13:59:34] I think it uses the good image though tox-poetry-buster [13:59:55] oh, with the script I get `PermissionError: [Errno 13] Permission denied: '.mypy_cache/missing_stubs'` [13:59:58] is that what you get? [14:01:55] https://www.irccloud.com/pastebin/FFtzTYhE/ [14:02:45] ah, no, my error is because /src is mounted read-only, and then the pre-commit stuff (ex. end-of-file fixer) fails to change files [14:03:20] that sounds as if you have an old versions of toolforge-weld somewhere installed [14:03:57] for me it pulls 1.4.0 [14:04:29] but tox uses poetry-installed dependencies from its own env, doesn't it? [14:04:48] it should yes [14:05:01] yes, it's 1.4.0 too [14:05:12] what version of mypy do you have? [14:06:48] none locally, tox must be providing it? [14:07:52] or the pre-commit hook, more specifically [14:08:01] pre-commit should be getting it yes [14:08:15] https://www.irccloud.com/pastebin/Hcds90LV/ [14:08:20] not sure if that's very helpful xd [14:08:42] I'm using python 3.12 though [14:09:23] (my system python) [14:10:30] the last hack worked \e/ https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-builder/-/jobs/184003 [14:11:19] yay! [14:27:30] hmm, it's not just mypy: latest envvars version is not working for me [14:28:19] https://www.irccloud.com/pastebin/NpH0Z6SU/ [14:30:21] that's interesting [14:30:39] so you are using a virtualenv there, with python3.9 [14:31:11] this is poetry's shell [14:32:31] cat you check what version of toolforge-weld is that one? [14:33:51] we don't seem to have a version string in the code itself xd [14:34:14] toolforge-weld 1.1.0 [14:34:31] that should be 1.4.0 [14:34:43] maybe we can force the dependency [14:35:00] why is poetry using python 3.9? [14:35:24] something like poetry add 'toolforge-weld>=1.4,<2.0' [14:35:33] that's the system python in the lima-kilo VM I guess [14:35:56] does yours use the same? [14:36:58] let me check [14:37:15] yes [14:37:16] https://www.irccloud.com/pastebin/kNh77ENK/ [14:37:38] ok, so bullseye system python I guess [14:38:23] ok, so I'll try forcing toolforge-weld 1.4 [14:39:28] would be nice to change it in the poetry.toml too, so we for sure force the upgrade [14:39:51] yeah, that's what I'm doing [14:40:45] awesome, thanks :) [14:44:26] that fixed it (but not mypy) [14:44:46] something is something xd [14:45:00] for mypy iirc we specify the packages we need (like types-something) [14:45:05] maybe that's in tox.ini? [14:45:46] I'll check, there's already a related task iirc [14:46:06] .pre-commit-config.yaml: ` "toolforge-weld>=1.1.0",; [14:46:32] T353044 [14:46:33] T353044: [builds-cli][ci] Investigate discrepancy between different CI envs - https://phabricator.wikimedia.org/T353044 [14:50:25] mypy passing now too :)) [14:54:01] \o/ what was the issue? [14:54:31] can I get a +1 on this request? T354192 [14:54:31] T354192: Request creation of OpenVAS VPS project - https://phabricator.wikimedia.org/T354192 [14:56:50] dcaro: the issue was the toolforge-weld version in pre-commit, as you pointed out [14:57:14] good, I was scared it would be the version of python or mpyp... [14:58:10] dcaro: quick review https://gitlab.wikimedia.org/repos/cloud/toolforge/envvars-cli/-/merge_requests/18 [14:58:43] dhinus: done [15:00:14] thanks :) [15:00:41] blancadesal: done [15:00:51] thanks :)) [15:01:39] needs changing in builds-cli too I think [15:08:11] dcaro: another quick one: https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-cli/-/merge_requests/46 [15:08:47] done [15:11:29] thx [15:12:32] now I can go back to whatever I was actually trying to do xd [15:14:53] hahahaha, yep, I strongly empathize with that feeling [15:16:40] it's kind of never not like that... xd [15:47:23] andrewbogott: I think in this page "viewer" should actually be "reader", do you agree? https://wikitech.wikimedia.org/wiki/Help:Cloud_VPS_user_roles_and_rights [15:48:12] dhinus: yep, you're right [15:49:28] I'll replace it [15:50:13] done [16:02:51] thanks! [16:52:03] * dcaro clocking out [16:52:16] any last review/etc before I lock the screen? [16:52:19] :) [17:10:39] I guess not, /me out [17:10:41] cya tomorrow [17:11:00] bye :) [18:43:21] * bd808 lunch [22:45:09] * bd808 got his IRC client recompiled for ARM64 [22:46:10] that sounds like a big project [22:48:14] I only compile the thing like once every 2-3 years so there is always some "wait, how does this all work?" time. This time that only ate up about an hour. :) [22:49:38] I'm not an IDE person, and xcode can be super confusing in my experience [22:50:20] But hey, it's not as bad as autotools ;)