[07:01:18] greetings [08:52:22] morning [08:58:47] quick review? (from yesterday) https://gerrit.wikimedia.org/r/c/cloud/wmcs-cookbooks/+/1201029 [09:03:52] LGTM [09:04:04] thanks! [09:04:20] sure np, feel free to add me to gerrit reviews and i'll take a look [09:09:44] morning [09:10:48] morning! [11:07:32] dcaro: https://toolforge-functional-runner.toolforge.org running https://github.com/DamianZaremba/toolforge-functional-runner if you're interested. Needs some more work but will leave it running as an experiment for now [11:10:29] Damianz: nice, I think we will be able to reuse most of it when we add it platfrom-side [11:50:06] * dcaro lunch [13:15:33] finally got around fixing the maintain-kubeusers tests freezing the date, https://gitlab.wikimedia.org/repos/cloud/toolforge/maintain-kubeusers/-/merge_requests/79 [13:15:58] bundling it up with the ci changes as both need each other to pass [13:17:05] quick review if anyone has a moment ^ [13:20:44] lftm, freezegun is pretty sweet if it gets more complicated than that [13:21:43] I tried, but the mock it generates messes up with the serialization that k8s cli does somehow and decided to not go down that rabbithole yet [13:22:11] jobs-api:239 & jobs-api:240 need needreview label if someone doesn't mind (T409007). will test after lunch [13:22:12] T409007: [jobs-api] failed to create job from components - https://phabricator.wikimedia.org/T409007 [14:28:24] bd808: anything I can do to help getting the interwiki handler fix out? [14:41:49] does maintain-dbusers manage accounts in wiki replica hosts, or just for toolsdb? [14:44:02] andrewbogott: everywhere [14:44:18] ok, as I thought. thx [15:55:05] taavi: I should have a patch for you to review tomorrow. I figured out the core use case on Friday. The TODO left is handling the [[toolforge:]] edge case. I had to work on other things yesterday, but I expect to finish up testing in my afternoon. [16:08:32] Raymond_Ndibe: the mr I was talking about is https://gitlab.wikimedia.org/repos/cloud/toolforge/components-cli/-/merge_requests/65 [17:19:45] quick review https://gerrit.wikimedia.org/r/c/operations/puppet/+/1201737 [17:21:23] dcaro: is the intention to remove those from metricsinfra afterwards or keep them duplicated on both prometheus deployments? [17:22:02] I did not know they were in metricsinfra, though I think they belong there better yep [17:22:11] wdyt? [17:22:31] 'there' being which instance? [17:23:22] sorry, toolforge prometheus [17:25:23] * taavi has no strong preference except having a single thing in two places is confusing [17:28:40] dhinus: the reason for T404570#11341257 is that the wiki has not been created yet [17:28:41] T404570: [wikireplicas] Create views for new wiki tokwiki - https://phabricator.wikimedia.org/T404570 [17:29:00] taavi: ack [17:29:08] taavi: thanks, though T404566 is marked as completed, so I'm confused [17:29:09] T404566: Prepare and check storage layer for tokwiki - https://phabricator.wikimedia.org/T404566 [17:29:44] I left a comment in that task [17:43:30] * dhinus off [18:28:47] * dcaro off