[07:17:14] <godog>	 greetings
[08:27:57] <godog>	 andrewbogott: no reason not to delete the fullstackd VMs no
[08:28:13] <godog>	 re: add_server, I replied on the patch, might have been a mistake indeed
[08:30:22] <godog>	 I'm re-reading the code and now I'm not clear on the usage of prefix vs volume name for the service record
[08:31:32] <godog>	 also did I get it right that add_server / migrate_service did work for a few projects though it is choking on some others? which ones ?
[13:36:04] <andrewbogott>	 godog: If I add a server and then try to migrate from an existing (years-old/bullseye) server, it fails because of the naming mismatch.
[13:36:28] <andrewbogott>	 but I will double-check the logic... I might just add a third argument for the service record rather than reverting the change, haven't decided.
[13:38:50] <godog>	 andrewbogott: ok SGTM, is the failure to migrate based essentially on the age of the server? i.e. newer ones worked ?
[13:39:29] <andrewbogott>	 I don't know, I haven't tried to migrate any fresh ones. But I imagine that if I built two servers with the cookbooks right now it would work to migrate between them.
[13:39:49] <andrewbogott>	 but yeah, that's a reason to add a new argument, so that it works with both old and new
[13:39:55] <andrewbogott>	 or /can/ work at least
[13:42:26] * godog nods
[14:57:09] <andrewbogott>	 godog: https://gerrit.wikimedia.org/r/c/cloud/wmcs-cookbooks/+/1305913 and https://gerrit.wikimedia.org/r/c/cloud/wmcs-cookbooks/+/1305914
[14:57:17] <andrewbogott>	 The first one should get me unblocked, the second is just for good measure
[15:17:10] <dhinus>	 andrewbogott: I think g.odog has already logged off, but IIRC you should be able to run those with "test-cookbook -c {patchid}" until they get merged
[15:17:31] <andrewbogott>	 yep, i just remembered that :)  thx