[07:43:49] morning! [08:27:45] morning [11:01:25] some easy-ish reviews to fix the acct issue mentioned on cloud-l: https://gerrit.wikimedia.org/r/c/operations/puppet/+/1327079 https://gerrit.wikimedia.org/r/c/operations/puppet/+/1327087 [11:03:33] sent a quick comment, will review after lunch if nobody did first [11:03:37] * dcaro lunch [11:06:30] also, i'd like to send a reminder email about the elasticsearch shutdown: https://etherpad.wikimedia.org/p/toolforge-opensearch-announcement [11:18:11] patches and announcement LGTM [11:18:33] besides the point, though why do we even bother with acct nowadays ? [11:18:45] pacct rather [11:19:44] I got some reviews out myself, https://gerrit.wikimedia.org/r/q/topic:%22bug/T362397%22 https://gerrit.wikimedia.org/r/q/topic:%22bug/T424802%22 https://gerrit.wikimedia.org/r/q/topic:%22bug/T284747%22 [11:32:22] looking [11:33:45] godog: for https://gerrit.wikimedia.org/r/c/operations/puppet/+/1326279 should all the files be ensure => absent,ed before being removed entirely? [11:34:47] taavi: for checks running on the icinga host itself IIRC no, there's no race [11:35:16] that and the alerts are not firing anyways since wikitech-static.w.o is considered down by icinga [11:35:46] or rather maybe there's a small race? icinga runs puppet basically continuously these days [11:38:21] but isn't that leaving stale files in the filesystem? `/usr/lib/nagios/plugins` doesn't seem to be automatically purged, and nagios_common::check_command::config might not as well although I can't tell from the code alone [11:40:24] ah yes that's true, I'll absent the files [11:41:15] if that wasn't obvious I'm not particularly keen on properly maintaining icinga anymore [11:42:26] ah fair :P [11:43:02] tbh I think it's better to properly absent the files rather than to end up in a state where the alerting host has a bunch of unmanaged files and no-one knows if they're in use anymore or if the entire system can be decom'd [11:45:03] yeah you are right, might as well do it and {{done}} [11:46:02] i think the current patch will fail to compile, as it's referencing files and templates gone from the repo [11:46:10] files not sure, but the template() call will fail for sure [11:50:12] gah of course, ok fixed in next PS [11:50:24] running an errand, will check back later [11:50:27] thank you [12:35:16] komla: given the reply in https://lists.wikimedia.org/hyperkitty/list/cloud@lists.wikimedia.org/message/KVRB52OBTFYVQBQF47XKFNO5NBOZ6F5Q/ that to me implies that maintainers don't need to delete their own VMs, what is the plan to have them actually deleted? [16:55:34] taavi: andrewbogott: last friday we talked about an expiring cert for the `integration` puppet server. I dismissed it cause I looked at the CRL date instead of the CA date 🙁 [16:56:03] I'll do the runbook at https://wikitech.wikimedia.org/wiki/Help:Project_puppetserver#Renewing_puppetserver_CA_certificate [16:56:09] thank you for having filed the task ( https://phabricator.wikimedia.org/T435319 ) [16:57:26] * dhinus off [16:59:24] * dcaro off [16:59:26] cya tomorrow!