[03:45:57] Could someone take a look at a bug in VideoCutTool? youtu.be/yqa2whY0FS0 [03:46:58] So when I click the log in button there is a pop up window (which didnt appear here) but the window says it is succesful [03:47:18] Could someone file a case about this at phab? [07:57:29] jeromy_mikhael: you can open a phabricator ticket and enter the details you see here: https://phabricator.wikimedia.org/maniphest/task/edit/form/1/ [08:57:04] D: how long should I normally have to wait before i can sudo on a machine i creat? [09:01:14] a couple of minutes, the first puppet run should bring that in. You can check the 'logs' tab in the instance details page in horizon (openstack ui) to see if it got stuck or had errors [09:01:37] *checks* [09:01:51] I can already ssh there, but not sudo :/ [09:03:53] 15 mins, maybe I should just recreate it [09:04:17] what kind of user do you have (sudo access reflects ldap, and that depends on who is projectadmin or only user) [09:04:33] but if you created a VM you are most probably projectadmin [09:04:42] im project admin, and I see me in the sudo list for all commands at https://horizon.wikimedia.org/project/sudo/ [09:05:13] Its gitlab-runner-addshore-1002.integration.eqiad1.wikimedia.cloud if you are curious [09:05:35] I just deleted the 1001 instance and made a 1002 instance, could sudo on the last one, can't on this one [09:05:42] The only thing I changed in setup was debian 10 -> 11 [09:08:00] does ´sudo -l´ show anything? [09:08:54] it consistently wants a password https://usercontent.irccloud-cdn.com/file/FMrLbDHN/image.png [09:09:11] uh, that's definitely not what's supposed to happen [09:09:17] try rebooting the instance? [09:09:24] already tried rebooting it once [09:09:33] i can happily throw it away and make anenw one [09:09:40] as long as noone is curious to look at what happened :) [09:10:19] I don't have enough access yet :P [09:11:04] ill nuke it! [09:11:15] fingers crossed for take 2 [09:12:00] ack [09:12:02] * addshore launches 1003 [09:18:02] Wait, this could have somehting to do with it? [09:18:04] [ 236.663454] cloud-init[1585]: Cloud-init v. 20.4.1 finished at Mon, 11 Oct 2021 09:16:19 +0000. Datasource DataSourceOpenStackLocal [net,ver=2]. Up 236.65 seconds [09:18:04] [[0;1;31mFAILED[0m] Failed to start [0;1;39mExecute cloud user/final scripts[0m. [09:18:04] See 'systemctl status cloud-final.service' for details. [09:18:24] puppet has run, but that looks wrong [10:22:51] can you open a task? we can take a look when we have some time [10:31:59] !log toolsbeta Adding a new grid webgrid generic node (T292465) - cookbook ran by dcaro@vulcanus [10:32:03] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Toolsbeta/SAL [10:35:34] dcaro: will do [10:37:05] https://phabricator.wikimedia.org/T292959 [12:14:02] !log tools.lexeme-forms deployed fb32d04132 (l10n updates) [12:14:05] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.lexeme-forms/SAL [13:21:17] someone in the Wikimedia General chat telegram group reported “certificate verify failed” errors in the video2commons tool [13:21:25] maybe someone can restart the tool? that should be enough to resolve this Let’s Encrypt issue, right? [13:21:34] no [13:21:38] mh, ok [13:22:02] * chicocvenancio is in a meeting, will give more details soon [13:22:15] then I hope you’ll be successful in your maintainership request… [13:22:47] T292355 has a bit more details... [13:22:47] T292355: video2commons login is broken by the LE cert expiry (py2.7) - https://phabricator.wikimedia.org/T292355 [13:23:21] thanks, I’ve forwarded that task ID [13:24:43] * chicocvenancio pokes andrewbogott with the "only a few minutes of work to port to python 3" message [13:27:52] chicocvenancio: where does the python code live? [13:28:26] https://github.com/toolforge/video2commons [13:45:18] I guess I'm going to be delayed by 'Support for password authentication was removed on August 13, 2021' [13:51:47] chicocvenancio: I just sent you a pull request with the easy bits [13:52:33] Of course I haven't tried running anything because I don't immediately know where/how to do that. If you want I can stand by while you test and we can sort out any dependency issues that arise. [13:52:56] requirements.txt is very short so I'm optimistic [13:58:54] !log tools.video2commons-test checking out PR#138 and running with python3.9 type T292355 [13:58:57] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.video2commons-test/SAL [13:58:57] T292355: video2commons login is broken by the LE cert expiry (py2.7) - https://phabricator.wikimedia.org/T292355 [14:00:17] chicocvenancio: I would expect immediate failures due to failed imports; logic errors are much less likely. So if it looks like it's working, it's probably working! [14:01:04] its erroring out :( [14:01:10] https://www.irccloud.com/pastebin/bcEvQDqc/ [14:01:36] is this running in a venv or right on the VM? [14:01:48] ahh [14:01:49] fair [14:02:17] If in a VM then deps need regenerating, if on the VM then 'apt-get install python3-encodings' and repeat as necessary :) [14:02:58] yikes, I mean 'if in a venv then deps need...' [14:03:24] my fingers think that 'venv' and 'vm' sound the same so never type the right thing [14:05:17] installing requirements in new pyton3.9 venv [14:07:27] `ModuleNotFoundError: No module named 'pywikibot' ` [14:07:36] * chicocvenancio is fixing that [14:09:45] kubectl is erroring out now... [14:12:54] https://www.irccloud.com/pastebin/4eJzWKgS/ [14:17:23] andrewbogott: ^ [14:18:36] hmmmm that looks to me like it's still trying to use py2 but looking [14:19:29] looks like the error is that `async` became a keyword in Python 3 [14:19:34] so you can’t use it directly as a kwargs name [14:19:54] but **{'async': bool(chunked)} should still work [14:20:02] not sure if you can freely combine ** with other named args, though [14:20:11] or if you’d need to convert the whole argument list to **{...} syntax [14:20:44] https://i.imgur.com/ln3bir9.png [14:21:01] bridgebot drunk some unicode booze (re @wmtelegram_bot: or if youâ€™d need to convert the whole argument list to **{...} syntax) [14:21:13] thanks Lucas_WMDE that's pretty obscure! [14:21:13] yeah I’ve noticed that before :( [14:21:31] apparently the Telegram->IRC direction handles Unicode better :shrug: [14:22:05] that seems like something that needs fixing in pywikibot :/ [14:22:30] you sure? the stack trace looks like the call is in video2commons [14:22:39] let me see if I can find the file on github [14:22:52] kubectl is still erroring out... [14:23:02] so I can't rush the crashloopbackoff [14:23:12] oooh [14:23:30] this looks better [14:23:32] https://www.irccloud.com/pastebin/yTTuDIHb/ [14:23:44] https://video2commons-test.toolforge.org/ [14:24:14] Lucas_WMDE: I mean that pywikibot takes an arg called 'async' [14:24:16] consumers is not properly set for test. Let me commit this and move to v2c proper [14:24:22] but yeah, not going to break backwards compatilibity for pywikibot just now [14:24:39] andrewbogott: fair, but for now we can work around it https://github.com/toolforge/video2commons/pull/139 [14:24:46] great [14:24:49] I hope [14:24:53] (haven’t tested this) [14:25:10] I've tested with just the final arg [14:25:23] that **{} syntax is horrifying but if it works it works :) [14:25:38] I *think* I’ve had to do something similar in one of my tools but I don’t remember which one [14:25:59] and GitHub doesn’t really like codesearching for "**{" it seems ;) [14:26:40] aha, it was “assert” that time https://github.com/lucaswerkmeister/tool-quickcategories/commit/ad1e46865dae230a161a1922080a19bfc9ff64d6 [14:31:48] Lucas_WMDE: I'm still trying to understand what's happening with that 'async' arg. I can't find the associated function in pywikibot; do you see it? [14:31:54] https://github.com/wikimedia/pywikibot [14:32:07] I haven’t looked for it yet, let me see [14:32:14] I see an upload function with an 'asynchronous' arg which is suspicious [14:32:37] !log tools.video2commons trying python3 port [14:32:39] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.video2commons/SAL [14:32:47] 🤔 [14:33:10] it doesn’t look like it was ever called “async”, it was introduced as “asynchronous” already https://github.com/wikimedia/pywikibot/commit/e68f6191cab256ab9dba23de7541e275dd876a24 [14:33:25] did video2commons accidentally use the wrong arg name and nobody noticed? [14:33:47] for that matter I can't find a class named 'Site' in pywikibot either so I'm making some major mistake here [14:33:48] * chicocvenancio shrugs [14:33:52] Lucas_WMDE: that's how I'm leaning atm [14:34:00] although the script takes --async [14:34:07] I keep wanting that to be related somehow [14:34:17] Maybe we've found some never-traversed code in v2c [14:34:35] its not used by the frontend, I think [14:35:04] ie, not in toolforge that I'm changing [14:35:15] hm [14:35:30] but should be used in the workers in the vps project [14:35:46] oh wait, that “asynchronous” argument is from this year [14:35:52] that can’t be what the v2c code was referring to [14:36:46] I think I/we must be looking at the wrong version of pywikibot [14:37:17] argh, theres some live uncommited changes in the tool [14:37:32] ah, there’s the relevant pywikibot change I think https://github.com/wikimedia/pywikibot/commit/6f7ecb4d4391648da8494ad11ec18c00a0ca599a [14:37:39] replacing “async” with “asynchronous”, 2017 [14:38:00] what the heck, why didn't I find that grepping the log for 'async' [14:38:07] because it’s gone now I think [14:38:11] I git logged -S async= [14:38:21] this @deprecate_arg() backwards compatibility thing was also removed at some point I think [14:38:27] so in the grep today it would be gone [14:38:41] squashed in a merge or something? [14:39:03] deprecated_args() gone in https://github.com/wikimedia/pywikibot/commit/c358f1abd1856533b84948aa1613aea25af9070b two days ago apparently [14:39:03] ok, anyway, it sounds like there's a clear right answer for fixing in v2c, which is 'rename that argument to 'asynchronous' [14:39:15] unless we don't have that version of pywikibot running on toolforge :/ [14:39:34] probably [14:39:41] https://www.irccloud.com/pastebin/w6MH7WR1/ [14:39:53] grmbc [14:39:56] *grmbl [14:40:10] heeeey that explains why I couldn't find the 'Site' class ! [14:40:48] how did it work in video2commons-test ?! [14:41:29] ahhh I see [14:41:39] weird, locally I still get a Site() (though it’s deprecated) [14:42:06] chicocvenancio: I'm sorry about how wrong I was with that 'few minutes' thing [14:42:11] Although I suspect this is still tractable [14:42:16] reinstalled the venv before pulling requirements.txt changes [14:43:17] andrewbogott: no worries. I knew it was not a quick fix, but its probably better [14:43:29] so its working within python3.9 now [14:44:03] And we're live! [14:44:06] https://usercontent.irccloud-cdn.com/file/g2ajMTRg/image.png [14:44:12] :o [14:44:19] or, at least logs in [14:45:20] * andrewbogott checks the time [14:45:48] 80 minutes. More than a few I guess [14:45:50] it’s an amount of minutes [14:47:36] I'm going afk for now but satisfied that I nerdsniped you into doing the hard parts of this [14:47:47] (It is a weird US holiday today) [15:00:35] !log toolsbeta Adding a new grid webgrid generic node (T292465) - cookbook ran by dcaro@vulcanus [15:00:38] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Toolsbeta/SAL [15:24:57] !log toolsbeta Adding a new grid webgrid generic node (T292465) - cookbook ran by dcaro@vulcanus [15:25:00] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Toolsbeta/SAL [18:01:31] chicocvenancio you are now a project admin on the video project, feel free to do whatever you see fit [18:01:41] thanks [18:13:25] chicocvenancio: thanks [18:14:01] * chicocvenancio waves to zhuyifei1999_ [18:14:09] hi [18:14:39] * zhuyifei1999_ backreads [18:17:39] oh v2c used to use a custom fork of pwb for async chunked uploading. it has been merged a while back https://gerrit.wikimedia.org/r/679021 [18:19:19] good to know, but the errors were only on the frontend, so I'm leaving the backend as is for now. I'm hoping updating PWB on it can improve sending videos, but I want to test around a bit and be more confident I can bring it up once I break it. [18:21:22] ok cool [22:28:52] I'm trying to get re-setup with Gerrit and LDAP, but it's been a while since I've committed to any WMF repos and I'm having 2FA issues: Either 2FA wasn't required last time I used Gerrit, or I simply forget what authenticator I used. I've added my public key to Gerrit, but according to [1] I need to add it to LDAP as well. How do I go about getting [22:28:52] this worked out? One thing I read said I might need a WMF staff member to vouch for who I say I am. @tgr or @cicalese can do so. Thanks! https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr [22:28:58] [1] https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr [22:44:41] jamesmontalvo3: adding an SSH key to LDAP would probably be on https://wikitech.wikimedia.org/wiki/Special:Preferences#mw-prefsection-openstack, but I’m not sure if Gerrit uses that [22:59:21] Yeah I was wondering if I really needed to do the step "Also add your public key to LDAP using any of ..." step from the [1] link I sent above. I haven't tried it yet. But at some point I'll likely need to get into wikitech or toolsadmin, so I figured I should figure it out. [22:59:55] lucaswerkmeister the link you sent requires logging in, which requires the 2FA I currently don't have setup [23:00:12] hm, I see [23:01:36] if you don’t have the 2FA access anymore AFAIK you need to file a phabricator task to get it disabled https://wikitech.wikimedia.org/wiki/Password_and_2FA_reset#For_users [23:02:22] Understood, thanks