[06:41:50] Amir1: looking.. I see 'The selected edit policy excludes you. Choose a edit policy which allows you to edit the object.' in the logs :/ [06:42:27] ah, guess that has been broken since https://phabricator.wikimedia.org/applications/view/PhabricatorProjectApplication/#53. fixed by adding StrikerBot to trusted-contributors [09:25:20] awesome. Thanks [09:45:26] I really think there is something odd with me not being able to SSH to bullseye instances that I created [09:45:44] Just made gitlab-runner-addshore-1013.mwcli.eqiad1.wikimedia.cloud and I can't ssh there :/ I remmeber having this issue months back too, but just assumed it was as bullseye was new [09:46:15] If anyone has any thoughts on what might be going on that'd be grand, I just get addshore@gitlab-runner-addshore-1013.mwcli.eqiad1.wikimedia.cloud: Permission denied (publickey). [09:46:27] when did you create it? [09:47:55] Bah, yes it works now, it was indeed just slightly too fresh still [09:48:12] * addshore apologises for the noise [10:28:44] puppet runs can get slow [10:33:18] we should probably refresh the base images at some point so the initial apt upgrade and puppet run doesn't take that long [10:38:00] yep [16:53:36] Hi, anybody available to help me learn / implement conftool: https://gerrit.wikimedia.org/r/c/operations/puppet/+/779926 [16:53:36] (this is to move wikireplicas from puppet configuration to etcd) [16:53:36] or LVS: https://gerrit.wikimedia.org/r/c/operations/puppet/+/779915/ [16:53:36] (this is to make the dbproxy hosts pooled together so if one goes down for maintenance traffic goes to the other) [16:53:36] Even if you don't know these technologies we can learn together :) [16:57:20] I'd be interested, but I'm almost off today (got a meeting in 3 min), and won't be around until next friday [17:10:26] cool dcaro none of this stuff is particularly urgent, so let's plan for the week after that. I'll make a calendar invite [20:14:44] !log admin restarting nova-api and nova-conductor services in a superstitious attempt to reduce open DB connections [20:14:47] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Admin/SAL [20:15:38] lol [20:15:44] I almost want to put that on bash.t.o [20:19:30] !log packaging - deleting strech instance packager01 T306089 [20:19:32] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Packaging/SAL [20:19:35] T306089: Cloud VPS "packaging" project Stretch deprecation - https://phabricator.wikimedia.org/T306089 [20:20:43] !log packaging - revoking project-admin for myself [20:20:45] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Packaging/SAL [20:22:13] !log integration - revoking project-admin for myself [20:22:14] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Integration/SAL [20:42:58] andrewbogott: do you mind that on bash [20:43:11] no :) [20:43:32] although if we log every time I do something out of superstition we're going to run out of space [20:48:26] well, you gotta start somewhere [21:31:29] !log toolhub Updated demo server to 26cc79 [21:31:32] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Toolhub/SAL [22:28:15] Hey there - the wikimedia ruby gem relies on absurdly out of date faraday - i've got a PR for it - but the rights to push are restricted to a group of two people... can we create a refspec for authenticated users to push (perhaps under feature/ or some such?) [22:29:03] i may not even be in the right channel - but there's a lot here... [22:29:53] i - think i can modify the repos rights which - is this normal ? [22:31:19] oh... oh.... there's out of date pages talking about gerrit [22:31:45] rickmark: gerrit.wikimedia.org is still in use [22:32:12] ah rgr - https://gerrit.wikimedia.org/r/admin/repos/mediawiki/ruby/api,access - is where i'm trying to push a topic branch [22:32:31] the edit commands are open here - but the group membership is closed - oversight? [22:35:45] rickmark: this is the person you want for this, afaict: https://phabricator.wikimedia.org/p/zeljkofilipin/ [22:35:55] they would be able to change that [22:36:01] and are still around [22:36:06] perf - TY [22:36:31] so you have different options here [22:36:43] you can create a ticket in phabricator.wikimedia.org and tag them [22:36:54] you can use an existing Wikipedia or Gerrit user [22:37:14] ^^ have gerrit user - just no perms to push the changeset for review [22:37:15] or you can write on https://www.mediawiki.org/wiki/User_talk:ZFilipin_(WMF) [22:38:03] the last time ANY change was made to that group was ...2014 :p [22:38:16] i'll open a ticket since I think registered and authed users should be able to push a changeset to be discussed - basically the github PR model [22:38:41] i shouldn't for sure as a stranger get to push to main or such [22:39:07] but esp for the clients - community uptake is helpful [22:39:08] this is the best option if you can do that, yes [22:39:14] better to fix it for real [22:39:28] agreed [22:39:34] i think `refs/feature/*` should be open to guests or something [22:39:46] is there a convention elsewhere? [22:40:35] I don't think it's consistent but I would also excpect that normally anyone can upload a change [22:40:39] rickmark: gerrit patch sets are not "pushed". See https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr for the shortest gerrit "how to" [22:40:41] and then a limited group can actually merge it [22:42:26] ah - forgive my ignorance - i saw somewhere gerritt in some configs does support push based submits [22:42:51] i've been living that github lyfe too long [22:43:48] is https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr out of date? latest gerrit-tools says `-R` is not right [22:43:51] it is possible to replace `git review` with `git push gerrit HEAD:refs/for/master`. That's the magic that git-review really does ultimately [22:44:50] hmmm... they removed -R,--no-rebase upstream? That seems weird. [22:45:27] it seems to work with `git review push` [22:46:20] ah - first submission - thanks for the hand holding - https://gerrit.wikimedia.org/r/c/mediawiki/ruby/api/+/781063 [22:46:53] The "git-review version 2.2.0" I have installed still has -R. That looks to be the latest upstream version per https://docs.opendev.org/opendev/git-review/latest/releasenotes.html [22:47:21] rickmark: awesome. Thanks for the patch and working through the different environment. :) [22:47:36] oh god - its because homebrew is packaging 1.0.0 [22:47:43] i'm not from the future - i'm from the distant past [22:48:14] *grumble grumble* *clones brew* [22:49:08] nvm - its just a stub loader in brew [22:51:06] yeah - `gerritt-tools` was repalced with `brew install git-review` [22:51:42] i may make a comment in that page that if you're getting errors with `-R` you need to swtich [22:51:46] * bd808 sees that Chris McMahon is still in gerrit as an owner for mediawiki-ruby-api and ... wow [22:53:40] ctx? guessing that's the long long ago in the before times? [22:55:39] final Q - should i still create a phab ticket now that I have a gerritt review up? does discussion occur in gerritt or phab for things like changing client libs [22:58:07] rickmark: the patch is probably fine. I added the 2 most likely reviewers to it for you. [22:58:26] perhaps a phab ticket to update the default reviewers then? [22:58:40] ruby seems ... well unloved these days [22:58:47] The context on my Chris McMahon comment is that he moved on from Wikimedia 5-6 years ago [23:00:33] BTW - thanks a ton - i'm modernizing theiphonewiki.com and doing complex sync of the firmware keys to YAML (not that we don't love mediawiki - but prob not the best DB format) [23:00:33] rickmark: that library is functionally dead -- https://gerrit.wikimedia.org/r/q/status:merged+project:mediawiki/ruby/api -- 2 commits in 5 years or so. [23:00:45] i volenter as tribute? [23:00:56] https://github.com/rickmark/ [23:01:30] in essence the api was so dead it was locking dependencies to worrying levels for security .... [23:01:59] If you are interested in long term maintainership, that would be a useful thing to propose via a phabricator task. [23:02:03] i can also reach out to lfaraone to see if they would sponsor me as a maintainer here [23:02:19] (we worked together at DBX) [23:05:36] I wonder which of https://www.mediawiki.org/wiki/API:Client_code#Ruby more folks actually use? musikanimal what's your ruby action api client library of choice? [23:06:45] i'm a prude - and always from supply chain select the official clients [23:06:54] when I first created my bot there was only one decent client out there, and it became unmaintained so I forked it and am maintaining it at https://github.com/MusikAnimal/mediawiki-gateway . It kinda sucks though, only XML support for starters [23:07:25] i'd prob say unifying them might prove wise - perhaps pull in a better community gem as v2 [23:07:47] and inviting the team to join as official owners? [23:07:58] but that's above my pay grade [23:11:46] is it possible to start a experimental v2 (yes i'm calling v0 v1 in this case and v2 supersedes both versions) branch - phab task I'd guess? [23:12:35] yes - i'm forbidden from branch create [23:17:16] rickmark: so the thing is that ruby is no longer the QA automation language of choice and I'm pretty sure the only reason that library exists is that it used to be used by our QA folks. [23:17:45] i noted that gerritt didn't run spec... [23:18:27] oh for you change, I can make that happen. Tests are not run for new contributors by default (a weak vandalism protection) [23:18:41] we do the same at hack-different [23:20:04] ah perf - looks like it isn't happy in CI [23:20:29] .... i'm spoiled by overcommit - darn linting rules [23:21:18] ... in files i didn't even change! *laughs* [23:21:52] yeah... I think those are maybe jsut new rubocop checks since the last time this was touched [23:23:26] I think the only one that is legit your change is the long line error for line 32 in the gemspec