[13:54:15] Hi, I'm wondering why was I just notified about phab's monitoring task (T330655). I'm neither added as a subscriber, nor are in Cloud-VPS, and Observability-Alerting Tags. My LDAP account is the same as my nickname (Szczot3k). https://phabricator.wikimedia.org/T330655 [13:54:16] T330655: monitoring: Disk space check can fail to read fuse mounts - https://phabricator.wikimedia.org/T330655 [13:55:24] Nvm, Cloud-Services has been added, and then removed. [13:55:34] yeah, as a subscriber instead of a tag (accidentally) [13:56:00] Curiosity satisfied, I can now go to sleep for another year [13:56:48] sweet dreams [14:39:05] i typed out that whole exact question about the same task here earlier today, but deleted it without posting when i realized what had happened with Cloud-Services having been a subscriber 😅 [14:41:44] !log quarry enable search 00064ea160bb856513c2cdcf64f629e654b96dc2 T90509 [14:41:47] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Quarry/SAL [14:41:48] T90509: Search or filter queries by title or summary - https://phabricator.wikimedia.org/T90509 [14:45:55] I wonder if there’s even a legitimate use case for subscribing a project to a task [14:46:39] I think to me it would feel disrespectful if it was done intentionally: it should be up to each user whether they want to be a Member or a Watcher of a project [14:47:00] and subscribing the project effectively treats all the Members as Watchers (IIUC) [15:23:51] Lucas_WMDE: not really, AFAIU you will only get emails if you're in the "watchers" list for the project, not if you're on the "members" list. Or to phrase it differently, if you're a "watcher" of a project you automatically "watch" all tasks tagged with that project, but if you're a "member" of project, you don't. [15:24:31] yup, that’s how I understand it too [15:24:56] when you say "subscribing a project to a task", do you mean adding the project label to the task, or something different? [15:27:19] adding the project in the “subscribers” field, which Phabricator lets you do [15:27:28] and which was apparently done in T330655, before it was fixed in https://phabricator.wikimedia.org/T330655#8648601 [15:27:28] T330655: monitoring: Disk space check can fail to read fuse mounts - https://phabricator.wikimedia.org/T330655 [15:27:50] which led to all of the *members* of the project receiving emails [15:33:55] right! I didn't realize you could do it, and I agree I don't really see a legitimate use case [15:39:13] ok, then we’re on the same page ^^ [17:40:55] dhinus (and fyi szcot3k, @jhsoby) turns out there is a phab task for it (took me a while to find it ^^) T303829 [17:40:55] T303829: Disallow adding Project Tags in the Subscribers field - https://phabricator.wikimedia.org/T303829 [17:54:52] Tags as subscribers is to me yet another Phab workflow hole mostly caused by the original assumption that the product was only going to be used by folks with good intent (like inside a corporate firewall). [19:54:35] !log tools.lexeme-forms deployed 50aa1e2dc5 (l10n updates: hi, hno, pa, pnb, ur) [19:54:37] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.lexeme-forms/SAL [20:20:09] I'm trying to create a tool account for dyk-tools-admin, but https://toolsadmin.wikimedia.org/tools/create says "Tool name is already in use or invalid" [20:20:33] I'm pretty sure it's not in use, so why is it invalid? [20:24:08] it matches the title blacklist https://meta.wikimedia.org/wiki/Title_blacklist [20:24:15] specifically `.*AD+MI+N.*` [20:24:28] (the check that striker aka toolsadmin performs is https://meta.wikimedia.org/w/api.php?action=query&format=json&list=users&formatversion=2&usprop=cancreate&ususers=dyk-tools-admin) [20:24:37] roy649: potential developer account and tool names are checked against the global title blacklist, so I suspect that one is getting flagged due to the 'admin' bit in it. added it to https://wikitech.wikimedia.org/w/index.php?title=MediaWiki%3ATitlewhitelist&diff=prev&oldid=2056902&diffmode=source, so it should work now [20:25:05] tbh I don’t think disallowing a tool with “tools*admin” in the name is unreasonable [20:25:15] but ok sure ^^ [20:25:27] yup, I'm getting green now, thanks. [20:25:55] This is a second account for dyk-tools, specifically for it to run bot tasks that need admin rights. [20:26:11] naming it dyk-tools-admin makes sense to me. [20:27:15] fair point, but I saw the discussion on enwiki and the use case makes sense plus dyk-tools is an existing project by a relatively trusted person so I think one is fine [20:27:45] glad to know I'm relatively trusted :-) [20:31:42] and by that I mean "you're probably not going to go and set up a phishing website on that tool" [20:32:59] I run my phishing sites on AWS.