[10:59:03] !log tools.wd-image-positions deployed 81999c31af (Python 3.11) [10:59:05] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.wd-image-positions/SAL [11:13:01] I just noticed that the startupProbe I patched into the lexeme-forms deployment is gone [11:13:07] guess that explains why the restarts felt so much faster recently :S [11:13:42] oh well, in that case I might as well recreate the deployment for 3.11 instead of just editing the image in it [11:16:01] creationTimestamp is 2022-10-10 so probably due to one of the changes in https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/SAL#2022-10-10 I guess (dunno which one) [11:30:34] !log tools.lexeme-forms deployed 02f72f81a2 (Python 3.11) [11:30:37] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.lexeme-forms/SAL [11:31:29] @lucaswerkmeister: how have you been restarting it? a `webservice restart` replaces the deployment to the canonical form [11:31:31] !log tools.lexeme-forms kubectl patch deployment lexeme-forms --patch-file patch-add-startup-probe.yml [11:31:33] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.lexeme-forms/SAL [11:32:09] I used to do `kubectl rollout restart deployment lexeme-forms` but switched back to `webservice restart` when that change for better restarts was deployed [11:32:32] but yeah, I guess I need to keep using the kubectl command if I want the probe to stay intact? [11:32:36] I didn’t consider that [11:32:56] (at least until `webservice` gains support for probes) [11:33:49] you should send patches to make it a native feature :P [11:33:58] let me just try a webservice restart again [11:34:18] yeah you’re right, it wiped the probe again [11:34:26] /me patches it back in [11:34:38] taavi: idk what that would look like ^^ [11:34:44] I guess a phab task would be a good start [11:35:03] and there we can figure out how to represent it in… service.template is probably the right place? [11:45:30] created https://phabricator.wikimedia.org/T341919 [11:45:59] I feel like we already had a task for that .. T314053 maybe? [11:46:00] T314053: Allow automatically restarting tool web services if non OK error code - https://phabricator.wikimedia.org/T314053 [11:46:31] definitely some overlap yeah [12:02:58] !log tools.lexeme-forms pip-sync (i.e., actually install dependencies in the new venv, which I completely forgot to do earlier) [12:03:01] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.lexeme-forms/SAL [13:15:30] !log tools.speedpatrolling deployed 8403f51fb5 (Python 3.11) [13:15:32] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.speedpatrolling/SAL [13:28:51] !log tools.quickcategories deployed 7fd188d540 (Python 3.11) [13:28:53] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.quickcategories/SAL [13:37:11] !log tools.quickcategories deployed a937a30991 (cleanup typings and update github actions) [13:37:13] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.quickcategories/SAL [15:26:24] !log tools.pagepile-visual-filter deployed dfe5850ab6 (Python 3.11) [15:26:27] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.pagepile-visual-filter/SAL [15:36:53] !log tools.ranker deployed 1de5a9e1f1 (Python 3.11) [15:36:55] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.ranker/SAL [15:41:22] !log tools.ranker deployed 0e3bf213e8 (cleanup typings and update github actions) [15:41:23] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.ranker/SAL [15:46:07] !log tools.translate-link deployed 5dcc4f86ae (Python 3.11) [15:46:10] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.translate-link/SAL [15:48:18] !log tools.translate-link pulled 3e60ebef8c (update github actions, no webservice restart needed) [15:48:19] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.translate-link/SAL [15:50:01] !log tools.pagepile-visual-filter pulled 446faeaf5e (update github actions, no webservice restart needed) [15:50:02] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.pagepile-visual-filter/SAL