[02:28:43] bd808, our favorite bot went down again last night, is there any way to read its python script?..wonder if its kubernates related or the script.. [02:37:57] stemoc: I'm poking around a bit in ~tools.yifeibot. It looks like the "flr" job that you are interested in is a script written by Bryan Tong Minh many, many years ago. [02:38:58] https://commons.wikimedia.org/wiki/User:FlickreviewR_2/flickreviewr.py this is the one i see, not updated since 2017 so wondering if a recent change to wikimedia broke something [02:40:10] stemoc: the running code seems to be https://yifeibot.toolforge.org/gitweb/?p=botscripts.git;a=blob;f=o/toolserver/bryan/flickr/bots/flickreviewr.py;h=6efc48842e85b2534cbf23d855c957b9359f1df5;hb=refs/heads/master [02:40:50] * bd808 needs to double check for uncommited changes... [02:42:12] there are other dirty files in the working dir, but flickreviewr.py seems to be committed. [02:44:53] do u know what file it was reviewing then halted? [02:45:41] The last line in flr.out is `[2024-03-12 08:52:45] * [[:File:St Mary's Rowing Club (53305757743).jpg]] passed cc-by-2.0` [02:46:12] originally felt like had something to do with a public domain licence template..as it was doing that when it went down the first 2 times but this time it was the normal cc-2.0 one [02:48:16] it passed that so was onto the next one and didn't review it, i reviewed the ones it was suppose to after that (following the names of the file) hoping it would skip it and do the others.. didn't work.. [02:48:59] things in this tool's $HOME are very "bespoke". The run loop for that bot is https://phabricator.wikimedia.org/P58775. [02:52:32] The actual entrypoint is written such that that run loop script crashing won't halt the container. That should be fixable to make this thing restart itself when the python crashes. [02:55:35] hmmm... actually it looks like maybe the python is still running inside the container. [02:55:43] ooh might be a good idea, if its file related, maybe someone can find a way for it to skip the ones it can't do, and log it so licence reviewers can do it manually [02:59:59] the python here was carefully constructed by someone who didn't think that normal python modules and packages were fun enough [03:00:47] there is a lot of confusing PYTHONPATH manipulation to load things [03:03:32] lol [03:06:43] !log bd808@tools-sgebastion-11 tools.yifeibot 'kubectl delete pod flr-6d74b958d9-pc6p9' after reports of FlickreviewR 2 not working on IRC [03:06:46] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.yifeibot/SAL [03:07:55] stemoc: I restarted the script with that ^^. I'm going to mostly just repeat that someone needs to get zhuyifei1999_ to make them a co-maintainer or hard fork the bot. [03:09:40] * bd808 keeps sort of hoping that the irc pings will summon YiFei [03:12:39] idle 520:01:18, signon: Wed Nov 22 00:01:47 [03:12:46] probably not :( [03:17:04] around the week the bot first halted, we had a major issue with UploadWizard/Flickr extension too, thats why i thot it might be flickr api related [03:22:28] Just wanted to be here to celebrate grid engine going away 🙂 [03:24:01] hahaha, immediately got a thumbs down on telegram. Both very surprising and very unsurprising at the same time 😄 [03:24:44] I mean I wouldn't call it a celebration :( (re @yuvipanda: hahaha, immediately got a thumbs down on telegram. Both very surprising and very unsurprising at the same time 😄) [03:26:49] I'm still trying to find time to move phetools (hopefully I'll get some time tmrw) [03:28:02] If y'all have any idea for a quick and dirty graphing library that would help :) [03:28:22] JS graphing library [03:29:54] grid will have its revenge, AI will replace you guys one day :P [03:32:03] The soul of the grid lives on :p [03:51:09] @yuvipanda: I'm here to celebrate with you. I understand why some folks are not happy about the change, but I know the pain grid engine put you and so many other SREs thorough. [03:52:10] Unmaintained code designed in and for a prior decade is not fun to keep running. [04:04:35] I mean sure, one part of my brain is really happy that we are moving to kubernetes, but I am absolutely not happy about how this deprecation timeline went for peeps who develop and maintain bots and tools :( [04:05:50] @rook fwiw, I spent a bunch of time looking at superset to see if it coul do what I wanted it to do before I built Quarry back in the day. It felt like a fundamentally different tool and a little far away from the wiki ethos for me (particularly about keeping results around). And I wasn't happy with the tech either - it just felt like it was targeted at a 'company has business a [04:05:50] nalysts who need help' rather than a more communal experience. I gave a talk about how Quarry (and PAWS) were designed with 'wikimedia principles' back when I still was part of the SRE team (https://docs.google.com/presentation/d/1KWzhtDk4LnpwT-FCSYSMa4moOWcx9OZ2RF9i_REQOfI/edit#slide=id.g184517c16e_0_501, https://www.youtube.com/watch?v=rEyqVXzCJJc). Happy to see it's still love [04:05:51] d 🙂 [04:07:08] lol, apparently I'm the one who authored that phab ticket! I have no memory of that either [04:07:48] fwiw I really wanted to put the results dbs in object storage instead of NFS but at that time there wasn't any object storage for me to use in labs (now cloud). [04:09:35] ooooh, you're the person who has been maintaining quarry recently! THANK YOU, rook 🙂 [04:11:15] * Krinkle continues to use Quarry regularly. [04:13:18] 😄 I'm so glad to see these projects have outlived my time here [04:13:30] (also hi Krinkle) [04:20:49] also coming back because I'm demo'ing PAWS at a JupyterHub talk I'm giving at NERSC (https://www.nersc.gov/) tomorrow, and am grateful for whoever is keeping it still running. [04:48:29] @sohom_datta: I'm sorry you feel that way. October 2022-Now felt like a reasonably long migration period, but I also know that a number of tools where not really movable until 3-4 months ago. [05:36:36] i definitely remember thinking 'oh yeah, i am sure i can help decom gridengine by 2017! 2018 tops!' [05:39:09] *bounces head off wall* [05:40:15] Why does it seem so hard to make a bot now compared to a year ago [05:40:36] I made a website that helps answer that question https://werecomputersamistake.com/ [05:41:19] hah wm-bb [05:44:40] I was also going to help build better bot functionality into PAWS, so that would be a good way for many bots to run. alas, instead i just ran away [05:45:10] 'ran away' is probably a little harsher on myself than I need to be. [06:04:15] If i wanted to just run a test with no changes using a shared script, what would be the command? [06:07:25] ok so I got disconnected for some reason [06:30:27] Anyone around to help me for a few minutes please on pywikibot? Please dm me [06:36:37] I feel like I missed something [08:40:01] Is there an easy way to create a web proxy that restricts incoming traffic to a Cloud VPS server from mwmaint/stat production IPs only? [08:53:23] !log lucaswerkmeister@tools-sgebastion-10 tools.bridgebot Double IRC messages to other bridges [08:53:26] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.bridgebot/SAL [09:26:26] kostajh: depends on your definition of "easy", but probably not. the proxy service by default does not forward XFF data, so your proxy needs to be added to the allowlist for that. then there's the issue of how to restrict to specific wikiprod machines only, as both mwmaints and stats don't have public IPs and so need to use the outgoing wikiprod [09:26:26] web proxy (and all traffic via that is seen as a single IP from the Cloud VPS POV) [09:28:22] Got it. Ok, thanks taavi [09:29:55] so my general recommendation would be to restrict to all wikiprod networks + use a strong authentication to further restrict it to the specific clients that need access [11:23:11] !log taavi@tools-sgebastion-11 tools.wikibugs toolforge jobs restart irc [11:23:15] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.wikibugs/SAL [12:10:42] !log tools.grid-webservices kubectl sudo delete clusterrolebinding grid-webservices-obs # T359934 [12:10:46] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.grid-webservices/SAL [12:10:46] T359934: [infra] Archive grid engine related infrastructure tools - https://phabricator.wikimedia.org/T359934 [12:14:52] !log metricsinfra MariaDB [prometheusconfig]> delete from alerts where name = 'GridQueueProblem'; # T314664 [12:14:55] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Metricsinfra/SAL [12:14:55] T314664: [infra] Decommission the Grid Engine infrastructure - https://phabricator.wikimedia.org/T314664 [12:40:15] !log taavi@tools-sgebastion-11 tools.wikibugs toolforge jobs restart irc [12:40:18] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.wikibugs/SAL [14:13:25] bd808_: is wikibugs intentionally sometimes coloring the task title and URL gray? [14:41:07] Hi, could somebody help me with https://paste.toolforge.org/view/c14aa964? I'm trying to execute a single python program and it keeps telling me "ModuleNotFoundError: No module named 'importlib_metadata'". How can I fix it? Do I have to install this module? [14:44:19] @Pau: you're seeing that error because Pywikibot no longer supports the Python version running on the toolforge grid engine and the bastion (login) hosts. you need to migrate it to run on the toolforge jobs framework. https://wikitech.wikimedia.org/wiki/Help:Toolforge/Running_Pywikibot_scripts_(advanced) is a tutorial on how to do that [14:45:43] I already have followed that tutorial. I suppose I've done something wrong [14:46:42] you are trying to run the script directly on the bastion host, and not via the jobs framework [14:47:15] ok [14:47:41] but if I use toolforge jobs, it neither works [14:48:31] could you be more specific on how does it not work when using `toolforge jobs`? [14:50:43] I tried "toolforge jobs run sensecat-$(date +%d-%m-%Y-%H-%M) --command "$HOME/pwbvenv/bin/python3 $HOME/sensecat.py" --image python3.11" [14:50:54] but now it seems to work [14:51:07] I'm sorry [14:51:44] well then, I have another question [14:51:53] you're welcome, great to hear it's working. [14:52:03] :) [14:52:25] how can I execute an ordre like "sh robot.sh" in toolforge jobs? [14:52:55] by setting --command to that [14:53:18] toolforge jobs run robot-$(date +%d-%m-%Y-%H-%M) --command "sh robot.sh" --image python3.11 [14:58:24] it seems the commans inside robot.sh is not correct, the server cannot find pywikibot: https://paste.toolforge.org/view/5c35f8ca [15:00:42] Pau: what's in robot.sh? [15:02:45] The contents of robot.sh: https://paste.toolforge.org/view/f70489c4 [15:03:38] Maybe I have the wrong path to pywikibot ... [15:03:46] !log lucaswerkmeister@tools-sgebastion-10 tools.wikibugs toolforge jobs restart irc [15:03:49] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.wikibugs/SAL [15:04:02] taavi: yes, I implemented T140881 yesterday. [15:04:03] T140881: Print events in closed tasks in grey - https://phabricator.wikimedia.org/T140881 [15:04:05] !log taavi@tools-sgebastion-11 tools.wikibugs toolforge jobs restart gerrit [15:04:07] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.wikibugs/SAL [15:09:30] Pau: you can try adding `export PYTHONPATH=$PYTHONPATH:/data/project/shared/pywikibot/stable` before running the pywikibot script inside `robot.sh` [15:10:00] but I'm not sure it will work [15:10:06] how did you run that script before? [15:12:13] with cron [15:15:36] with the new python path, it went to toolforge but it failed: https://paste.toolforge.org/view/358f2162 [15:17:34] another option would be to do something like that, bypassing the sh file: toolforge jobs run robot-general-$(date +%d-%m-%Y-%H-%M) --image tool-pywikibot/pywikibot-scripts-stable:latest --command "pwb -family:wikipedia -lang:ca replace -regex "\n *\n" "\n\n" -ns:0 -recentchanges:0,2880 -always -summary:"neteja i estandardització de codi"" [15:18:37] yep, that should work for sure [15:19:23] but it does not understand the mix of " [15:20:14] change the inner " with single ' [15:20:18] the mix of quotation marks, I mean [15:20:29] like "pwd...'something' ..." [15:22:56] for long/complex/weird --commands, maybe wrap that in a simple `script.sh` that you can call from the job, to simplify all the shell character escaping game [15:23:06] it seems to work [15:23:45] arturo, I'm having trouble precisely because of the script.sh file [15:24:33] oh, sorry for the drive-by comment :-( [15:24:38] Contents of robot.sh: https://paste.toolforge.org/view/f70489c4 [15:25:12] It would be better for me to get that sh file working, because I think it will be easier to handle [15:26:02] Do you know what I have done wrong? the python path? [15:28:03] I think the last paste https://paste.toolforge.org/view/f70489c4 contains something to improve in the script, because it calls python3 directly instead of loading the venv first, but I could be wrong [15:28:05] Pau: you can use `pwd -family:...` in the script file instead of using directly the python file [15:28:36] that should load the environment properly (no need to change PYTHONPATH for example) [15:29:23] Isn't /data/project/shared/pywikibot pretty much deprecated at this point? That's why taavi built the new shared iamge documented at https://wikitech.wikimedia.org/wiki/Help:Toolforge/Running_Pywikibot_scripts [15:30:10] I don't understand: do I have to substitute "python3 /data/project/shared/pywikibot/stable/scripts/replace.py" for something beginning for pwd -family: ? [15:31:12] I use family: etc in the toolforge command [15:31:41] Do I have to change the beginning of robot.sh [15:31:52] ? [15:35:25] bd808_: kinda yes, but some people still use it from python* images [15:35:59] What do I have to change, exactly? [15:36:20] dcaro: sure, but trying whack-a-mole debugging for the old process seems to be less useful that converting to the more supported solution [15:36:22] Pau: so in the script, instead of the `python3 ...`, you can add the same line you used before when using the pywikibot directly `pwb -family:wikipedia -lang:ca replace -regex "\n *\n" "\n\n" -ns:0 -recentchanges:0,2880 -always -summary:"neteja i estandardització de codi"`, and as it's inside the script, your quoting does not need to be so tricky [15:36:41] bd808: that's what we are trying to do :), to run the script with the pywikibot image, instead of the python one [15:37:08] Pau: keep also the `--image tool-pywikibot/pywikibot-scripts-stable:latest` argument to `toolforge jobs run` [15:37:13] on the grid no venv was needed. in a plain pythong container a venv is very much needed [15:37:26] instead of the python3.11 [15:38:09] * bd808 got confused by the backscroll apparently [15:38:18] Pau: so the job run command would be `toolforge jobs run robot-$(date +%d-%m-%Y-%H-%M) --command "sh robot.sh" --image "tool-pywikibot/pywikibot-scripts-stable:latest"` [15:44:05] robot.sh -> #!/usr/bin/env bash [15:44:05] pwb -family:wikipedia -lang:ca replace -regex [changes] -ns:0 -recentchanges:0,2880 -always -summary:"neteja i estandardització de codi and -> toolforge jobs run robot-general-$(date +%d-%m-%Y-%H-%M) --image tool-pywikibot/pywikibot-scripts-stable:latest --command "sh robot.sh" and it still fails [15:44:18] is everything how it is supposed to be? [15:44:41] Pau: looks like it to me, what's the error? [15:44:59] Job name: Job type: Status: [15:44:59] ------------------------------ ------------------ ---------------------------------------- [15:45:00] robot-general-13-03-2024-15-41 one-off Failed [15:46:06] there is no .err file [15:47:30] oh, can you add `--filelog --mount=all` to the `toolforge job run` command? [15:50:18] there is an .err file now with: sh: 0: cannot open robot.sh: No such file [15:51:33] aaaahhh, I see, try `--command='sh $TOOL_DATA_DIR/robot.sh'` [15:54:45] TOOL_DATA_DIR is only that or do I have to change it for the path to my bot? [15:57:26] just use that, it will get evaluated by the system [15:57:30] @Pau: The directory that you know as $HOME on the bastion becomes $TOOL_DATA_DIR inside of the running container. [15:57:40] ok [15:58:08] this path mapping is a quirk of the buildpack based images [16:00:32] Now the .err file is very verbose: https://paste.toolforge.org/view/6b28eb95 [16:02:38] that feels way more like a pywikibot specific problem [16:03:22] How can I solve it? [16:03:48] I'm not familiar with the pywikbot framework. I assume this was working before, in the grid? [16:04:10] yes [16:04:22] 'eval: line 1: syntax error near unexpected token' sounds like a syntax error in the shell script file [16:05:04] is it related to a common install or its my pywikibot? [16:06:29] Pau: let me give it a try as your tool, rebot was the tool? [16:07:09] yes [16:07:44] Pau: I think you are missing the envvars: https://wikitech.wikimedia.org/wiki/Help:Toolforge/Running_Pywikibot_scripts#Setup [16:07:53] for authentication [16:08:04] !log bd808@tools-sgebastion-11 tools.wikibugs Restared gerrit task to pick up 82caa471 fix for T360038 [16:08:09] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.wikibugs/SAL [16:08:42] Oh ffs [16:08:45] though might not be all, looking [16:09:45] I'm sorry, i would not have followed the tutorials properly [16:13:59] I'm registering my tool at https://meta.wikimedia.org/wiki/Special:OAuthConsumerRegistration/propose/oauth1a [16:18:31] !log bd808@tools-sgebastion-11 tools.wikibugs Restared gerrit task to pick up fa4fbd54 fix for T360038 [16:18:35] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.wikibugs/SAL [16:21:13] !log bd808@tools-sgebastion-11 tools.wikibugs Changed branch protections on https://gitlab.wikimedia.org/toolforge-repos/wikibugs2 to disallow push to main by all. fa4fbd54 was accidentally pushed to main rather than a feature branch. [16:21:16] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.wikibugs/SAL [16:23:36] done it [16:24:19] The tutorial says "You are now ready to run Pywikibot scripts on Toolforge.", but I was already ready before this setup ... [16:25:59] it seems the job also crashed [16:28:10] the .err file is the same as before [16:29:26] If I wanted to run a test without changing pages, what is the command? I can’t find it on the docs. There used to be a doc that walked you step by step through this but it disappeared. [16:32:30] PotsdamLamb: could you be more specific on what you're trying to do? [16:34:49] Pau: it seems you are using the wrong user? `pywikibot.exceptions.NoUsernameError: Logged in on wikipedia:ca via OAuth as Paucabot, but expect as Rebot` [16:35:07] if I may, I understand that he is asking for something like "pywibot --test" [16:35:18] dcaro, yes, it could be [16:36:11] does it mean I have done the oauth using my username? [16:36:40] maybe [16:37:22] I don't know how to logout of my username and login with the bot username [16:37:42] Pau I think that the regex you are using is getting messed up, and the script might not be running what you think it is running [16:38:02] can you try a simpler regex for a start and see if the authentication works? [16:38:30] it has 16k characters now xd [16:38:33] https://www.irccloud.com/pastebin/WQplAJCC/ [16:39:59] and the username error? is it not important? [16:41:07] it might, but I think it might be comming from the command getting mangled (due to the regex, the first errors in the error log are because of the regex I think) [16:41:36] it's a multiple replace bot, It worked perfectly until kubernetes arrived ;) [16:41:50] that's ok, I think that the issue might be the quoting [16:42:01] all the 16k are correct [16:44:37] for example, on the error log, there's the line `./pwb.sh: line 1: 1] group=>: No such file or directory` [16:45:13] that is referencing the string inside the regex `group=\"\">"` but it seems it lost the escaped quotes completely [16:45:54] so there's something going on there, that's why I want to go bit by bit, start with the authentication, once we know that works, start adding complexity [16:47:24] ok [16:47:54] how do i fix "`pywikibot.exceptions.NoUsernameError: Logged in on wikipedia:ca via OAuth as Paucabot, but expect as Rebot`"? [16:50:22] Pau is that still hapenning after trimming the regex? [16:54:55] I have not done it. I'll try now [16:55:02] Pau: when I try to run `toolforge jobs run test --image tool-pywikibot/pywikibot-scripts-stable:latest --command='pwb -family:wikipedia -lang:ca listpages -cat:Bots'` I get the error [16:55:08] 2024-03-13T16:53:28+00:00 [test-4mqqr] CRITICAL: Exiting due to uncaught exception NoUsernameError: Failed OAuth authentication for wikipedia:ca: The authorization headers in your request are not valid: No approved grant was found for that authorization token. [16:55:28] maybe your request has not been approved yet? [16:56:20] @taavi: basically I want to test a built in script through python3 and get a list of pages that it would change had I actually ran it. [16:57:11] Via pywikibot [16:58:26] pwb -family:wikipedia -lang:ca replace -regex "== (Geografía|Geography) ==" "== Geografia ==" -ns:0 -recentchanges:0,2880 -always -summary:"neteja i estandardització de codi" also fails [16:59:18] Pau: same error? [16:59:47] i cancelled the oauth because it was for the wrong user (paucabot) but now I cannot get it for the right one (rebot) [17:04:06] family and mylang are not set. [17:04:08] Defaulting to family='wikipedia' and mylang='test'. [17:04:09] WARNING: API error mwoauth-invalid-authorization: The authorization headers in your request are not valid: No approved grant was found for that authorization token. [17:04:19] and more errors [17:07:31] Pau: I think that the first message (family and mylang are not set.. defaulting to ...) is not right [17:07:43] I can see wikitech stuff with this tool, and it also shows that message [17:07:49] https://www.irccloud.com/pastebin/jrXljKSi/ [17:08:22] double checked and those are listed in the wikitech bots category: https://wikitech.wikimedia.org/wiki/Category:Bots [17:09:52] I am getting the correct oauth for my bot [17:11:50] done [17:12:03] I'll try to run the bot one more time [17:12:32] Pau: now it seemed to work for me listing the categories (it was empty though) [17:13:32] Was the job "test" yours? [17:14:17] yep, that's me :) [17:15:14] yay! [17:15:20] https://www.irccloud.com/pastebin/NHxE8y4A/ [17:15:26] I think my job "robot general etc" it's working now [17:15:47] 🎉 [17:16:00] 😃 [17:16:05] Pau: does the robot.sh work also? [17:16:16] I'll try now the big one [17:16:25] 🤞 [17:21:20] It's not doing any edit: https://ca.wikipedia.org/wiki/Especial:Contribucions/Rebot [17:21:31] and it should [17:22:50] err file: family and mylang are not set. [17:22:51] Defaulting to family='wikipedia' and mylang='test'. [17:23:00] where do I change that [17:23:16] ? [17:23:34] It's running in test mode, I presume [17:23:36] I think that message is wrong, as in it's not a problem [17:24:02] (not 100 percent sure though, but it does not match what I see) [17:24:23] I see this edit: 18:19, 13 març 2024 dif. hist. +937.584‎ m Ercros ‎ neteja i estandardització de codi darrera [17:24:31] it has done one big change: https://ca.wikipedia.org/w/index.php?title=Ercros&diff=prev&oldid=33251775 [17:25:13] it's over 900k! (sorry) [17:25:26] I'll kill the job [17:25:58] so it does stuff, so it can authenticate, though it seems it's not doing what it should, is that correct? [17:27:00] yes [17:27:14] hmm... is that the one with the big regex? [17:27:21] yes [17:27:39] I'll try with another sh [17:27:53] hmmm... I think that something in the way the pwb script runs is messing up with your regex [17:28:04] (the quoting thing) [17:29:09] ok [17:29:24] now I have to go [17:30:06] I'll continue trying and I'll come to bother you again ;) [17:30:56] Pau: I might not be around, if there's nobody, don't hesitate to open a task so we can follow up tomorrow [17:31:28] ok, thanks for your kindness [17:33:59] thanks for your contributions! :) [17:35:02] 👍 [19:21:07] !log tools shutting down old puppet infra: tools-puppetmaster-02 and tools-puppetdb-1. These can be deleted in a week or two presuming everything remains stable. [19:21:11] Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/SAL [21:03:27] Something weird is going on with setting up python venvs... [21:03:32] I ran "toolforge jobs run bootstrap-venv --command "cd $PWD && ./bootstrap_venv.sh" --image python3.11 --wait" [21:03:42] but when i activate the venv I get Python 3.7 [21:03:43] wtf [21:04:03] I try to run pip in the venv and I get "ModuleNotFoundError: No module named 'pip'" [21:05:18] this is running from tools-sgebastion-10 if it helps [21:05:39] which tool? how are you setting up the venv? [21:07:02] g13bot, and using the command above, which references the `bootstrap_venv.sh` file in the tool root [21:07:43] this tool stopped working a few days ago with weird `ModuleNotFoundError: No module named 'packaging'` errors too [21:07:55] I thought the venv had gotten corrupted so thought I'd recreate it (despite nothing changing) [21:08:21] do you have a leftover PYTHONPATH from the old shared pywikibot setup in your .bash_profile by any chance? [21:08:41] ooooh interesting - let's see [21:09:11] lol yes [21:09:18] regenerating the venv now without that [21:09:38] just removing that and then logging out and back in should do it I think [21:09:59] meh I've kicked the process off now so it'll prob be in an inconsistent state if I interrupt :) [21:10:25] thx taavi [21:19:08] taavi - weirdly despite deleting that file and regenerating I'm getting the same thing [21:19:15] can you take a look and see if I'm doing something stupid? [21:21:14] firefly_wp: how exactly are you creating the venv? [21:23:11] toolforge jobs run bootstrap-venv --command "cd $PWD && ./bootstrap_venv.sh" --image python3.11 --wait [21:23:25] I assume you want the contents of the script as well? :) [21:23:35] I can see that :-) [21:23:39] cool cool [21:29:44] ok, so the venv itself sees fine to me, and in a python3.11 container I can import packages from it. where do you see it failing? [21:33:02] huh [21:37:09] okay so I just ran `toolforge jobs run g13nudgetest --command ./g13_nudge.sh --image python3.11` as a test [21:37:28] if you check the error logs for that job you'll see the weird "cant find packaging" module import errors [21:37:33] taavi & [21:37:36] * ^ [21:38:21] `g13_nudge.sh` has that same PYTHONPATH line at the top of it that you probably want to remove [21:40:09] ._. [21:40:12] goddammit [22:16:46] I feel like we will hear "did you check for an old PYTHONPATH" followed by "doh!" or "damn" for a while around here :) [22:19:38] lol [22:19:40] indeed [22:19:57] yes - the last pywikibot relase introduced new dependencies so using the shared files with a pre-9.0 version installed will cause errors