[00:28:36] oooof [00:28:44] https://wm-bot.wmcloud.org/logs/%23wikimedia-dev/20220717.txt [00:30:11] (03PS11) 10Dreamy Jazz: T311375: Show results in paginator instead of truncation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) [00:31:01] (03PS5) 10Dreamy Jazz: Move the function to log a check into a new CheckUserLogService [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814297 (https://phabricator.wikimedia.org/T247789) [00:31:15] 10MediaWiki-Parser: Template-equals-category is still populating Category:Pages which use = as a template despite {{=}} now being a magic word - https://phabricator.wikimedia.org/T313169 (10Legoktm) 05Open→03Invalid [00:31:24] 10MediaWiki-Installer, 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), and 2 others: {{=}} should be a parser function - https://phabricator.wikimedia.org/T91154 (10Legoktm) [00:32:42] (03PS6) 10Dreamy Jazz: Move the function to log a check into a new CheckUserLogService [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814297 (https://phabricator.wikimedia.org/T247789) [00:32:59] (03PS20) 10Dreamy Jazz: Add filters that allow only searching for users or IPs [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/807217 (https://phabricator.wikimedia.org/T121190) [00:33:10] (03PS13) 10Dreamy Jazz: Add filter for established users for Get edits and Get users [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/808262 (https://phabricator.wikimedia.org/T26232) [00:36:45] legoktm: Do you happen to know when and why logging had been turned off for this channel? [00:37:00] probably got lost in the freenode->libera migration [00:37:37] my fault probably, it was just a chaotic time :( [00:38:45] maybe someone has ZNC logs we can retroactively publish [00:43:19] unless the channel topic said so, probably not. https://libera.chat/policies/#public-logging [00:43:34] probably not everyone reads https://meta.wikimedia.org/wiki/IRC/Channels [00:43:45] 10MediaWiki-General, 10wikimedia-irc-libera: Publish lost logs of #wikimedia-dev IRC channel - https://phabricator.wikimedia.org/T313175 (10Legoktm) [00:43:57] cc'd you on ^ [00:45:35] and poked a Libera staffer for their thoughts [00:52:41] legoktm: I have some questions about IRC. First, do I understand correctly that (ignoring the bot noise) this channel is a lot quieter than it used to be because most WMF devs moved to Slack? [00:53:43] I think first a bunch of developers moved to "team" channels and then yeah, Slack :( [00:54:00] it's pretty frustrating when it's being encouraged by upper WMF management, I'm not exactly sure what to do to reverse the trend [00:54:39] what made upper WMF management encourage this? [00:55:12] t.gr has/had been doing some work on getting Matrix set up as a more usable replacement for IRC but it's obviously slow going [00:56:46] zabe: in 2013 Slack was explicitly rejected for WMF use, but sometime 14 -16 someone created a WMF Slack and then at some point management said everyone had to be on Slack and then if everyone is required to be there, it's easier to reach people that way than IRC, where not everyone has bouncers (even though WMF paid for IRCCloud for everyone) [00:58:00] (fyi, I have to leave for dinner in like ~5min) [00:59:31] bon appétit [01:09:40] and the channels get overrun with both noise, then every 24 months or so there is "lets reduce the bot noise so people the channels again" cycle, then the bots increase again [01:10:21] I take "I'm not exactly sure what to do to reverse the trend" back, my solution is to get on the board lol [01:11:01] Not that the board should say that WMF can't use slack, but rather ask for an evaluation of all non-free software use in accordance with the guiding principles [01:11:13] it is atrocious and I'm surprised there hasn't been a bigger outcry [01:15:09] 10MediaWiki-Page-editing, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10Chinese-Sites: Support highlighting for language conversion tags -{}- - https://phabricator.wikimedia.org/T281024 (10Stang) [01:16:00] 10MediaWiki-Language-converter, 10SyntaxHighlight, 10Chinese-Sites, 10I18n, 10Patch-For-Review: Auto-conversion between zh-hans & zh-hant in elements - https://phabricator.wikimedia.org/T34943 (10Stang) [01:17:34] especially when you see how many techies complain its resource usage on end user devices [01:17:58] that's the least offensive thing about it [01:23:27] https://meta.wikimedia.org/w/index.php?title=FLOSS-Exchange&type=revision&diff=17519218&oldid=17519209 [01:23:27] ori: if you want horrid systems, teams is my PABX at work [01:23:35] So around 2016-17 I guess [01:24:50] legoktm: what's the last date for which we have logs? https://wm-bot.wmcloud.org/logs/%23wikimedia-dev/ doesn't have any apart from the one you just started [01:25:41] https://bots.wmflabs.org/logs/%23wikimedia-dev/ are the freenode logs [01:26:33] https://wm-bot.wmflabs.org/logs/%23wikimedia-dev/ [01:26:42] lego was faster [01:27:30] it's a pitty we just didn't merge the logs together or put them on the new system and just rename the file names to freenode, so they were in one spot [01:27:57] 04(no projects): "Your Impact" numbers on Special:Homepage in Wikipedia - https://phabricator.wikimedia.org/T313176 (10InfiniteSword) [01:32:12] 10MediaWiki-Page-editing, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10Chinese-Sites: Support highlighting for language conversion tags -{}- - https://phabricator.wikimedia.org/T281024 (10Func) 05duplicate→03Open @Stang This task is about CodeMirror, for page editing. [01:33:24] "MediaWiki - the open source wiki software which runs all Wikimedia projects. We also use it internally for the office staff, and for coordination with chapter organizations in multiple countries." .> [01:47:46] 10MediaWiki-Page-editing: Can't save page when receiving "There is currently no text in this page" error, inifinite edit conflicts - https://phabricator.wikimedia.org/T313152 (10Novem_Linguae) Reinstalling the SQL database without changing any files fixed it. So likely SQL database related. [01:54:10] 10MediaWiki-General, 10wikimedia-irc-libera: Publish lost logs of #wikimedia-dev IRC channel - https://phabricator.wikimedia.org/T313175 (10ori) @Legoktm I put my more-or-less complete logs from znc/weechat at `people.eqiad.wmnet:~ori/wikimedia-dev_20210520_to_20220717.log.gz`. If you figure out that they are... [02:05:06] (03PS3) 10Universal Omega: Replace usage of 'Blacklisted' with 'Disabled' [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/814325 (https://phabricator.wikimedia.org/T313170) [02:38:04] (03CR) 10CI reject: [V: 04-1] fetchLexers: Pass '--json' to Pygmentize [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/814347 (owner: 10Ori) [02:42:27] (03PS2) 10Ori: fetchLexers: Pass '--json' to Pygmentize [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/814347 [03:46:47] 10AbuseFilter: AbuseFilter API "aflprop=details" should allow querying finer grained variables - https://phabricator.wikimedia.org/T313163 (100xDeadbeef) So for the software that analyzes past hits, I only needed [[ https://github.com/fee1-dead/wiki/blob/8d1f0887aa3fd8939b4c5d809d8334eafc4d9fb1/mwget/src/abuse_l... [04:19:32] 10MediaWiki-extensions-Scribunto: Lua error: Not enough memory due to several templates in pages - https://phabricator.wikimedia.org/T308796 (10Amitie_10g) **Some updates:** I've edited the module [[ https://es.wikipedia.org/wiki/Módulo:Lanzamientovj | Lanzamientovj ]] for optimisations and proper import from W... [04:45:07] (03PS55) 10Cmelo: Add the ability to load more participants on scroll [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/809008 (https://phabricator.wikimedia.org/T308576) [04:48:31] (03CR) 10CI reject: [V: 04-1] Add the ability to load more participants on scroll [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/809008 (https://phabricator.wikimedia.org/T308576) (owner: 10Cmelo) [05:14:26] 10InternetArchiveBot: The IABot has the ability to set the URL to near death, while the normal user cannot. - https://phabricator.wikimedia.org/T313180 (10IN) [05:16:29] 10InternetArchiveBot: The IABot has the ability to set the URL to near death, while the normal user cannot. - https://phabricator.wikimedia.org/T313180 (10Cyberpower678) 05Open→03Declined This is intentional. Users are expected to be able to have better judgement when assessing URLs than the bot, and thus o... [05:18:45] (03PS56) 10Cmelo: Add the ability to load more participants on scroll [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/809008 (https://phabricator.wikimedia.org/T308576) [05:22:41] (03CR) 10CI reject: [V: 04-1] Add the ability to load more participants on scroll [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/809008 (https://phabricator.wikimedia.org/T308576) (owner: 10Cmelo) [05:39:14] (03PS57) 10Cmelo: Add the ability to load more participants on scroll [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/809008 (https://phabricator.wikimedia.org/T308576) [05:56:13] 10MediaWiki-Language-converter, 10SyntaxHighlight, 10Chinese-Sites, 10I18n, 10Patch-For-Review: Auto-conversion between zh-hans & zh-hant in elements - https://phabricator.wikimedia.org/T34943 (10Diskdance) [06:11:07] (03CR) 10Universal Omega: [C: 03+2] Move skinStyles LESS files to own directory [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/814327 (owner: 10Universal Omega) [06:23:03] (03CR) 10Universal Omega: [V: 03+2 C: 03+2] Move VisualEditor.CodeMirror.DarkTheme.less to sub-directory [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/814328 (owner: 10Universal Omega) [06:26:06] 10MediaWiki-extensions-OAuth: OAuth extension should support OpenID Connect - https://phabricator.wikimedia.org/T254063 (10Tgr) Arguably, the OAuth extension as it is now already implements a functional subset of the OIDC spec. You can register an application with the "authorization code" grant type, get an acce... [07:38:58] (03CR) 10Physikerwelt: [C: 03+2] Add wbEntitySelector widget to edit qid in VE (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/807527 (owner: 10Fwolz) [09:33:27] (03CR) 10Daniel Kinzler: [C: 03+2] tests: Use `overrideConfigValue(s)` where necessary [core] - 10https://gerrit.wikimedia.org/r/813996 (owner: 10D3r1ck01) [09:47:40] (03PS4) 10Daniel Kinzler: test: installMockMwServices should apply overrides per default. [core] - 10https://gerrit.wikimedia.org/r/814281 (https://phabricator.wikimedia.org/T312709) [09:47:45] (03CR) 10Daniel Kinzler: test: installMockMwServices should apply overrides per default. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/814281 (https://phabricator.wikimedia.org/T312709) (owner: 10Daniel Kinzler) [09:49:04] (03Merged) 10jenkins-bot: tests: Use `overrideConfigValue(s)` where necessary [core] - 10https://gerrit.wikimedia.org/r/813996 (owner: 10D3r1ck01) [09:59:56] (03PS1) 10Physikerwelt: Make dependency to Wikibase client config optional [extensions/Math] - 10https://gerrit.wikimedia.org/r/814348 (https://phabricator.wikimedia.org/T313143) [10:01:44] (03CR) 10CI reject: [V: 04-1] test: installMockMwServices should apply overrides per default. [core] - 10https://gerrit.wikimedia.org/r/814281 (https://phabricator.wikimedia.org/T312709) (owner: 10Daniel Kinzler) [10:07:51] (03PS1) 10Raimond Spekking: Add Ghanaian Pidgin (gbe) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/814349 (https://phabricator.wikimedia.org/T311975) [10:14:41] (03CR) 10CI reject: [V: 04-1] Make dependency to Wikibase client config optional [extensions/Math] - 10https://gerrit.wikimedia.org/r/814348 (https://phabricator.wikimedia.org/T313143) (owner: 10Physikerwelt) [10:20:01] (03PS1) 10Novem Linguae: Fix AFD and PROD bugs [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/814350 (https://phabricator.wikimedia.org/T238025) [10:21:27] (03CR) 10Novem Linguae: "Hi :)" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/814350 (https://phabricator.wikimedia.org/T238025) (owner: 10Novem Linguae) [10:23:30] (03PS2) 10Novem Linguae: Fix AFD and PROD bugs [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/814350 (https://phabricator.wikimedia.org/T238025) [10:35:17] (03CR) 10Raimond Spekking: [C: 03+2] Add Ghanaian Pidgin (gpe) [core] - 10https://gerrit.wikimedia.org/r/814284 (https://phabricator.wikimedia.org/T311975) (owner: 10Amire80) [10:35:28] 10MediaWiki-Comment-store, 10MediaWiki-Page-rename, 10good first task: Incorrect summary when summary includes "$100" (somebody forgot to escape their regular expression replacement) - https://phabricator.wikimedia.org/T307153 (10AlexisJazz) [10:38:06] 10MediaWiki-extensions-Newsletter: Special:Newsletters doesn't show the newsletters - https://phabricator.wikimedia.org/T313157 (1001tonythomas) So I just booted up a vagrant machine pointing to fresh "master" branch. Added the `newsletter` role, with this on top: ` 429be9a (HEAD -> master, origin/master, origi... [10:41:43] (03PS2) 10Thiemo Kreuz (WMDE): Rewrite parts of importImages maintenance script for readability [core] - 10https://gerrit.wikimedia.org/r/808800 [10:41:45] (03PS1) 10Thiemo Kreuz (WMDE): Fix confusing $$var indirection in importImages script [core] - 10https://gerrit.wikimedia.org/r/814351 [10:41:47] (03PS1) 10Thiemo Kreuz (WMDE): Replace deep nesting in importImages script with guard clauses [core] - 10https://gerrit.wikimedia.org/r/814352 [10:46:08] (03PS12) 10Dreamy Jazz: T311375: Show results in paginator instead of truncation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) [10:47:32] 10MediaWiki-extensions-Newsletter: Special:Newsletters doesn't show the newsletters - https://phabricator.wikimedia.org/T313157 (10Reedy) >>! In T313157#8082290, @Reedy wrote: > https://en.wikipedia.beta.wmflabs.org/wiki/Special:Newsletters shows the same behaviour... Let me see if there's anything in the DB the... [10:49:01] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Only set real name if it is not null [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/814300 (owner: 10Zabe) [10:49:39] (03PS13) 10Dreamy Jazz: T311375: Show results in paginator instead of truncation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) [10:51:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "It appears like this revert helps unblocking other people. Nothing is really lost when we temporarily revert this rather small change. An " [extensions/Math] - 10https://gerrit.wikimedia.org/r/814322 (https://phabricator.wikimedia.org/T313143) (owner: 10Reedy) [10:51:48] (03CR) 10Dreamy Jazz: "Last two patches were for a rebase off the date selection patch." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) (owner: 10Dreamy Jazz) [10:51:56] (03PS7) 10Dreamy Jazz: Move the function to log a check into a new CheckUserLogService [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814297 (https://phabricator.wikimedia.org/T247789) [10:52:27] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] scripts: Avoid DELETE LIMIT for script UpdateTable on postgres [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/814295 (owner: 10Umherirrender) [10:53:09] (03Merged) 10jenkins-bot: Add Ghanaian Pidgin (gpe) [core] - 10https://gerrit.wikimedia.org/r/814284 (https://phabricator.wikimedia.org/T311975) (owner: 10Amire80) [10:53:14] (03Merged) 10jenkins-bot: Only set real name if it is not null [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/814300 (owner: 10Zabe) [10:54:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "If it helps making this work with PostgreSQL, why not? Still I wonder if there is a way to avoid this (really minor) code duplication?" [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/814296 (owner: 10Umherirrender) [10:55:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Always use IDatabase::addQuotes for quoting [extensions/Translate] - 10https://gerrit.wikimedia.org/r/814278 (owner: 10Umherirrender) [11:02:59] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] PageTranslationSpecialPage: Null coalescence in execute() (031 comment) [extensions/Translate] - 10https://gerrit.wikimedia.org/r/813998 (https://phabricator.wikimedia.org/T313054) (owner: 10Reedy) [11:03:13] (03CR) 10CI reject: [V: 04-1] Replace deep nesting in importImages script with guard clauses [core] - 10https://gerrit.wikimedia.org/r/814352 (owner: 10Thiemo Kreuz (WMDE)) [11:05:23] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Don't pass in null for key [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/813634 (owner: 10MarkAHershberger) [11:06:42] (03CR) 10CI reject: [V: 04-1] T311375: Show results in paginator instead of truncation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) (owner: 10Dreamy Jazz) [11:07:35] (03CR) 10CI reject: [V: 04-1] Move the function to log a check into a new CheckUserLogService [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814297 (https://phabricator.wikimedia.org/T247789) (owner: 10Dreamy Jazz) [11:10:43] (03Merged) 10jenkins-bot: Revert "Add wbEntitySelector widget to edit qid in VE" [extensions/Math] - 10https://gerrit.wikimedia.org/r/814322 (https://phabricator.wikimedia.org/T313143) (owner: 10Reedy) [11:12:32] 10MediaWiki-Special-pages, 10Wikibase-Quality-Constraints, 10Wikidata, 10wdwb-tech, 10I18n: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages - https://phabricator.wikimedia.org/T313181 (10Amire80) [11:12:56] (03Merged) 10jenkins-bot: scripts: Avoid DELETE LIMIT for script UpdateTable on postgres [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/814295 (owner: 10Umherirrender) [11:12:58] (03Merged) 10jenkins-bot: Always use IDatabase::addQuotes for quoting [extensions/Translate] - 10https://gerrit.wikimedia.org/r/814278 (owner: 10Umherirrender) [11:20:13] (03Merged) 10jenkins-bot: PageTranslationSpecialPage: Null coalescence in execute() [extensions/Translate] - 10https://gerrit.wikimedia.org/r/813998 (https://phabricator.wikimedia.org/T313054) (owner: 10Reedy) [11:20:35] (03Merged) 10jenkins-bot: Don't pass in null for key [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/813634 (owner: 10MarkAHershberger) [11:31:11] 10MediaWiki-Action-API, 10Growth-Team, 10Growth-Team-Filtering, 10Notifications, and 2 others: Thank api assumes that echo event will go through - https://phabricator.wikimedia.org/T241474 (10AlexisJazz) [11:36:33] 10MediaWiki-extensions-MultiMail, 10Project-Admins, 10Continuous-Integration-Config: Publish MultiMail extension - https://phabricator.wikimedia.org/T311542 (10Mainframe98) 05Open→03Resolved [11:40:41] 10MediaWiki-extensions-Newsletter: Special:Newsletters doesn't show the newsletters - https://phabricator.wikimedia.org/T313157 (10Reedy) I should try creating a new newsletter I guess [11:51:55] (03PS1) 10Dreamy Jazz: Add cul_period to cu_log [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814353 (https://phabricator.wikimedia.org/T204347) [12:02:26] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata Lexicographical data, and 3 others: Split Wikibase message files to smaller groups - https://phabricator.wikimedia.org/T313183 (10Amire80) [12:03:19] (03PS14) 10Dreamy Jazz: T311375: Show results in paginator instead of truncation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) [12:06:54] (03PS15) 10Dreamy Jazz: T311375: Show results in paginator instead of truncation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) [12:09:11] (03PS8) 10Dreamy Jazz: Move the function to log a check into a new CheckUserLogService [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814297 (https://phabricator.wikimedia.org/T247789) [12:10:09] (03CR) 10Zabe: [C: 03+2] "This change is ready for review." [extensions/CheckUser] (REL1_38) - 10https://gerrit.wikimedia.org/r/814329 (https://phabricator.wikimedia.org/T313056) (owner: 10Zabe) [12:10:26] (03PS1) 10Zabe: SpecialCheckUserLog: Null coalescence in execute() [extensions/CheckUser] (REL1_37) - 10https://gerrit.wikimedia.org/r/814330 (https://phabricator.wikimedia.org/T313056) [12:10:31] (03CR) 10Zabe: [C: 03+2] SpecialCheckUserLog: Null coalescence in execute() [extensions/CheckUser] (REL1_37) - 10https://gerrit.wikimedia.org/r/814330 (https://phabricator.wikimedia.org/T313056) (owner: 10Zabe) [12:11:42] 10MediaWiki-General, 10MediaWiki-extensions-General, 10MW-1.35-notes, 10MW-1.35-release, and 7 others: Fix passing null to non-null param of PHP internal functions in MediaWiki core (PHP 8.1 warning) - https://phabricator.wikimedia.org/T289926 (10Dreamy_Jazz) [12:11:56] 10CheckUser, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), 10PHP 8.1 support, 10Patch-For-Review: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in SpecialCheckUserLog.php on line 67 - https://phabricator.wikimedia.org/T313056 (10Dreamy_Jazz) 05Resolved→03Open Lo... [12:12:36] (03Merged) 10jenkins-bot: SpecialCheckUserLog: Null coalescence in execute() [extensions/CheckUser] (REL1_38) - 10https://gerrit.wikimedia.org/r/814329 (https://phabricator.wikimedia.org/T313056) (owner: 10Zabe) [12:14:12] (03CR) 10Zabe: [C: 03+2] "This change is ready for review." [extensions/CheckUser] (REL1_35) - 10https://gerrit.wikimedia.org/r/814331 (https://phabricator.wikimedia.org/T313056) (owner: 10Zabe) [12:14:14] (03Merged) 10jenkins-bot: SpecialCheckUserLog: Null coalescence in execute() [extensions/CheckUser] (REL1_37) - 10https://gerrit.wikimedia.org/r/814330 (https://phabricator.wikimedia.org/T313056) (owner: 10Zabe) [12:15:40] (03PS1) 10Amire80: Change search preference message [core] - 10https://gerrit.wikimedia.org/r/814355 [12:16:26] 10CheckUser, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), 10PHP 8.1 support, 10Patch-For-Review: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in SpecialCheckUserLog.php on line 67 - https://phabricator.wikimedia.org/T313056 (10Reedy) >>! In T313056#8082880, @Dream... [12:19:13] (03Merged) 10jenkins-bot: SpecialCheckUserLog: Null coalescence in execute() [extensions/CheckUser] (REL1_35) - 10https://gerrit.wikimedia.org/r/814331 (https://phabricator.wikimedia.org/T313056) (owner: 10Zabe) [12:19:54] 10CheckUser, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), 10PHP 8.1 support, 10Patch-For-Review: Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in SpecialCheckUserLog.php on line 67 - https://phabricator.wikimedia.org/T313056 (10Zabe) 05Open→03Resolved [12:20:00] 10MediaWiki-General, 10MediaWiki-extensions-General, 10MW-1.35-notes, 10MW-1.35-release, and 7 others: Fix passing null to non-null param of PHP internal functions in MediaWiki core (PHP 8.1 warning) - https://phabricator.wikimedia.org/T289926 (10Zabe) [12:21:22] 10SDC General: Page refresh or Null edit required after SDC edit - https://phabricator.wikimedia.org/T313185 (10HenkvD) [12:27:01] 10CheckUser: Simplify the period selection - https://phabricator.wikimedia.org/T311426 (10Dreamy_Jazz) 05Resolved→03Open On second thoughts I asked the checkuser-l list. It seems being able to select dates is not necessarily wanted. Therefore, reopening as other tickets will use this as parent ticket. Withou... [12:28:49] (03PS17) 10Daniel Kinzler: Experiment: Implement rate limiting in Authority. [core] - 10https://gerrit.wikimedia.org/r/809295 (https://phabricator.wikimedia.org/T310476) [12:29:17] 10AbuseFilter (Overhaul-2020), 10Patch-For-Review, 10Schema-change: Read from and write to `actor` table in AbuseFilter - https://phabricator.wikimedia.org/T188180 (10matej_suchanek) >>! In T188180#7975147, @Zabe wrote: > `abuse_filter_log` saves non-existing users when AbuseFilter prevents account creation.... [12:32:51] (03CR) 10Samtar: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/814350 (https://phabricator.wikimedia.org/T238025) (owner: 10Novem Linguae) [12:35:34] (03PS18) 10Daniel Kinzler: Experiment: Implement rate limiting in Authority. [core] - 10https://gerrit.wikimedia.org/r/809295 (https://phabricator.wikimedia.org/T310476) [12:40:07] (03CR) 10CI reject: [V: 04-1] Fix AFD and PROD bugs [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/814350 (https://phabricator.wikimedia.org/T238025) (owner: 10Novem Linguae) [12:49:47] (03PS21) 10Dreamy Jazz: Add filters that allow only searching for users or IPs [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/807217 (https://phabricator.wikimedia.org/T121190) [12:51:21] (03PS14) 10Dreamy Jazz: Add filter for established users for Get edits and Get users [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/808262 (https://phabricator.wikimedia.org/T26232) [12:55:45] (03CR) 10CI reject: [V: 04-1] Experiment: Implement rate limiting in Authority. [core] - 10https://gerrit.wikimedia.org/r/809295 (https://phabricator.wikimedia.org/T310476) (owner: 10Daniel Kinzler) [12:56:47] (03PS1) 10Zabe: Initial commit [extensions/EmergencyCaptcha] - 10https://gerrit.wikimedia.org/r/814357 (https://phabricator.wikimedia.org/T303433) [13:08:00] 10MediaWiki-extensions-CentralAuth, 10ConfirmEdit (CAPTCHA extension), 10Platform Engineering, 10SRE, and 7 others: Allow Stewards to enable 'emergency CAPTCHAs' for anonymous IP edits - https://phabricator.wikimedia.org/T303433 (10Zabe) >>! In T303433#7765136, @taavi wrote: > I'm not sure if I like a patt... [13:16:58] (03PS3) 10Novem Linguae: Fix AFD and PROD bugs [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/814350 (https://phabricator.wikimedia.org/T238025) [13:21:06] (03CR) 10Samtar: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/814350 (https://phabricator.wikimedia.org/T238025) (owner: 10Novem Linguae) [13:21:55] oh drat that wasn't needed [13:22:30] taavi: thanks for merging that so quickly ^^ [13:23:19] (03PS1) 10Daniel Kinzler: Experiment: introduce authorize() into Authority. [core] - 10https://gerrit.wikimedia.org/r/814359 [13:25:59] 04(no projects): StickyTableHeader hidden behind top header in Vector Skin 2022 - https://phabricator.wikimedia.org/T313187 (10PutzfetzenORG) [13:42:28] (03PS2) 10Southparkfan: Replace Linker::link() and linkKnown() with LinkRenderer service [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/814265 (https://phabricator.wikimedia.org/T279369) [13:43:06] 04(no projects): StickyTableHeader hidden behind top header in Vector Skin 2022 - https://phabricator.wikimedia.org/T313187 (10PutzfetzenORG) [13:44:28] (03CR) 10CI reject: [V: 04-1] Experiment: introduce authorize() into Authority. [core] - 10https://gerrit.wikimedia.org/r/814359 (owner: 10Daniel Kinzler) [14:17:27] (03PS1) 10Daniel Kinzler: WIP: Experiment: Introduce Authorizer [core] - 10https://gerrit.wikimedia.org/r/814360 [14:25:46] (03CR) 10CI reject: [V: 04-1] WIP: Experiment: Introduce Authorizer [core] - 10https://gerrit.wikimedia.org/r/814360 (owner: 10Daniel Kinzler) [14:56:42] (03PS7) 10Winston Sung: Revert language fallback chain changes to yue [core] - 10https://gerrit.wikimedia.org/r/811417 (https://phabricator.wikimedia.org/T296188) [15:19:21] 10DiscussionTools: Most of the reply links don't work on ckbwiki - https://phabricator.wikimedia.org/T313188 (10matmarex) [15:23:58] 10DiscussionTools, 10Editing-team (FY2021-22 Kanban Board): Most of the reply links don't work on ckbwiki - https://phabricator.wikimedia.org/T313188 (10matmarex) a:03matmarex This is a very similar bug to T312828, similarly related to the changes from T304595, but the cause is different. MediaWiki overrides... [15:32:02] 04(no projects): Add template editor right to wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) [15:32:28] 04(no projects): Add template editor right to wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) [15:34:09] (03PS5) 10Daniel Kinzler: test: installMockMwServices should apply overrides per default. [core] - 10https://gerrit.wikimedia.org/r/814281 (https://phabricator.wikimedia.org/T312709) [15:37:53] (03PS1) 10Bartosz Dziewoński: Ensure custom locales for Moment.js overrides, don't change 'en' [core] - 10https://gerrit.wikimedia.org/r/814361 (https://phabricator.wikimedia.org/T313188) [15:47:37] 04(no projects): Add template editor right to wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) [15:48:47] 10CheckUser: Simplify the period selection - https://phabricator.wikimedia.org/T311426 (10JJMC89) >>! In T311426#8082905, @Dreamy_Jazz wrote: > remove the ability to select by a custom timestamp in the checkuser API. The API shouldn't be made worse because CUs don't want to improve the web UI. [15:49:43] 10Wikimedia-Site-requests, 10Community-consensus-needed: Add template editor right to wikiquote - https://phabricator.wikimedia.org/T313189 (10Zabe) [15:50:42] 10Wikimedia-Site-requests: Add template editor right to wikiquote - https://phabricator.wikimedia.org/T313189 (10Zabe) Please provide a community consensus for this change. [15:50:46] 10Wikimedia-Site-requests: Add template editor right to wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) [15:52:06] 10MediaWiki-Interface (Tables): Enabling Drop-Down Table Headings - https://phabricator.wikimedia.org/T313147 (10matmarex) [15:52:11] 10MediaWiki-Interface (Tables), 10Timeless, 10CommTech-Hackathon-AKA-CodeJam-2022, 10JavaScript, 10Patch-For-Review: Implement repeated/fixed/floating table headers - https://phabricator.wikimedia.org/T42763 (10matmarex) [15:52:19] 10Wikimedia-Site-requests: Add template editor right to wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) >>! In T313189#8083005, @Zabe wrote: > Please provide a community consensus for this change. [[https://en.wikiquote.org/w/index.php?title=Wikiquote:Village_pump&oldid=3143440#Add_temp... [15:57:27] 10Wikimedia-Site-requests: Add template editor right to wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) [16:03:26] 10Wikimedia-Site-requests: Add template editor right to wikiquote - https://phabricator.wikimedia.org/T313189 (10Aklapper) In the future, please always follow https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes when requesting site configuration changes for a Wikimedia website. Thanks. Please d... [16:04:15] 10Wikimedia-Site-requests: Add template editor right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Aklapper) [16:10:52] 10CheckUser: Simplify the period selection - https://phabricator.wikimedia.org/T311426 (10Dreamy_Jazz) > The API shouldn't be made worse because CUs don't want to improve the web UI. This is the direction I was pointed in due to the following comment (from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/C... [16:11:29] 10DiscussionTools, 10Editing-team (FY2021-22 Kanban Board), 10Patch-For-Review: Most of the reply links don't work on ckbwiki - https://phabricator.wikimedia.org/T313188 (10AramBakir) @matmarex Thank you so much for creating this task. You're right. A long time ago, I've noticed that the dates don't work on... [16:11:32] 10Wikimedia-Site-requests: Add template editor right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) >>! In T313189#8083022, @Aklapper wrote: > In the future, please always follow https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes when requesting site config... [16:13:25] 10Wikimedia-Site-requests: Add template editor right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Aklapper) If anybody would like to create a software patch to resolve this request, please see [[ https://www.mediawiki.org/wiki/Developer_access | Developer access ]] and the [[ https://www.m... [16:14:13] 10MediaWiki-User-management, 10SpamBlacklist, 10Community-consensus-needed: Grant sysops the sboverride userright - https://phabricator.wikimedia.org/T313106 (10Ilovemydoodle2) **Neutral** While I see the potential benefits of this, I am also concerned that if a bot was compromised, this could be abused. [16:24:59] 10CheckUser: Simplify the period selection - https://phabricator.wikimedia.org/T311426 (10JJMC89) > This is the direction I was pointed in As Amir said, they aren't the PM. They don't get to make that call. > You should not let arbitrary time periods in API. Many other MW APIs allow querying arbitrary time pe... [16:28:31] 10CheckUser: Simplify the period selection - https://phabricator.wikimedia.org/T311426 (10Dreamy_Jazz) > As Amir said, they aren't the PM. They don't get to make that call. Fair. > Personally, I very much dislike that web UI only allows the selection of pre-defined (and possibly useless) periods. I'll comment th... [16:37:53] 10MediaWiki-extension-requests, 10Commons, 10Page-Previews, 10WMF-Inspiration-Week-2022-ML-Collab: Allow hiding certain (NSFW etc) images by default and letting users explicitly expand them - https://phabricator.wikimedia.org/T198550 (10Ppehrson) >>! In T198550#6439735, @Iniquity wrote: > One more NSFW fil... [16:53:05] (03CR) 10VolkerE: "A few things for understanding before amending this patch:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/813937 (https://phabricator.wikimedia.org/T313066) (owner: 10Jdlrobson) [16:59:02] 10Wikimedia-Site-requests: Add template editor right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) @Aklapper Is there any way for a user to choose the name of the right they want to be called? (e.g. some might want to go by "template administrator", while other may want to g... [17:10:03] (03CR) 10Universal Omega: [C: 03+2] Replace usage of 'Blacklisted' with 'Disabled' [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/814325 (https://phabricator.wikimedia.org/T313170) (owner: 10Universal Omega) [17:19:23] (03Merged) 10jenkins-bot: Replace usage of 'Blacklisted' with 'Disabled' [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/814325 (https://phabricator.wikimedia.org/T313170) (owner: 10Universal Omega) [17:20:50] 10Cosmos, 10Patch-For-Review, 10Voice & Tone: Replace usage of 'Blacklisted' in Cosmos - https://phabricator.wikimedia.org/T313170 (10Universal_Omega) [17:21:42] 10Cosmos, 10Voice & Tone: Replace usage of 'Blacklisted' in Cosmos - https://phabricator.wikimedia.org/T313170 (10Universal_Omega) 05Open→03Resolved a:03Universal_Omega [17:21:56] 10MediaWiki-General, 10MediaWiki-extensions-General, 10WMF-General-or-Unknown, 10MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), and 5 others: Reconsidering how we name things - https://phabricator.wikimedia.org/T254646 (10Universal_Omega) [17:23:29] 10Wikimedia-Site-requests: Add template editor right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Aklapper) Ambiguous names are super confusing and that's what's an on-wiki discussion is for. [17:24:02] 10Codex, 10Design-Systems-Team: [Needs discussion] Thumbnails should have relative sizes - https://phabricator.wikimedia.org/T312582 (10Volker_E) Full support! [17:24:55] 10Wikimedia-Site-requests: Add template administrator right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) [17:30:13] 10CampaignEvents, 10Campaign-Registration, 10Campaign-Tools (Campaign-Tools-Sprint-16), 10Patch-For-Review: Implement infinite scrolling on participant list in EventDetails - https://phabricator.wikimedia.org/T308576 (10PatchDemoBot) Test wiki on [[ https://patchdemo.wmflabs.org | Patch demo ]] by CMelo (... [17:54:12] 10MediaWiki-extensions-Newsletter: Special:Newsletters doesn't show the newsletters - https://phabricator.wikimedia.org/T313157 (10Reedy) {F35319643} {F35319642} [17:55:08] 10MediaWiki-extensions-Newsletter: Special:Newsletters doesn't show the newsletters - https://phabricator.wikimedia.org/T313157 (10Reedy) Visiting the `Newsletter:Testing_Letter` pages (and same for the older ones) works fine [18:02:37] (03CR) 10Umherirrender: [C: 03+2] Fix confusing $$var indirection in importImages script [core] - 10https://gerrit.wikimedia.org/r/814351 (owner: 10Thiemo Kreuz (WMDE)) [18:07:49] 10MediaWiki-User-management, 10SpamBlacklist, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), 10Patch-Needs-Improvement, 10User-DannyS712: Create a user right that allows ignoring the spam blacklist - https://phabricator.wikimedia.org/T36928 (10Stang) If a user with `sboverride` permission performed an edit... [18:08:06] (03CR) 10Umherirrender: [C: 03+2] Replace Linker with LinkRenderer [extensions/Poll] - 10https://gerrit.wikimedia.org/r/814266 (https://phabricator.wikimedia.org/T279367) (owner: 10Southparkfan) [18:12:14] 10MediaWiki-User-management, 10SpamBlacklist, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), 10User-DannyS712: Create a user right that allows ignoring the spam blacklist - https://phabricator.wikimedia.org/T36928 (10Stang) Since patch has been merged. [18:15:44] (03CR) 10Umherirrender: Replace Linker::link() and linkKnown() with LinkRenderer service (035 comments) [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/814265 (https://phabricator.wikimedia.org/T279369) (owner: 10Southparkfan) [18:16:27] (03CR) 10Umherirrender: [C: 03+2] Replace Linker with LinkRenderer [extensions/CloneDiff] - 10https://gerrit.wikimedia.org/r/814260 (https://phabricator.wikimedia.org/T149346) (owner: 10Southparkfan) [18:17:06] (03CR) 10Umherirrender: [C: 03+2] Replace Linker with LinkRenderer [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/814263 (https://phabricator.wikimedia.org/T149346) (owner: 10Southparkfan) [18:17:42] (03CR) 10Umherirrender: [C: 03+2] Replace Linker with LinkRenderer [extensions/AjaxShowEditors] - 10https://gerrit.wikimedia.org/r/814264 (https://phabricator.wikimedia.org/T149346) (owner: 10Southparkfan) [18:17:44] 10Documentation-Review-Board, 10Key docs update 2021-22: Review and rewrite accessibility guide - https://phabricator.wikimedia.org/T293777 (10Aklapper) @TheDJ: Just to make this explicit, I like a lot of parts of the original document. I just don't have a better idea than merging when it comes to how to bring... [18:18:03] 10Documentation-Review-Board, 10Key docs update 2021-22: Review and rewrite accessibility guide - https://phabricator.wikimedia.org/T293777 (10Aklapper) a:05Aklapper→03None [18:20:46] (03Merged) 10jenkins-bot: Fix confusing $$var indirection in importImages script [core] - 10https://gerrit.wikimedia.org/r/814351 (owner: 10Thiemo Kreuz (WMDE)) [18:20:50] (03Merged) 10jenkins-bot: Replace Linker with LinkRenderer [extensions/Poll] - 10https://gerrit.wikimedia.org/r/814266 (https://phabricator.wikimedia.org/T279367) (owner: 10Southparkfan) [18:20:53] (03Merged) 10jenkins-bot: Replace Linker with LinkRenderer [extensions/CloneDiff] - 10https://gerrit.wikimedia.org/r/814260 (https://phabricator.wikimedia.org/T149346) (owner: 10Southparkfan) [18:20:55] (03Merged) 10jenkins-bot: Replace Linker with LinkRenderer [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/814263 (https://phabricator.wikimedia.org/T149346) (owner: 10Southparkfan) [18:20:58] (03Merged) 10jenkins-bot: Replace Linker with LinkRenderer [extensions/AjaxShowEditors] - 10https://gerrit.wikimedia.org/r/814264 (https://phabricator.wikimedia.org/T149346) (owner: 10Southparkfan) [18:25:49] 10Reading-Web-Local-Wiki-Issues: StickyTableHeader (gadget) on English Wikipedia hidden behind top header in Vector Skin 2022 - https://phabricator.wikimedia.org/T313187 (10Aklapper) [18:26:30] 10Reading-Web-Local-Wiki-Issues: StickyTableHeader (gadget) on English Wikipedia hidden behind top header in Vector Skin 2022 - https://phabricator.wikimedia.org/T313187 (10Aklapper) 05Open→03Invalid Hi @PutzfetzenORG, thanks for taking the time to report this! User scripts, gadgets, templates, custom CSS... [18:29:03] 10MediaWiki-extensions-Poll, 10Patch-For-Review, 10Technical-Debt: Replace usages of Linker::link() and Linker::linkKnown() in extension Poll - https://phabricator.wikimedia.org/T279367 (10Southparkfan) 05Open→03Resolved [18:29:11] 10MediaWiki-extensions-General, 10MediaWiki-extensions-Other, 10MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), 10Patch-For-Review, and 2 others: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions - https://phabricator.wikimedia.org/T149346 (10Southparkfan) [18:29:13] 04(no projects): Some photos fail to show when logged in - https://phabricator.wikimedia.org/T313167 (10Mike_Peel) 05Stalled→03Invalid Ah, thanks for the link to that help page, I'd forgotten about that! With a bit of investigation, it turned out that AdBlocker Ultimate was blocking the images as advertisem... [18:29:33] 10MediaWiki-extensions-General, 10MediaWiki-extensions-Other, 10MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), 10Patch-For-Review, and 2 others: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions - https://phabricator.wikimedia.org/T149346 (10Southparkfan) [18:29:46] (03PS2) 10Physikerwelt: Make dependency to Wikibase client config optional [extensions/Math] - 10https://gerrit.wikimedia.org/r/814348 (https://phabricator.wikimedia.org/T313143) [18:30:42] 10Wikimedia-Extension-setup: add WikiLove extension in ptwikinews - https://phabricator.wikimedia.org/T313173 (10Stang) [18:38:01] (03PS3) 10Southparkfan: Replace Linker::link() and linkKnown() with LinkRenderer service [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/814265 (https://phabricator.wikimedia.org/T279369) [18:38:05] (03CR) 10Southparkfan: Replace Linker::link() and linkKnown() with LinkRenderer service (035 comments) [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/814265 (https://phabricator.wikimedia.org/T279369) (owner: 10Southparkfan) [18:46:28] 10Security-Team, 10Wikimedia-Extension-setup, 10SecTeam-Processed: Request to install Extension:Upload Wizard on id-internal.wikimedia.org - https://phabricator.wikimedia.org/T304291 (10Stang) 05Resolved→03Declined a:05Stang→03None Change status to Declined since this extension is not actually deploy... [18:52:22] 10Wikimedia-Extension-setup: Flagged Revisions for Vietnamese Wikipedia - https://phabricator.wikimedia.org/T204354 (10Stang) [18:52:24] 10Wikimedia-Extension-setup, 10Chinese-Sites: Enable Flagged Revisions (for trial run purpose) at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10Stang) [18:56:21] 04(no projects): Some photos fail to show when logged in - https://phabricator.wikimedia.org/T313167 (10Aklapper) Glad you found the reason! [18:56:30] 04(no projects): Some photos fail to show when logged in (due to AdBlocker browser add-on) - https://phabricator.wikimedia.org/T313167 (10Aklapper) [19:09:38] 10Security-Team, 10Wikimedia-Extension-setup, 10SecTeam-Processed: Request to install Extension:Upload Wizard on id-internal.wikimedia.org - https://phabricator.wikimedia.org/T304291 (10Aklapper) The extension *is* actually deployed already, e.g. on donatewiki, so I'm curious why it would require a security... [19:15:49] 10Security-Team, 10Wikimedia-Extension-setup, 10SecTeam-Processed: Request to install Extension:Upload Wizard on id-internal.wikimedia.org - https://phabricator.wikimedia.org/T304291 (10Stang) Per https://gerrit.wikimedia.org/r/c/788812, the only reason is "id_internalwikimedia is a private wiki". [19:39:52] 10MediaWiki-General, 10MediaWiki-extensions-General, 10MW-1.35-notes, 10MW-1.35-release, and 7 others: Fix passing null to non-null param of PHP internal functions in MediaWiki core (PHP 8.1 warning) - https://phabricator.wikimedia.org/T289926 (10Reedy) [19:39:58] 10MediaWiki-extensions-Translate, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), 10PHP 8.1 support: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541 - https://phabricator.wikimedia.org/T313054 (10Reedy) 05Open→03Resolved a:... [19:42:38] (03PS1) 10Reedy: SpecialNuke: Null coalescence in execute() [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/814368 (https://phabricator.wikimedia.org/T313146) [19:44:46] 10MediaWiki-File-management, 10Commons, 10PHP 8.1 support: PHPUnit\Framework\TestFailure not found - https://phabricator.wikimedia.org/T307304 (10Reedy) 05Open→03Resolved a:03Hexmode [20:11:07] (03CR) 10D3r1ck01: [C: 03+2] Fix config overrides in SkinVectorTest. [skins/Vector] - 10https://gerrit.wikimedia.org/r/814283 (owner: 10Daniel Kinzler) [20:11:12] 10Wikimedia-Site-requests, 10Community-consensus-needed: Add template administrator right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10TheresNoTime) 05Open→03Stalled Waiting for consensus to form at https://en.wikiquote.org/wiki/Wikiquote:Village_pump#Add_template_editor_right 🙂 [20:27:50] 10Wikimedia-Site-requests, 10Community-consensus-needed: Add template administrator right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) >>! In T313189#8083139, @TheresNoTime wrote: > Waiting for consensus to form at https://en.wikiquote.org/wiki/Wikiquote:Village_pump#Add_... [20:28:05] 10Wikimedia-Site-requests: Add template administrator right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) [20:28:12] 10Wikimedia-Site-requests: Add template administrator right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Ilovemydoodle2) 05Stalled→03Open [20:31:13] 10Wikimedia-Site-requests: Add template administrator right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10TheresNoTime) >>! In T313189#8083152, @Ilovemydoodle2 wrote: >>>! In T313189#8083139, @TheresNoTime wrote: >> Waiting for consensus to form at https://en.wikiquote.org/wiki/Wikiquote:Vi... [20:37:38] 10Wikimedia-Site-requests: Add template administrator right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Stang) There's 12 sites already implemented such restriction level with name `templateeditor`, so it would be great to keep such canonical name as group name. The name of this group may... [20:37:49] 10Wikimedia-Site-requests: Add template administrator right to English Wikiquote - https://phabricator.wikimedia.org/T313189 (10Stang) [20:53:39] 10Mobile: Page history link missing from top of page on mobile when logged out - https://phabricator.wikimedia.org/T313191 (10Cheesycow5) [20:58:46] (03PS3) 10EpicPupper: Clarify wording of preview settings [core] - 10https://gerrit.wikimedia.org/r/802948 (https://phabricator.wikimedia.org/T234383) [21:00:34] 10MediaWiki-Core-Preferences, 10I18n, 10Patch-For-Review, 10User-EpicPupper, 10Voice & Tone: MediaWiki:Tog-previewonfirst badly worded: Unclear what "first edit" in "Show preview on first edit" means - https://phabricator.wikimedia.org/T234383 (10EpicPupper) >>! In T234383#7981919, @Amire80 wrote: > The... [21:00:40] (03PS5) 10EpicPupper: Clarify wording for high-volume grants [core] - 10https://gerrit.wikimedia.org/r/791740 (https://phabricator.wikimedia.org/T70312) [21:03:23] (03PS6) 10EpicPupper: Clarify wording for high-volume grants [core] - 10https://gerrit.wikimedia.org/r/791740 (https://phabricator.wikimedia.org/T70312) [21:03:42] (03PS7) 10EpicPupper: Clarify wording for high-volume grants [core] - 10https://gerrit.wikimedia.org/r/791740 (https://phabricator.wikimedia.org/T70312) [21:04:15] 10MediaWiki-extensions-OAuth, 10Patch-For-Review, 10User-EpicPupper, 10Voice & Tone: OAuth: Grant "High-volume editing" is confusing (does not provide "edit" right) - https://phabricator.wikimedia.org/T70312 (10EpicPupper) Added parentheticals and fixed attribution. [21:06:01] (03PS4) 10EpicPupper: Clarify message for granting access to all projects [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/791738 (https://phabricator.wikimedia.org/T148942) [21:06:31] (03PS5) 10EpicPupper: Clarify message for granting access to all projects [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/791738 (https://phabricator.wikimedia.org/T148942) [21:08:58] (03CR) 10Cmelo: Add the ability to load more participants on scroll (0316 comments) [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/809008 (https://phabricator.wikimedia.org/T308576) (owner: 10Cmelo) [21:12:34] (03CR) 10EpicPupper: [C: 03+1] "Looks good to me. This is quite important to sites like Meta and reduces confusion." [core] - 10https://gerrit.wikimedia.org/r/777034 (https://phabricator.wikimedia.org/T305419) (owner: 10Stang) [21:13:08] (03PS1) 10Cmelo: Return central user id on ListParticipantsHandler [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/814369 [21:15:41] (03CR) 10CI reject: [V: 04-1] Return central user id on ListParticipantsHandler [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/814369 (owner: 10Cmelo) [21:17:02] (03PS2) 10Cmelo: Return central user id on ListParticipantsHandler [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/814369 [21:17:10] 10Reading-Web-Local-Wiki-Issues: StickyTableHeader (gadget) on English Wikipedia hidden behind top header in Vector Skin 2022 - https://phabricator.wikimedia.org/T313187 (10PutzfetzenORG) It's the main Wikipedia where it would matter to me. (EN and DE for me). I assume you know the issue tracker structures/conv... [21:20:10] 10CheckUser, 10PHP 8.1 support: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541 - https://phabricator.wikimedia.org/T313192 (10Reedy) [21:22:24] (03PS1) 10Reedy: SpecialCheckUser: Null coalescene in execute() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814370 (https://phabricator.wikimedia.org/T313192) [21:30:59] 10WPCleaner: Automatic fixing button is not working and there is an issue with interface language - https://phabricator.wikimedia.org/T288422 (10NicoV) Hi @AramBakir, I'm not sure I understand what it the problem you're facing, because I tried again on my computer and it seems to work. I can only see 2 things t... [21:35:53] 10Reading-Web-Local-Wiki-Issues: StickyTableHeader (gadget) on English Wikipedia hidden behind top header in Vector Skin 2022 - https://phabricator.wikimedia.org/T313187 (10Ciencia_Al_Poder) According to {T311170} [[ https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Features/Sticky_Header#My_templa... [21:53:10] (03CR) 10Dreamy Jazz: [C: 03+2] SpecialCheckUser: Null coalescene in execute() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814370 (https://phabricator.wikimedia.org/T313192) (owner: 10Reedy) [22:07:18] 10DiscussionTools: Introduce permalinks on wikitext talk pages - https://phabricator.wikimedia.org/T302011 (10Sdkb) Thanks, @ppelberg! Trying it out, I like it. The main areas for improvement are things around the edges. Visually, it'd be nicer if it were separated by a pipe from the reply button, e.g. [ reply... [22:09:14] 10CheckUser: /wiki/Special:Contributions/172.18.0.1 Error: Call to a member function isRegistered() on null - https://phabricator.wikimedia.org/T313193 (10Dreamy_Jazz) [22:09:52] (03Merged) 10jenkins-bot: SpecialCheckUser: Null coalescene in execute() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814370 (https://phabricator.wikimedia.org/T313192) (owner: 10Reedy) [22:11:05] (03PS1) 10Reedy: SpecialCheckUser: Null coalescene in execute() [extensions/CheckUser] (REL1_37) - 10https://gerrit.wikimedia.org/r/814335 (https://phabricator.wikimedia.org/T313192) [22:11:42] 10CheckUser: /wiki/Special:Contributions/172.18.0.1 Error: Call to a member function isRegistered() on null - https://phabricator.wikimedia.org/T313193 (10Dreamy_Jazz) p:05Triage→03High a:03Dreamy_Jazz Due to me changing usage from UserFactory to UserIdentityLookup. Seems I didn't properly test it. It retu... [22:14:45] (03PS1) 10Dreamy Jazz: Check for null when using UserIdentityLookup while looking up by ID [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814371 (https://phabricator.wikimedia.org/T313193) [22:18:59] 10CheckUser, 10Patch-For-Review: /wiki/Special:Contributions/172.18.0.1 Error: Call to a member function isRegistered() on null - https://phabricator.wikimedia.org/T313193 (10TheresNoTime) >>! In T313193#8083227, @Dreamy_Jazz wrote: > Due to me changing usage from UserFactory to UserIdentityLookup. Seems I did... [22:20:25] 10CheckUser, 10Patch-For-Review: /wiki/Special:Contributions/172.18.0.1 Error: Call to a member function isRegistered() on null - https://phabricator.wikimedia.org/T313193 (10Dreamy_Jazz) I'm not sure why Phan didn't catch this issue as usually Phan notifies when there are null issues. [22:21:39] (03CR) 10Zabe: Check for null when using UserIdentityLookup while looking up by ID (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814371 (https://phabricator.wikimedia.org/T313193) (owner: 10Dreamy Jazz) [22:22:33] (03CR) 10Dreamy Jazz: "Fix for this patch not checking for null is in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/814371" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/813658 (https://phabricator.wikimedia.org/T310947) (owner: 10Dreamy Jazz) [22:22:41] (03CR) 10Zabe: Check for null when using UserIdentityLookup while looking up by ID (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814371 (https://phabricator.wikimedia.org/T313193) (owner: 10Dreamy Jazz) [22:24:09] (03CR) 10Dreamy Jazz: Check for null when using UserIdentityLookup while looking up by ID (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814371 (https://phabricator.wikimedia.org/T313193) (owner: 10Dreamy Jazz) [22:26:19] (03PS2) 10Dreamy Jazz: Check for null when using UserIdentityLookup while looking up by ID [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814371 (https://phabricator.wikimedia.org/T313193) [22:28:27] (03PS3) 10Dreamy Jazz: Use user ID for contributions hook instead of UserIdentityLookup [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814371 (https://phabricator.wikimedia.org/T313193) [22:29:18] (03CR) 10Dreamy Jazz: "Thanks for the thoughts." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814371 (https://phabricator.wikimedia.org/T313193) (owner: 10Dreamy Jazz) [22:30:50] 10CheckUser, 10Patch-For-Review: /wiki/Special:Contributions/172.18.0.1 Error: Call to a member function isRegistered() on null - https://phabricator.wikimedia.org/T313193 (10Dreamy_Jazz) [22:31:34] 10CheckUser, 10Patch-For-Review: /wiki/Special:Contributions/172.18.0.1 Error: Call to a member function isRegistered() on null - https://phabricator.wikimedia.org/T313193 (10Dreamy_Jazz) [22:42:09] (03CR) 10Dreamy Jazz: [C: 03+2] SpecialCheckUser: Null coalescene in execute() [extensions/CheckUser] (REL1_38) - 10https://gerrit.wikimedia.org/r/814334 (https://phabricator.wikimedia.org/T313192) (owner: 10Reedy) [22:42:28] (03CR) 10Dreamy Jazz: [C: 03+2] SpecialCheckUser: Null coalescene in execute() [extensions/CheckUser] (REL1_37) - 10https://gerrit.wikimedia.org/r/814335 (https://phabricator.wikimedia.org/T313192) (owner: 10Reedy) [22:42:45] (03CR) 10Dreamy Jazz: [C: 03+2] SpecialCheckUser: Null coalescene in execute() [extensions/CheckUser] (REL1_35) - 10https://gerrit.wikimedia.org/r/814336 (https://phabricator.wikimedia.org/T313192) (owner: 10Reedy) [22:44:27] (03Merged) 10jenkins-bot: SpecialCheckUser: Null coalescene in execute() [extensions/CheckUser] (REL1_38) - 10https://gerrit.wikimedia.org/r/814334 (https://phabricator.wikimedia.org/T313192) (owner: 10Reedy) [22:45:32] (03Merged) 10jenkins-bot: SpecialCheckUser: Null coalescene in execute() [extensions/CheckUser] (REL1_37) - 10https://gerrit.wikimedia.org/r/814335 (https://phabricator.wikimedia.org/T313192) (owner: 10Reedy) [22:45:48] (03CR) 10Zabe: [C: 03+2] Use user ID for contributions hook instead of UserIdentityLookup [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814371 (https://phabricator.wikimedia.org/T313193) (owner: 10Dreamy Jazz) [22:47:03] (03Merged) 10jenkins-bot: SpecialCheckUser: Null coalescene in execute() [extensions/CheckUser] (REL1_35) - 10https://gerrit.wikimedia.org/r/814336 (https://phabricator.wikimedia.org/T313192) (owner: 10Reedy) [22:59:40] 10CheckUser, 10PHP 8.1 support, 10Patch-For-Review: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541 - https://phabricator.wikimedia.org/T313192 (10Dreamy_Jazz) 05Open→03Resolved a:03Reedy Merged and backported. [23:02:31] (03Merged) 10jenkins-bot: Use user ID for contributions hook instead of UserIdentityLookup [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814371 (https://phabricator.wikimedia.org/T313193) (owner: 10Dreamy Jazz) [23:08:19] 10CheckUser, 10Patch-For-Review: /wiki/Special:Contributions/172.18.0.1 Error: Call to a member function isRegistered() on null - https://phabricator.wikimedia.org/T313193 (10Dreamy_Jazz) 05Open→03Resolved Merged. Tested locally and this has been fixed. [23:12:15] (03PS16) 10Dreamy Jazz: T311375: Show results in paginator instead of truncation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) [23:14:32] (03PS9) 10Dreamy Jazz: Move the function to log a check into a new CheckUserLogService [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814297 (https://phabricator.wikimedia.org/T247789) [23:14:41] (03PS22) 10Dreamy Jazz: Add filters that allow only searching for users or IPs [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/807217 (https://phabricator.wikimedia.org/T121190) [23:14:47] (03PS15) 10Dreamy Jazz: Add filter for established users for Get edits and Get users [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/808262 (https://phabricator.wikimedia.org/T26232) [23:15:28] (03CR) 10Tim Starling: [C: 03+2] RateLimiter: improve test coverage [core] - 10https://gerrit.wikimedia.org/r/812870 (owner: 10Daniel Kinzler) [23:35:49] (03Merged) 10jenkins-bot: RateLimiter: improve test coverage [core] - 10https://gerrit.wikimedia.org/r/812870 (owner: 10Daniel Kinzler)