[00:27:12] 10MediaWiki-Action-API: Action API: list=blocks doesn't show reblock timestamps properly - https://phabricator.wikimedia.org/T313661 (10Dragoniez) @Umherirrender Just as I explained, but let's look at **[[ https://ja.wikipedia.org/w/index.php?title=%E7%89%B9%E5%88%A5:%E3%83%AD%E3%82%B0/block&page=%E5%88%A9%E7%94... [00:27:59] (03PS5) 10Umherirrender: ParamValidator: Handle array url parameters on validation [core] - 10https://gerrit.wikimedia.org/r/773339 (https://phabricator.wikimedia.org/T304353) [00:37:34] 10MediaWiki-Action-API: Action API: list=blocks doesn't show reblock timestamps properly - https://phabricator.wikimedia.org/T313661 (10Dragoniez) But the blockID doesn't change even if the relevant user is reblocked, so the alternative is perhaps not a very good idea. I'm just wondering whether that the timesta... [00:41:02] (03CR) 10CI reject: [V: 04-1] ParamValidator: Handle array url parameters on validation [core] - 10https://gerrit.wikimedia.org/r/773339 (https://phabricator.wikimedia.org/T304353) (owner: 10Umherirrender) [00:43:13] 10MediaWiki-Action-API: Action API: list=blocks doesn't show reblock timestamps properly - https://phabricator.wikimedia.org/T313661 (10Dragoniez) >>! In T313661#8099586, @Dragoniez wrote: > But the blockID doesn't change even if the relevant user is reblocked Sorry forget about what I said in the quoted part. T... [01:06:55] (03PS10) 10MarkAHershberger: Update for php 8+ and some clean up [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/813623 (https://phabricator.wikimedia.org/T312930) [01:07:41] (03CR) 10MarkAHershberger: Update for php 8+ and some clean up (032 comments) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/813623 (https://phabricator.wikimedia.org/T312930) (owner: 10MarkAHershberger) [01:09:05] (03PS11) 10MarkAHershberger: Update for php 8+ and some clean up [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/813623 (https://phabricator.wikimedia.org/T312930) [01:26:08] (03PS1) 10Umherirrender: abstractSchema: Support 'AbstractSchema' attribute in extension.json [core] - 10https://gerrit.wikimedia.org/r/816262 (https://phabricator.wikimedia.org/T237839) [01:36:29] (03PS12) 10MarkAHershberger: Update for php 8+ and some clean up [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/813623 (https://phabricator.wikimedia.org/T312930) [01:37:17] (03CR) 10MarkAHershberger: Update for php 8+ and some clean up (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/813623 (https://phabricator.wikimedia.org/T312930) (owner: 10MarkAHershberger) [01:45:06] (03Abandoned) 10Umherirrender: ParamValidator: Handle array url parameters on validation [core] - 10https://gerrit.wikimedia.org/r/773339 (https://phabricator.wikimedia.org/T304353) (owner: 10Umherirrender) [02:28:38] 10MassMessage: Some MassMessages not reaching cywikibooks - https://phabricator.wikimedia.org/T313672 (10Rschen7754) [02:52:43] 10SectionTranslation, 10Epic: [Epic] Onboarding for Section Translation - https://phabricator.wikimedia.org/T313673 (10JFernandez-WMF) [02:57:14] 10SectionTranslation, 10Epic: Onboarding tutorial for Section Translation: Background & initial explorations. - https://phabricator.wikimedia.org/T313674 (10JFernandez-WMF) [03:03:04] 10SectionTranslation, 10Epic: Section Translation onboarding tutorial: Validation with user testing. - https://phabricator.wikimedia.org/T313676 (10JFernandez-WMF) [03:18:02] (03PS2) 10Umherirrender: abstractSchema: Support 'AbstractSchema' attribute in extension.json [core] - 10https://gerrit.wikimedia.org/r/816262 (https://phabricator.wikimedia.org/T237839) [03:21:09] 10SectionTranslation, 10Epic: Section Translation onboarding tutorial: Explorations for next iterations based on usability test results. - https://phabricator.wikimedia.org/T313677 (10JFernandez-WMF) [03:26:07] 10SectionTranslation, 10Epic: Section Translation onboarding tutorial: Design input. - https://phabricator.wikimedia.org/T313678 (10JFernandez-WMF) [03:44:58] 10SectionTranslation, 10Epic: Section Translation onboarding tutorial: Flow and steps sequence details. - https://phabricator.wikimedia.org/T313679 (10JFernandez-WMF) [03:51:45] 10SectionTranslation, 10Epic: Section Translation onboarding tutorial: Existing tutorial adjustments and added full-screens. - https://phabricator.wikimedia.org/T313680 (10JFernandez-WMF) [04:00:13] (03PS3) 10Umherirrender: abstractSchema: Support 'AbstractSchema' attribute in extension.json [core] - 10https://gerrit.wikimedia.org/r/816262 (https://phabricator.wikimedia.org/T237839) [04:35:13] (03PS1) 10Amire80: Add namespaces and linkTrail for Tswana (tn) [core] - 10https://gerrit.wikimedia.org/r/816264 [05:07:48] (03PS2) 10Gergő Tisza: Ignore cirrusExplain for incompatible dump options [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805141 [05:07:50] (03PS2) 10Gergő Tisza: Improve error logging for script errors [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805142 [05:07:52] (03PS2) 10Gergő Tisza: Allow other extensions to extend profile configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805143 [05:07:54] (03PS2) 10Gergő Tisza: Apply attribute handling to $wgCirrusSearchCompletionProfiles [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805144 [05:23:21] (03CR) 10CI reject: [V: 04-1] Apply attribute handling to $wgCirrusSearchCompletionProfiles [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805144 (owner: 10Gergő Tisza) [05:23:46] (03CR) 10CI reject: [V: 04-1] Allow other extensions to extend profile configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805143 (owner: 10Gergő Tisza) [05:24:59] (03CR) 10CI reject: [V: 04-1] Improve error logging for script errors [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805142 (owner: 10Gergő Tisza) [05:25:56] (03CR) 10Cindy-the-browser-test-bot: [V: 04-1] "I ran tests for your patch and there were some errors: clean_phantomjs_bad_syntax_Searches_that_prompt_or_not_for_new_page_creation.clean_" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805144 (owner: 10Gergő Tisza) [05:28:28] (03CR) 10CI reject: [V: 04-1] Ignore cirrusExplain for incompatible dump options [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805141 (owner: 10Gergő Tisza) [05:40:46] (03CR) 10Cindy-the-browser-test-bot: [V: 04-1] "I ran tests for your patch and there were some errors: clean_phantomjs_bad_syntax_Searches_that_prompt_or_not_for_new_page_creation.clean_" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805143 (owner: 10Gergő Tisza) [05:55:02] (03CR) 10Cindy-the-browser-test-bot: [V: 04-1] "I ran tests for your patch and there were some errors: clean_phantomjs_bad_syntax_Searches_that_prompt_or_not_for_new_page_creation.clean_" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805142 (owner: 10Gergő Tisza) [06:09:28] (03CR) 10Cindy-the-browser-test-bot: [V: 04-1] "I ran tests for your patch and there were some errors: clean_phantomjs_bad_syntax_Searches_that_prompt_or_not_for_new_page_creation.clean_" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805141 (owner: 10Gergő Tisza) [07:33:32] (03PS7) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816165 [07:34:41] 10MediaWiki-User-login-and-signup: No active login attempt is in progress for your session. - https://phabricator.wikimedia.org/T312042 (10AlexisJazz) >>! In T312042#8099494, @Aklapper wrote: > See https://www.mediawiki.org/wiki/Manual:How_to_debug/Login_problems in theory. Also, browser info and browser version... [07:35:02] (03CR) 10CI reject: [V: 04-1] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816165 (owner: 10Thomas-topway-it) [07:38:37] (03PS8) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816165 [07:40:13] (03CR) 10CI reject: [V: 04-1] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816165 (owner: 10Thomas-topway-it) [07:44:23] (03PS9) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816165 [07:45:56] (03CR) 10CI reject: [V: 04-1] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816165 (owner: 10Thomas-topway-it) [07:49:36] (03PS10) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816165 [07:52:53] (03CR) 10Thomas-topway-it: [V: 03+2 C: 03+2] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816165 (owner: 10Thomas-topway-it) [08:37:03] (03PS1) 10Fomafix: Use explicit mw.msg() instead of implicit mw.message() [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/816287 [08:46:05] (03PS5) 10Dreamy Jazz: Remove now redundant code now that the page_time index is fully renamed [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816048 [08:48:53] (03PS1) 10Fomafix: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/Wikistories] - 10https://gerrit.wikimedia.org/r/816288 [08:50:52] (03PS1) 10Fomafix: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/816289 [08:54:25] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/Wikistories] - 10https://gerrit.wikimedia.org/r/816288 (owner: 10Fomafix) [08:54:37] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/816289 (owner: 10Fomafix) [08:55:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Looks good. I will merge this soon but want to give the owners of this codebase some time to see this." [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/816287 (owner: 10Fomafix) [08:56:39] (03Merged) 10jenkins-bot: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/Wikistories] - 10https://gerrit.wikimedia.org/r/816288 (owner: 10Fomafix) [09:08:21] (03Merged) 10jenkins-bot: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/816289 (owner: 10Fomafix) [09:14:26] (03CR) 10Thomas-topway-it: [V: 03+2 C: 03+2] "This change is ready for review." [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816268 (owner: 10Thomas-topway-it) [09:14:32] (03PS2) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816268 [09:19:04] (03CR) 10Thomas-topway-it: [V: 03+2 C: 03+2] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816268 (owner: 10Thomas-topway-it) [09:21:45] 10Wiki-Loves-Monuments, 10I18n: Add missing i18n messages for the monuments database - https://phabricator.wikimedia.org/T39701 (10Ciell) Thanks Andre! [09:21:54] (03PS1) 10Dreamy Jazz: Ignore broken code coverage reports for ServiceWiring.php [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816291 [09:26:42] (03CR) 10Universal Omega: [C: 03+2] Ensure CosmosNavigation::getMenu() always returns a string [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/816269 (owner: 10Universal Omega) [09:28:01] (03PS1) 10Fomafix: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/VikiTitleIcon] - 10https://gerrit.wikimedia.org/r/816292 [09:35:32] (03PS1) 10Fomafix: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/816293 [09:39:06] (03PS1) 10Fomafix: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/816294 [09:45:07] (03CR) 10Tacsipacsi: Update for php 8+ and some clean up (032 comments) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/813623 (https://phabricator.wikimedia.org/T312930) (owner: 10MarkAHershberger) [09:45:19] (03CR) 10Zabe: [C: 03+2] Ignore broken code coverage reports for ServiceWiring.php [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816291 (owner: 10Dreamy Jazz) [10:01:38] (03Merged) 10jenkins-bot: Ignore broken code coverage reports for ServiceWiring.php [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816291 (owner: 10Dreamy Jazz) [10:29:15] (03PS4) 10Umherirrender: abstractSchema: Support 'AbstractSchema' attribute in extension.json [core] - 10https://gerrit.wikimedia.org/r/816262 (https://phabricator.wikimedia.org/T237839) [10:32:57] (03PS5) 10Umherirrender: abstractSchema: Support 'AbstractSchema' attribute in extension.json [core] - 10https://gerrit.wikimedia.org/r/816262 (https://phabricator.wikimedia.org/T237839) [10:44:56] (03PS1) 10Dreamy Jazz: Further tests for Hooks.php [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816296 (https://phabricator.wikimedia.org/T175920) [10:46:30] (03PS2) 10Dreamy Jazz: Further tests for Hooks.php [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816296 (https://phabricator.wikimedia.org/T175920) [10:47:30] (03CR) 10Sohom Datta: "One of the things missing in this patch is a PHP server-side check against loading the editinsequence portlet if no pagination is found. W" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/813328 (https://phabricator.wikimedia.org/T308098) (owner: 10Sohom Datta) [10:47:58] (03CR) 10Umherirrender: [C: 03+2] Remove now redundant code now that the page_time index is fully renamed [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816048 (owner: 10Dreamy Jazz) [10:48:52] (03CR) 10Dreamy Jazz: [C: 03+2] tests: Fix testUpdateCheckUserData for postgres [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816033 (owner: 10Umherirrender) [10:52:09] (03PS3) 10Dreamy Jazz: Further tests for Hooks.php [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816296 (https://phabricator.wikimedia.org/T175920) [10:54:14] 10Lingua Libre, 10good first task: Service > SignIt: fix "Contribute" button - https://phabricator.wikimedia.org/T313348 (10Yug) Ok. I initially went for a light dive in order to welcome you but I ended diving further and doing the job, was not expected. Anyway : - [x] contribute button fixed - [x] npm depende... [10:54:52] 10Lingua Libre, 10good first task: Service > SignIt: fix "Contribute" button - https://phabricator.wikimedia.org/T313348 (10Yug) 05Open→03Resolved a:03Yug [10:59:29] (03PS4) 10Dreamy Jazz: Further tests for Hooks.php [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816296 (https://phabricator.wikimedia.org/T175920) [11:02:36] (03CR) 10Zabe: [C: 03+2] Fix isValidRange and getIpConds tests and document test data [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816045 (https://phabricator.wikimedia.org/T175920) (owner: 10Dreamy Jazz) [11:02:39] (03CR) 10Thomas-topway-it: [V: 03+2 C: 03+2] "This change is ready for review." [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816270 (owner: 10Thomas-topway-it) [11:02:44] (03PS2) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816270 [11:03:27] (03Merged) 10jenkins-bot: tests: Fix testUpdateCheckUserData for postgres [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816033 (owner: 10Umherirrender) [11:04:36] (03CR) 10CI reject: [V: 04-1] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816270 (owner: 10Thomas-topway-it) [11:06:07] (03CR) 10Umherirrender: [C: 03+2] Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/816294 (owner: 10Fomafix) [11:06:22] (03CR) 10Umherirrender: [C: 03+2] Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/VikiTitleIcon] - 10https://gerrit.wikimedia.org/r/816292 (owner: 10Fomafix) [11:06:41] (03CR) 10Umherirrender: [C: 03+2] Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/816293 (owner: 10Fomafix) [11:09:31] (03PS3) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816270 [11:10:44] (03CR) 10Umherirrender: Further tests for Hooks.php (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816296 (https://phabricator.wikimedia.org/T175920) (owner: 10Dreamy Jazz) [11:11:02] (03CR) 10CI reject: [V: 04-1] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816270 (owner: 10Thomas-topway-it) [11:11:06] (03PS5) 10Dreamy Jazz: Further tests for Hooks.php [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816296 (https://phabricator.wikimedia.org/T175920) [11:12:48] (03PS4) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816270 [11:14:15] (03CR) 10CI reject: [V: 04-1] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816270 (owner: 10Thomas-topway-it) [11:16:57] (03CR) 10Zabe: Show results in paginator instead of truncation (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) (owner: 10Dreamy Jazz) [11:17:14] (03Merged) 10jenkins-bot: Fix isValidRange and getIpConds tests and document test data [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816045 (https://phabricator.wikimedia.org/T175920) (owner: 10Dreamy Jazz) [11:18:32] (03PS6) 10Dreamy Jazz: Further tests for Hooks.php [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816296 (https://phabricator.wikimedia.org/T175920) [11:20:18] (03CR) 10Dreamy Jazz: Further tests for Hooks.php (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816296 (https://phabricator.wikimedia.org/T175920) (owner: 10Dreamy Jazz) [11:21:02] (03Merged) 10jenkins-bot: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/816294 (owner: 10Fomafix) [11:21:06] (03Merged) 10jenkins-bot: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/VikiTitleIcon] - 10https://gerrit.wikimedia.org/r/816292 (owner: 10Fomafix) [11:21:10] (03Merged) 10jenkins-bot: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/816293 (owner: 10Fomafix) [11:28:49] (03PS5) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816270 [11:28:59] (03PS4) 10Zabe: Cleanup remains of the gu_hidden migration [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/810476 (https://phabricator.wikimedia.org/T289068) (owner: 10Majavah) [11:29:07] (03CR) 10Zabe: [C: 03+2] Cleanup remains of the gu_hidden migration [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/810476 (https://phabricator.wikimedia.org/T289068) (owner: 10Majavah) [11:29:32] (03PS24) 10Dreamy Jazz: Show results in paginator instead of truncation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) [11:31:04] (03CR) 10Dreamy Jazz: "Thanks for the useful comments. These are addressed in the latest patchset (as well as rebasing)." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) (owner: 10Dreamy Jazz) [11:31:22] (03Merged) 10jenkins-bot: Cleanup remains of the gu_hidden migration [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/810476 (https://phabricator.wikimedia.org/T289068) (owner: 10Majavah) [11:31:29] (03PS15) 10Dreamy Jazz: Move the function to log a check into a new CheckUserLogService [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814297 (https://phabricator.wikimedia.org/T247789) [11:31:58] (03PS10) 10Dreamy Jazz: Use Mustache templates on the server side for result lines in CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814376 (https://phabricator.wikimedia.org/T94735) [11:32:17] (03PS6) 10Dreamy Jazz: Remove now redundant code now that the page_time index is fully renamed [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816048 [11:49:03] (03CR) 10Thomas-topway-it: [V: 03+2 C: 03+2] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816270 (owner: 10Thomas-topway-it) [11:49:05] (03PS5) 10Esanders: Fix fetching of oldest comment in a thread [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/811348 (https://phabricator.wikimedia.org/T298617) [11:49:07] (03PS5) 10Esanders: Refactor thread summary getters [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/811388 [11:50:00] 10DiscussionTools, 10Editing-team (FY2021-22 Kanban Board), 10Patch-For-Review: Ability subscribing when there is no signature in section but a signature present in subsection - https://phabricator.wikimedia.org/T298617 (10Esanders) [11:51:39] (03CR) 10Zabe: [C: 03+2] "The patch is quite scary, but let's try it. Other stuff I might have missed can be fixed in a follow-up." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) (owner: 10Dreamy Jazz) [11:54:09] (03CR) 10jenkins-bot: Refactor thread summary getters [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/811388 (owner: 10Esanders) [11:56:19] (03CR) 10CI reject: [V: 04-1] Fix fetching of oldest comment in a thread [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/811348 (https://phabricator.wikimedia.org/T298617) (owner: 10Esanders) [12:02:33] (03PS2) 10Physikerwelt: Implement curly [services/texvcjs] - 10https://gerrit.wikimedia.org/r/816222 [12:04:25] (03PS1) 10Physikerwelt: Implement dollar [services/texvcjs] - 10https://gerrit.wikimedia.org/r/816299 [12:08:40] (03Merged) 10jenkins-bot: Show results in paginator instead of truncation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/814006 (https://phabricator.wikimedia.org/T311375) (owner: 10Dreamy Jazz) [12:10:24] (03Merged) 10jenkins-bot: Remove now redundant code now that the page_time index is fully renamed [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816048 (owner: 10Dreamy Jazz) [12:23:09] (03PS1) 10Physikerwelt: Fix coverage test [services/texvcjs] - 10https://gerrit.wikimedia.org/r/816301 [12:37:51] (03CR) 10Thomas-topway-it: [V: 03+2 C: 03+2] "This change is ready for review." [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816271 (owner: 10Thomas-topway-it) [12:37:54] (03PS2) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816271 [12:39:37] (03CR) 10CI reject: [V: 04-1] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816271 (owner: 10Thomas-topway-it) [12:53:37] 10ContentTranslation: Can't click on "Why?" link in "Translation services not available" warning - https://phabricator.wikimedia.org/T313685 (10Esanders) [12:55:02] (03PS2) 10Physikerwelt: Fix coverage test [services/texvcjs] - 10https://gerrit.wikimedia.org/r/816301 [12:56:18] (03PS3) 10Physikerwelt: Fix coverage test [services/texvcjs] - 10https://gerrit.wikimedia.org/r/816301 [12:59:49] 10ContentTranslation: Clicking "Add link" on a selected work has UX issues - https://phabricator.wikimedia.org/T313686 (10Esanders) [13:09:22] (03PS3) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816271 [13:10:47] (03CR) 10CI reject: [V: 04-1] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816271 (owner: 10Thomas-topway-it) [13:14:07] (03PS4) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816271 [13:15:44] (03CR) 10CI reject: [V: 04-1] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816271 (owner: 10Thomas-topway-it) [13:19:49] (03PS1) 10Dreamy Jazz: Disable showing the paging navigation bar until paging for Get IPs works [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816304 (https://phabricator.wikimedia.org/T311375) [13:20:25] (03PS5) 10Thomas-topway-it: update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816271 [13:22:27] (03PS2) 10Dreamy Jazz: Disable showing the paging navigation bar until paging for Get IPs works [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816304 (https://phabricator.wikimedia.org/T311375) [13:24:45] (03PS1) 10Fomafix: Use jQuery instead of HTML parsing to create elements [extensions/Theme] - 10https://gerrit.wikimedia.org/r/816305 [13:28:14] 10MediaWiki-General, 10MediaWiki-Stakeholders-Group, 10MW-1.35-notes, 10PHP 8.0 support: Make MediaWiki compatible with PHP 8 - https://phabricator.wikimedia.org/T248925 (10Bawolff) Another question - In order to declare we support php8.0, is it a requirement that we run tests in CI under php8.0 for all th... [13:30:54] (03CR) 10Thomas-topway-it: [V: 03+2 C: 03+2] update [extensions/CIForms] - 10https://gerrit.wikimedia.org/r/816271 (owner: 10Thomas-topway-it) [13:30:58] 10MediaWiki-Core-Tests, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), 10PHP 8.1 support: Failing phpunit tests on php8.1 - https://phabricator.wikimedia.org/T313663 (10Bawolff) Ok, now down to: ` There were 5 errors: 1) EtcdConfigTest::testFetchFromServerWithoutPort strlen(): Passing null to parameter #1 (... [13:34:57] (03CR) 10CI reject: [V: 04-1] Disable showing the paging navigation bar until paging for Get IPs works [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816304 (https://phabricator.wikimedia.org/T311375) (owner: 10Dreamy Jazz) [13:38:06] (03PS1) 10Brian Wolff: [php8] Don't use strlen on potentially null string [core] - 10https://gerrit.wikimedia.org/r/816306 (https://phabricator.wikimedia.org/T313663) [13:38:34] (03CR) 10Brian Wolff: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/816306 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [13:42:47] (03CR) 10Legoktm: "Excited to see this! Have you seen my ideas on T258852?" [core] - 10https://gerrit.wikimedia.org/r/816262 (https://phabricator.wikimedia.org/T237839) (owner: 10Umherirrender) [13:47:26] (03PS1) 10Brian Wolff: [php8] Suppress warnings for the null test of addIdentifierQuotes [core] - 10https://gerrit.wikimedia.org/r/816307 (https://phabricator.wikimedia.org/T313663) [13:48:17] (03CR) 10Brian Wolff: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/816307 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [13:49:44] (03PS1) 10Zabe: Omit navigation bar from 'get edits' when there are no results [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816308 (https://phabricator.wikimedia.org/T311375) [13:53:15] 10Lingua Libre, 10good first task: Service > SignIt: fix "Contribute" button - https://phabricator.wikimedia.org/T313348 (10WelpThatWorked) >>! In T313348#8099517, @Yug wrote: > Special:RecordWizard step 2 has an auto-declaration for languages mastered, where you can add French Sign Language or Kazakh sign lan... [13:54:18] 10MediaWiki-Core-Tests: Improve extension loading logic in PHPUnit's bootstrap.php - https://phabricator.wikimedia.org/T313687 (10Daimona) [13:55:59] (03PS2) 10Brian Wolff: [php8] Suppress warnings for the null test of addIdentifierQuotes [core] - 10https://gerrit.wikimedia.org/r/816307 (https://phabricator.wikimedia.org/T313663) [13:56:26] (03CR) 10Brian Wolff: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/816307 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [13:58:19] (03CR) 10MarkAHershberger: "wfm now that the typo is fixed" [core] - 10https://gerrit.wikimedia.org/r/816307 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [14:05:03] (03PS1) 10Brian Wolff: [php8.1] Suppress test warning about providing null [core] - 10https://gerrit.wikimedia.org/r/816309 (https://phabricator.wikimedia.org/T313663) [14:05:30] 10MediaWiki-General, 10MediaWiki-Stakeholders-Group, 10MW-1.35-notes, 10PHP 8.0 support: Make MediaWiki compatible with PHP 8 - https://phabricator.wikimedia.org/T248925 (10MarkAHershberger) >>! In T248925#8099843, @Bawolff wrote: > Another question - In order to declare we support php8.0, is it a requirem... [14:05:52] (03CR) 10Brian Wolff: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/816309 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [14:11:17] (03PS1) 10Physikerwelt: Ignore coverage report for fallback handlers [services/texvcjs] - 10https://gerrit.wikimedia.org/r/816310 [14:12:01] (03PS13) 10MarkAHershberger: Update for php 8+ and some clean up [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/813623 (https://phabricator.wikimedia.org/T312930) [14:13:43] (03CR) 10MarkAHershberger: Update for php 8+ and some clean up (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/813623 (https://phabricator.wikimedia.org/T312930) (owner: 10MarkAHershberger) [14:15:09] (03CR) 10MarkAHershberger: [C: 03+2] [php8] Suppress warnings for the null test of addIdentifierQuotes [core] - 10https://gerrit.wikimedia.org/r/816307 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [14:23:22] 10API-Portal: Persistent Invalid CSRF token errors - https://phabricator.wikimedia.org/T313688 (10Giftpflanze) [14:24:00] 10MediaWiki-General, 10MediaWiki-Stakeholders-Group, 10MW-1.35-notes, 10PHP 8.0 support: Make MediaWiki compatible with PHP 8 - https://phabricator.wikimedia.org/T248925 (10Falloutgen) Hello, We use mediawiki on two wikis in Wmf21 (and follow the wmf cycle) with PHP 8.1 and elasica, no problem to report si... [14:29:09] (03PS1) 10Fomafix: Replace WebRequest::getVal by WebRequest::getRawVal [extensions/Theme] - 10https://gerrit.wikimedia.org/r/816311 [14:30:28] (03Merged) 10jenkins-bot: [php8] Suppress warnings for the null test of addIdentifierQuotes [core] - 10https://gerrit.wikimedia.org/r/816307 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [14:31:16] (03PS1) 10Novem Linguae: Add filter "Articles by autopatrolled users" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/816312 (https://phabricator.wikimedia.org/T41547) [14:34:19] (03PS1) 10Brian Wolff: [php8.1] Make WikiImporterFactoryTest use better mock for ImportSource [core] - 10https://gerrit.wikimedia.org/r/816313 (https://phabricator.wikimedia.org/T313663) [14:34:55] (03CR) 10Brian Wolff: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/816313 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [14:37:16] 10MediaWiki-libs-Services, 10Release, 10Technical-Debt: Make a new release of the Services library - https://phabricator.wikimedia.org/T303227 (10MarkAHershberger) For some reason, {T300840} bit me today. Using dev-master of this library worked. Is there any opposition to tagging HEAD with 3.0.0 so compose... [14:38:33] 10CheckUser, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18): Display link of checkuser actions done by the user in contributions page only for CheckUsers - https://phabricator.wikimedia.org/T310947 (10AntiCompositeNumber) 05Open→03Declined Task as stated is Declined per discussion. [14:42:45] 10MediaWiki-Authentication-and-authorization: After log in on mobile Beta Commons, "No active login attempt is in progress for your session." (centralauth-error-badtoken) is displayed - https://phabricator.wikimedia.org/T312042 (10Aklapper) [14:42:51] 10MediaWiki-Authentication-and-authorization: After log in on mobile Beta Commons, "No active login attempt is in progress for your session." (centralauth-error-badtoken) is displayed - https://phabricator.wikimedia.org/T312042 (10Aklapper) [14:43:13] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10MobileFrontend (Tracking): CentralAuth edge login and autologin for some Wikimedia domains broken on mobile - https://phabricator.wikimedia.org/T257852 (10Aklapper) [14:43:56] 04(no projects): Dialog buttons not working in Chromium clones - https://phabricator.wikimedia.org/T313690 (10Nux) [14:58:02] 10MediaWiki-Page-editing, 10DiscussionTools: Non-existent talk page archives should not have "start a discussion" button - https://phabricator.wikimedia.org/T312560 (10Spinningspark) >>! In T312560#8062374, @Esanders wrote: > Agreed. Navigating to a non-existent archive page is certainly an edge case limited t... [14:59:13] 04(no projects): Persistent Invalid CSRF token errors - https://phabricator.wikimedia.org/T313688 (10Aklapper) (Removing #API-Portal as this sounds unrelated to api.wikimedia.org) What login method is used? Where to find the source code of these bots? [15:02:29] 04(no projects): Dialog buttons not working in Chromium clones - https://phabricator.wikimedia.org/T313690 (10Nux) Tested to make sure this is not specific to plwiki. I can reproduce on fwiki by removing contents of one of required fields: https://fr.wikipedia.org/wiki/Ursidae?veaction=edit Same also on enwiki:... [15:07:21] 10Wikimedia-DC: Fix svg rendering on wmdc sites - https://phabricator.wikimedia.org/T115174 (10Aklapper) 05Open→03Stalled @Isarra: If there are broken SVG files somewhere then please provide URLs, or a link to some changes that backed out SVGs to revert, or generally more context. Thanks. [15:09:21] (03PS2) 10Fomafix: Replace WebRequest::getVal by WebRequest::getRawVal [extensions/Theme] - 10https://gerrit.wikimedia.org/r/816311 [15:11:00] (03CR) 10CI reject: [V: 04-1] Replace WebRequest::getVal by WebRequest::getRawVal [extensions/Theme] - 10https://gerrit.wikimedia.org/r/816311 (owner: 10Fomafix) [15:12:48] 10MediaWiki-Email: Mail notifications should include key data as mail headers - https://phabricator.wikimedia.org/T87273 (10Aklapper) [15:18:34] 04(no projects): Persistent Invalid CSRF token errors - https://phabricator.wikimedia.org/T313688 (10Giftpflanze) The bots authenticate via OAuth owner-only consumers. The source code is in ~taxonbot on the instance taxonbot.dwl on WMCS. [15:20:48] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10MobileFrontend (Tracking): CentralAuth edge login and autologin for some Wikimedia domains broken on mobile - https://phabricator.wikimedia.org/T257852 (10AlexisJazz) I sort of doubt T312042 is a dupe of this. `A megadott hit... [15:27:08] 10WMF-General-or-Unknown: 404 page is wrong on sister projects when path starts with /w/ - https://phabricator.wikimedia.org/T56357 (10Aklapper) p:05Medium→03Low [15:32:16] 10WMF-General-or-Unknown: 504 Gateway timeout when editing through API - https://phabricator.wikimedia.org/T45046 (10Aklapper) @Strainu: 9 years later, is this still an issue, or can this ticket be closed? :-/ [15:37:57] (03PS3) 10Fomafix: Replace WebRequest::getVal by WebRequest::getRawVal [extensions/Theme] - 10https://gerrit.wikimedia.org/r/816311 [15:38:15] 04(no projects): Dialog buttons not working in Chromium clones - https://phabricator.wikimedia.org/T313690 (10Nux) The problem seem to be in `inert` attribute mostly. You can remove all those attributes to unlock buttons: ` $('[inert]').attr('inert', null) ` **But** when your press ESC in that dialog it is kep... [15:52:00] (03PS3) 10Dreamy Jazz: Disable showing the paging navigation bar until paging for Get IPs works [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816304 (https://phabricator.wikimedia.org/T311375) [15:54:25] 04(no projects): Dialog buttons not working in Chromium clones - https://phabricator.wikimedia.org/T313690 (10Nux) [16:08:32] (03CR) 10Zabe: [C: 03+2] Disable showing the paging navigation bar until paging for Get IPs works [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816304 (https://phabricator.wikimedia.org/T311375) (owner: 10Dreamy Jazz) [16:18:50] 10MediaWiki-libs-Services, 10Release, 10Technical-Debt: Make a new release of the Services library - https://phabricator.wikimedia.org/T303227 (10Reedy) [16:22:55] (03Merged) 10jenkins-bot: Disable showing the paging navigation bar until paging for Get IPs works [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816304 (https://phabricator.wikimedia.org/T311375) (owner: 10Dreamy Jazz) [16:24:43] (03PS1) 10Reedy: Upgrade wikimedia/scoped-callback and wikimedia/services [vendor] - 10https://gerrit.wikimedia.org/r/816314 (https://phabricator.wikimedia.org/T303227) [16:28:32] (03PS1) 10Reedy: Upgrade wikimedia/scoped-callback and wikimedia/services [core] - 10https://gerrit.wikimedia.org/r/816315 (https://phabricator.wikimedia.org/T303227) [16:30:27] 10Reading-Web-Local-Wiki-Issues, 10Patch-For-Review: StickyTableHeader (gadget) on English Wikipedia hidden behind top header in Vector Skin 2022 - https://phabricator.wikimedia.org/T313187 (10PutzfetzenORG) Nice, I already see the Sticky Headers with the Vector Skin in action on the EN Wikipedia. So much bet... [16:32:46] (03PS1) 10Reedy: Make ReadOnlyModeTest work in php8. [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816275 (https://phabricator.wikimedia.org/T313663) [16:32:58] (03CR) 10Reedy: [C: 03+2] Make ReadOnlyModeTest work in php8. [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816275 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:33:24] (03PS1) 10Reedy: Make HandlerTestTrait compatible with php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816277 (https://phabricator.wikimedia.org/T313663) [16:33:38] (03PS2) 10Reedy: Make HandlerTestTrait compatible with php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816277 (https://phabricator.wikimedia.org/T313663) [16:33:43] (03CR) 10Reedy: [C: 03+2] Make HandlerTestTrait compatible with php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816277 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:33:57] (03PS1) 10Reedy: Make HandlerTestTrait compatible with php8.1 [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/816278 (https://phabricator.wikimedia.org/T313663) [16:34:04] (03CR) 10Reedy: [C: 03+2] Make HandlerTestTrait compatible with php8.1 [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/816278 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:34:14] (03PS1) 10Reedy: Make HandlerTestTrait compatible with php8.1 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/816279 (https://phabricator.wikimedia.org/T313663) [16:34:23] (03CR) 10Reedy: [C: 03+2] Make HandlerTestTrait compatible with php8.1 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/816279 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:35:06] 10MediaWiki-Core-Tests, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), 10PHP 8.1 support, 10Patch-For-Review: Failing phpunit tests on php8.1 - https://phabricator.wikimedia.org/T313663 (10Reedy) [16:36:46] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2022-July-September), 10Patch-For-Review, 10Regression: Marking translations as reviewed fails - https://phabricator.wikimedia.org/T313608 (10abi_) p:05Triage→03High a:03abi_ [16:38:42] (03CR) 10CI reject: [V: 04-1] add type returns and params to CosmosNavigation [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/816273 (owner: 10Universal Omega) [16:42:36] (03Merged) 10jenkins-bot: Make HandlerTestTrait compatible with php8.1 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/816279 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:42:46] (03PS4) 10Universal Omega: add type returns and params to CosmosNavigation [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/816273 [16:44:18] (03Merged) 10jenkins-bot: Make ReadOnlyModeTest work in php8. [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816275 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:44:29] (03PS4) 10Fomafix: Replace WebRequest::getVal by WebRequest::getRawVal [extensions/Theme] - 10https://gerrit.wikimedia.org/r/816311 [16:45:08] (03Merged) 10jenkins-bot: Make HandlerTestTrait compatible with php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816277 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:45:13] (03Merged) 10jenkins-bot: Make HandlerTestTrait compatible with php8.1 [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/816278 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:48:25] (03PS1) 10Reedy: [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816280 (https://phabricator.wikimedia.org/T313663) [16:48:32] (03CR) 10Reedy: [C: 03+2] [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816280 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:48:41] (03PS1) 10Reedy: [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/816281 (https://phabricator.wikimedia.org/T313663) [16:49:06] (03CR) 10Reedy: [C: 03+2] [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/816281 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:52:52] (03CR) 10CI reject: [V: 04-1] [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816280 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:52:59] (03PS5) 10Universal Omega: add type returns and params to CosmosNavigation [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/816273 [16:53:37] (03CR) 10CI reject: [V: 04-1] [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/816281 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [16:56:21] (03PS2) 10Reedy: [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816280 (https://phabricator.wikimedia.org/T313663) [16:56:33] (03PS2) 10Reedy: [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/816281 (https://phabricator.wikimedia.org/T313663) [17:00:25] 10Wikimedia-Extension-setup: add WikiLove extension in ptwikinews - https://phabricator.wikimedia.org/T313173 (10Stang) a:03Stang [17:01:50] (03Abandoned) 10Reedy: [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816280 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [17:01:55] (03Abandoned) 10Reedy: [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/816281 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [17:05:35] (03CR) 10Universal Omega: [C: 03+2] add type returns and params to CosmosNavigation [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/816273 (owner: 10Universal Omega) [17:15:26] (03Merged) 10jenkins-bot: add type returns and params to CosmosNavigation [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/816273 (owner: 10Universal Omega) [17:21:01] (03PS1) 10Stang: DisableAccount: Copy blockDisabledAccounts.php to this repo [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/816317 (https://phabricator.wikimedia.org/T106068) [17:22:28] (03CR) 10CI reject: [V: 04-1] DisableAccount: Copy blockDisabledAccounts.php to this repo [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/816317 (https://phabricator.wikimedia.org/T106068) (owner: 10Stang) [17:23:13] (03PS2) 10Stang: DisableAccount: Copy blockDisabledAccounts.php to this repo [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/816317 (https://phabricator.wikimedia.org/T106068) [17:26:24] (03PS1) 10Physikerwelt: Improve test coverage for identifiers [services/texvcjs] - 10https://gerrit.wikimedia.org/r/816318 [17:32:23] (03CR) 10Dreamy Jazz: [C: 03+2] Omit navigation bar from 'get edits' when there are no results [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816308 (https://phabricator.wikimedia.org/T311375) (owner: 10Zabe) [17:33:57] (03CR) 10MarkAHershberger: [C: 03+2] [php8.1] Suppress test warning about providing null [core] - 10https://gerrit.wikimedia.org/r/816309 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [17:34:40] (03CR) 10MarkAHershberger: [C: 03+2] Upgrade wikimedia/scoped-callback and wikimedia/services [core] - 10https://gerrit.wikimedia.org/r/816315 (https://phabricator.wikimedia.org/T303227) (owner: 10Reedy) [17:39:01] 10Codex: Add Checkbox component to Codex - https://phabricator.wikimedia.org/T293384 (10Volker_E) 05Open→03Resolved Thanks for the catch @ldelench_wmf. I think that got stalled on subtask T304911 that I've filed and Checkbox, Radio both got resolved successfully in initial release v0.1.0-alpha.1 at 2022-02-1... [17:39:24] (03CR) 10MarkAHershberger: [C: 03+2] [php8.1] Make WikiImporterFactoryTest use better mock for ImportSource [core] - 10https://gerrit.wikimedia.org/r/816313 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [17:41:12] 10Codex: Add Radio component to Codex - https://phabricator.wikimedia.org/T293270 (10Volker_E) 05Open→03Resolved Got reviewed and resolved successfully in initial #Codex release v0.1.0-alpha.1 at 2022-02-14. [17:41:30] (03PS1) 10Fomafix: Use UserOptionsLookup::getOption instead of deprecated User::getOption [extensions/Theme] - 10https://gerrit.wikimedia.org/r/816320 (https://phabricator.wikimedia.org/T296083) [17:43:34] (03CR) 10CI reject: [V: 04-1] Use UserOptionsLookup::getOption instead of deprecated User::getOption [extensions/Theme] - 10https://gerrit.wikimedia.org/r/816320 (https://phabricator.wikimedia.org/T296083) (owner: 10Fomafix) [17:43:49] 10Codex, 10Design-Systems-Team: Select: Entering a long default label extends the component's maxLength - https://phabricator.wikimedia.org/T310399 (10Volker_E) [17:43:54] (03CR) 10MarkAHershberger: [C: 03+2] [php8] Don't use strlen on potentially null string [core] - 10https://gerrit.wikimedia.org/r/816306 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [17:48:56] (03CR) 10Lakejason0: "This change is ready for review." [extensions/MultiBoilerplate] - 10https://gerrit.wikimedia.org/r/816285 (owner: 10Lakejason0) [17:49:56] (03Merged) 10jenkins-bot: Omit navigation bar from 'get edits' when there are no results [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/816308 (https://phabricator.wikimedia.org/T311375) (owner: 10Zabe) [17:51:07] 10WMF-General-or-Unknown: Contributions list for "Conversion script" account on the English Wikipedia is wonky - https://phabricator.wikimedia.org/T45212 (10Aklapper) 05Open→03Declined p:05Medium→03Lowest Not a good use of anyone's time to look into this >20 years later. Boldly declining. [17:51:31] (03CR) 10Lakejason0: "This change is ready for review." [extensions/MultiBoilerplate] - 10https://gerrit.wikimedia.org/r/816326 (owner: 10Lakejason0) [17:52:11] (03Merged) 10jenkins-bot: [php8.1] Suppress test warning about providing null [core] - 10https://gerrit.wikimedia.org/r/816309 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [17:52:59] 10MediaWiki-Search, 10Discovery-Search: Running a second query on Special:Search should keep displayed number of results ("limit" parameter) - https://phabricator.wikimedia.org/T25449 (10Aklapper) [17:54:25] 10MediaWiki-Installer: During install, should do some check to make sure load.php output doesn't have random analytics code appended - https://phabricator.wikimedia.org/T35951 (10Aklapper) [17:54:49] (03PS3) 10Lakejason0: Special pages not found in 1.38.2 [extensions/MultiBoilerplate] - 10https://gerrit.wikimedia.org/r/816285 [17:55:58] (03PS3) 10Lakejason0: Add alias for Chinese (Both) [extensions/MultiBoilerplate] - 10https://gerrit.wikimedia.org/r/816326 [17:56:48] (03Merged) 10jenkins-bot: [php8.1] Make WikiImporterFactoryTest use better mock for ImportSource [core] - 10https://gerrit.wikimedia.org/r/816313 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [18:00:49] (03Merged) 10jenkins-bot: [php8] Don't use strlen on potentially null string [core] - 10https://gerrit.wikimedia.org/r/816306 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [18:00:56] 10WMF-General-or-Unknown, 10Pageviews-Anomaly: Suspiciously high pageviews for "undefined" pages in all wikimedia projects - https://phabricator.wikimedia.org/T40604 (10Aklapper) 05Open→03Declined Issue from 10 years ago, no capacity/priority to check nowadays I'm afraid. [18:10:24] (03CR) 10FreedomFighterSparrow: "This looks like it could be a problem in the future - as the Chinese translation uses '样板', which is apparently MW's official translation " [extensions/MultiBoilerplate] - 10https://gerrit.wikimedia.org/r/816326 (owner: 10Lakejason0) [18:11:23] 10MediaWiki-Installer: "enter your wiki" on final page of installer appears as an external link - https://phabricator.wikimedia.org/T67279 (10Aklapper) 05Open→03Resolved Assuming that this refers to the visual decoration of external links, this isn't the case anymore: https://commons.wikimedia.org/wiki/File:... [18:16:12] 10MediaWiki-Installer: Un-bundle (remove) LocalisationUpdate extension from bundled MediaWiki extensions - https://phabricator.wikimedia.org/T54060 (10Aklapper) 05Open→03Resolved Resolved as part of T300498 [18:16:14] 10MediaWiki-Installer, 10Tracking-Neverending: Installer: extensions improvements: descriptions, alternatives, multiselection, configuration (tracking) - https://phabricator.wikimedia.org/T33279 (10Aklapper) [18:18:06] (03PS2) 10Fomafix: Use UserOptionsLookup::getOption instead of deprecated User::getOption [extensions/Theme] - 10https://gerrit.wikimedia.org/r/816320 (https://phabricator.wikimedia.org/T296083) [18:24:42] 10MediaWiki-Maintenance-system: Clean up list of default interwikis - https://phabricator.wikimedia.org/T71997 (10Aklapper) [18:35:34] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2022-July-September): TUX extends beyond the screen width with Vector 2022 skin - https://phabricator.wikimedia.org/T313671 (10abi_) p:05Triage→03High a:03abi_ I am able to reproduce this locally with the following configuration set: ` $wgVecto... [18:35:58] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2022-July-September): TUX extends beyond the screen width with Vector 2022 skin - https://phabricator.wikimedia.org/T313671 (10abi_) a:05abi_→03None [18:44:18] (03PS1) 10Fomafix: Use explicit mw.msg() instead of implicit mw.message() [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/816321 [18:46:14] (03CR) 10Lakejason0: Add alias for Chinese (Both) (031 comment) [extensions/MultiBoilerplate] - 10https://gerrit.wikimedia.org/r/816326 (owner: 10Lakejason0) [18:46:29] (03PS1) 10Fomafix: Use shortcut mw.msg( ... ) instead of mw.message( ... ).text() [extensions/PageCheckout] - 10https://gerrit.wikimedia.org/r/816322 [18:52:50] (03CR) 10Lakejason0: Add alias for Chinese (Both) (031 comment) [extensions/MultiBoilerplate] - 10https://gerrit.wikimedia.org/r/816326 (owner: 10Lakejason0) [18:55:49] 10Design, 10Codex, 10Design-Systems-Team: [Epic] Design and define design tokens for the Wikimedia Design System - https://phabricator.wikimedia.org/T293127 (10Volker_E) [18:56:03] (03PS1) 10Fomafix: Remove Byte Order Mark (U+FEFF) from JavaScript files [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/816324 [19:04:58] 10Accessibility, 10MediaWiki-extensions-SecurePoll, 10Patch-For-Review: "Thrown out" votes in SecurePoll are difficult to distinguish from live votes - https://phabricator.wikimedia.org/T308960 (10Stang) p:05Triage→03Medium > Something like #EB000 with a strikeout may work I just wonder if it's acceptabl... [19:05:01] 10TitleBlacklist, 10Patch-For-Review: TitleBlacklist should support customized RestrictionLevels - https://phabricator.wikimedia.org/T311006 (10Stang) p:05Triage→03Medium [19:19:59] (03CR) 10Samtar: [C: 03+2] Use Shellbox for in EspeakEngine [extensions/Phonos] - 10https://gerrit.wikimedia.org/r/816043 (https://phabricator.wikimedia.org/T313556) (owner: 10MusikAnimal) [19:21:46] (03CR) 10Samtar: [C: 03+2] Move tag menu "Mark as reviewed" check box [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/816240 (https://phabricator.wikimedia.org/T313651) (owner: 10Novem Linguae) [19:22:01] (03Merged) 10jenkins-bot: Use Shellbox for in EspeakEngine [extensions/Phonos] - 10https://gerrit.wikimedia.org/r/816043 (https://phabricator.wikimedia.org/T313556) (owner: 10MusikAnimal) [19:23:51] 10WMIT-Infrastructure: Adopt VisualEditor in wiki.wikimedia.it - https://phabricator.wikimedia.org/T268529 (10valerio.bozzolan) I was able to install, adopt and use VisualEditor after playing with {T310607}. The wiki is still semi-private. It works since VisualEditor do internal loopback connections to itself p... [19:24:05] (03CR) 10Samtar: [C: 03+2] Remove cuSearchType from contribs target link as it's no longer used [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/815819 (owner: 10Dreamy Jazz) [19:26:55] (03Merged) 10jenkins-bot: Move tag menu "Mark as reviewed" check box [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/816240 (https://phabricator.wikimedia.org/T313651) (owner: 10Novem Linguae) [19:38:03] (03Merged) 10jenkins-bot: Remove cuSearchType from contribs target link as it's no longer used [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/815819 (owner: 10Dreamy Jazz) [19:54:11] (03CR) 10VolkerE: [C: 03+1] "Thanks!" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/816126 (owner: 10Ladsgroup) [20:08:53] 10Design, 10Codex, 10Design-Systems-Team (Design-Systems-Sprint): Define the system's typographic scale (sizes and line-heights) - https://phabricator.wikimedia.org/T305947 (10Volker_E) [20:12:27] 10Design, 10Codex, 10Design-Systems-Team (Design-Systems-Sprint): Define the system's typographic scale (sizes and line-heights) - https://phabricator.wikimedia.org/T305947 (10Volker_E) The Typographic scale is caring for font-size and line-height tokens and is currently in v5 exploration phase. It doesn't n... [20:16:50] 10Wikimedia-Extension-setup, 10I18n, 10Wikimedia-extension-review-queue: Review and deploy FormatNum extension - https://phabricator.wikimedia.org/T42422 (10Stang) FormatNum has been archived. This request could be switched to [[ https://www.mediawiki.org/wiki/Extension:NumberFormat | Extension:NumberFormat... [20:27:36] 10MediaWiki-Authentication-and-authorization: Increased rate of warnings from MediaWiki\\Session\\MetadataMergeException - https://phabricator.wikimedia.org/T313426 (10Aklapper) [20:32:57] 10Design, 10Codex, 10Design-Systems-Team (Design-Systems-Sprint): Implement system typeface choices in Codex tokens - https://phabricator.wikimedia.org/T313693 (10Volker_E) [20:45:11] (03CR) 10Jhf2442: "Haven't tried 1.38 yet, but in my understanding, the entry only adds a new intem (and a mapping to a callback class), whose name can be fr" [extensions/MultiBoilerplate] - 10https://gerrit.wikimedia.org/r/816285 (owner: 10Lakejason0) [20:46:08] 10Design, 10Codex, 10Design-Systems-Team (Design-Systems-Sprint): Implement system typeface choices in Codex tokens - https://phabricator.wikimedia.org/T313693 (10Volker_E) [20:46:14] (03CR) 10Jhf2442: "Not speaking chinese, therefore I abstain myself from evaluating the change" [extensions/MultiBoilerplate] - 10https://gerrit.wikimedia.org/r/816326 (owner: 10Lakejason0) [20:54:29] 10PHP 8.1 support: CSP errors in 8.1 - https://phabricator.wikimedia.org/T313694 (10MarkAHershberger) [20:54:58] (03CR) 10FreedomFighterSparrow: Special pages not found in 1.38.2 (031 comment) [extensions/MultiBoilerplate] - 10https://gerrit.wikimedia.org/r/816285 (owner: 10Lakejason0) [20:57:02] 10WMF-General-or-Unknown: 504 Gateway timeout when editing through API - https://phabricator.wikimedia.org/T45046 (10Strainu) I think it can be closed, I haven't seen a 504 in a long time. [20:58:00] (03PS1) 10MarkAHershberger: Ensure URL is a string for ContentSecurityPolicy::prepareUrlForCSP [core] - 10https://gerrit.wikimedia.org/r/816347 (https://phabricator.wikimedia.org/T313694) [21:33:13] (03CR) 10Pastakhov: [C: 03+1] Ignore "fileexists-no-change" errors on images uploading [extensions/Push] - 10https://gerrit.wikimedia.org/r/667157 (owner: 10Vedmaka Wakalaka) [21:46:38] (03CR) 10Universal Omega: [C: 03+2] Use SpecialPage::getTitleFor() to get special page titles [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/816284 (owner: 10Universal Omega) [21:54:37] (03Merged) 10jenkins-bot: Use SpecialPage::getTitleFor() to get special page titles [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/816284 (owner: 10Universal Omega) [21:56:44] (03CR) 10MarkAHershberger: [C: 03+2] Allow composer/installers plugin in composer.json [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/816068 (owner: 10MarkAHershberger) [21:57:24] 10Utilities-grabbers: grabFiles.php broken in MediaWiki 1.38 due to MediaWiki API changes - https://phabricator.wikimedia.org/T313404 (10Ciencia_Al_Poder) a:03Ciencia_Al_Poder [22:02:59] (03PS1) 10Physikerwelt: Remove unused statement in subscript handling [services/texvcjs] - 10https://gerrit.wikimedia.org/r/816348 [22:03:33] (03PS1) 10Martineznovo: Compatibility changes for MediaWiki 1.35-1.38 [tools/grabbers] - 10https://gerrit.wikimedia.org/r/816349 (https://phabricator.wikimedia.org/T313404) [22:04:34] (03Merged) 10jenkins-bot: Allow composer/installers plugin in composer.json [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/816068 (owner: 10MarkAHershberger) [22:14:12] 10DiscussionTools: New Topic tool's empty state message displaying when there are conversations on the page - https://phabricator.wikimedia.org/T313695 (10Whatamidoing-WMF) [22:18:46] (03PS1) 10MarkAHershberger: bump wikimedia/services [core] - 10https://gerrit.wikimedia.org/r/816350 (https://phabricator.wikimedia.org/T303227) [22:19:34] (03Abandoned) 10MarkAHershberger: bump wikimedia/services [core] - 10https://gerrit.wikimedia.org/r/816350 (https://phabricator.wikimedia.org/T303227) (owner: 10MarkAHershberger) [22:21:02] (03CR) 10MarkAHershberger: "Thought I was on REL1_35 where I thought it was failing." [core] - 10https://gerrit.wikimedia.org/r/816350 (https://phabricator.wikimedia.org/T303227) (owner: 10MarkAHershberger) [22:21:36] (03PS2) 10TsepoThoabala: Layout shift when IP Info arrives into expanded state insufficient height reserved [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/812438 (https://phabricator.wikimedia.org/T306746) [22:38:01] (03PS3) 10Gergő Tisza: Ignore cirrusExplain for incompatible dump options [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805141 [22:38:03] (03PS3) 10Gergő Tisza: Improve error logging for script errors [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805142 [22:38:05] (03PS3) 10Gergő Tisza: Allow other extensions to extend profile configuration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805143 [22:38:07] (03PS3) 10Gergő Tisza: Apply attribute handling to $wgCirrusSearchCompletionProfiles [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805144 [22:38:46] (03PS1) 10Josepharhar: Make sections expandable by find-in-page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/816351 (https://phabricator.wikimedia.org/T239295) [22:41:41] 10MobileFrontend, 10Desktop Improvements, 10Readers-Web-Backlog, 10Patch-For-Review, and 4 others: Use display locking to allow browser's native "Find in page" function to work with collapsed sections - https://phabricator.wikimedia.org/T216789 (10Josepharhar) I started on a patch here: https://gerrit.wiki... [23:00:44] (03CR) 10Cindy-the-browser-test-bot: [V: 04-1] "I ran tests for your patch and there were some errors: clean_phantomjs_bad_syntax_Searches_that_prompt_or_not_for_new_page_creation.clean_" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805143 (owner: 10Gergő Tisza) [23:05:10] 10MediaWiki-Page-editing, 10DiscussionTools: Non-existent talk page archives should not have "start a discussion" button - https://phabricator.wikimedia.org/T312560 (10Xaosflux) @Spinningspark based on your last note, would you agree this is a request for new functionality to be designed and implemented (a fea... [23:14:53] (03CR) 10Cindy-the-browser-test-bot: [V: 04-1] "I ran tests for your patch and there were some errors: clean_phantomjs_bad_syntax_Searches_that_prompt_or_not_for_new_page_creation.clean_" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805142 (owner: 10Gergő Tisza) [23:17:41] (03CR) 10Legoktm: [C: 03+2] .gitattributes: Ignore build folder [libs/Services] - 10https://gerrit.wikimedia.org/r/816274 (owner: 10Reedy) [23:18:25] (03Merged) 10jenkins-bot: .gitattributes: Ignore build folder [libs/Services] - 10https://gerrit.wikimedia.org/r/816274 (owner: 10Reedy) [23:24:27] 10Inuka-Team (Kanban), 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), 10Wikistories (R2): It is hard to tell what the CTA to create a WikiStory informs a user to do - https://phabricator.wikimedia.org/T308247 (10EUdoh-WMF) **Testing:** 1. For wiki pages that have images, the first image is used as the CTA imag... [23:29:18] (03CR) 10Cindy-the-browser-test-bot: [V: 04-1] "I ran tests for your patch and there were some errors: clean_phantomjs_bad_syntax_Searches_that_prompt_or_not_for_new_page_creation.clean_" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805144 (owner: 10Gergő Tisza) [23:33:55] 10MediaWiki-Authentication-and-authorization: After log in on mobile Beta Commons, "No active login attempt is in progress for your session." (centralauth-error-nologinattempt) is displayed - https://phabricator.wikimedia.org/T312042 (10Tgr) [23:43:40] (03CR) 10Cindy-the-browser-test-bot: [V: 04-1] "I ran tests for your patch and there were some errors: clean_phantomjs_bad_syntax_Searches_that_prompt_or_not_for_new_page_creation.clean_" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805141 (owner: 10Gergő Tisza) [23:43:48] 10MediaWiki-Authentication-and-authorization: After log in on mobile Beta Commons, user gets redirected to non-mobile page (and is not logged in there) - https://phabricator.wikimedia.org/T312042 (10Tgr) [23:51:36] 10MediaWiki-Authentication-and-authorization: After log in on mobile Beta Commons, user gets redirected to non-mobile page (and is not logged in there) - https://phabricator.wikimedia.org/T312042 (10Tgr) 05duplicate→03Open I guess something relating to mobile site autodetection / autoredirect is misconfigure... [23:52:40] (03CR) 10Gergő Tisza: "I think the Cindy errors here and in the child patches are bogus." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/805141 (owner: 10Gergő Tisza) [23:56:51] (03CR) 10Tacsipacsi: Add wikiquote.org to the new portal (031 comment) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/812898 (https://phabricator.wikimedia.org/T273179) (owner: 10Ladsgroup)