[00:01:00] (03CR) 10CI reject: [V: 04-1] build: Updating npm dependencies [services/change-propagation] - 10https://gerrit.wikimedia.org/r/818519 (owner: 10Libraryupgrader) [00:13:08] (03Merged) 10jenkins-bot: Parsoid Parser Tests: Fix test processing to update knownFailures [core] - 10https://gerrit.wikimedia.org/r/817870 (owner: 10Subramanya Sastry) [00:18:37] 10MediaWiki-extensions-SecurePoll: Use error message widget on VotePage [L] - https://phabricator.wikimedia.org/T279570 (10jrbs) It might also be nice if these messages were shown "live", so that voters don't have to re-select their options if they hit this error. [00:20:39] (03CR) 10Krinkle: [C: 04-1] Merge ext.flow.jquery.findWithParent into ext.flow.components [extensions/Flow] - 10https://gerrit.wikimedia.org/r/802625 (https://phabricator.wikimedia.org/T292245) (owner: 10DannyS712) [00:21:05] (03CR) 10Krinkle: "Consider de-basing this from I7c31bdc5881b333 as it LGTM on its own." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/802826 (https://phabricator.wikimedia.org/T292245) (owner: 10DannyS712) [00:25:11] 10MediaWiki-extensions-SecurePoll, 10MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), 10Wikimedia-production-error: SecurePoll doing DB writes to securepoll_voters on HTTP GET [Timebox: 8h] - https://phabricator.wikimedia.org/T288784 (10jrbs) Since we're now actively using the processes this task discusses for the... [00:26:40] 10MediaWiki-extensions-SecurePoll: SecurePoll: Fatal exception of type "Wikimedia\Rdbms\DBTransactionSizeError" when submitting a translation - https://phabricator.wikimedia.org/T288831 (10jrbs) I don't believe this is an active problem. >>! In T288831#7282852, @tstarling wrote: > That's a temporary fix. I thin... [00:28:20] 10MediaWiki-extensions-SecurePoll: SecurePoll: You must log in to vote in this election [Timebox: 8h] - https://phabricator.wikimedia.org/T288839 (10jrbs) p:05Medium→03Low Boldly lowering the priority. This should only impact people who have an account and are logged in on votewiki, which is deliberately a v... [00:31:52] 10DiscussionTools, 10Editing-team (Tracking): Implement editing specific comments - https://phabricator.wikimedia.org/T245225 (10ppelberg) [00:38:28] 10MediaWiki-General, 10MW-1.35-notes, 10MW-1.37-notes, 10MW-1.38-notes, and 2 others: PHP 8.2: ${var} style string interpolation is deprecated - https://phabricator.wikimedia.org/T314096 (10Reedy) [00:39:50] (03PS1) 10Reedy: preprocessor: Add missing field declarations [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818419 (https://phabricator.wikimedia.org/T314099) [00:39:56] (03CR) 10Reedy: [C: 03+2] preprocessor: Add missing field declarations [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818419 (https://phabricator.wikimedia.org/T314099) (owner: 10Reedy) [00:40:05] 10DiscussionTools: Enable people to quickly "jump" back to the top of a talk page section - https://phabricator.wikimedia.org/T314203 (10ppelberg) [00:40:06] (03PS1) 10Reedy: preprocessor: Add missing field declarations [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/818420 (https://phabricator.wikimedia.org/T314099) [00:40:17] (03CR) 10Reedy: [C: 03+2] preprocessor: Add missing field declarations [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/818420 (https://phabricator.wikimedia.org/T314099) (owner: 10Reedy) [00:42:08] 10DiscussionTools: Enable people to quickly "jump" back to the top of a talk page - https://phabricator.wikimedia.org/T314204 (10ppelberg) [00:42:34] 10MediaWiki-extensions-SecurePoll: Drop old board election scripts - https://phabricator.wikimedia.org/T298455 (10jrbs) I think this is now done - though perhaps we can add this to the Wikitech SecurePoll documentation (to also delete the previous year's Board elections scripts when updating for current year) [00:44:21] 10MediaWiki-extensions-SecurePoll: Replace 2021 board election hack with proper fix - https://phabricator.wikimedia.org/T303135 (10jrbs) Would this need to be implemented again for 2022? [00:45:03] 10DiscussionTools, 10Editing-team (Design Backlog): Enable talk page topics to be collapsed and expanded - https://phabricator.wikimedia.org/T269954 (10ppelberg) [00:46:30] 10DiscussionTools: Enable people to use Topic Containers to reveal the usernames of the people participating in a discussion - https://phabricator.wikimedia.org/T309752 (10ppelberg) [00:50:51] (03Merged) 10jenkins-bot: preprocessor: Add missing field declarations [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818419 (https://phabricator.wikimedia.org/T314099) (owner: 10Reedy) [00:53:27] (03Merged) 10jenkins-bot: preprocessor: Add missing field declarations [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/818420 (https://phabricator.wikimedia.org/T314099) (owner: 10Reedy) [01:02:02] 10Design-Systems-Team: Make eslint-config-wikimedia enable Vue 3 lint rules by default - https://phabricator.wikimedia.org/T314205 (10Catrope) [01:07:39] (03PS6) 10Krinkle: SpecialImport: Replace custom JS with HTMLForm disable-if [core] - 10https://gerrit.wikimedia.org/r/809273 [01:07:59] (03PS7) 10Krinkle: SpecialImport: Replace custom JS with HTMLForm disable-if [core] - 10https://gerrit.wikimedia.org/r/809273 [01:08:21] 10Design-Systems-Team: Update eslint-config-wikimedia and stylelint-config-wikimedia in all repos that use Vue - https://phabricator.wikimedia.org/T314206 (10Catrope) [01:08:28] 10Design-Systems-Team: Update eslint-config-wikimedia and stylelint-config-wikimedia in all repos that use Vue - https://phabricator.wikimedia.org/T314206 (10Catrope) [01:08:30] 10Design-Systems-Team: Make eslint-config-wikimedia enable Vue 3 lint rules by default - https://phabricator.wikimedia.org/T314205 (10Catrope) [01:10:16] (03CR) 10Krinkle: SpecialImport: Replace custom JS with HTMLForm disable-if (031 comment) [core] - 10https://gerrit.wikimedia.org/r/809273 (owner: 10Krinkle) [01:10:35] 10Design-Systems-Team, 10Epic: Design System Infrastructure Capabilities Scoping - https://phabricator.wikimedia.org/T314082 (10Catrope) >>! In T314082#8113331, @egardner wrote: > * **Finalize Vue 3 Migration** T289017: finalize migration to Vue 3 (by removing the compat build). Continuing to ship the Vue comp... [01:10:53] (03CR) 10Krinkle: [C: 04-1] "-1 for inDebugMode issue." [core] - 10https://gerrit.wikimedia.org/r/815776 (https://phabricator.wikimedia.org/T36738) (owner: 10Southparkfan) [01:12:59] 10Design-Systems-Team, 10Epic: Design System Infrastructure Capabilities Scoping - https://phabricator.wikimedia.org/T314082 (10Catrope) >>! In T314082#8113536, @AnneT wrote: > There are also larger questions about displaying different themes on the docs site, e.g. a Vector theme that sets the font size to 14p... [01:15:30] 10Design-Systems-Team, 10Epic: Design System Infrastructure Capabilities Scoping - https://phabricator.wikimedia.org/T314082 (10Catrope) There's also {T313767}, does that fit here, or should we take its parent epic ({T311244}) and put it under a different roadmap item? It's an infrastructural change but it's i... [01:21:04] 10MediaWiki-Action-API, 10Performance-Team (Radar), 10Platform Engineering (Icebox), 10patch-welcome: siteinfo api calls should be cached for N minutes on the caching layer - https://phabricator.wikimedia.org/T244204 (10Krinkle) [01:24:28] 10Design-Systems-Team, 10MW-1.38-notes (1.38.0-wmf.25; 2022-03-07): Migrate all extension code using Vuex to Vuex 4 - https://phabricator.wikimedia.org/T289103 (10Catrope) [01:26:12] 10Design-Systems-Team, 10LibUp, 10Patch-For-Review: Consider using library-upgrader to manage Vue-related dev dependencies - https://phabricator.wikimedia.org/T308496 (10Catrope) 05Resolved→03Open Reopening because I'd also like us to manage `@vue/test-utils` and friends this way. [01:27:48] 10Design-Systems-Team, 10Epic: Design System Infrastructure Capabilities Scoping - https://phabricator.wikimedia.org/T314082 (10Catrope) Another suggestion: {T308496} would help keep testing infrastructure consistent across repositories [01:52:30] (03CR) 10Samwilson: [C: 03+2] RealtimePreview: force update when reloading from error message [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/818097 (https://phabricator.wikimedia.org/T313381) (owner: 10Dmaza) [02:00:26] (03CR) 10Scardenasmolinar: [C: 03+1] Add metric platfrom event tracking on mobile desktop toggle [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/812009 (https://phabricator.wikimedia.org/T310852) (owner: 10Eigyan) [02:07:12] (03PS1) 10Krinkle: QueryPage: Improve isExpensive() docs and ref UpdateSpecialPages [core] - 10https://gerrit.wikimedia.org/r/818522 [02:07:33] (03Merged) 10jenkins-bot: RealtimePreview: force update when reloading from error message [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/818097 (https://phabricator.wikimedia.org/T313381) (owner: 10Dmaza) [02:40:19] (03PS1) 10Brian Wolff: Make default value for optional args {{PAGESINCAT:..}} be '' not null [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818422 (https://phabricator.wikimedia.org/T313663) [02:40:33] (03CR) 10Brian Wolff: [C: 03+2] Make default value for optional args {{PAGESINCAT:..}} be '' not null [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818422 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [02:41:19] (03PS1) 10Brian Wolff: Make default value for optional args {{PAGESINCAT:..}} be '' not null [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/818423 (https://phabricator.wikimedia.org/T313663) [02:41:34] (03CR) 10Brian Wolff: [C: 03+2] Make default value for optional args {{PAGESINCAT:..}} be '' not null [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/818423 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [02:41:47] (03PS1) 10Brian Wolff: Make default value for optional args {{PAGESINCAT:..}} be '' not null [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/818424 (https://phabricator.wikimedia.org/T313663) [02:42:02] (03CR) 10Brian Wolff: [C: 03+2] Make default value for optional args {{PAGESINCAT:..}} be '' not null [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/818424 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [02:51:14] (03Merged) 10jenkins-bot: Make default value for optional args {{PAGESINCAT:..}} be '' not null [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/818424 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [02:51:37] (03Merged) 10jenkins-bot: Make default value for optional args {{PAGESINCAT:..}} be '' not null [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/818423 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [02:52:21] (03Merged) 10jenkins-bot: Make default value for optional args {{PAGESINCAT:..}} be '' not null [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818422 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [03:04:44] 10PHP 8.1 support: Make REL1_38 pass test suite on php 8.1 - https://phabricator.wikimedia.org/T314208 (10Bawolff) [03:05:10] 10PHP 8.1 support: Make REL1_38 pass test suite on php 8.1 - https://phabricator.wikimedia.org/T314208 (10Bawolff) One of the tests that work on master, is due to 472a914c63baaff93, but that seems like quite a lot to backport. [03:05:25] 10MW-1.38-release, 10PHP 8.1 support: Make REL1_38 pass test suite on php 8.1 - https://phabricator.wikimedia.org/T314208 (10Peachey88) [03:05:43] 10Wikipedia-Android-App-Backlog: This userscript is protected editnotice refers to "User:Badtitle/dummy title for API calls set in api.php" as the relevant user - https://phabricator.wikimedia.org/T313262 (10Vahurzpu) 05Open→03Resolved a:03Vahurzpu Verified that this bug no longer occurs (with the same rev... [03:12:28] 10MediaWiki-libs-ObjectCache, 10Performance-Team, 10PHP 8.1 support: strtr(): Passing null to parameter #1 ($string) of type string is deprecated - https://phabricator.wikimedia.org/T314210 (10Reedy) [03:13:14] 10MediaWiki-Core-Tests, 10MediaWiki-General, 10PHP 8.1 support: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated - https://phabricator.wikimedia.org/T314211 (10Reedy) [03:13:36] 10SiteMatrix, 10PHP 8.1 support: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated - https://phabricator.wikimedia.org/T314212 (10Reedy) [03:17:05] 10SiteMatrix, 10Documentation: Clarify the meaning of struck links on Special:SiteMatrix - https://phabricator.wikimedia.org/T298968 (10Reedy) [03:20:29] 10SiteMatrix, 10PHP 8.1 support: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated - https://phabricator.wikimedia.org/T314212 (10Reedy) It looks like `str_replace( '-', '_', $minor ) ` is done in numerous places in the code... As output from `$wgConf->siteFromDB`. Whic... [03:22:28] (03PS1) 10Brian Wolff: [php8.1] Mock out getLocalDomainID for WatchedItemStore tests [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818523 (https://phabricator.wikimedia.org/T313663) [03:22:55] (03CR) 10Brian Wolff: "check experimental" [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818523 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [03:26:51] 10Design-Systems-Team, 10GrowthExperiments-MentorDashboard, 10Vue.js, 10Growth-Team (Current Sprint), and 2 others: Migration of mentee overview to Vue - https://phabricator.wikimedia.org/T300532 (10Etonkovidova) Two other "i" icons on Special:Mentorship page are ` (03CR) 10Brian Wolff: [C: 03+2] [php8.1] Mock out getLocalDomainID for WatchedItemStore tests [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818523 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [03:31:29] (03CR) 10Brian Wolff: [C: 03+2] [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816280 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [03:39:42] (03Merged) 10jenkins-bot: [php8.1] Mock out getLocalDomainID for WatchedItemStore tests [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818523 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [03:41:54] (03Merged) 10jenkins-bot: [php8] Make DeletePageTest stop giving warnings on php8.1 [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816280 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [03:56:08] (03CR) 10Brian Wolff: [C: 03+2] "This change is ready for review." [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816283 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [04:01:21] 10UniversalLanguageSelector, 10Language-Team (Language-2022-July-September): Language selector on multilingual wikis needs adjustments - https://phabricator.wikimedia.org/T314021 (10Nikki) As an editor on a multilingual wiki, the Commons image is clearly better. Why would you want to remove the display and inp... [04:05:27] (03PS3) 10Brian Wolff: Suppress warnings for the null test of addIdentifierQuotes [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816283 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [04:05:29] (03CR) 10CI reject: [V: 04-1] Suppress warnings for the null test of addIdentifierQuotes [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816283 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [04:09:13] 10MediaWiki-Core-Preferences, 10Platform Engineering: DBTransactionSizeError: Transaction spent {time}s in writes, exceeding the 3s limit - https://phabricator.wikimedia.org/T311308 (10MusikAnimal) Until we see an error in production, I think it's safe to assume this probably isn't an issue with GlobalPreferen... [04:26:18] 10UniversalLanguageSelector: Input panel is opened instead of display panel - https://phabricator.wikimedia.org/T59967 (10Nikki) @Amire80 What needs clarification here? The steps in the description still reproduce the issue so it seems clear enough to me. [04:31:51] (03CR) 10Brian Wolff: [C: 03+2] Suppress warnings for the null test of addIdentifierQuotes [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816283 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [04:32:21] (03PS1) 10Brian Wolff: Do not compare byte-for-byte of serialized items in tests [php8.1] [core] - 10https://gerrit.wikimedia.org/r/818524 (https://phabricator.wikimedia.org/T313663) [04:34:53] (03CR) 10Brian Wolff: "I wasn't sure what the best approach here is. I think this tests what we really want to test without tying us inflexibly to quirks in the " [core] - 10https://gerrit.wikimedia.org/r/818524 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [04:35:08] (03CR) 10Brian Wolff: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/818524 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [04:42:40] (03Merged) 10jenkins-bot: Suppress warnings for the null test of addIdentifierQuotes [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/816283 (https://phabricator.wikimedia.org/T313663) (owner: 10Reedy) [04:45:02] 10MediaWiki-Core-Revision-backend, 10Dumps-Generation, 10Platform Team Workboards (Clinic Duty Team), 10Wikimedia-database-issue (Bad data): nl.wiktionary.org edits from May 2004 corrupt "PHP Warning: gzinflate(): data error" (fatal RevisionAccessException) - https://phabricator.wikimedia.org/T265989 (10Ale... [05:02:23] (03PS1) 10Brian Wolff: Do not test giving a null fragment to Title::makeTitle [core] - 10https://gerrit.wikimedia.org/r/818525 [05:13:20] (03PS1) 10Brian Wolff: Make ChangesListSpecialPageTest cast to string for php 8.1 [core] - 10https://gerrit.wikimedia.org/r/818526 (https://phabricator.wikimedia.org/T313663) [05:19:55] (03PS1) 10Brian Wolff: Cast results of Sqlite test to string [php 8.1] [core] - 10https://gerrit.wikimedia.org/r/818527 (https://phabricator.wikimedia.org/T313663) [06:26:49] 10CampaignEvents, 10Campaign-Registration, 10Campaign-Tools (Campaign-Tools-Sprint-17): Investigate issues that may arise by enabling CampaignEvents extension on multiple wikis - https://phabricator.wikimedia.org/T311649 (10vaughnwalters) {F35354729} I haven't found any more major technical issues in testin... [06:34:12] (03PS2) 10Nikerabbit: Do not compare byte-for-byte of serialized items in tests [php8.1] [core] - 10https://gerrit.wikimedia.org/r/818524 (https://phabricator.wikimedia.org/T313663) (owner: 10Brian Wolff) [07:07:34] 10Design, 10MediaWiki-General, 10UI-Standardization, 10Vector, and 3 others: Use standard external link icon for external links - https://phabricator.wikimedia.org/T261391 (10Nikki) When the text has superscript text directly after it, the icon is too close to it. It was less apparent before partly because... [07:16:24] 10Design, 10IP Info, 10Anti-Harassment (AHaT Sprint 12: The Dutch Cap): IP Info: Fix capitalization in messages - https://phabricator.wikimedia.org/T311683 (10TThoabala) a:03TThoabala [07:36:00] 10Vector: Table of contents bugs in diff mode - https://phabricator.wikimedia.org/T314213 (10AramilFeraxa) [08:25:36] 10Codex, 10Design-Systems-Team (Design-Systems-Sprint), 10Spike: [SPIKE] Create scope for Link MVP - https://phabricator.wikimedia.org/T313507 (10bmartinezcalvo) >>! In T313507#8116257, @egardner wrote: > Another thing regarding "red links": > >> Do we want to name it "Destructive" to follow the same nomenc... [08:32:21] 10Accessibility, 10VideoJS player: Audio player is not tall enough for the file length at larger font sizes - https://phabricator.wikimedia.org/T313753 (10TheDJ) > The player should adapt its size according to the font size. It can’t because the native audio players (which appear first) have hard coded pixel... [08:43:37] 10VideoJS player: File page for audio file can only be reached after playing the file - https://phabricator.wikimedia.org/T313754 (10TheDJ) 05Open→03Declined if you need to speed run, you can just right click or option click. It’s a link just like any video or other link. I don’t see why we would need more... [08:45:21] (03CR) 10Thomas-topway-it: [V: 03+2 C: 03+2] "This change is ready for review." [extensions/PageProperties] - 10https://gerrit.wikimedia.org/r/818546 (owner: 10Thomas-topway-it) [08:45:44] (03PS2) 10Thomas-topway-it: update json-ld c [extensions/PageProperties] - 10https://gerrit.wikimedia.org/r/818546 [08:47:07] (03CR) 10CI reject: [V: 04-1] update json-ld c [extensions/PageProperties] - 10https://gerrit.wikimedia.org/r/818546 (owner: 10Thomas-topway-it) [08:53:52] 10MediaWiki-extensions-SecurePoll: Replace 2021 board election hack with proper fix - https://phabricator.wikimedia.org/T303135 (10Zabe) This has never been removed from the codebase, see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/SecurePoll/+/refs/heads/master/includes/Store/FormStore.p... [09:03:17] (03PS3) 10Thomas-topway-it: update json-ld c [extensions/PageProperties] - 10https://gerrit.wikimedia.org/r/818546 [09:04:37] (03CR) 10CI reject: [V: 04-1] update json-ld c [extensions/PageProperties] - 10https://gerrit.wikimedia.org/r/818546 (owner: 10Thomas-topway-it) [09:11:58] (03PS4) 10Thomas-topway-it: update json-ld c [extensions/PageProperties] - 10https://gerrit.wikimedia.org/r/818546 [09:15:38] (03CR) 10Thomas-topway-it: [V: 03+2 C: 03+2] update json-ld c [extensions/PageProperties] - 10https://gerrit.wikimedia.org/r/818546 (owner: 10Thomas-topway-it) [09:39:34] (03PS8) 10Dreamy Jazz: Refactor SpecialCheckUser.php checktype routing code [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/818517 [09:48:20] 10InternetArchiveBot: Bot is misclassifying subscription sites - https://phabricator.wikimedia.org/T310735 (10Cyberpower678) 05Open→03Resolved a:03Cyberpower678 [09:48:27] 10InternetArchiveBot: IABot is not properly handling duplicated named references - https://phabricator.wikimedia.org/T302917 (10Cyberpower678) 05Open→03Resolved [09:48:48] 10InternetArchiveBot, 10IABot-Priority-Eastern-Europe-Former-USSR: URL is cut off when parsing, resulting in links being treated as dead when they are not - https://phabricator.wikimedia.org/T290896 (10Cyberpower678) 05Open→03Resolved a:03Cyberpower678 [09:49:01] 10InternetArchiveBot, 10Chinese-Sites: Parameter error on Chinese Wikipedia - https://phabricator.wikimedia.org/T309728 (10Cyberpower678) 05Open→03Resolved [09:50:45] 10InternetArchiveBot: Choosing a closed wiki in IABot management interface causes endless auth failure loop - https://phabricator.wikimedia.org/T299576 (10Cyberpower678) 05Open→03Resolved a:03Cyberpower678 [09:50:53] 10InternetArchiveBot: Changes made in "Configure bot behavior" are not saving - https://phabricator.wikimedia.org/T286738 (10Cyberpower678) 05Open→03Resolved a:03Cyberpower678 [09:50:55] (03PS9) 10Dreamy Jazz: Refactor SpecialCheckUser.php checktype routing code [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/818517 [09:51:06] 10InternetArchiveBot: Bot is marking some links as dead, even though they are considered alive internally - https://phabricator.wikimedia.org/T309730 (10Cyberpower678) 05Open→03Resolved a:03Cyberpower678 [09:51:35] 10InternetArchiveBot, 10IABot-Priority-2022, 10IABot-Priority-Eastern-Europe-Former-USSR: Polish Wikipedia: Adding archive to templates with archive.is/org links in url does not look correct - https://phabricator.wikimedia.org/T310212 (10Cyberpower678) 05Open→03Resolved a:03Cyberpower678 [09:52:02] 10Internet-Archive, 10InternetArchiveBot: IABot uses a dead archive site (WebCite), resulting in errenous automated archive-url parameters. - https://phabricator.wikimedia.org/T309254 (10Cyberpower678) 05Open→03Resolved a:03Cyberpower678 [09:57:34] (03PS1) 10Dreamy Jazz: Move isValidRange to the abstract pager as it's only used there [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/818529 [10:01:19] (03PS2) 10Dreamy Jazz: Move isValidRange to the abstract pager as it's only used there [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/818529 [10:01:43] (03CR) 10Vedmaka Wakalaka: [C: 03+2] Fix Javascript on Special:GoogleCustomWikiSearch page [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/818427 (https://phabricator.wikimedia.org/T274708) (owner: 10Pastakhov) [10:03:26] (03PS2) 10Fomafix: Rework JavaScript [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818224 [10:03:54] (03Merged) 10jenkins-bot: Fix Javascript on Special:GoogleCustomWikiSearch page [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/818427 (https://phabricator.wikimedia.org/T274708) (owner: 10Pastakhov) [11:00:05] 10MobileFrontend, 10MinervaNeue: Links with .mw-usertoollinks-contribs-no-edits are not red in Minerva on mobile platform - https://phabricator.wikimedia.org/T314216 (10JohanahoJ) [11:18:47] 10CheckUser: Checkuserblock form is broken - https://phabricator.wikimedia.org/T314217 (10Dreamy_Jazz) [11:19:09] 10CheckUser: Checkuserblock form is broken - https://phabricator.wikimedia.org/T314217 (10Dreamy_Jazz) p:05Triage→03High [11:19:22] 10CheckUser: Checkuserblock form is broken when paging links are shown on 'Get users' - https://phabricator.wikimedia.org/T314217 (10Dreamy_Jazz) [11:24:50] (03PS1) 10Dreamy Jazz: Remove the bottom paging links for 'Get users' as forms cannot be nested [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/818530 (https://phabricator.wikimedia.org/T314217) [11:28:05] (03CR) 10Dreamy Jazz: "Reviewer bot seems to be broken recently. Anyway this is a important patch to be merged. The issue was caused by Idd643e8a45aade2c21b97b6f" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/818530 (https://phabricator.wikimedia.org/T314217) (owner: 10Dreamy Jazz) [11:28:52] 10CheckUser, 10Patch-For-Review: Checkuserblock form is broken when paging links are shown on 'Get users' - https://phabricator.wikimedia.org/T314217 (10Dreamy_Jazz) [11:28:56] 10CheckUser, 10Stewards-and-global-tools, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25): Instead of not showing any results on too many results show the results to the truncation point with a pager that allows generation of more results - https://phabricator.wikimedia.org/T311375 (10Dreamy_Jazz) [11:31:01] 10CheckUser, 10Patch-For-Review: Checkuserblock form is broken when paging links are shown on 'Get users' - https://phabricator.wikimedia.org/T314217 (10Dreamy_Jazz) [11:35:30] 10CheckUser, 10Patch-For-Review: Checkuserblock form is broken when paging links are shown on 'Get users' - https://phabricator.wikimedia.org/T314217 (10Dreamy_Jazz) a:03Dreamy_Jazz [11:44:00] 10MobileFrontend, 10MinervaNeue, 10Regression: Links with .mw-usertoollinks-contribs-no-edits are not red in Minerva on mobile platform - https://phabricator.wikimedia.org/T314216 (10JohanahoJ) [13:11:49] 10MediaWiki-extensions-Translate: [TUX] Insertables don't add state in undo stack - https://phabricator.wikimedia.org/T64099 (10matmarex) 05Open→03Resolved a:03matmarex This seems to work correctly now. It looks like TUX is using jquery.textSelection, and its behavior was recently improved in T33780. [13:37:52] 10Data-Catalog, 10Data Engineering Planning (Sprint 02): Document Two Additional Canonical Datasets - https://phabricator.wikimedia.org/T308048 (10EChetty) [13:38:10] (03CR) 10Matěj Suchánek: [C: 03+2] Use UserIdentity in VariableGenerator::addEditVars [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/809004 (owner: 10Umherirrender) [13:43:13] 10DiscussionTools: Make the message you're replying to more visible - https://phabricator.wikimedia.org/T314218 (10Iniquity) [13:43:34] (03PS3) 10Fomafix: Rework JavaScript [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818224 [13:43:52] (03PS1) 10Fomafix: Optimize ResourceLoader usage [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818533 [13:45:46] (03CR) 10CI reject: [V: 04-1] Optimize ResourceLoader usage [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818533 (owner: 10Fomafix) [13:55:24] (03Merged) 10jenkins-bot: Use UserIdentity in VariableGenerator::addEditVars [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/809004 (owner: 10Umherirrender) [14:04:31] (03PS1) 10Bartosz Dziewoński: EditPage: Restore stripping '== ... ==' from summary and section title [core] - 10https://gerrit.wikimedia.org/r/818534 [14:06:52] (03CR) 10Bartosz Dziewoński: "This caused issues in Twinkle:" [core] - 10https://gerrit.wikimedia.org/r/814003 (https://phabricator.wikimedia.org/T191722) (owner: 10Bartosz Dziewoński) [14:22:40] (03PS2) 10Fomafix: Optimize ResourceLoader usage [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818533 [14:22:57] 10DiscussionTools: Wrap sign on a new line when working with numbered lists - https://phabricator.wikimedia.org/T314220 (10Iniquity) [14:25:24] 10Design, 10DiscussionTools: Make the message you're replying to more visible - https://phabricator.wikimedia.org/T314218 (10Iniquity) [14:32:46] (03PS1) 10TheDJ: Hide cursor within playback area when user inactive [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/818536 (https://phabricator.wikimedia.org/T220951) [14:33:12] 10VideoJS player, 10Patch-For-Review: Cursor should disappear when hovering video - https://phabricator.wikimedia.org/T220951 (10TheDJ) a:03TheDJ [14:40:10] 10MediaWiki-extensions-Page_Forms: PF File Upload Duplicate Image not overwriting - https://phabricator.wikimedia.org/T314221 (10rijvirajib) [14:47:43] (03CR) 10CI reject: [V: 04-1] Hide cursor within playback area when user inactive [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/818536 (https://phabricator.wikimedia.org/T220951) (owner: 10TheDJ) [15:57:04] 04(no projects): Contributions page of new editors appearing on the User Creation Log are automatically blue-linked, even though they haven’t edited anything yet. - https://phabricator.wikimedia.org/T314224 (10ProClasher97) [16:10:21] 10MediaWiki-Categories, 10PHP 8.1 support: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /var/www/wiki/mediawiki/core/includes/WebRequest.php on line 541 - https://phabricator.wikimedia.org/T314225 (10Reedy) [16:11:24] (03PS1) 10Reedy: SpecialCategories: Null coalescene $par [core] - 10https://gerrit.wikimedia.org/r/818539 (https://phabricator.wikimedia.org/T314225) [16:12:38] 10MediaWiki-User-login-and-signup, 10PHP 8.1 support: Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in LoginSignupSpecialPage.php on line 831 - https://phabricator.wikimedia.org/T314226 (10Reedy) [16:12:59] 10MediaWiki-Categories, 10PHP 8.1 support, 10Patch-For-Review: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541 - https://phabricator.wikimedia.org/T314225 (10Reedy) [16:13:59] 10MediaWiki-extensions-MultiMaps: Use of ParserOutput::addModules triggers error message - https://phabricator.wikimedia.org/T314227 (10FellTiger) [16:15:36] (03PS1) 10Reedy: LoginSignupSpecialPage: Fix some indenting [core] - 10https://gerrit.wikimedia.org/r/818540 [16:16:26] 10MediaWiki-User-login-and-signup, 10PHP 8.1 support: Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in LoginSignupSpecialPage.php on line 831 - https://phabricator.wikimedia.org/T314226 (10Reedy) [16:35:58] 10UniversalLanguageSelector, 10Language-Team (Language-2022-July-September): Language selector on multilingual wikis needs adjustments - https://phabricator.wikimedia.org/T314021 (10mrephabricator) I agree that there is no problem here. Just leave it as is [17:02:30] (03PS1) 10Reedy: Namespace Rendering classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818541 [17:04:23] (03CR) 10CI reject: [V: 04-1] Namespace Rendering classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818541 (owner: 10Reedy) [17:13:39] 10Design, 10Codex, 10Design-Systems-Team: TextInput: Deemphasize clearable icon visually - https://phabricator.wikimedia.org/T314229 (10Volker_E) [17:14:43] 10Design, 10Codex, 10Design-Systems-Team: TextInput: Deemphasize clearable icon visually - https://phabricator.wikimedia.org/T314229 (10Volker_E) To also cite @bmartinezcalvo from T310403#8022315: > I think this clear icon should have the following states since it's an action and not a simple decorative icon... [17:16:51] 10Codex, 10Design-Systems-Team: TextInput: The clearable icon should be able to gain focus using the keyboard - https://phabricator.wikimedia.org/T310403 (10Volker_E) 05Open→03Declined Declining as the keyboard interaction asked for in this task, has been identified to being unnecessary for keyboard users. [17:17:39] (03PS2) 10Reedy: Namespace Rendering classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818541 [17:17:40] (03PS1) 10Reedy: Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 [17:17:42] (03PS1) 10Reedy: Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 [17:19:31] (03CR) 10CI reject: [V: 04-1] Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 (owner: 10Reedy) [17:19:33] (03CR) 10CI reject: [V: 04-1] Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 (owner: 10Reedy) [17:20:30] (03PS1) 10Reedy: extension.json: Remove TestAutoloadClasses [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/818544 [17:26:19] (03PS2) 10Reedy: Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 [17:26:21] (03PS2) 10Reedy: Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 [17:28:07] (03CR) 10CI reject: [V: 04-1] Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 (owner: 10Reedy) [17:28:10] (03CR) 10CI reject: [V: 04-1] Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 (owner: 10Reedy) [17:29:32] (03PS3) 10Reedy: Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 [17:29:34] (03PS3) 10Reedy: Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 [17:31:30] (03CR) 10CI reject: [V: 04-1] Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 (owner: 10Reedy) [17:31:33] (03CR) 10CI reject: [V: 04-1] Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 (owner: 10Reedy) [17:35:07] (03PS4) 10Reedy: Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 [17:35:09] (03PS4) 10Reedy: Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 [17:36:45] (03CR) 10CI reject: [V: 04-1] Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 (owner: 10Reedy) [17:37:02] (03CR) 10CI reject: [V: 04-1] Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 (owner: 10Reedy) [17:37:18] (03PS5) 10Reedy: Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 [17:38:55] (03CR) 10CI reject: [V: 04-1] Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 (owner: 10Reedy) [17:41:05] (03PS6) 10Reedy: Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 [17:41:07] (03PS1) 10Reedy: tests: Rename to match includes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818545 [17:42:52] (03CR) 10CI reject: [V: 04-1] tests: Rename to match includes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818545 (owner: 10Reedy) [17:43:06] (03CR) 10CI reject: [V: 04-1] Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 (owner: 10Reedy) [17:48:34] (03PS7) 10Reedy: Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 [17:48:36] (03PS2) 10Reedy: tests: Rename to match includes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818545 [17:48:38] (03PS1) 10Reedy: Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 [17:49:20] (03PS1) 10Stang: Update Italian translation of (no)index magic words [core] - 10https://gerrit.wikimedia.org/r/818568 (https://phabricator.wikimedia.org/T314165) [17:50:32] (03PS2) 10Reedy: Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 [17:50:46] (03CR) 10CI reject: [V: 04-1] Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 (owner: 10Reedy) [17:51:02] (03CR) 10CI reject: [V: 04-1] tests: Rename to match includes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818545 (owner: 10Reedy) [17:51:18] (03CR) 10CI reject: [V: 04-1] Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 (owner: 10Reedy) [17:51:23] 10MediaWiki-Internationalization, 10Wikimedia-Site-requests, 10I18n, 10Patch-For-Review: Changing the ns2/ns3 robot policy on itwiki - https://phabricator.wikimedia.org/T314165 (10Stang) a:03Stang [17:51:54] 10MediaWiki-Internationalization, 10Wikimedia-Site-requests, 10I18n, 10Patch-For-Review: Changing the ns2/ns3 robot policy on itwiki - https://phabricator.wikimedia.org/T314165 (10Stang) There's still [[ https://global-search.toolforge.org/?q=%22__INDICE__%22 | some ]] [[ https://global-search.toolforge.or... [17:52:31] (03CR) 10CI reject: [V: 04-1] Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 (owner: 10Reedy) [17:53:14] (03CR) 10jenkins-bot: Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 (owner: 10Reedy) [17:56:46] (03PS5) 10Reedy: Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 [17:56:48] (03PS8) 10Reedy: Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 [17:56:50] (03PS3) 10Reedy: tests: Rename to match includes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818545 [17:56:52] (03PS3) 10Reedy: Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 [17:58:35] 10MediaWiki-extensions-General, 10Epic, 10MW-1.38-notes (1.38.0-wmf.25; 2022-03-07): Adopt PSR-4 namespaces in WMF-deployed extensions/skins - https://phabricator.wikimedia.org/T278278 (10Reedy) [17:58:54] (03CR) 10CI reject: [V: 04-1] Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 (owner: 10Reedy) [17:59:15] (03CR) 10CI reject: [V: 04-1] Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 (owner: 10Reedy) [17:59:23] (03CR) 10jenkins-bot: tests: Rename to match includes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818545 (owner: 10Reedy) [17:59:29] (03CR) 10jenkins-bot: Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 (owner: 10Reedy) [18:01:25] (03PS6) 10Reedy: Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 [18:01:27] (03PS9) 10Reedy: Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 [18:01:29] (03PS4) 10Reedy: tests: Rename to match includes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818545 [18:01:31] (03PS4) 10Reedy: Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 [18:03:02] 10MediaWiki-extensions-General, 10Epic, 10MW-1.38-notes (1.38.0-wmf.25; 2022-03-07): Adopt PSR-4 namespaces in WMF-deployed extensions/skins - https://phabricator.wikimedia.org/T278278 (10Reedy) ` reedy@deploy1002:/srv/mediawiki-staging/php-1.39.0-wmf.22$ grep \"AutoloadClasses extensions/*/extension.json ex... [18:03:45] (03CR) 10CI reject: [V: 04-1] Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 (owner: 10Reedy) [18:07:43] (03PS5) 10Reedy: Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 [18:08:58] 10Wikimedia-Site-requests, 10Patch-For-Review: Create Appendix namespace on Mon Wiktionary (mnwwiktionary) - https://phabricator.wikimedia.org/T314023 (10Stang) a:03Stang | **ID** | 100 | 101 | | **Canonical** | Appendix | Appendix_talk | | **Alias** | အဆက်လက္ကရဴ | အဆက်လက္ကရဴ_ဓရီုကျာ | Please run `namespaceD... [18:09:23] (03CR) 10CI reject: [V: 04-1] Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 (owner: 10Reedy) [18:10:53] (03PS6) 10Reedy: Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 [18:12:22] 10MediaWiki-extensions-General, 10Epic: Namespace MW Tarball Bundled Extensions/Skins - https://phabricator.wikimedia.org/T278279 (10Reedy) [18:13:04] (03PS13) 10Reedy: Namespace base classes [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/778556 [18:13:07] (03PS9) 10Reedy: Namespace captchas [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/778564 [18:21:25] (03PS1) 10Reedy: Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 [18:25:08] (03CR) 10CI reject: [V: 04-1] Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 (owner: 10Reedy) [18:25:35] (03PS2) 10Reedy: Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 [18:28:19] (03CR) 10CI reject: [V: 04-1] Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 (owner: 10Reedy) [18:28:31] (03PS3) 10Reedy: Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 [18:31:26] (03CR) 10CI reject: [V: 04-1] Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 (owner: 10Reedy) [18:32:31] (03PS4) 10Reedy: Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 [18:36:44] (03PS5) 10Reedy: Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 [18:40:01] (03PS6) 10Reedy: Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 [18:44:05] (03PS7) 10Reedy: Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 [18:51:38] (03PS1) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [18:56:44] 10MediaWiki-Maintenance-system: Instantiate MaintenanceScripts after extensions have registered with the autoloader - https://phabricator.wikimedia.org/T314231 (10daniel) [18:59:24] (03PS2) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [19:02:24] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/EnhancedUpload] (REL1_35) - 10https://gerrit.wikimedia.org/r/818297 (owner: 10Mschlindwein) [19:03:07] (03CR) 10Raimond Spekking: [C: 04-1] "i18n review" [skins/TuleapSkin] - 10https://gerrit.wikimedia.org/r/816758 (owner: 10Mschlindwein) [19:04:29] (03PS3) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [19:15:24] (03PS4) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [19:29:15] (03CR) 10CI reject: [V: 04-1] Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 (owner: 10Reedy) [19:33:21] (03PS5) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [19:36:44] (03PS6) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [19:41:16] (03PS7) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [19:46:57] (03PS8) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [19:52:56] (03PS9) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [19:55:35] 10MediaWiki-extensions-Scribunto: Many leftovers from the HHVM days - https://phabricator.wikimedia.org/T314233 (10Reedy) [19:59:04] (03PS10) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [20:00:42] (03PS11) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [20:03:52] (03PS12) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [20:06:08] 10MediaWiki-Page-diffs: Ability to view diff of page creation - https://phabricator.wikimedia.org/T314234 (10Novem_Linguae) [20:16:57] (03CR) 10CI reject: [V: 04-1] Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 (owner: 10Reedy) [20:20:17] (03PS13) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [20:20:27] 10DiscussionTools: Expose hash links for comments to users - https://phabricator.wikimedia.org/T284191 (10matmarex) [20:20:37] 10DiscussionTools: Introduce permalinks on wikitext talk pages - https://phabricator.wikimedia.org/T302011 (10matmarex) [20:23:08] (03CR) 10DannyS712: [C: 03+2] "I'm always happy to review phpcs fixes, feel free to add me to such patches as a reviewer" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818547 (owner: 10Reedy) [20:23:47] (03PS14) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [20:30:27] (03CR) 10DannyS712: [C: 04-1] JsonCodec: add CycleDetector to detect cyclic references (036 comments) [core] - 10https://gerrit.wikimedia.org/r/818478 (https://phabricator.wikimedia.org/T312589) (owner: 10C. Scott Ananian) [20:32:04] (03CR) 10Bartosz Dziewoński: [C: 03+2] SpecialImport: Replace custom JS with HTMLForm disable-if [core] - 10https://gerrit.wikimedia.org/r/809273 (owner: 10Krinkle) [20:37:23] (03Merged) 10jenkins-bot: Fix MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818547 (owner: 10Reedy) [20:37:28] 10MediaWiki-Core-Revision-backend, 10Dumps-Generation, 10Platform Team Workboards (Clinic Duty Team), 10Wikimedia-database-issue (Bad data): nl.wiktionary.org edits from May 2004 corrupt "PHP Warning: gzinflate(): data error" (fatal RevisionAccessException) - https://phabricator.wikimedia.org/T265989 (10Ple... [20:47:23] (03Merged) 10jenkins-bot: SpecialImport: Replace custom JS with HTMLForm disable-if [core] - 10https://gerrit.wikimedia.org/r/809273 (owner: 10Krinkle) [20:55:13] (03PS1) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [20:56:57] (03PS8) 10Reedy: Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 [20:56:59] (03PS15) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [20:57:01] (03PS2) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [20:57:03] (03CR) 10CI reject: [V: 04-1] Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 (owner: 10Reedy) [20:58:42] (03PS3) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [21:02:46] 10MediaWiki-extensions-Scribunto: Many leftovers from the HHVM days - https://phabricator.wikimedia.org/T314233 (10Legoktm) I think you have an old version of luasandbox checked out inside Scribunto? See 30449fcb5e8d89c764d9ad8350b54a99b3536291 (note the author of the commit ;-)). [21:07:09] (03PS4) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [21:12:51] 10MediaWiki-extensions-Scribunto: Many leftovers from the HHVM days - https://phabricator.wikimedia.org/T314233 (10Reedy) >>! In T314233#8117506, @Legoktm wrote: > I think you have an old version of luasandbox checked out inside Scribunto? Nope! We just have an old version pinned in composer.json :) `lang=jso... [21:13:33] (03CR) 10CI reject: [V: 04-1] Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 (owner: 10Reedy) [21:14:56] (03PS1) 10Reedy: composer.json: Bump mediawiki/lua-sandbox to 4.0.2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818573 (https://phabricator.wikimedia.org/T314233) [21:14:57] 10Desktop Improvements, 10Readers-Web-Backlog, 10Reading-Web-Local-Wiki-Issues, 10Vector: Fix alignment of coordinates and page indicators (Vector 2022) - https://phabricator.wikimedia.org/T281974 (10Theklan) Just for clarification: the templates used to display coordinates or page related issues (featured... [21:16:09] (03PS5) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [21:21:40] 04(no projects): Contributions page of new editors appearing on the User Creation Log are automatically blue-linked, even though they haven’t edited anything yet. - https://phabricator.wikimedia.org/T314224 (10Umherirrender) [21:21:52] 10MobileFrontend, 10MinervaNeue, 10Regression: Links with .mw-usertoollinks-contribs-no-edits are not red in Minerva on mobile platform - https://phabricator.wikimedia.org/T314216 (10Umherirrender) [21:21:59] 10MediaWiki-extensions-Scribunto, 10Patch-For-Review: Many leftovers from the HHVM days - https://phabricator.wikimedia.org/T314233 (10Reedy) [21:23:35] (03CR) 10Umherirrender: [C: 03+2] extension.json: Remove TestAutoloadClasses [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/818544 (owner: 10Reedy) [21:24:47] (03CR) 10Umherirrender: [C: 03+2] LoginSignupSpecialPage: Fix some indenting [core] - 10https://gerrit.wikimedia.org/r/818540 (owner: 10Reedy) [21:25:20] (03PS6) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [21:27:32] (03CR) 10Legoktm: [C: 03+2] Add alias for special page "Special:MyContribs" [core] - 10https://gerrit.wikimedia.org/r/802834 (owner: 10EpicPupper) [21:30:13] 10MassMessage: Some MassMessages not reaching cywikibooks - https://phabricator.wikimedia.org/T313672 (10Rschen7754) Also https://ky.wikibooks.org/wiki/Wikibooks:%D0%96%D0%B0%D0%BC%D0%B0%D0%B0%D1%82_%D0%BF%D0%BE%D1%80%D1%82%D0%B0%D0%BB%D1%8B [21:31:20] (03Merged) 10jenkins-bot: extension.json: Remove TestAutoloadClasses [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/818544 (owner: 10Reedy) [21:31:44] (03CR) 10Legoktm: [C: 03+2] composer.json: Bump mediawiki/lua-sandbox to 4.0.2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818573 (https://phabricator.wikimedia.org/T314233) (owner: 10Reedy) [21:38:31] 10LuaSandbox, 10PHP 8.2 support: LuaSandbox test failures on PHP 8.2 - https://phabricator.wikimedia.org/T314235 (10Legoktm) [21:41:53] (03Merged) 10jenkins-bot: LoginSignupSpecialPage: Fix some indenting [core] - 10https://gerrit.wikimedia.org/r/818540 (owner: 10Reedy) [21:42:48] (03Merged) 10jenkins-bot: Add alias for special page "Special:MyContribs" [core] - 10https://gerrit.wikimedia.org/r/802834 (owner: 10EpicPupper) [21:43:46] (03PS1) 10Daniel Kinzler: ExtensionRegistry: split exportExtractedData [core] - 10https://gerrit.wikimedia.org/r/818574 (https://phabricator.wikimedia.org/T314231) [21:44:01] (03CR) 10CI reject: [V: 04-1] Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 (owner: 10Reedy) [21:44:47] 10LuaSandbox, 10PHP 8.2 support: LuaSandbox test failures on PHP 8.2 - https://phabricator.wikimedia.org/T314235 (10Legoktm) $luaTrace I noticed in https://gerrit.wikimedia.org/r/c/mediawiki/php/luasandbox/+/424982, need to resuscitate that patch. [21:49:59] (03Merged) 10jenkins-bot: composer.json: Bump mediawiki/lua-sandbox to 4.0.2 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818573 (https://phabricator.wikimedia.org/T314233) (owner: 10Reedy) [21:50:45] (03PS9) 10Reedy: Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 [21:50:47] (03PS16) 10Reedy: Namespace LuaStandalone engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 [21:50:49] (03PS7) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [21:52:28] 10MediaWiki-extensions-Scribunto, 10Patch-For-Review: Many leftovers from the HHVM days - https://phabricator.wikimedia.org/T314233 (10Reedy) [21:52:31] (03PS1) 10Umherirrender: rebuildLocalisationCache: Avoid compare with false for bool, use ! [core] - 10https://gerrit.wikimedia.org/r/818575 [21:52:49] 10MediaWiki-extensions-Scribunto, 10Patch-For-Review: Leftover from the HHVM days - https://phabricator.wikimedia.org/T314233 (10Reedy) [21:56:09] (03PS8) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [21:57:29] 10Wikimedia-Site-requests, 10Logos, 10Patch-For-Review: Site logo cropped/not fully displayed on some projects - https://phabricator.wikimedia.org/T310961 (10Stang) >>! In T310961#8029375, @1234qwer1234qwer4 wrote: > Note that this is also a problem on https://hi.wikisource.org/. Same problem, I failed to f... [21:59:02] (03CR) 10CI reject: [V: 04-1] ExtensionRegistry: split exportExtractedData [core] - 10https://gerrit.wikimedia.org/r/818574 (https://phabricator.wikimedia.org/T314231) (owner: 10Daniel Kinzler) [22:03:10] legoktm: Thank you for sharing the link to your talk last week at HOPE. I found it very informative, and even as an established MediaWiki contributor, I learned a couple things. I liked your use of recent examples such as last week's network outage. [22:04:04] (03PS1) 10Esanders: ImmutableRange: Add surroundContents method [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818577 [22:04:06] (03PS1) 10Esanders: [WIP] Parser: Store timestamp ranges [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818578 [22:04:08] (03PS1) 10Esanders: [WIP] Turn comment timestamps into permalinks [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818579 [22:04:49] (03PS9) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [22:05:08] PleaseStand: :))) yw, glad to hear that! [22:06:08] (03CR) 10CI reject: [V: 04-1] Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 (owner: 10Reedy) [22:09:53] (03CR) 10CI reject: [V: 04-1] ImmutableRange: Add surroundContents method [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818577 (owner: 10Esanders) [22:11:13] (03PS10) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [22:11:50] (03CR) 10CI reject: [V: 04-1] [WIP] Parser: Store timestamp ranges [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818578 (owner: 10Esanders) [22:12:17] (03CR) 10CI reject: [V: 04-1] [WIP] Turn comment timestamps into permalinks [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818579 (owner: 10Esanders) [22:17:30] (03PS1) 10Reedy: Disable some more PHPCS rules... [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818580 [22:19:54] 10Wikimedia-Site-requests: Requesting logo change for ne.wikipedia.org (Mobile version) - https://phabricator.wikimedia.org/T311700 (10Stang) [22:22:40] (03CR) 10Umherirrender: [C: 03+2] SpecialCategories: Null coalescene $par [core] - 10https://gerrit.wikimedia.org/r/818539 (https://phabricator.wikimedia.org/T314225) (owner: 10Reedy) [22:25:29] (03Abandoned) 10Reedy: Disable some more PHPCS rules... [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818580 (owner: 10Reedy) [22:26:34] legoktm: The verbose pasting point was an interesting one. Just last night I think saw one of those: https://phabricator.wikimedia.org/T265989 [22:27:49] oooh, that's another good example [22:27:52] and way more complex too [22:31:04] we should start tracking/listing these somewhere [22:31:05] (03CR) 10Subramanya Sastry: Rest: Refactor the `ParsoidHandler::html2wt()` method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/814739 (https://phabricator.wikimedia.org/T310376) (owner: 10D3r1ck01) [22:31:23] (03PS11) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [22:31:25] (03PS1) 10Reedy: Capitalise Engines folder [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818581 [22:31:47] 10Wikimedia-Site-requests: Requesting logo change for ne.wikipedia.org (Mobile version) - https://phabricator.wikimedia.org/T311700 (10Stang) Personally suggest to redesign the logo without dependency to a specific font - just imagine those guys who has no such font , or even no Nepali fonts installed on their d... [22:34:38] (03PS1) 10Umherirrender: specials: Add more null check for $par [core] - 10https://gerrit.wikimedia.org/r/818582 (https://phabricator.wikimedia.org/T314225) [22:38:18] legoktm: The HyperKitty search box sure is nice! I'm sure that it made it much easier to find those old wikitech-l posts than it used to be in the Mailman 2 days. [22:38:51] absolutely [22:39:23] every time I find a broken pipermail link (from the time someone screwed up all the archives), I'm usually able to find the correct target via search and guessing by date range [22:40:01] (03Merged) 10jenkins-bot: SpecialCategories: Null coalescene $par [core] - 10https://gerrit.wikimedia.org/r/818539 (https://phabricator.wikimedia.org/T314225) (owner: 10Reedy) [22:42:38] 10Desktop Improvements, 10Readers-Web-Backlog, 10Reading-Web-Local-Wiki-Issues, 10Vector: Fix alignment of coordinates and page indicators (Vector 2022) - https://phabricator.wikimedia.org/T281974 (10Xaosflux) I suppose an overall design question is is: how much design should be specific to this data point... [22:43:11] (03PS1) 10Reedy: Namespace tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818583 [22:43:25] (03PS1) 10Reedy: SpecialCategories: Null coalescene $par [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818548 (https://phabricator.wikimedia.org/T314225) [22:43:32] (03CR) 10Reedy: [C: 03+2] SpecialCategories: Null coalescene $par [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818548 (https://phabricator.wikimedia.org/T314225) (owner: 10Reedy) [22:43:39] (03PS1) 10Reedy: SpecialCategories: Null coalescene $par [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/818549 (https://phabricator.wikimedia.org/T314225) [22:43:45] (03CR) 10Reedy: [C: 03+2] SpecialCategories: Null coalescene $par [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/818549 (https://phabricator.wikimedia.org/T314225) (owner: 10Reedy) [22:43:59] (03PS1) 10Reedy: SpecialCategories: Null coalescene $par [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/818550 (https://phabricator.wikimedia.org/T314225) [22:44:34] (03CR) 10Reedy: [C: 03+2] SpecialCategories: Null coalescene $par [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/818550 (https://phabricator.wikimedia.org/T314225) (owner: 10Reedy) [22:45:19] (03CR) 10CI reject: [V: 04-1] Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 (owner: 10Reedy) [22:45:22] (03CR) 10CI reject: [V: 04-1] Namespace tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818583 (owner: 10Reedy) [22:46:07] (03CR) 10CI reject: [V: 04-1] Capitalise Engines folder [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818581 (owner: 10Reedy) [22:48:08] (03PS12) 10Reedy: Namespace LuaCommon [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818572 [22:48:10] (03PS2) 10Reedy: Capitalise Engines folder [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818581 [22:48:12] (03PS2) 10Reedy: Namespace tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818583 [22:48:33] (03CR) 10Subramanya Sastry: "This patch breaks roundtrip-test.js in a different way. See below. I think transform.js testing probably needs an update to add tests for " [core] - 10https://gerrit.wikimedia.org/r/816134 (owner: 10Daniel Kinzler) [22:49:07] (03CR) 10jenkins-bot: Namespace tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818583 (owner: 10Reedy) [22:50:11] (03CR) 10DannyS712: [C: 03+2] tests: Rename to match includes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818545 (owner: 10Reedy) [22:50:27] 10MediaWiki-Categories, 10PHP 8.1 support, 10Patch-For-Review: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541 - https://phabricator.wikimedia.org/T314225 (10Reedy) 05Open→03Resolved a:03Reedy [22:51:01] (03CR) 10CI reject: [V: 04-1] Namespace tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818583 (owner: 10Reedy) [22:51:34] (03CR) 10DannyS712: [C: 03+2] "per codesearch, only reference to these classes outside of this extension is in a github fork" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818541 (owner: 10Reedy) [22:53:17] (03CR) 10CI reject: [V: 04-1] SpecialCategories: Null coalescene $par [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/818550 (https://phabricator.wikimedia.org/T314225) (owner: 10Reedy) [22:53:38] (03CR) 10Reedy: [C: 03+2] SpecialCategories: Null coalescene $par [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/818550 (https://phabricator.wikimedia.org/T314225) (owner: 10Reedy) [22:54:48] (03Merged) 10jenkins-bot: SpecialCategories: Null coalescene $par [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/818550 (https://phabricator.wikimedia.org/T314225) (owner: 10Reedy) [22:54:52] (03Merged) 10jenkins-bot: Namespace Rendering classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818541 (owner: 10Reedy) [22:54:58] (03Merged) 10jenkins-bot: SpecialCategories: Null coalescene $par [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/818549 (https://phabricator.wikimedia.org/T314225) (owner: 10Reedy) [22:55:11] (03CR) 10DannyS712: [C: 03+2] "per codesearch, only reference to these classes outside of this extension is in a github fork" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 (owner: 10Reedy) [22:56:02] (03CR) 10DannyS712: [C: 03+2] "per codesearch, only reference to these classes outside of this extension is in a github fork" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 (owner: 10Reedy) [22:56:30] (03PS13) 10C. Scott Ananian: JsonCodec: fix en/decoding of nested objects and stdClass objects [core] - 10https://gerrit.wikimedia.org/r/812076 (https://phabricator.wikimedia.org/T312589) [22:56:32] (03PS4) 10C. Scott Ananian: JsonCodec: add CycleDetector to detect cyclic references [core] - 10https://gerrit.wikimedia.org/r/818478 (https://phabricator.wikimedia.org/T312589) [22:56:43] (03CR) 10C. Scott Ananian: JsonCodec: add CycleDetector to detect cyclic references (036 comments) [core] - 10https://gerrit.wikimedia.org/r/818478 (https://phabricator.wikimedia.org/T312589) (owner: 10C. Scott Ananian) [22:56:45] (03Merged) 10jenkins-bot: SpecialCategories: Null coalescene $par [core] (REL1_38) - 10https://gerrit.wikimedia.org/r/818548 (https://phabricator.wikimedia.org/T314225) (owner: 10Reedy) [22:57:15] (03CR) 10DannyS712: [C: 03+2] "per codesearch, only reference to these classes outside of this extension is in a github fork" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 (owner: 10Reedy) [22:58:14] (03PS2) 10D3r1ck01: Use SelectQueryBuilder instead of IDatabase::select() [core] - 10https://gerrit.wikimedia.org/r/818228 [22:58:23] (03Merged) 10jenkins-bot: Namespace a few more classes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818542 (owner: 10Reedy) [22:58:42] (03PS3) 10D3r1ck01: Migrate usage of `setMwGlobals()` to `overrideConfigValue(s)` [core] - 10https://gerrit.wikimedia.org/r/818222 [22:58:49] (03CR) 10Reedy: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/818274 (https://phabricator.wikimedia.org/T314099) (owner: 10TK-999) [22:59:13] (03Merged) 10jenkins-bot: Namespace SpecialCollection [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818543 (owner: 10Reedy) [22:59:24] (03Merged) 10jenkins-bot: tests: Rename to match includes [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818545 (owner: 10Reedy) [23:00:13] (03PS1) 10Legoktm: Set #[AllowDynamicProperties] for extending LuaSandbox test [php/luasandbox] - 10https://gerrit.wikimedia.org/r/818584 (https://phabricator.wikimedia.org/T314235) [23:00:52] (03CR) 10Legoktm: "This change is ready for review." [php/luasandbox] - 10https://gerrit.wikimedia.org/r/424982 (https://phabricator.wikimedia.org/T314235) (owner: 10Legoktm) [23:01:59] (03Merged) 10jenkins-bot: Namespace templates [extensions/Collection] - 10https://gerrit.wikimedia.org/r/818567 (owner: 10Reedy) [23:03:02] (03PS3) 10Reedy: preprocessor: Add missing field declarations [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/818421 (https://phabricator.wikimedia.org/T314099) [23:04:16] (03CR) 10DannyS712: [C: 03+2] "per codesearch, no references outside of this repo" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 (owner: 10Reedy) [23:04:55] 10LuaSandbox, 10PHP 8.2 support, 10Patch-For-Review: LuaSandbox test failures on PHP 8.2 - https://phabricator.wikimedia.org/T314235 (10Legoktm) a:03Legoktm With the above two patches I got everything to pass on 8.2.0alpha3. [23:06:17] (03CR) 10DannyS712: Namespace LuaStandalone engine (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 (owner: 10Reedy) [23:07:08] (03CR) 10DannyS712: [C: 03+2] "Sorry, misclick" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 (owner: 10Reedy) [23:07:41] (03CR) 10Reedy: Namespace LuaStandalone engine (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 (owner: 10Reedy) [23:08:11] (03Abandoned) 10Reedy: preprocessor: Add missing field declarations [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/818421 (https://phabricator.wikimedia.org/T314099) (owner: 10Reedy) [23:08:19] (03PS1) 10Daniel Kinzler: ParsoidHandler: measure input size in characters [core] - 10https://gerrit.wikimedia.org/r/818585 [23:08:21] (03PS1) 10Esanders: Enable new comment notifications on mobile [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818586 (https://phabricator.wikimedia.org/T301929) [23:10:28] (03PS1) 10Reedy: phpunit: Fix trivial dynamic property usages in tests [core] (REL1_37) - 10https://gerrit.wikimedia.org/r/818551 (https://phabricator.wikimedia.org/T314099) [23:13:11] (03CR) 10Legoktm: "> Patch Set 1:" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/424982 (https://phabricator.wikimedia.org/T314235) (owner: 10Legoktm) [23:19:58] (03Merged) 10jenkins-bot: Namespace LuaSandbox engine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818570 (owner: 10Reedy) [23:28:20] (03PS3) 10Reedy: Namespace tests [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818583 [23:35:02] (03PS1) 10TsepoThoabala: Fix capitalization in messages [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/818587 (https://phabricator.wikimedia.org/T311683) [23:36:11] (03PS1) 10Bartosz Dziewoński: Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) [23:37:42] (03CR) 10CI reject: [V: 04-1] Fix capitalization in messages [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/818587 (https://phabricator.wikimedia.org/T311683) (owner: 10TsepoThoabala) [23:44:18] (03CR) 10CI reject: [V: 04-1] Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) (owner: 10Bartosz Dziewoński) [23:45:33] (03PS1) 10Bartosz Dziewoński: Re-enable find-and-replace in comment widget [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818589 [23:46:30] (03PS2) 10TsepoThoabala: Fix capitalization in messages [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/818587 (https://phabricator.wikimedia.org/T311683) [23:47:52] 10Codex, 10Design-Systems-Team: Thumbnail: determine how to handle updated `thumbnail` prop - https://phabricator.wikimedia.org/T312540 (10DannyS712) Just came across this while creating a configurable demo for the Card component. I suggest for changing once the image is loaded that the default be to show a pl... [23:50:31] legoktm: I just read your blog post about your first MediaWiki patch. Interesting story, as is often the case when things go wrong. So I guess you could say my first patch was less interesting: https://static-bugzilla.wikimedia.org/34972 [23:50:47] legoktm: This was at the tail end of the SVN + CodeReview era, during the "code slush" [23:52:53] Looking through the old wikitech-l posts I sometimes have nostalgia for those simpler times, even though CodeReview was a worse system than Gerrit in several important ways [23:55:05] (03CR) 10DannyS712: Namespace LuaStandalone engine (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 (owner: 10Reedy) [23:56:18] (03CR) 10Reedy: Namespace LuaStandalone engine (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/818571 (owner: 10Reedy) [23:59:40] PleaseStand: neat! interesting to learn you were the one who added wgRelevantPageName client-side.