[00:00:40] I always enjoy reading old mailing list threads to see how various debates of the time were argued (or not) [00:01:22] and I appreciated the TechCom RfC era for the same reason, participating in IRC office hours that led to various architectural changes [00:02:47] (03CR) 10CI reject: [V: 04-1] JsonCodec: fix en/decoding of nested objects and stdClass objects [core] - 10https://gerrit.wikimedia.org/r/812076 (https://phabricator.wikimedia.org/T312589) (owner: 10C. Scott Ananian) [00:05:39] (03PS1) 10Umherirrender: Various doc fixes about false and null on method arguments/return types [core] - 10https://gerrit.wikimedia.org/r/818590 [00:25:48] legoktm: Another interesting fact then: I am also the one who made MediaWiki send the X-Frame-Options header, not by writing the patch (that was Tim Starling) but by sending an email to security@ [00:25:52] https://lists.wikimedia.org/pipermail/mediawiki-announce/2011-January/000093.html [00:31:01] :D you might be interested in https://phabricator.wikimedia.org/T255881 btw [00:31:08] trying to remember my first security bug [00:32:21] https://phabricator.wikimedia.org/T53837 [00:33:38] legoktm: T53837 still not fixed yet? "Access Denied: Restricted Task" [00:34:07] PleaseStand: just subscribed you. I entirely lost track of it, thought we had fixed it years ago [00:34:53] hm, someone in 2018 figured out it was worse than what I originally reported [00:35:39] https://phabricator.wikimedia.org/T62218 is probably my first *fixed* security bug :D [00:40:22] (03PS1) 10Bartosz Dziewoński: Re-enable keyboard sequences for template, table etc. in new topic tool [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818591 (https://phabricator.wikimedia.org/T311653) [00:41:50] PleaseStand: oh, I remember https://phabricator.wikimedia.org/T73167 being one of the coolest attacks I'd read of at the time :) [01:02:23] (03PS2) 10Bartosz Dziewoński: Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) [01:09:23] (03CR) 10CI reject: [V: 04-1] Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) (owner: 10Bartosz Dziewoński) [01:09:33] legoktm: Of course, the "add a timestamp to tokens" thing that I think was already being worked on at the time would have made that cool attack difficult if not impossible to pull off [01:09:54] By the way, I almost got access to security tasks in 2015 but had second thoughts about the Volunteer NDA [01:09:58] https://phabricator.wikimedia.org/T97929 [01:16:06] what made you not want to sign it, if you don't mind sharing? [01:19:57] legoktm: Remember, this was during the period that "superprotect" was a thing. At the time I was concerned that an NDA would limit my ability to express my opinions regarding WMF, should I choose to do so. [01:20:06] ah, right [01:22:52] PleaseStand: I don't know if the volunteer NDA I signed in January is different from the one that was used in 2015, but I just re-read it and it seems rather clear to me about only covering "Confidential Information", with no clauses that could be construed as non-disparagement [01:25:58] the old wording if its different is probably still in legalpad on phab [01:30:02] (03PS3) 10Bartosz Dziewoński: Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) [01:30:04] (03PS1) 10Bartosz Dziewoński: EventDispatcherTest: Use `null` instead of special placeholder file [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818592 [01:33:36] not sure if y'all can see https://phabricator.wikimedia.org/legalpad/view/2/ [01:33:39] that has the diffs [01:33:55] (03PS4) 10Bartosz Dziewoński: Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) [01:34:11] only those that have been added into it, can see legalpad [01:34:17] hm [01:34:22] well it hasn't changed since March 2015 [01:34:41] (03PS5) 10Bartosz Dziewoński: Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) [01:35:12] I signed my NDA as a PDF, but that was because it had an Appendix A for root access [01:37:44] legoktm: you and Ori are special [01:38:03] <3 [01:40:31] (03CR) 10CI reject: [V: 04-1] Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) (owner: 10Bartosz Dziewoński) [01:44:33] legoktm: Maybe I'll look at those security tasks tomorrow. If you don't mind, I have some questions about code review, if it isn't too late for you tonight. [01:44:58] nope, fire away [01:46:13] So even though I have been contributing for years, I always worry, "Am I adding the right reviewers to my patches?" [01:47:54] https://www.mediawiki.org/wiki/Developers/Maintainers isn't well maintained. [01:49:06] "Parent5446" is still under Authentication and Authorization even though he has not been active in years [01:50:02] And then there's changes that could fit under multiple categories, or don't fit nicely under any of them [01:50:15] yeah.... :| [01:52:04] usually I will add the bug reporter (if they're a +2er), then whoever touched it last, either as a reviewer or author. And then I fallback to people who are usually very nice about reviewing whatever like R.eedy, J.ames_F, K.rinkle [01:53:42] as the saying goes, sometimes its easier to ask for forgiveness compared to permission, sometimes you just need to pick people who you think might be the best, but aren't (but hopefully they will triage and add someone who should be able to help) [01:56:57] Of course, a special case of "whoever touched it last" is when that change introduced an obvious bug fixed in my patch. Then my patch is usually merged very quickly :) [01:57:16] If they are a +2er [01:57:35] (03PS1) 10Bartosz Dziewoński: Add more tests cases using the "tracked" template [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818593 [01:57:37] (03PS1) 10Bartosz Dziewoński: Ignore "tracked" templates at the beginning of comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818594 (https://phabricator.wikimedia.org/T313097) [02:00:06] (03PS6) 10Bartosz Dziewoński: Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) [02:00:50] (03PS7) 10Bartosz Dziewoński: Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) [02:01:19] Regarding Developers/Maintainers, one of my open change sets is an example of something that doesn't fall into just one category [02:01:54] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/818110 [02:02:08] Configuration? Internationalization? Something else? [02:02:40] So far I just added the last person to touch the file [02:06:35] (03CR) 10CI reject: [V: 04-1] Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) (owner: 10Bartosz Dziewoński) [02:10:56] (03CR) 10Bartosz Dziewoński: [C: 03+2] Enable new comment notifications on mobile [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818586 (https://phabricator.wikimedia.org/T301929) (owner: 10Esanders) [02:11:26] 10DiscussionTools, 10Editing-team (FY2021-22 Kanban Board), 10Goal, 10Patch-For-Review: Introduce new comment notifications within Reply Tool (mobile) - https://phabricator.wikimedia.org/T301929 (10matmarex) a:03Esanders [02:13:50] (03PS8) 10Bartosz Dziewoński: Notify users when a topic they are subscribed to is removed from a page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818588 (https://phabricator.wikimedia.org/T299657) [02:14:20] legoktm: Any thoughts? Is there anyone else you think I should add? [02:14:34] sorry, got distracted [02:14:56] > // @todo UGLY UGLY [02:14:57] nice [02:16:24] PleaseStand: this is a regression from the recent config refactor right? it used to work but now because extension.json namespaces are added after it doesn't? [02:16:45] (03Merged) 10jenkins-bot: Enable new comment notifications on mobile [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818586 (https://phabricator.wikimedia.org/T301929) (owner: 10Esanders) [02:18:33] legoktm: Which config refactor change are you thinking of? You were the one who changed Scribunto in 2017 to use extension.json instead of the CanonicalNamespaces hook. [02:22:15] Daniel's from a few months ago [02:24:51] maybe it was Aryeh's, not sure [02:25:07] because I really thought this worked when I introduced it into extension.json however many years ago [02:25:22] (03CR) 10Legoktm: [C: 03+2] Don't add $wgExtraNamespaces to $wgCanonicalNamespaceNames [core] - 10https://gerrit.wikimedia.org/r/818110 (https://phabricator.wikimedia.org/T314013) (owner: 10PleaseStand) [02:32:48] Legoktm: just tested in 1.38, broken in that version as well [02:34:52] PleaseStand: can you try 1.37? because 1.38 has said config refactor [02:35:44] (but good to know, we can cherry-pick to 1.38) [02:39:22] (03Merged) 10jenkins-bot: Don't add $wgExtraNamespaces to $wgCanonicalNamespaceNames [core] - 10https://gerrit.wikimedia.org/r/818110 (https://phabricator.wikimedia.org/T314013) (owner: 10PleaseStand) [02:40:38] Weird, on the NoLocalSettings page in 1.37, I see a bunch of "Deprecated: Premature access to service container" warnings [02:41:15] Then PHP 8.1 deprecation warnings on the first page of the actual installer [02:42:00] I guess that's a reason why "PHP 8.1 is not supported." yet [02:43:04] Turned off the deprecation warnings [02:48:13] legoktm: same bug exists in 1.37 as well [02:48:31] bummer [02:48:35] well, glad you fixed it!! [02:49:05] 10MediaWiki-Internationalization, 10Performance-Team, 10Scap, 10Release-Engineering-Team (Radar): Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Krinkle) [02:50:05] legoktm: Problem is, I think the fix has the potential to break any extension that still accesses $wgCanonicalNamespaceNames directly [02:50:23] So it may not be appropriate to backport [02:50:33] I think you're right [02:50:45] also it's a very old bug, not a recent one [02:52:32] legoktm: and sysadmins may have to run namespaceDupes.php; not the sort of thing that should be part of a point release IMO. [02:54:12] agreed [02:55:51] Then I should probably add an entry to RELEASE-NOTES-1.39 then? [02:56:30] yeah that would be nice [03:11:06] 10ConfirmEdit (CAPTCHA extension): Add a hook for altering captcha strength in FancyCaptcha - https://phabricator.wikimedia.org/T189546 (10Tgr) [03:13:43] (03CR) 10Gergő Tisza: "I wonder if it would be better to also pass the acting user to the hook (cf T176589), although that would probably require a little refact" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/778678 (https://phabricator.wikimedia.org/T303433) (owner: 10Zabe) [03:14:21] 10DiscussionTools, 10Editing QA, 10Editing-team (FY2021-22 Kanban Board), 10Goal, 10MW-1.39-notes (1.39.0-wmf.23; 2022-08-01): Introduce new comment notifications within Reply Tool (mobile) - https://phabricator.wikimedia.org/T301929 (10matmarex) [03:15:17] 10MediaWiki-extensions-ThrottleOverride, 10ConfirmEdit (CAPTCHA extension), 10Patch-For-Review: Offer a hook manipulating the need for solving captchas - https://phabricator.wikimedia.org/T176589 (10Tgr) {607452ef0568751ac010bc6cf457c11118517150} added a similar hook, but it does not include the user (who I... [03:15:41] 10DiscussionTools, 10Editing-team (FY2021-22 Kanban Board), 10Patch-For-Review: Replying to bulleted list edge case (places reply in wrong location) - https://phabricator.wikimedia.org/T313097 (10Legoktm) >>! In T313097#8079873, @matmarex wrote: > It's because of the {{tracked}} templates on that page, which... [03:42:40] (03PS12) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [03:43:06] (03PS13) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [04:26:13] 10MediaWiki-Maintenance-system, 10Patch-For-Review: Instantiate MaintenanceScripts after extensions have registered with the autoloader - https://phabricator.wikimedia.org/T314231 (10Legoktm) > Proposed solution: move the config update logic out of ExtensionRegistry::loadFromQueue(), but keep the autoloader lo... [04:41:34] (03PS1) 10PleaseStand: Add release notes for 1636c24306b9fa5c [core] - 10https://gerrit.wikimedia.org/r/818596 (https://phabricator.wikimedia.org/T314013) [04:43:30] (03PS14) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [05:29:58] 10Abstract Wikipedia team: Check front end code for obscure Benjamin array bugs - https://phabricator.wikimedia.org/T314237 (10DMartin-WMF) [05:35:21] 103D: Opening 3D STL image then arrowing to non-3D image 1) leaves 3D label and 2) left aligns other images - https://phabricator.wikimedia.org/T314238 (10Novem_Linguae) [05:44:28] (03CR) 10Subramanya Sastry: Move knowledge about the attribs array out of TransformContext (032 comments) [core] - 10https://gerrit.wikimedia.org/r/815779 (owner: 10Daniel Kinzler) [05:46:42] (03CR) 10Subramanya Sastry: Move dowgrade logic into HTMLTransformInput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/816134 (owner: 10Daniel Kinzler) [05:50:50] (03CR) 10Subramanya Sastry: [C: 03+2] ParsoidHandler: measure input size in characters [core] - 10https://gerrit.wikimedia.org/r/818585 (owner: 10Daniel Kinzler) [05:55:55] 10Wikimedia-Site-requests: Change Vietnamese Wikibooks article count method to any - https://phabricator.wikimedia.org/T314239 (10mxn) [06:09:47] (03Merged) 10jenkins-bot: ParsoidHandler: measure input size in characters [core] - 10https://gerrit.wikimedia.org/r/818585 (owner: 10Daniel Kinzler) [06:22:38] (03PS1) 10Fomafix: Remove eslint rule max-lines: off [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818598 [06:24:48] 10Wikimedia-Site-requests, 10Patch-For-Review: Change Vietnamese Wikibooks article count method to any - https://phabricator.wikimedia.org/T314239 (10Stang) a:03Stang [06:27:20] (03CR) 10Fomafix: "https://integration.wikimedia.org/ci/job/mwgate-node14-docker/47949/console contains:" [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818598 (owner: 10Fomafix) [06:31:04] (03PS2) 10Fomafix: Remove eslint rule max-lines: off and shorten comments [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818598 [07:54:47] (03CR) 10Lakejason0: "This change is ready for review." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/818554 (owner: 10Lakejason0) [07:55:15] (03PS2) 10Lakejason0: Fix deprecated usage of addModules and addModuleStyles [extensions/Comments] - 10https://gerrit.wikimedia.org/r/818554 [07:55:54] (03PS3) 10Lakejason0: Fix deprecated usage of addModules and addModuleStyles [extensions/Comments] - 10https://gerrit.wikimedia.org/r/818554 [08:30:58] (03CR) 10Matěj Suchánek: "This change is ready for review." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814125 (https://phabricator.wikimedia.org/T233004) (owner: 10Matěj Suchánek) [08:31:02] (03CR) 10Matěj Suchánek: "This change is ready for review." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/813686 (owner: 10Matěj Suchánek) [08:44:06] (03PS1) 10Fomafix: Trigger change of styles in a requestAnimationFrame callback [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818600 [09:05:36] (03PS1) 10Novem Linguae: Prevent race condition when tagging for deletion [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/818601 (https://phabricator.wikimedia.org/T238025) [09:12:21] (03CR) 10CI reject: [V: 04-1] Prevent race condition when tagging for deletion [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/818601 (https://phabricator.wikimedia.org/T238025) (owner: 10Novem Linguae) [09:18:29] (03PS1) 10Novem Linguae: Handle XFD log page not existing [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/818603 (https://phabricator.wikimedia.org/T313178) [09:30:01] (03PS2) 10Novem Linguae: Prevent race condition when tagging for deletion [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/818601 (https://phabricator.wikimedia.org/T238025) [09:33:19] (03PS3) 10Novem Linguae: Make PageTriage wiki-agnostic [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/815686 [09:36:47] (03CR) 10CI reject: [V: 04-1] Prevent race condition when tagging for deletion [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/818601 (https://phabricator.wikimedia.org/T238025) (owner: 10Novem Linguae) [09:38:50] (03PS3) 10Novem Linguae: Prevent race condition when tagging for deletion [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/818601 (https://phabricator.wikimedia.org/T238025) [09:41:23] (03CR) 10DannyS712: "bump, I believe I have addressed the issues raised" [design/codex] - 10https://gerrit.wikimedia.org/r/802959 (owner: 10DannyS712) [09:48:25] (03PS1) 10Daniel Kinzler: Parsoid: Fix e2e tests for size limits. [core] - 10https://gerrit.wikimedia.org/r/818604 [09:56:01] 10CheckUser: The mass locker button shown on the 'get users' screen can produce a URL too long to be accepted by the browser - https://phabricator.wikimedia.org/T314243 (10Dreamy_Jazz) [09:59:10] 10CheckUser: The mass locker button shown on the 'get users' screen can produce a URL too long to be accepted by the browser - https://phabricator.wikimedia.org/T314243 (10Dreamy_Jazz) [10:00:39] 10CheckUser: The mass locker button shown on the 'get users' screen can produce a URL too long to be accepted by the browser - https://phabricator.wikimedia.org/T314243 (10Dreamy_Jazz) [10:01:49] (03CR) 10CI reject: [V: 04-1] Parsoid: Fix e2e tests for size limits. [core] - 10https://gerrit.wikimedia.org/r/818604 (owner: 10Daniel Kinzler) [10:12:45] (03CR) 10Daniel Kinzler: "Fails because GrowthExperiments has a selenium test that runs against a page that is a lot larger than the 20KB limit imposed by this patc" [core] - 10https://gerrit.wikimedia.org/r/818604 (owner: 10Daniel Kinzler) [10:25:05] (03PS2) 10Daniel Kinzler: ExtensionRegistry: split exportExtractedData [core] - 10https://gerrit.wikimedia.org/r/818574 (https://phabricator.wikimedia.org/T314231) [10:50:31] (03PS3) 10Fomafix: Remove overwrite by URL parameter skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818451 [10:50:43] (03PS4) 10Fomafix: Rework JavaScript [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818224 [10:50:55] (03PS3) 10Fomafix: Optimize ResourceLoader usage [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818533 [10:51:13] (03PS1) 10Fomafix: Support the usetheme URL parameter to detect the initial loaded module [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818605 [10:52:14] (03PS2) 10Fomafix: Trigger change of styles in a requestAnimationFrame callback [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818600 [10:53:15] (03CR) 10CI reject: [V: 04-1] Support the usetheme URL parameter to detect the initial loaded module [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818605 (owner: 10Fomafix) [10:55:56] (03PS2) 10Fomafix: Support the usetheme URL parameter to detect the initial loaded module [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818605 [11:00:46] (03CR) 10Fomafix: "On server side an unknown theme name in the usetheme URL parameter like usetheme=foo leads to the default theme instead of the theme in th" [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818605 (owner: 10Fomafix) [11:01:25] (03PS4) 10Lakejason0: Fix deprecated usage of addModules and addModuleStyles [extensions/Comments] - 10https://gerrit.wikimedia.org/r/818554 [11:02:34] (03Abandoned) 10Fomafix: Use indexOf() instead of match() [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818225 (owner: 10Fomafix) [11:44:02] (03PS1) 10Umherirrender: Remove unneeded use of TitleValue::newFromPage [core] - 10https://gerrit.wikimedia.org/r/818607 [11:52:43] (03CR) 10Umherirrender: [C: 03+2] Add regression test for RunVariableGenerator [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814106 (owner: 10Matěj Suchánek) [11:58:06] (03CR) 10CI reject: [V: 04-1] Remove unneeded use of TitleValue::newFromPage [core] - 10https://gerrit.wikimedia.org/r/818607 (owner: 10Umherirrender) [12:07:15] (03Merged) 10jenkins-bot: Add regression test for RunVariableGenerator [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814106 (owner: 10Matěj Suchánek) [12:22:29] (03PS7) 10Matěj Suchánek: Add regression test for abuse log entries [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814177 [12:23:03] (03CR) 10Matěj Suchánek: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814177 (owner: 10Matěj Suchánek) [12:26:12] (03PS2) 10Umherirrender: Remove unneeded use of TitleValue::newFromPage [core] - 10https://gerrit.wikimedia.org/r/818607 [12:28:30] (03CR) 10Umherirrender: Add regression test for abuse log entries (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814177 (owner: 10Matěj Suchánek) [12:33:58] (03PS8) 10Matěj Suchánek: Add regression test for abuse log entries [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814177 [12:34:00] (03CR) 10Matěj Suchánek: Add regression test for abuse log entries (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814177 (owner: 10Matěj Suchánek) [12:39:38] (03CR) 10Umherirrender: [C: 03+2] Add regression test for abuse log entries [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814177 (owner: 10Matěj Suchánek) [12:39:44] (03PS2) 10Umherirrender: Make a separate method for ManualLogEntry construction [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814287 (owner: 10Matěj Suchánek) [12:39:48] (03CR) 10Umherirrender: [C: 03+2] Make a separate method for ManualLogEntry construction [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814287 (owner: 10Matěj Suchánek) [12:54:36] (03Merged) 10jenkins-bot: Add regression test for abuse log entries [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814177 (owner: 10Matěj Suchánek) [12:57:46] (03Merged) 10jenkins-bot: Make a separate method for ManualLogEntry construction [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/814287 (owner: 10Matěj Suchánek) [13:50:52] 10ISA: Texts modifications - feedback notes from translators - https://phabricator.wikimedia.org/T300982 (10Anthere) Thank you for doing this Nikerabbit [13:53:55] 10AbuseFilter (Overhaul-2020), 10Patch-For-Review, 10Schema-change: Read from and write to `actor` table in AbuseFilter - https://phabricator.wikimedia.org/T188180 (10Umherirrender) `$wgAbuseFilterNotifications = 'rc'` or `'rcandudp'` is broken as well and throws `CannotCreateActorException` (it's post send,... [13:56:05] 10Desktop Improvements: CSS classes related to TOC lost styling in Vector-2022 - https://phabricator.wikimedia.org/T314254 (10XanonymusX) [14:05:51] (03CR) 10Umherirrender: Treat consequences params less aggressively and consistently (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/795408 (owner: 10Matěj Suchánek) [14:14:37] (03CR) 10Umherirrender: Migrate usage of `setMwGlobals()` to `overrideConfigValue(s)` (031 comment) [core] - 10https://gerrit.wikimedia.org/r/818222 (owner: 10D3r1ck01) [14:27:30] (03PS1) 10Umherirrender: Use DISTINCT on LazyVariableComputer::getLinksFromDB [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/818610 [14:34:12] (03PS1) 10Umherirrender: Clean up line indent with mixed tabs and whitespaces [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/818611 [14:43:17] 10MediaWiki-Internationalization, 10Wikimedia-Site-requests, 10I18n, 10Patch-For-Review: Changing the ns2/ns3 robot policy on itwiki - https://phabricator.wikimedia.org/T314165 (10Superpes15) >>! In T314165#8117420, @Stang wrote: > There's still [[ https://global-search.toolforge.org/?q=%22__INDICE__%22 |... [15:10:53] 10DiscussionTools: Removal from talkpage redirects of new talkpage invitation to begin discussion - https://phabricator.wikimedia.org/T314255 (10Paine_Ellsworth) [15:17:15] (03CR) 10D3r1ck01: Migrate usage of `setMwGlobals()` to `overrideConfigValue(s)` (031 comment) [core] - 10https://gerrit.wikimedia.org/r/818222 (owner: 10D3r1ck01) [15:33:02] (03CR) 10Matěj Suchánek: [C: 03+2] Clean up line indent with mixed tabs and whitespaces [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/818611 (owner: 10Umherirrender) [15:42:36] 10DiscussionTools: Removal from talkpage redirects of new talkpage invitation to begin discussion - https://phabricator.wikimedia.org/T314255 (10Paine_Ellsworth) Also found on redlinked talk pages. Example: * https://en.wikipedia.org/w/index.php?title=Talk:Sega_3D_Fukkoku_Archives_3:_Final_Stage&action=edit&red... [15:45:59] (03CR) 10DLynch: [C: 03+2] EventDispatcherTest: Use `null` instead of special placeholder file [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818592 (owner: 10Bartosz Dziewoński) [15:50:00] (03Merged) 10jenkins-bot: Clean up line indent with mixed tabs and whitespaces [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/818611 (owner: 10Umherirrender) [15:52:14] (03Merged) 10jenkins-bot: EventDispatcherTest: Use `null` instead of special placeholder file [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818592 (owner: 10Bartosz Dziewoński) [16:09:12] 10Wikimedia-Site-requests: Requesting logo change for ne.wikipedia.org (Mobile version) - https://phabricator.wikimedia.org/T311700 (10Badakaji) I have converted the files ([[https://commons.wikimedia.org/wiki/File:Wikipedia-wordmark-ne.svg | #1]] [[https://commons.wikimedia.org/wiki/File:Wikipedia-wordmark-ne-b... [16:15:23] 10DiscussionTools: Removal from talkpage redirects of new talkpage invitation to begin discussion - https://phabricator.wikimedia.org/T314255 (10Paine_Ellsworth) As can be seen by my comment above, the new invitation to begin a discussion notice is found on all talk page redirects, to include those that are uncr... [16:47:40] 10MediaWiki-extensions-Translate: [TUX] Insertables don't add state in undo stack - https://phabricator.wikimedia.org/T64099 (10Nikerabbit) Awesome! Thanks so much. [17:01:22] 10MobileFrontend, 10Moderator-Tools-Team, 10Readers-Web-Backlog, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), 10Regression: Mobile frontend cannot identify special page from nonexistent page - https://phabricator.wikimedia.org/T310679 (10Jdlrobson) 05Open→03Resolved a:03Jdlrobson [17:01:56] 10MobileFrontend, 10MinervaNeue, 10Regression: Links with .mw-usertoollinks-contribs-no-edits are not red in Minerva on mobile platform - https://phabricator.wikimedia.org/T314216 (10Jdlrobson) This is by design. The link does not represent a page that is editable, therefore it is misleading for it to be red... [17:02:02] 10MobileFrontend, 10MinervaNeue, 10Regression: Links with .mw-usertoollinks-contribs-no-edits are not red in Minerva on mobile platform - https://phabricator.wikimedia.org/T314216 (10Jdlrobson) 05Open→03Declined [17:37:09] (03PS2) 10Umherirrender: Use DISTINCT on LazyVariableComputer::getLinksFromDB [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/818610 [17:40:38] (03CR) 10Umherirrender: "VariableHolder::$forFilter is used as optimisation on edit. To get the old links it is necessary to parse the old wikitext, but on edit th" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/776320 (owner: 10Matěj Suchánek) [17:59:27] (03CR) 10Legoktm: [C: 03+2] "Thanks :)" [core] - 10https://gerrit.wikimedia.org/r/818596 (https://phabricator.wikimedia.org/T314013) (owner: 10PleaseStand) [18:01:27] (03PS6) 10Legoktm: rdbms: Bump the minimum required version of PG to 9.5 [core] - 10https://gerrit.wikimedia.org/r/818473 (https://phabricator.wikimedia.org/T307616) (owner: 10Ladsgroup) [18:01:56] (03CR) 10Legoktm: [C: 03+1] "+1 on raising PG to 9.5, haven't reviewed the actual code changes." [core] - 10https://gerrit.wikimedia.org/r/818473 (https://phabricator.wikimedia.org/T307616) (owner: 10Ladsgroup) [18:04:00] 10MediaWiki-General, 10SRE, 10Traffic-Icebox, 10Patch-For-Review: Investigate query parameter normalization for MW/services - https://phabricator.wikimedia.org/T138093 (10ori) Rolling this out to the high-traffic wikis will be a little bit tricky. When we turn it on, we can expect the cache hit rate to go... [18:14:20] (03Merged) 10jenkins-bot: Add release notes for 1636c24306b9fa5c [core] - 10https://gerrit.wikimedia.org/r/818596 (https://phabricator.wikimedia.org/T314013) (owner: 10PleaseStand) [18:17:10] 10Design, 10MediaWiki-General, 10UI-Standardization, 10Vector, and 3 others: Use standard external link icon for external links - https://phabricator.wikimedia.org/T261391 (10Ahecht) I agree with Nikki here that the arrow should be leaving the box, not pointing to the corner. [18:17:31] (03CR) 10Umherirrender: "The VariableGenerator only adds some more variable to the holder, the generic vars are still added as last part to the holder, but a bit e" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/808371 (owner: 10Matěj Suchánek) [18:20:54] 10MediaWiki-Maintenance-system: Maintenance scripts with required parameters show error messages when --help is given - https://phabricator.wikimedia.org/T314257 (10Mainframe98) [18:24:50] 10Elections: Create list of developers eligible to vote on the 2022 board vote - https://phabricator.wikimedia.org/T309754 (10taavi) As requested by @Legoktm, I've generated an updated list of toolforge maintainer SUL accounts: P32117 The changes to the previous list are as follows: 1. Filtered out all developer... [18:31:58] (03CR) 10DannyS712: [C: 04-1] "mostly LGTM, a few small issues" [design/codex] - 10https://gerrit.wikimedia.org/r/817813 (owner: 10Catrope) [18:33:04] 10MediaWiki-Maintenance-system: importSites.php and exportSites.php have their parent::__construct call too late - https://phabricator.wikimedia.org/T314258 (10Mainframe98) [18:33:12] 10Design, 10Desktop Improvements, 10Mobile, 10Readers-Web-Backlog (Kanbanana-2022-23-Q1), 10Verified: Article toolbar shrinks on iPhone - https://phabricator.wikimedia.org/T313098 (10Iniquity) 05Open→03Resolved [18:33:16] 10Design, 10Desktop Improvements, 10Mobile, 10Readers-Web-Backlog (Kanbanana-2022-23-Q1), 10Verified: Article toolbar shrinks on iPhone - https://phabricator.wikimedia.org/T313098 (10Iniquity) Thanks! Fixed. [18:34:38] 10DiscussionTools: Removal from talkpage redirects of new talkpage invitation to begin discussion - https://phabricator.wikimedia.org/T314255 (10matmarex) Thanks for the bug report! If I understand correctly, you're talking about two different situations: 1. When the talk page itself is a redirect – In which c... [18:36:21] 10MediaWiki-Maintenance-system: importSites.php and exportSites.php have their parent::__construct call too late - https://phabricator.wikimedia.org/T314258 (10Mainframe98) [18:40:24] 10MediaWiki-Maintenance-system: Maintenance scripts with required parameters and/or arguments show error messages when --help is given - https://phabricator.wikimedia.org/T314257 (10Mainframe98) [18:41:47] (03CR) 10DannyS712: [C: 04-1] Button, Tabs: Factor out common slot content analysis code (032 comments) [design/codex] - 10https://gerrit.wikimedia.org/r/817814 (owner: 10Catrope) [18:49:47] 10Wikimedia-Site-requests, 10Patch-For-Review: Requesting logo change for ne.wikipedia.org (Mobile version) - https://phabricator.wikimedia.org/T311700 (10Stang) a:03Stang [18:50:39] 10UniversalLanguageSelector, 10Language-Team (Language-2022-July-September): Language selector on multilingual wikis needs adjustments - https://phabricator.wikimedia.org/T314021 (10Yupik) As someone who regularly moves between multiple language versions on wp, the French wp language selector is horrendous. I... [18:52:22] 10MediaWiki-Maintenance-system: Premature access to service container in rebuildFileCache.php - https://phabricator.wikimedia.org/T314259 (10Mainframe98) [18:55:12] (03PS15) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [18:57:34] (03PS3) 10Daniel Kinzler: ExtensionRegistry: split exportExtractedData [core] - 10https://gerrit.wikimedia.org/r/818574 (https://phabricator.wikimedia.org/T314231) [19:02:50] (03CR) 10CI reject: [V: 04-1] Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 (owner: 10Universal Omega) [19:04:11] 10DiscussionTools: Removal from talkpage redirects of new talkpage invitation to begin discussion - https://phabricator.wikimedia.org/T314255 (10matmarex) In fact, there's also case 3: 3. When the talk page of a redirect page exists, and is not a redirect. According to this query: https://quarry.wmcloud.org/que... [19:11:28] (03PS1) 10Umherirrender: Check against $wgTextModelsToParse when compute variables from parser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/818615 [19:12:46] (03PS16) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [19:15:41] (03PS17) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [19:20:15] (03PS18) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [19:20:33] (03PS2) 10Umherirrender: Check against $wgTextModelsToParse when compute variables from parser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/818615 [19:22:59] (03PS19) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [19:35:39] (03PS20) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [19:38:10] (03PS3) 10Fomafix: Support the usetheme URL parameter to detect the initial loaded module [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818605 [19:38:49] (03CR) 10Fomafix: Support the usetheme URL parameter to detect the initial loaded module (031 comment) [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818605 (owner: 10Fomafix) [19:41:39] (03CR) 10DannyS712: "This change is ready for review." [design/codex] - 10https://gerrit.wikimedia.org/r/818555 (https://phabricator.wikimedia.org/T314236) (owner: 10DannyS712) [19:45:54] (03PS21) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [19:47:22] (03PS22) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [19:50:55] (03PS1) 10Fomafix: Show preview-note also on default theme [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818617 [19:53:00] 10MassMessage: Some MassMessages not reaching cywikibooks - https://phabricator.wikimedia.org/T313672 (10Rschen7754) Also https://mk.wikibooks.org/wiki/Викикниги:Портал на заедницата [19:57:35] (03PS23) 10Universal Omega: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 [20:01:08] 10MediaWiki-Core-Snapshots, 10MediaWiki-Maintenance-system, 10Regression: importSites.php and exportSites.php have their parent::__construct call too late - https://phabricator.wikimedia.org/T314258 (10Reedy) p:05Triage→03High [20:01:17] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10DarkMode: Provide a dark / night mode skin or theme - https://phabricator.wikimedia.org/T26070 (10HLHJ) Two related issues: First, I trust any skins will meet [[ https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Accessibility#Color | colourb... [20:02:07] (03CR) 10Reedy: [C: 03+2] User: Allow dynamic properties on PHP 8.2 [core] - 10https://gerrit.wikimedia.org/r/818274 (https://phabricator.wikimedia.org/T314099) (owner: 10TK-999) [20:09:27] (03PS1) 10Zabe: (import|export)Sites.php: Move parent::__construct call above addDescription [core] - 10https://gerrit.wikimedia.org/r/818618 (https://phabricator.wikimedia.org/T314258) [20:13:47] (03PS1) 10MusikAnimal: Add support for Vector 2022 and update dark mode styles [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/818619 [20:15:26] (03PS2) 10MusikAnimal: Add support for Vector 2022 and update dark mode styles [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/818619 [20:15:28] (03CR) 10CI reject: [V: 04-1] Add support for Vector 2022 and update dark mode styles [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/818619 (owner: 10MusikAnimal) [20:16:49] (03CR) 10CI reject: [V: 04-1] Add support for Vector 2022 and update dark mode styles [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/818619 (owner: 10MusikAnimal) [20:16:57] (03Merged) 10jenkins-bot: User: Allow dynamic properties on PHP 8.2 [core] - 10https://gerrit.wikimedia.org/r/818274 (https://phabricator.wikimedia.org/T314099) (owner: 10TK-999) [20:17:14] (03PS3) 10MusikAnimal: Add support for Vector 2022 and update dark mode styles [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/818619 [20:18:55] (03PS2) 10Fomafix: Use jQuery instead of HTML parsing to create elements [extensions/Theme] - 10https://gerrit.wikimedia.org/r/816305 [20:18:57] (03PS1) 10Fomafix: Use JavaScript variable instead of DOM query [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818620 [20:23:58] (03CR) 10MusikAnimal: [C: 03+2] "Self-merging as sole maintainer of WMF-undeployed extension" [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/818619 (owner: 10MusikAnimal) [20:24:52] (03CR) 10Universal Omega: [C: 03+2] Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 (owner: 10Universal Omega) [20:25:57] (03Merged) 10jenkins-bot: Add support for Vector 2022 and update dark mode styles [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/818619 (owner: 10MusikAnimal) [20:28:17] 10Desktop Improvements, 10Readers-Web-Backlog (Kanbanana-2022-23-Q1): #right-navigation Tab Moves to The Left, Next to #left-navigation, on browsers that do not have full Flexbox support in Vector-2022 - https://phabricator.wikimedia.org/T309223 (10Edtadros) a:05Edtadros→03ovasileva === Test Result - Prod... [20:29:41] 10Desktop Improvements, 10Readers-Web-Backlog (Kanbanana-2022-23-Q1): #right-navigation Tab Moves to The Left, Next to #left-navigation, on browsers that do not have full Flexbox support in Vector-2022 - https://phabricator.wikimedia.org/T309223 (10Edtadros) [20:32:35] 10Desktop Improvements, 10Chinese-Sites, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), 10Readers-Web-Backlog (Kanbanana-2022-23-Q1), 10Regression: Variant tab in Vector 2022 is too close to the tab on its left - https://phabricator.wikimedia.org/T312212 (10Edtadros) a:05Edtadros→03ovasileva === Test R... [20:33:40] 10Desktop Improvements, 10Chinese-Sites, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), 10Readers-Web-Backlog (Kanbanana-2022-23-Q1), 10Regression: Variant tab in Vector 2022 is too close to the tab on its left - https://phabricator.wikimedia.org/T312212 (10Edtadros) [20:34:17] (03Merged) 10jenkins-bot: Replace the CosmosRail class with a CosmosRailBuilder service [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/818553 (owner: 10Universal Omega) [20:35:41] 10Desktop Improvements, 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Kanbanana-2022-23-Q1): Enable language switching button for logged-out users on non-pilot wikis - https://phabricator.wikimedia.org/T312861 (10Edtadros) a:05Edtadros→03ovasileva === Test Result - Prod **Status:** ✅ PASS **Environm... [20:37:09] 10Desktop Improvements, 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Kanbanana-2022-23-Q1): Enable language switching button for logged-out users on non-pilot wikis - https://phabricator.wikimedia.org/T312861 (10Edtadros) [20:38:17] 10Desktop Improvements, 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Kanbanana-2022-23-Q1): Collapse sidebar by default for logged-out people - https://phabricator.wikimedia.org/T287609 (10Edtadros) a:05Edtadros→03ovasileva === Test Result - Prod **Status:** ✅ PASS **Environment:** frwiki **OS:** m... [20:39:13] 10Desktop Improvements, 10Vector, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), 10Readers-Web-Backlog (Kanbanana-2022-23-Q1): [Bug] Safari doesn't allow font-size scaling on iPad for users viewing legacy and modern Vector - https://phabricator.wikimedia.org/T311795 (10Pythoncoder) 05Resolved→03Open p:0... [20:39:18] 10Desktop Improvements, 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Kanbanana-2022-23-Q1): Collapse sidebar by default for logged-out people - https://phabricator.wikimedia.org/T287609 (10Edtadros) [20:51:13] 10Desktop Improvements, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), 10Readers-Web-Backlog (Kanbanana-2022-23-Q1): TOC scrollbar should be on top of bottom fade (Chrome & Safari) - https://phabricator.wikimedia.org/T311436 (10Edtadros) a:05Edtadros→03ovasileva === Test Result - Prod **Status:** ✅ PASS *... [20:52:06] 10Desktop Improvements, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), 10Readers-Web-Backlog (Kanbanana-2022-23-Q1): TOC scrollbar should be on top of bottom fade (Chrome & Safari) - https://phabricator.wikimedia.org/T311436 (10Edtadros) [21:08:25] (03CR) 10Daniel Kinzler: [C: 03+2] (import|export)Sites.php: Move parent::__construct call above addDescription [core] - 10https://gerrit.wikimedia.org/r/818618 (https://phabricator.wikimedia.org/T314258) (owner: 10Zabe) [21:20:21] 10MediaWiki-General, 10MW-1.38-release, 10PHP 8.1 support: Make REL1_38 pass test suite on php 8.1 - https://phabricator.wikimedia.org/T314208 (10Aklapper) [21:21:03] 10Developer-Advocacy (Oct-Dec 2022): Quarterly Newsletter for October 2022 - https://phabricator.wikimedia.org/T314168 (10Aklapper) [21:27:20] 10MediaWiki-Internationalization, 10MediaWiki-REST-API: Selecting user language in the REST API - https://phabricator.wikimedia.org/T269492 (10Tgr) >>! In T269492#8113518, @BPirkle wrote: > I didn't even talk about variants in my above comment. While I'm unsure how valuable variant support for error messages i... [21:27:56] (03Merged) 10jenkins-bot: (import|export)Sites.php: Move parent::__construct call above addDescription [core] - 10https://gerrit.wikimedia.org/r/818618 (https://phabricator.wikimedia.org/T314258) (owner: 10Zabe) [21:33:25] 10OOUI: Autosized MultilineTextInputWidget jumps occasionally - https://phabricator.wikimedia.org/T169335 (10Jack_who_built_the_house) And this is how autosizing behaves in the last Firefox occasionaly, if you have the system font other than 100%: {F35371777} [21:37:40] 10Small-Wiki-Toolkits, 10Developer-Advocacy (Jul-Sep 2022): Coordinate "how to maintain bots" workshop - https://phabricator.wikimedia.org/T312612 (10Aklapper) [21:40:19] 10MassMessage: Some MassMessages not reaching cywikibooks - https://phabricator.wikimedia.org/T313672 (10Rschen7754) And https://ml.wikibooks.org/wiki/വിക്കി പുസ്തകശാല:Community Portal [21:40:54] 10MediaWiki-Core-Snapshots, 10MediaWiki-Maintenance-system, 10Regression: importSites.php and exportSites.php have their parent::__construct call too late - https://phabricator.wikimedia.org/T314258 (10Zabe) 05Open→03Resolved a:03Zabe [21:41:43] 10MediaWiki-Email, 10Community-Tech, 10Growth-Team, 10Growth-Team-Filtering, and 3 others: Send a notification when someone else edits your userpage - https://phabricator.wikimedia.org/T3876 (10Legoktm) Sorry about the lack of updates, I both underestimated how much was needed to do this and overestimated... [21:42:42] 10DiscussionTools, 10Regression: Reply links no longer showing on old revisions - https://phabricator.wikimedia.org/T314260 (10Esanders) [22:01:33] (03PS1) 10Esanders: Fix styling of new comment notification on mobile [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818621 [22:02:46] (03PS1) 10Fomafix: Use querySelector instead of jQuery [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818622 [22:15:03] 10DiscussionTools: Wrap sign on a new line when working with numbered lists - https://phabricator.wikimedia.org/T314220 (10Jack_who_built_the_house) It's actually disappointing that DT doesn't add a newline when there is a list at the end of the user input. DT with its own hands creates the worst possible layout... [22:15:55] 10DiscussionTools: Put signature on a new line when comment ends with list - https://phabricator.wikimedia.org/T314220 (10Jack_who_built_the_house) [22:18:19] 10DiscussionTools: Put signature on a new line when comment ends with list - https://phabricator.wikimedia.org/T314220 (10Jack_who_built_the_house) If it's OK I repurposed the task from numbered lists to any lists since the situation is no better with bulleted lists. [22:20:33] 10Abstract Wikipedia team: Waiting bars do not clear if text search does not return a result - https://phabricator.wikimedia.org/T314262 (10OZhang-WMF) [22:20:46] (03CR) 10Krinkle: [C: 03+2] Remove overwrite by URL parameter skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818451 (owner: 10Fomafix) [22:21:30] 10MediaWiki-extensions-Translate: Prevent unreviewed automated translation to be published on Extension:Translate - https://phabricator.wikimedia.org/T216824 (10Tacsipacsi) [22:22:16] (03CR) 10Krinkle: [C: 03+2] Rework JavaScript [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818224 (owner: 10Fomafix) [22:22:41] (03Merged) 10jenkins-bot: Remove overwrite by URL parameter skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818451 (owner: 10Fomafix) [22:23:58] (03Merged) 10jenkins-bot: Rework JavaScript [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818224 (owner: 10Fomafix) [22:24:17] (03CR) 10Krinkle: Optimize ResourceLoader usage (031 comment) [extensions/Theme] - 10https://gerrit.wikimedia.org/r/818533 (owner: 10Fomafix) [22:26:28] 10Abstract Wikipedia team: Naming convention for testers appears inconsistent - https://phabricator.wikimedia.org/T314263 (10OZhang-WMF) [22:33:25] 10Abstract Wikipedia team: Function call results do not clear after removing the function selection - https://phabricator.wikimedia.org/T314264 (10OZhang-WMF) [22:36:16] 10Abstract Wikipedia team: Dropdown boxes do not pre-populate - https://phabricator.wikimedia.org/T314265 (10OZhang-WMF) [22:39:52] 10Abstract Wikipedia team: Indicator on how to delete labels when there's more than one - https://phabricator.wikimedia.org/T314266 (10OZhang-WMF) [22:44:45] (03PS3) 10Umherirrender: Check against $wgTextModelsToParse when compute variables from parser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/818615 [23:27:32] (03CR) 10DannyS712: "This change is ready for review." [design/codex] - 10https://gerrit.wikimedia.org/r/811284 (owner: 10DannyS712) [23:27:34] (03PS4) 10DannyS712: docs, Controls: simplify splitting of props and slot controls [design/codex] - 10https://gerrit.wikimedia.org/r/811284 [23:37:24] (03CR) 10DannyS712: "This change is ready for review." [design/codex] - 10https://gerrit.wikimedia.org/r/818556 (owner: 10DannyS712) [23:59:38] (03PS1) 10MusikAnimal: Add class to the element instead of [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/818627 (https://phabricator.wikimedia.org/T305149)