[00:00:24] 10Reading-Web-Local-Wiki-Issues: Page jumps when landing on a page after clicking a section link due to local gadget - https://phabricator.wikimedia.org/T318358 (10Izno) >>! In T318358#8301681, @Jdlrobson wrote: > The issue is due to the gadget: Change UTC-based times and dates, such as those used in signatures,... [00:05:09] (03PS23) 10Daimona Eaytoy: tests: Upgrade PHPUnit from 8.5+ to 9.5+ [core] - 10https://gerrit.wikimedia.org/r/674851 (https://phabricator.wikimedia.org/T243600) [00:10:05] (03PS5) 10Reedy: ValidateTest: Increase test coverage [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840241 [00:10:16] wtf is going on with this [00:14:23] 10MediaWiki-General, 10Composer, 10Patch-For-Review: Package phpunit/php-token-stream is abandoned - https://phabricator.wikimedia.org/T262076 (10Daimona) 05Stalled→03Open [00:14:57] 10Web Team Visual Regression Framework, 10Epic: [Goal] Make it easier to see intentionality and attribution of failures on https://pixel.wmcloud.org - https://phabricator.wikimedia.org/T320303 (10nray) [00:15:23] 10Web Team Visual Regression Framework, 10Epic: [Goal] Make it easier to see intentionality and attribution of visual differences on https://pixel.wmcloud.org - https://phabricator.wikimedia.org/T320303 (10nray) [00:17:18] (03PS6) 10Reedy: ValidateTest: Increase test coverage [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840241 [00:17:28] 10Web Team Visual Regression Framework, 10Epic: [GOAL] Make it easier to see intentionality and attribution of visual differences on https://pixel.wmcloud.org - https://phabricator.wikimedia.org/T320303 (10nray) [00:19:10] 10Web Team Visual Regression Framework, 10Epic: [GOAL] Make it easier to see intentionality and attribution of visual differences on https://pixel.wmcloud.org - https://phabricator.wikimedia.org/T320303 (10nray) [00:19:45] 10Web Team Visual Regression Framework, 10Epic: [GOAL] Make it easier to see intentionality and attribution of visual differences on https://pixel.wmcloud.org - https://phabricator.wikimedia.org/T320303 (10nray) [00:20:21] (03CR) 10Daimona Eaytoy: "Finally." [core] - 10https://gerrit.wikimedia.org/r/674851 (https://phabricator.wikimedia.org/T243600) (owner: 10Daimona Eaytoy) [00:20:47] (03CR) 10Reedy: [C: 03+2] Remove deprecated use of mTitle [extensions/TitleKey] (REL1_39) - 10https://gerrit.wikimedia.org/r/840184 (owner: 10Paladox) [00:21:10] (03CR) 10Reedy: [C: 03+1] "Ship it? ;)" [core] - 10https://gerrit.wikimedia.org/r/674851 (https://phabricator.wikimedia.org/T243600) (owner: 10Daimona Eaytoy) [00:22:40] (03Merged) 10jenkins-bot: Remove deprecated use of mTitle [extensions/TitleKey] (REL1_39) - 10https://gerrit.wikimedia.org/r/840184 (owner: 10Paladox) [00:30:26] 10Research, 10Research-foundational: Research Report #7 - https://phabricator.wikimedia.org/T319684 (10leila) @ELescak I did a pass over [[ https://docs.google.com/document/d/1CatgAWlKLo-MJGLJPFtggU7OV91NOQZzr6dg6t_NPns/edit# | the outline ]] and expanded it. @Miriam please do a pass over the outline and updat... [00:30:40] 10Web Team Visual Regression Framework, 10Epic: [GOAL] Allow Pixel to run in CI - https://phabricator.wikimedia.org/T320304 (10nray) [00:30:44] 10Research-foundational, 10Research (FY2022-23-Research-October-December): Research Report #7 - https://phabricator.wikimedia.org/T319684 (10leila) [00:31:01] 10Research-foundational, 10Research (FY2022-23-Research-October-December): Research Report #7 - https://phabricator.wikimedia.org/T319684 (10leila) p:05Triage→03Medium [00:32:48] 10Web Team Visual Regression Framework, 10Epic: [GOAL] Allow Pixel to run in CI - https://phabricator.wikimedia.org/T320304 (10nray) [00:33:28] 10Web Team Visual Regression Framework: Keep historic jobs - https://phabricator.wikimedia.org/T317668 (10nray) [00:33:35] 10Web Team Visual Regression Framework, 10Epic: [GOAL] Make it easier to see intentionality and attribution of visual differences on https://pixel.wmcloud.org - https://phabricator.wikimedia.org/T320303 (10nray) [00:33:59] 10Web Team Visual Regression Framework: Allow for expected regressions - https://phabricator.wikimedia.org/T317669 (10nray) [00:34:01] 10Web Team Visual Regression Framework, 10Epic: [GOAL] Make it easier to see intentionality and attribution of visual differences on https://pixel.wmcloud.org - https://phabricator.wikimedia.org/T320303 (10nray) [00:35:07] 10Web Team Visual Regression Framework, 10Epic: [GOAL] Make it easier to see intentionality and attribution of visual differences on https://pixel.wmcloud.org - https://phabricator.wikimedia.org/T320303 (10nray) 05duplicate→03Open [00:36:09] 10Web Team Visual Regression Framework: Allow for expected regressions - https://phabricator.wikimedia.org/T317669 (10nray) [00:36:11] 10Web Team Visual Regression Framework, 10Epic: [GOAL] Make it easier to see intentionality and attribution of visual differences on https://pixel.wmcloud.org - https://phabricator.wikimedia.org/T320303 (10nray) [00:38:34] (03PS1) 10Reedy: includes: chmod 644 php files [core] - 10https://gerrit.wikimedia.org/r/840243 [00:39:19] (03CR) 10Reedy: "Not sure why, but this patch chmod'd some files to 755... Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/840243" [core] - 10https://gerrit.wikimedia.org/r/828553 (https://phabricator.wikimedia.org/T306883) (owner: 10Matthias Mullie) [00:40:10] (03PS2) 10Reedy: chmod 644 some files that are 755 [core] - 10https://gerrit.wikimedia.org/r/840243 [00:40:51] (03CR) 10Daimona Eaytoy: tests: Upgrade PHPUnit from 8.5+ to 9.5+ (031 comment) [core] - 10https://gerrit.wikimedia.org/r/674851 (https://phabricator.wikimedia.org/T243600) (owner: 10Daimona Eaytoy) [00:41:41] (03CR) 10Reedy: [C: 03+2] tests: Upgrade PHPUnit from 8.5+ to 9.5+ [core] - 10https://gerrit.wikimedia.org/r/674851 (https://phabricator.wikimedia.org/T243600) (owner: 10Daimona Eaytoy) [00:49:13] (03PS1) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840245 [01:02:17] (03Merged) 10jenkins-bot: tests: Upgrade PHPUnit from 8.5+ to 9.5+ [core] - 10https://gerrit.wikimedia.org/r/674851 (https://phabricator.wikimedia.org/T243600) (owner: 10Daimona Eaytoy) [01:04:53] 10MediaWiki-Vendor, 10Composer, 10Continuous-Integration-Config: Upgrade composer to 2.4.x - https://phabricator.wikimedia.org/T319257 (10Reedy) It gives some nice format updates.. ` % php ../composer.phar outdated Color legend: - patch or minor release available - update recommended - major release availab... [01:11:58] 10Outreachy (Round 25): Hybrid event production for QueeringWikipedia 2023 with Outreachy intern - https://phabricator.wikimedia.org/T319310 (10frederic_ed) [01:12:20] 10Outreachy (Round 25): Hybrid event production for QueeringWikipedia 2023 with Outreachy intern - https://phabricator.wikimedia.org/T319310 (10frederic_ed) [01:42:33] 10MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), 10MW-1.40-notes (1.40.0-wmf.4; 2022-10-03), 10Patch-For-Review, 10SDAW-Search-Improvements (Milestone 1: CSS changes to all wikis), 10Structured-Data-Backlog (Current Work): [L] Searchers see thumbnails next to search ... - https://phabricator.wikimedia.org/T306883 [01:42:35] 10MediaWiki-Search, 10CirrusSearch, 10Discovery-Search: Special:Search should not use - https://phabricator.wikimedia.org/T320295 (10Izno) [01:42:37] 10Accessibility, 10MediaWiki-Search, 10Discovery-Search: Special:Search should not have links without alt text for their contents - https://phabricator.wikimedia.org/T320299 (10Izno) [01:50:34] (03PS42) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [01:50:49] (03CR) 10Universal Omega: Add support for file backend for avatar, award and gift images (0315 comments) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [01:51:56] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [01:54:16] 10Accessibility, 10MediaWiki-Search, 10Discovery-Search: Special:Search images should not have links without alt text for their contents - https://phabricator.wikimedia.org/T320299 (10Izno) [01:57:27] (03PS43) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [01:58:13] 10MediaWiki-Search, 10CirrusSearch, 10Discovery-Search: Special:Search should not use
- https://phabricator.wikimedia.org/T320295 (10Izno) [01:58:53] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:11:21] (03PS44) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:12:45] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:17:08] 10Accessibility, 10MediaWiki-Search, 10Discovery-Search: Special:Search images should not have links without alt text for their contents - https://phabricator.wikimedia.org/T320299 (10Izno) One user [[https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)#Images_with_search_results|at... [02:17:28] (03PS45) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:19:15] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:23:06] 10View-it!: October TMIG update - https://phabricator.wikimedia.org/T318615 (10Jamie-NAL) 05In progress→03Resolved [02:24:09] (03PS46) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:24:21] (03CR) 10Universal Omega: Add support for file backend for avatar, award and gift images (031 comment) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:24:49] (03PS47) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:26:17] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:41:52] (03PS48) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:43:20] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [02:49:41] 10Vector (legacy skin): Wikiquote pages not valid when parsed as XML - https://phabricator.wikimedia.org/T320215 (10Jruschme) >>! In T320215#8299535, @Aklapper wrote: >> fetch the wikiquote page > > What is "the wikiquote page"? Please provide full URLs. The issue seems to affect all pages, but since you need... [03:00:46] (03CR) 10Legoktm: [C: 03+2] Add various @codeCoverageIgnore [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840240 (owner: 10Reedy) [03:01:00] (03CR) 10Legoktm: [C: 03+2] composer.json: Add phpunit command [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840242 (owner: 10Reedy) [03:01:16] (03CR) 10Legoktm: [C: 03+2] ValidateTest: Increase test coverage [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840241 (owner: 10Reedy) [03:01:20] (03Merged) 10jenkins-bot: Add various @codeCoverageIgnore [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840240 (owner: 10Reedy) [03:01:34] (03Merged) 10jenkins-bot: composer.json: Add phpunit command [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840242 (owner: 10Reedy) [03:01:54] (03Merged) 10jenkins-bot: ValidateTest: Increase test coverage [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840241 (owner: 10Reedy) [03:06:42] (03PS1) 10Legoktm: Suppress PhanUndeclaredProperty phan errors [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/840249 [03:07:51] (03PS2) 10Legoktm: build: Updating grunt-banana-checker to 0.10.0 [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/840017 (owner: 10Libraryupgrader) [03:20:53] (03PS1) 10Legoktm: Update test for core pager changes [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/840251 [03:22:17] (03CR) 10CI reject: [V: 04-1] Update test for core pager changes [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/840251 (owner: 10Legoktm) [03:25:03] (03PS2) 10Legoktm: build: Updating grunt-banana-checker to 0.10.0 [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/839967 (owner: 10Libraryupgrader) [03:25:28] (03PS2) 10Legoktm: Update test for core pager changes [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/840251 [03:25:30] (03PS3) 10Legoktm: build: Updating grunt-banana-checker to 0.10.0 [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/839967 (owner: 10Libraryupgrader) [03:47:14] (03PS1) 10Legoktm: Suppress phan error in back-compat code [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/840252 [03:49:40] (03PS2) 10Legoktm: build: Updating grunt-banana-checker to 0.10.0 [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/839962 (owner: 10Libraryupgrader) [03:50:25] 10Phabricator, 10VPS-project-Codesearch: Consider adding a way to query Codesearch from Phabricator - https://phabricator.wikimedia.org/T183608 (10Krinkle) [03:52:14] (03PS1) 10Legoktm: Don't expect that a global title is always set [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/840253 [03:54:51] (03PS2) 10Legoktm: build: Updating grunt-banana-checker to 0.10.0 [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/839944 (owner: 10Libraryupgrader) [03:57:38] (03CR) 10Legoktm: [C: 03+2] "..." [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/839731 (owner: 10Libraryupgrader) [04:00:06] (03CR) 10CI reject: [V: 04-1] build: Updating grunt-banana-checker to 0.10.0 [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/839731 (owner: 10Libraryupgrader) [04:02:01] ugh [04:03:02] (03PS1) 10Legoktm: Update test for core pager changes [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/840254 [04:04:11] 10MediaWiki-extensions-MediaModeration, 10ci-test-error: PHP 8.0 test failures for MediaModeration - https://phabricator.wikimedia.org/T320307 (10Legoktm) [04:04:23] (03CR) 10Legoktm: "Filed T320307" [extensions/MediaModeration] - 10https://gerrit.wikimedia.org/r/839410 (owner: 10Libraryupgrader) [04:04:25] (03CR) 10CI reject: [V: 04-1] Update test for core pager changes [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/840254 (owner: 10Legoktm) [04:06:58] 10MediaWiki-General, 10Performance-Team: libpcre-related performance opportunities - https://phabricator.wikimedia.org/T216744 (10Krinkle) 05Open→03Declined Given the small percentage, closing for now from list of future goals. I do suggest that as part of {T255502} and T237708 when we analyze the subset... [04:11:22] (03PS1) 10Legoktm: Require MediaWiki 1.37+, remove back-compat code causing phan issues [extensions/CentralLogging] - 10https://gerrit.wikimedia.org/r/840255 [04:17:42] (03PS2) 10Legoktm: build: Updating grunt-banana-checker to 0.10.0 [extensions/CentralLogging] - 10https://gerrit.wikimedia.org/r/839688 (owner: 10Libraryupgrader) [04:57:48] 10MediaWiki-Internationalization, 10Discovery-Search, 10MW-1.35-release, 10Platform Team Workboards (Clinic Duty Team), and 2 others: LogicException: Process cache for 'en' should be set by now - https://phabricator.wikimedia.org/T258860 (10Epopen) Hi All I tried to upgrade from 1.35.5 to 1.35.6 and encou... [05:45:31] 10MediaWiki-Search, 10Discovery-Search, 10Platform Engineering, 10MW-1.40-notes (1.40.0-wmf.4; 2022-10-03), and 2 others: Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent a proper page, but merely a link target (fr... - https://phabricator.wikimedia.org/T319798 [05:49:20] (03PS1) 10MPGuy2824: CurationToolbar:Add newlines for each maint tag added. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/840258 (https://phabricator.wikimedia.org/T313649) [05:55:14] (03CR) 10CI reject: [V: 04-1] CurationToolbar:Add newlines for each maint tag added. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/840258 (https://phabricator.wikimedia.org/T313649) (owner: 10MPGuy2824) [05:58:33] (03CR) 10Majavah: [C: 03+2] Require MediaWiki 1.37+, remove back-compat code causing phan issues [extensions/CentralLogging] - 10https://gerrit.wikimedia.org/r/840255 (owner: 10Legoktm) [06:00:07] (03CR) 10Majavah: [C: 03+2] chmod 644 some files that are 755 [core] - 10https://gerrit.wikimedia.org/r/840243 (owner: 10Reedy) [06:00:31] (03Merged) 10jenkins-bot: Require MediaWiki 1.37+, remove back-compat code causing phan issues [extensions/CentralLogging] - 10https://gerrit.wikimedia.org/r/840255 (owner: 10Legoktm) [06:01:51] 10MediaWiki-Documentation, 10MediaWiki-libs-ObjectCache, 10Continuous-Integration-Infrastructure, 10Doxygen, 10Performance-Team: Upgrade Doxygen to 1.9.1 - https://phabricator.wikimedia.org/T291950 (10Krinkle) [06:03:46] 10MediaWiki-Parser, 10Performance-Team, 10Readers-Web-Backlog, 10Epic: Desktop MediaWiki should be able to lazy load images - https://phabricator.wikimedia.org/T148047 (10Krinkle) [06:16:29] (03Merged) 10jenkins-bot: chmod 644 some files that are 755 [core] - 10https://gerrit.wikimedia.org/r/840243 (owner: 10Reedy) [06:17:32] (03CR) 10Krinkle: [C: 03+2] Simplify SurveyFactory::parseSurveyConfig() implementation [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/833072 (owner: 10Thiemo Kreuz (WMDE)) [06:17:58] (03CR) 10Krinkle: Drop unused Survey::isEnabled() feature (031 comment) [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/833091 (owner: 10Thiemo Kreuz (WMDE)) [06:18:17] (03CR) 10Krinkle: [C: 03+2] Simplify SurveyFactory::parseSurveyConfig() implementation (031 comment) [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/833072 (owner: 10Thiemo Kreuz (WMDE)) [06:19:24] (03Merged) 10jenkins-bot: Simplify SurveyFactory::parseSurveyConfig() implementation [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/833072 (owner: 10Thiemo Kreuz (WMDE)) [06:42:02] 10Desktop Improvements (Vector 2022): Search button does not open input field when browser window has a specific width - https://phabricator.wikimedia.org/T320308 (10Formatierer) [06:46:59] (03PS3) 10KartikMistry: Cypress test framework [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/840187 (https://phabricator.wikimedia.org/T312543) (owner: 10Echukwukere) [07:01:12] (03CR) 10CI reject: [V: 04-1] Cypress test framework [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/840187 (https://phabricator.wikimedia.org/T312543) (owner: 10Echukwukere) [07:11:25] (03CR) 10Majavah: [C: 03+2] Suppress phan error in back-compat code [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/840252 (owner: 10Legoktm) [07:12:10] (03CR) 10Majavah: [C: 03+2] Don't expect that a global title is always set [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/840253 (owner: 10Legoktm) [07:14:43] (03Merged) 10jenkins-bot: Suppress phan error in back-compat code [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/840252 (owner: 10Legoktm) [07:14:54] (03Merged) 10jenkins-bot: Don't expect that a global title is always set [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/840253 (owner: 10Legoktm) [07:16:10] (03CR) 10Majavah: [C: 03+2] Suppress PhanUndeclaredProperty phan errors [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/840249 (owner: 10Legoktm) [07:17:56] (03Merged) 10jenkins-bot: Suppress PhanUndeclaredProperty phan errors [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/840249 (owner: 10Legoktm) [07:42:01] 10CommRel-Specialists-Support (Oct-Dec-2022): Support Product folks in potentially updating the dept page on mediawiki.org - https://phabricator.wikimedia.org/T313527 (10Elitre) [07:43:31] 10WMIT-CiviCRM: Traduzione in italiano di Webform CiviCRM Integration - https://phabricator.wikimedia.org/T320309 (10samuele.masetto) [07:44:44] 10CommRel-Specialists-Support (Jul-Sep-2022): FY 22-23 CRS Support to Content Data Products teams - https://phabricator.wikimedia.org/T308019 (10Elitre) 05Open→03Resolved I believe with the current contractors' hiring and my temp support for Commons, this is pretty much sorted. [07:45:20] 10CommRel-Specialists-Support (Oct-Dec-2022): FY 22-23 CRS Support to Content Transform team - https://phabricator.wikimedia.org/T308022 (10Elitre) p:05Triage→03Low [07:46:11] 10MediaWiki-extensions-TwitterLogin: Convert TwitterLogin to use extension registration - https://phabricator.wikimedia.org/T320310 (10Kizule) [07:46:14] 10CommRel-Specialists-Support (Oct-Dec-2022): FY 22-23 CRS Support to Content Transform team - https://phabricator.wikimedia.org/T308022 (10Elitre) Team is slowly proceeding and we'll hear from them when they need a bit more help in socializing anything. [07:57:52] 10MediaWiki-extensions-Other: Convert StickToThatLanguage to use extension registration - https://phabricator.wikimedia.org/T320311 (10Kizule) [07:59:10] 10MediaWiki-extensions-Other: Convert StickToThatLanguage to use extension registration - https://phabricator.wikimedia.org/T320311 (10Kizule) I'm thinking is https://www.mediawiki.org/wiki/Extension:UniversalLanguageSelector related in any way with this extension. If so, we could archive this one. [08:00:06] (03PS33) 10Winston Sung: Add language conversion support using LanguageConverter on syntaxhighlight [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/762760 (https://phabricator.wikimedia.org/T34943) [08:01:03] 10MediaWiki-extensions-Other, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Wikimedia-GitHub, and 2 others: Archive the StarterWiki extension - https://phabricator.wikimedia.org/T294176 (10Kizule) Without a response for nearly a year, I really believe that we should archive this extension. [08:01:35] (03PS21) 10Winston Sung: i18n: Add missing BCP 47 codes in Names.php and LanguageCode.php [core] - 10https://gerrit.wikimedia.org/r/805351 [08:06:02] (03CR) 10CI reject: [V: 04-1] Add language conversion support using LanguageConverter on syntaxhighlight [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/762760 (https://phabricator.wikimedia.org/T34943) (owner: 10Winston Sung) [08:29:11] 10MediaWiki-extensions-Other, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Wikimedia-GitHub, and 2 others: Archive the StarterWiki extension - https://phabricator.wikimedia.org/T294176 (10Peachey88) Maybe give @DanielFriesen another poke, I see they were activate in Aug (https://guc.toolfor... [08:40:13] 10Desktop Improvements (Vector 2022): Search button does not open input field when browser window has a specific width - https://phabricator.wikimedia.org/T320308 (10Formatierer) [09:38:47] 10Outreachy (Round 25): Hybrid event production for QueeringWikipedia 2023 with Outreachy intern - https://phabricator.wikimedia.org/T319310 (10Zblace) [09:48:19] 10Outreachy (Round 25): Document overview of minimum tech requirements for Jitsi and BigBlueButton - Task 1 - https://phabricator.wikimedia.org/T320223 (10Zblace) [09:48:42] 10Outreachy (Round 25): Document preparation of Queering Wikipedia 2022 Meeting (online only event) - Task 2.1 - https://phabricator.wikimedia.org/T320227 (10Zblace) [09:49:07] 10Outreachy (Round 25): Document preparation of Queering Wikipedia 2023 Conference (hybrid event) - Task 2.2 - https://phabricator.wikimedia.org/T320228 (10Zblace) [09:56:04] 10Outreachy (Round 25): Hybrid event production for QueeringWikipedia 2023 with Outreachy intern - https://phabricator.wikimedia.org/T319310 (10Zblace) [09:57:22] 10Outreachy (Round 25): Document preparation of Queering Wikipedia 2022 Meeting (online only event) - Task 2.1 - https://phabricator.wikimedia.org/T320227 (10Zblace) [09:57:24] 10Outreachy (Round 25): Hybrid event production for QueeringWikipedia 2023 with Outreachy intern - https://phabricator.wikimedia.org/T319310 (10Zblace) [10:00:56] 10Outreachy (Round 25): Document overview of minimum tech requirements for Jitsi and BigBlueButton - Task 1 - https://phabricator.wikimedia.org/T320223 (10Zblace) [10:02:20] 10Outreachy (Round 25): Document preparation of Queering Wikipedia 2022 Meeting (online only event) - Task 2.1 - https://phabricator.wikimedia.org/T320227 (10Zblace) [10:02:22] 10Outreachy (Round 25): Hybrid event production for QueeringWikipedia 2023 with Outreachy intern - https://phabricator.wikimedia.org/T319310 (10Zblace) [10:03:06] 10Outreachy (Round 25): Document preparation of Queering Wikipedia 2022 Meeting (online only event) - Task 2.1 - https://phabricator.wikimedia.org/T320227 (10Zblace) [10:03:10] 10Outreachy (Round 25): Document overview of minimum tech requirements for Jitsi and BigBlueButton - Task 1 - https://phabricator.wikimedia.org/T320223 (10Zblace) [10:03:32] 10Outreachy (Round 25): Document preparation of Queering Wikipedia 2023 Conference (hybrid event) - Task 2.2 - https://phabricator.wikimedia.org/T320228 (10Zblace) [10:03:34] 10Outreachy (Round 25): Document overview of minimum tech requirements for Jitsi and BigBlueButton - Task 1 - https://phabricator.wikimedia.org/T320223 (10Zblace) [10:03:36] 10Outreachy (Round 25): Hybrid event production for QueeringWikipedia 2023 with Outreachy intern - https://phabricator.wikimedia.org/T319310 (10Zblace) [11:26:04] 10WMF-General-or-Unknown, 10Patch-For-Review: Migrate all Wikimedia codebases to use PHPUnit 9 - https://phabricator.wikimedia.org/T320245 (10Daimona) [11:26:06] 10MediaWiki-General, 10Composer, 10MW-1.40-notes (1.40.0-wmf.5; 2022-10-10): Package phpunit/php-token-stream is abandoned - https://phabricator.wikimedia.org/T262076 (10Daimona) [11:26:31] 10MediaWiki-Core-Tests, 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), 10MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), 10MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), and 2 others: Migrate MediaWiki core (and thus extensions and skins) to PHPUnit 9 - https://phabricator.wikimedia.org/T243600 (10Daimona) 05Open→0... [11:26:40] 10MediaWiki-General, 10Composer, 10MW-1.40-notes (1.40.0-wmf.5; 2022-10-10): Package phpunit/php-token-stream is abandoned - https://phabricator.wikimedia.org/T262076 (10Daimona) 05Open→03Resolved a:03Daimona [11:29:55] (03CR) 10Daimona Eaytoy: "The config needs to be updated, too:" [libs/LangConv] - 10https://gerrit.wikimedia.org/r/840224 (https://phabricator.wikimedia.org/T320245) (owner: 10Jforrester) [11:34:31] 10MediaWiki-extensions-MediaModeration, 10ci-test-error: PHP 8.0 test failures for MediaModeration - https://phabricator.wikimedia.org/T320307 (10Daimona) a:03Daimona Most probably a consequence of T243600. Fixing. [11:37:08] (03PS2) 10Daimona Eaytoy: build: Updating grunt-banana-checker to 0.10.0 [extensions/MediaModeration] - 10https://gerrit.wikimedia.org/r/839410 (owner: 10Libraryupgrader) [11:39:10] (03CR) 10Daniel Kinzler: Fix passing the wikiId into ParsoidOutputAccess. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/840157 (owner: 10Daniel Kinzler) [11:40:00] (03PS3) 10Daimona Eaytoy: build: Updating grunt-banana-checker to 0.10.0 [extensions/MediaModeration] - 10https://gerrit.wikimedia.org/r/839410 (https://phabricator.wikimedia.org/T320307) (owner: 10Libraryupgrader) [11:40:11] (03PS4) 10Daimona Eaytoy: build: Updating grunt-banana-checker to 0.10.0 [extensions/MediaModeration] - 10https://gerrit.wikimedia.org/r/839410 (https://phabricator.wikimedia.org/T320307) (owner: 10Libraryupgrader) [11:40:45] 10Wikibase.cloud: Add robots.txt to wbcloud mediawiki deployment - https://phabricator.wikimedia.org/T298902 (10Shizhao) [11:40:49] 10Wikimedia-Site-requests, 10Tracking-Neverending: robots.txt (tracking) - https://phabricator.wikimedia.org/T16720 (10Shizhao) [11:44:17] 10Wikimedia-Site-requests, 10Tracking-Neverending: robots.txt (tracking) - https://phabricator.wikimedia.org/T16720 (10Shizhao) [12:07:42] (03CR) 10D3r1ck01: [C: 03+2] Fix passing the wikiId into ParsoidOutputAccess. [core] - 10https://gerrit.wikimedia.org/r/840157 (owner: 10Daniel Kinzler) [12:09:36] 10MediaWiki-General, 10PHP 8.0 support: Remove references to ini_setting "track_errors" once we support PHP8+ only - https://phabricator.wikimedia.org/T320317 (10Daimona) [12:13:21] (03PS1) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 [12:15:35] (03PS1) 10Daimona Eaytoy: [WIP] Fixes for the phan upgrade [core] - 10https://gerrit.wikimedia.org/r/840275 [12:16:01] 10Accessibility, 10MediaWiki-Search, 10Discovery-Search: Special:Search images should not have links without alt text for their contents - https://phabricator.wikimedia.org/T320299 (10Bugreporter) One issue to consider: If the link is suppressed there should be another way to indicate attribution, as require... [12:16:08] (03PS2) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 [12:18:31] (03CR) 10D3r1ck01: [C: 03+2] Fix passing the wikiId into ParsoidOutputAccess. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/840157 (owner: 10Daniel Kinzler) [12:23:52] (03Merged) 10jenkins-bot: Fix passing the wikiId into ParsoidOutputAccess. [core] - 10https://gerrit.wikimedia.org/r/840157 (owner: 10Daniel Kinzler) [12:34:12] (03CR) 10CI reject: [V: 04-1] build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 (owner: 10Daimona Eaytoy) [12:36:29] (03CR) 10CI reject: [V: 04-1] [WIP] Fixes for the phan upgrade [core] - 10https://gerrit.wikimedia.org/r/840275 (owner: 10Daimona Eaytoy) [12:36:46] (03PS2) 10Daimona Eaytoy: Fixes for the phan upgrade, part 1 [core] - 10https://gerrit.wikimedia.org/r/840275 [12:40:31] (03PS3) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 [12:51:30] (03CR) 10CI reject: [V: 04-1] Fixes for the phan upgrade, part 1 [core] - 10https://gerrit.wikimedia.org/r/840275 (owner: 10Daimona Eaytoy) [12:52:23] (03PS3) 10Daimona Eaytoy: Fixes for the phan upgrade, part 1 [core] - 10https://gerrit.wikimedia.org/r/840275 [12:56:52] (03CR) 10CI reject: [V: 04-1] build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 (owner: 10Daimona Eaytoy) [13:01:12] (03PS1) 10Reedy: ValidateTest: Even more test coverage [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840278 [13:05:00] (03CR) 10Reedy: "In theory.. This take Validate.php to have only ~3 lines not covered by tests..." [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840278 (owner: 10Reedy) [13:06:32] (03CR) 10CI reject: [V: 04-1] Fixes for the phan upgrade, part 1 [core] - 10https://gerrit.wikimedia.org/r/840275 (owner: 10Daimona Eaytoy) [13:08:08] (03PS1) 10Daimona Eaytoy: [WIP] Fixes for the phan upgrade, part 2 [core] - 10https://gerrit.wikimedia.org/r/840279 [13:08:51] (03PS4) 10Daimona Eaytoy: Fixes for the phan upgrade, part 1 [core] - 10https://gerrit.wikimedia.org/r/840275 [13:09:01] (03PS2) 10Daimona Eaytoy: [WIP] Fixes for the phan upgrade, part 2 [core] - 10https://gerrit.wikimedia.org/r/840279 [13:09:19] (03PS4) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 [13:23:10] (03PS3) 10Daimona Eaytoy: [WIP] Fixes for the phan upgrade, part 2 [core] - 10https://gerrit.wikimedia.org/r/840279 [13:25:36] (03PS4) 10Daimona Eaytoy: [WIP] Fixes for the phan upgrade, part 2 [core] - 10https://gerrit.wikimedia.org/r/840279 [13:27:11] (03PS5) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 [13:27:19] (03PS6) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 [13:29:52] (03PS3) 10Daimona Eaytoy: build: Update node dependencies [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/837762 (https://phabricator.wikimedia.org/T319228) [13:29:55] (03PS4) 10Daimona Eaytoy: build: Update node dependencies [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/837762 (https://phabricator.wikimedia.org/T319228) [13:39:28] (03PS7) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 [13:39:38] (03PS1) 10Sophivorus: Improve and tidy up code [extensions/WikiVideos] - 10https://gerrit.wikimedia.org/r/840284 [13:40:02] (03CR) 10Sophivorus: [V: 03+2 C: 03+2] Improve and tidy up code [extensions/WikiVideos] - 10https://gerrit.wikimedia.org/r/840284 (owner: 10Sophivorus) [13:40:46] (03PS5) 10Daimona Eaytoy: Fixes for the phan upgrade, part 2 [core] - 10https://gerrit.wikimedia.org/r/840279 [13:44:39] 10phan, 10Upstream: PhanCommentAbstractOnInheritedMethod false positive - https://phabricator.wikimedia.org/T298571 (10Daimona) a:03Daimona [13:46:06] (03PS8) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 (https://phabricator.wikimedia.org/T298571) [13:47:19] 10MediaWiki-extensions-Score, 10Growth-Team, 10StructuredDiscussions, 10phan, and 2 others: PhanPossiblyUndeclaredVariable false positive - https://phabricator.wikimedia.org/T301079 (10Daimona) a:03Daimona [13:51:26] (03PS1) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [extensions/Score] - 10https://gerrit.wikimedia.org/r/840285 (https://phabricator.wikimedia.org/T301079) [13:58:02] (03PS2) 10Reedy: ValidateTest: Even more test coverage [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840278 [13:58:04] (03PS1) 10Reedy: Upgrade to PHPUnit ^9.5 [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840306 [13:58:58] (03CR) 10Reedy: "Curious if this fixes a few php test coverage issues..." [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840306 (owner: 10Reedy) [14:01:03] (03PS2) 10Daimona Eaytoy: Upgrade to PHPUnit ^9.5 [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840306 (owner: 10Reedy) [14:01:57] (03CR) 10Daimona Eaytoy: [C: 03+1] "PS2: reformatted phpunit.xml.dist as before, approving everything else" [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840306 (owner: 10Reedy) [14:02:48] (03CR) 10Daimona Eaytoy: [C: 03+1] Upgrade to PHPUnit ^9.5 (031 comment) [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840306 (owner: 10Reedy) [14:02:58] (03PS2) 10Esanders: Use fragments for range tests [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/838770 [14:03:00] (03PS17) 10Esanders: [WIP] Parser: Store timestamp ranges [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818578 [14:03:02] (03PS18) 10Esanders: [WIP] Turn comment timestamps into permalinks [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818579 [14:03:04] (03CR) 10Reedy: Upgrade to PHPUnit ^9.5 (031 comment) [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840306 (owner: 10Reedy) [14:03:33] (03PS4) 10Daimona Eaytoy: [WIP] argv [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/769059 [14:04:00] (03PS17) 10Daimona Eaytoy: [WIP] Per-offset caused-by lines [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/765259 [14:04:37] (03CR) 10CI reject: [V: 04-1] [WIP] Per-offset caused-by lines [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/765259 (owner: 10Daimona Eaytoy) [14:05:09] (03CR) 10CI reject: [V: 04-1] [WIP] argv [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/769059 (owner: 10Daimona Eaytoy) [14:05:45] (03CR) 10CI reject: [V: 04-1] build: Update mediawiki/mediawiki-phan-config to 0.12.0 [extensions/Score] - 10https://gerrit.wikimedia.org/r/840285 (https://phabricator.wikimedia.org/T301079) (owner: 10Daimona Eaytoy) [14:09:38] (03CR) 10CI reject: [V: 04-1] Use fragments for range tests [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/838770 (owner: 10Esanders) [14:09:45] (03CR) 10CI reject: [V: 04-1] [WIP] Parser: Store timestamp ranges [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818578 (owner: 10Esanders) [14:09:57] (03CR) 10CI reject: [V: 04-1] [WIP] Turn comment timestamps into permalinks [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818579 (owner: 10Esanders) [14:12:50] (03CR) 10Reedy: [C: 03+2] Upgrade to PHPUnit ^9.5 [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840306 (owner: 10Reedy) [14:13:30] (03Merged) 10jenkins-bot: Upgrade to PHPUnit ^9.5 [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840306 (owner: 10Reedy) [14:13:37] (03PS3) 10Reedy: ValidateTest: Even more test coverage [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840278 [14:17:41] (03PS4) 10Reedy: ValidateTest: Even more test coverage [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840278 [14:18:44] (03CR) 10Reedy: ValidateTest: Even more test coverage (031 comment) [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840278 (owner: 10Reedy) [14:21:24] 10MediaWiki-Parser: Add a parser option to do preSaveTransform within certain tag extensions - https://phabricator.wikimedia.org/T319221 (10waldyrious) [14:38:46] 10MediaWiki-Parser: Add a parser option to do preSaveTransform within certain tag extensions - https://phabricator.wikimedia.org/T319221 (10matmarex) I have written a patch implementing this a long time ago: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/607367 (but I never tried to get it reviewed and merged). [14:45:08] (03CR) 10Daimona Eaytoy: "This change is ready for review." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/682323 (owner: 10Daimona Eaytoy) [14:46:13] 10phan-taint-check-plugin, 10ci-test-error: Phan reported some unrelated SecurityCheck-DoubleEscaped error in untouched files - https://phabricator.wikimedia.org/T300844 (10Daimona) 05Open→03Declined >>! In T300844#7676249, Umherirrender wrote: > The order of analyze of the classes and its function changed... [14:46:33] (03CR) 10Daimona Eaytoy: Track shape of varlinks (031 comment) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/682323 (owner: 10Daimona Eaytoy) [14:53:06] (03PS1) 10Bartosz Dziewoński: Parser: Minor code style and comment improvements [core] - 10https://gerrit.wikimedia.org/r/840307 [14:54:21] (03CR) 10Daimona Eaytoy: [C: 03+1] Upgrade to PHPUnit ^9.5 (031 comment) [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840306 (owner: 10Reedy) [14:54:56] 10mwcli: Make use of group runners in some situations for mwcli - https://phabricator.wikimedia.org/T296750 (10Addshore) a:03Addshore [15:03:36] (03PS4) 10Bartosz Dziewoński: [WILD IDEA] Allow PST in tag extensions, add tag for multi-line list items [core] - 10https://gerrit.wikimedia.org/r/607367 [15:03:54] (03CR) 10Bartosz Dziewoński: "(rebased)" [core] - 10https://gerrit.wikimedia.org/r/607367 (owner: 10Bartosz Dziewoński) [15:04:11] 10phan-taint-check-plugin: Replace SecurityCheckMulti with multiple issues - https://phabricator.wikimedia.org/T320321 (10Daimona) [15:04:51] 10phan-taint-check-plugin: Forbid exec_ taints in @return-taint - https://phabricator.wikimedia.org/T289327 (10Daimona) 05Open→03Resolved [15:06:44] (03PS5) 10Bartosz Dziewoński: [WILD IDEA] Allow PST in tag extensions, add tag for multi-line list items [core] - 10https://gerrit.wikimedia.org/r/607367 [15:11:45] 10TemplateStyles, 10css-sanitizer: Support CSS variables - https://phabricator.wikimedia.org/T320322 (10Push-f) [15:12:37] 10TemplateStyles, 10css-sanitizer: Support CSS variables - https://phabricator.wikimedia.org/T320322 (10Push-f) [15:14:10] 10TemplateStyles, 10css-sanitizer: Support CSS variables - https://phabricator.wikimedia.org/T320322 (10Izno) Some chatter about possibly using variables in {T200632} also. [15:45:16] (03PS1) 10Sophivorus: Improve comments and readibility [extensions/WikiVideos] - 10https://gerrit.wikimedia.org/r/840308 [15:46:01] (03CR) 10Sophivorus: [V: 03+2 C: 03+2] Improve comments and readibility [extensions/WikiVideos] - 10https://gerrit.wikimedia.org/r/840308 (owner: 10Sophivorus) [15:58:18] 10MediaWiki-Core-Preferences: Improve handling of invalid offsets in UserTimeCorrection - https://phabricator.wikimedia.org/T320296 (10matmarex) a:03matmarex This annoys me, I hope you don't mind reviewing a patch. [15:59:04] 10MediaWiki-Core-Preferences: Improve handling of invalid offsets in UserTimeCorrection - https://phabricator.wikimedia.org/T320296 (10Daimona) Sure, it annoys me as well, so I'll definitely review it. We would also benefit from proper error handling in #campaignevents. [16:01:09] (03PS1) 10Bartosz Dziewoński: preferences: Show errors about invalid timezone instead of silently correcting [core] - 10https://gerrit.wikimedia.org/r/840309 (https://phabricator.wikimedia.org/T320296) [16:01:11] (03PS1) 10Bartosz Dziewoński: UserTimeCorrection: Validate time offsets in 'Offset|…' format [core] - 10https://gerrit.wikimedia.org/r/840310 [16:01:21] (03CR) 10Daniel Kinzler: EXPERIMENT: Filter hooks and event hooks. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/838910 (https://phabricator.wikimedia.org/T212482) (owner: 10Daniel Kinzler) [16:10:15] (03CR) 10Bartosz Dziewoński: [C: 03+2] Use OOUI instead of jquery.ui for error popup [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/838283 (https://phabricator.wikimedia.org/T319361) (owner: 10Legoktm) [16:16:25] (03CR) 10CI reject: [V: 04-1] preferences: Show errors about invalid timezone instead of silently correcting [core] - 10https://gerrit.wikimedia.org/r/840309 (https://phabricator.wikimedia.org/T320296) (owner: 10Bartosz Dziewoński) [16:17:30] (03PS1) 10Edward Chernenko: (tests) Workaround test failure in 1.39 (unrelated to this extension) [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/840311 [16:22:33] (03CR) 10Edward Chernenko: [C: 03+2] (tests) Workaround test failure in 1.39 (unrelated to this extension) [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/840311 (owner: 10Edward Chernenko) [16:23:03] (03PS1) 10Daimona Eaytoy: [WIP] Remove SecurityCheckMulti [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840312 (https://phabricator.wikimedia.org/T320321) [16:24:02] (03CR) 10CI reject: [V: 04-1] [WIP] Remove SecurityCheckMulti [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840312 (https://phabricator.wikimedia.org/T320321) (owner: 10Daimona Eaytoy) [16:25:28] (03Merged) 10jenkins-bot: (tests) Workaround test failure in 1.39 (unrelated to this extension) [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/840311 (owner: 10Edward Chernenko) [16:25:30] (03CR) 10CI reject: [V: 04-1] Use OOUI instead of jquery.ui for error popup [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/838283 (https://phabricator.wikimedia.org/T319361) (owner: 10Legoktm) [16:35:49] (03PS1) 10Daimona Eaytoy: Remove taint type MISC [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840313 [16:38:09] (03PS1) 10Edward Chernenko: Replace deprecated ActorMigration class [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/840314 [16:38:35] (03PS1) 10Daimona Eaytoy: Increase severity of PathTraversal and RCE [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840315 [16:39:14] 10phan-taint-check-plugin, 10Patch-For-Review: Replace SecurityCheckMulti with multiple issues - https://phabricator.wikimedia.org/T320321 (10Daimona) a:03Daimona [16:39:34] (03CR) 10CI reject: [V: 04-1] Replace deprecated ActorMigration class [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/840314 (owner: 10Edward Chernenko) [16:39:41] (03PS2) 10Daimona Eaytoy: [WIP] Remove SecurityCheckMulti [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840312 (https://phabricator.wikimedia.org/T320321) [16:40:49] (03CR) 10CI reject: [V: 04-1] [WIP] Remove SecurityCheckMulti [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840312 (https://phabricator.wikimedia.org/T320321) (owner: 10Daimona Eaytoy) [16:42:22] (03PS2) 10Edward Chernenko: Replace deprecated ActorMigration class [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/840314 [16:46:47] (03PS3) 10Daimona Eaytoy: Remove SecurityCheckMulti [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840312 (https://phabricator.wikimedia.org/T320321) [16:48:17] (03PS2) 10Daimona Eaytoy: Remove taint type MISC [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840313 [16:48:29] (03PS2) 10Daimona Eaytoy: Increase severity of PathTraversal and RCE [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840315 [16:50:21] (03PS3) 10Daimona Eaytoy: Increase severity of PathTraversal and RCE [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840315 [16:50:28] (03PS4) 10Daimona Eaytoy: Remove SecurityCheckMulti [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840312 (https://phabricator.wikimedia.org/T320321) [16:51:35] (03PS5) 10Daimona Eaytoy: Remove SecurityCheckMulti [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840312 (https://phabricator.wikimedia.org/T320321) [16:54:13] (03CR) 10Umherirrender: Check return value of XMLReader::open (031 comment) [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840214 (owner: 10Umherirrender) [16:56:03] (03CR) 10Umherirrender: [C: 03+2] build: Update mediawiki/mediawiki-phan-config to 0.12.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840245 (owner: 10Daimona Eaytoy) [16:56:43] (03Merged) 10jenkins-bot: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840245 (owner: 10Daimona Eaytoy) [16:57:34] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Failure looks unrelated – a lot of "This test does not have a @covers annotation but is expected to have one". Did someone break master? L" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/838283 (https://phabricator.wikimedia.org/T319361) (owner: 10Legoktm) [16:57:59] (03PS3) 10Umherirrender: Require php7.4 and type hint class properties [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/837174 [16:58:15] (03CR) 10Reedy: Use OOUI instead of jquery.ui for error popup (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/838283 (https://phabricator.wikimedia.org/T319361) (owner: 10Legoktm) [17:00:01] (03CR) 10Edward Chernenko: [C: 03+2] Replace deprecated ActorMigration class [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/840314 (owner: 10Edward Chernenko) [17:02:07] (03Merged) 10jenkins-bot: Replace deprecated ActorMigration class [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/840314 (owner: 10Edward Chernenko) [17:06:49] (03PS1) 10Umherirrender: PhpunitAnnotaionsSniff: Suggest new expectExceptionMessageMatches() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840316 [17:09:09] (03CR) 10CI reject: [V: 04-1] PhpunitAnnotaionsSniff: Suggest new expectExceptionMessageMatches() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840316 (owner: 10Umherirrender) [17:10:02] (03CR) 10Reedy: PhpunitAnnotaionsSniff: Suggest new expectExceptionMessageMatches() (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840316 (owner: 10Umherirrender) [17:10:49] (03PS2) 10Umherirrender: [Phpunit9] AnnotaionsSniff: Suggest expectExceptionMessageMatches() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840316 [17:13:27] (03PS3) 10Umherirrender: [Phpunit9] AnnotationsSniff: Suggest expectExceptionMessageMatches() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840316 [17:13:37] 10MediaWiki-extensions-Translate: "Translate this page" leads to wrong page - https://phabricator.wikimedia.org/T320220 (10TheAafi) Hmm, I did encounter this bug much earlier than you but I wasn't in hurry to bring this to Phab and instead asked @Pols12 that what went wrong. Waiting for a while sorted out all th... [17:16:37] (03CR) 10CI reject: [V: 04-1] Use OOUI instead of jquery.ui for error popup [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/838283 (https://phabricator.wikimedia.org/T319361) (owner: 10Legoktm) [17:25:54] (03PS1) 10Daimona Eaytoy: Improve caused-by lines when there are multiple issue types [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840317 (https://phabricator.wikimedia.org/T320321) [17:26:33] (03CR) 10CI reject: [V: 04-1] Improve caused-by lines when there are multiple issue types [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840317 (https://phabricator.wikimedia.org/T320321) (owner: 10Daimona Eaytoy) [17:27:53] (03PS49) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [17:29:34] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [17:31:07] (03PS2) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [extensions/Score] - 10https://gerrit.wikimedia.org/r/840285 (https://phabricator.wikimedia.org/T301079) [17:32:51] (03PS1) 10Reedy: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [vendor] - 10https://gerrit.wikimedia.org/r/840319 [17:33:26] (03PS7) 10Umherirrender: SpecificAssertionsSniff: Check for more is_* usage in assertTrue/False [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/770066 [17:33:38] (03PS2) 10Daimona Eaytoy: Improve caused-by lines when there are multiple issue types [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840317 (https://phabricator.wikimedia.org/T320321) [17:33:46] (03PS1) 10Reedy: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [core] - 10https://gerrit.wikimedia.org/r/840320 [17:35:04] (03CR) 10CI reject: [V: 04-1] Improve caused-by lines when there are multiple issue types [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840317 (https://phabricator.wikimedia.org/T320321) (owner: 10Daimona Eaytoy) [17:35:12] (03PS2) 10Reedy: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [core] - 10https://gerrit.wikimedia.org/r/840320 [17:36:03] (03CR) 10CI reject: [V: 04-1] SpecificAssertionsSniff: Check for more is_* usage in assertTrue/False [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/770066 (owner: 10Umherirrender) [17:36:30] (03PS3) 10Daimona Eaytoy: Improve caused-by lines when there are multiple issue types [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/840317 (https://phabricator.wikimedia.org/T320321) [17:39:01] (03PS13) 10Daimona Eaytoy: Track shape of varlinks [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/682323 [17:44:18] (03PS1) 10Umherirrender: Check return value of XMLReader::open [core] - 10https://gerrit.wikimedia.org/r/840321 [17:44:32] (03PS50) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [17:44:42] (03CR) 10Daimona Eaytoy: "LGTM, besides the phpcs failure" [core] - 10https://gerrit.wikimedia.org/r/840309 (https://phabricator.wikimedia.org/T320296) (owner: 10Bartosz Dziewoński) [17:45:08] (03PS1) 10Reedy: composer.json: Bump required PHP to >= 7.4.3 [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840322 [17:45:10] (03PS1) 10Reedy: Upgrading mediawiki/mediawiki-phan-config (0.11.1 => 0.12.0) [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840323 [17:45:12] (03PS1) 10Reedy: Code updates [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840324 [17:46:24] (03CR) 10CI reject: [V: 04-1] build: Update mediawiki/mediawiki-phan-config to 0.12.0 [extensions/Score] - 10https://gerrit.wikimedia.org/r/840285 (https://phabricator.wikimedia.org/T301079) (owner: 10Daimona Eaytoy) [17:46:49] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [17:47:13] (03PS8) 10Umherirrender: SpecificAssertionsSniff: Check for more is_* usage in assertTrue/False [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/770066 [17:47:16] (03PS2) 10Daimona Eaytoy: Add testcase for wrong caused-by lines [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/763725 [17:48:32] (03CR) 10CI reject: [V: 04-1] Add testcase for wrong caused-by lines [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/763725 (owner: 10Daimona Eaytoy) [17:50:13] (03PS25) 10Daimona Eaytoy: Backprop non-numkey taints more accurately [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/720792 (https://phabricator.wikimedia.org/T281478) [17:53:07] (03PS3) 10D3r1ck01: Inject services [extensions/EditAccount] - 10https://gerrit.wikimedia.org/r/832733 (owner: 10Fomafix) [17:54:43] (03CR) 10Majavah: "Part of me feels like that the message should be customizable via translation messages. Although looks like other parts of the tagging log" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/837217 (https://phabricator.wikimedia.org/T319121) (owner: 10MPGuy2824) [17:56:32] (03PS1) 10Umherirrender: build: Upgrade PHPUnit from 8.5+ to 9.5+ [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840325 [17:58:06] (03PS2) 10Umherirrender: build: Upgrade PHPUnit from 8.5+ to 9.5+ [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840325 (https://phabricator.wikimedia.org/T320245) [18:00:07] (03CR) 10Reedy: [C: 03+2] build: Upgrade PHPUnit from 8.5+ to 9.5+ [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840325 (https://phabricator.wikimedia.org/T320245) (owner: 10Umherirrender) [18:00:47] (03Merged) 10jenkins-bot: build: Upgrade PHPUnit from 8.5+ to 9.5+ [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840325 (https://phabricator.wikimedia.org/T320245) (owner: 10Umherirrender) [18:01:12] 10MediaWiki-Core-Tests, 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), 10MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), 10MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), and 2 others: Migrate MediaWiki core (and thus extensions and skins) to PHPUnit 9 - https://phabricator.wikimedia.org/T243600 (10Umherirrender) >>! I... [18:02:48] 10WMF-General-or-Unknown, 10Patch-For-Review: Migrate all Wikimedia codebases to use PHPUnit 9 - https://phabricator.wikimedia.org/T320245 (10Umherirrender) Deprecation of assert functions: - `assertNotIsReadable` => `assertIsNotReadable` - `assertNotIsWritable` => `assertIsNotWritable` - `assertDirectoryNotEx... [18:02:56] (03CR) 10Umherirrender: [Phpunit9] AnnotationsSniff: Suggest expectExceptionMessageMatches() (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840316 (owner: 10Umherirrender) [18:02:58] (03PS4) 10Umherirrender: [Phpunit9] AnnotationsSniff: Suggest expectExceptionMessageMatches() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840316 [18:05:13] (03PS1) 10Reedy: Fix MediaWiki.WhiteSpace.EmptyLinesBetweenUse.Found [core] - 10https://gerrit.wikimedia.org/r/840326 [18:05:41] 10MediaWiki-Core-Tests, 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), 10MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), 10MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), and 2 others: Migrate MediaWiki core (and thus extensions and skins) to PHPUnit 9 - https://phabricator.wikimedia.org/T243600 (10Daimona) >>! In T243... [18:07:00] (03CR) 10Reedy: [C: 03+2] [Phpunit9] AnnotationsSniff: Suggest expectExceptionMessageMatches() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840316 (owner: 10Umherirrender) [18:07:28] 10WMF-General-or-Unknown, 10Patch-For-Review: Migrate all Wikimedia codebases to use PHPUnit 9 - https://phabricator.wikimedia.org/T320245 (10Umherirrender) [18:08:01] (03Merged) 10jenkins-bot: [Phpunit9] AnnotationsSniff: Suggest expectExceptionMessageMatches() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/840316 (owner: 10Umherirrender) [18:08:23] (03PS4) 10Umherirrender: Require php7.4 and type hint class properties [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/837174 [18:10:34] (03CR) 10Umherirrender: [C: 03+2] Fix MediaWiki.WhiteSpace.EmptyLinesBetweenUse.Found [core] - 10https://gerrit.wikimedia.org/r/840326 (owner: 10Reedy) [18:10:44] (03CR) 10Reedy: [C: 03+2] Require php7.4 and type hint class properties [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/837174 (owner: 10Umherirrender) [18:11:25] (03Merged) 10jenkins-bot: Require php7.4 and type hint class properties [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/837174 (owner: 10Umherirrender) [18:14:41] (03CR) 10Reedy: [C: 03+2] filerepo: Replace deprecated wfExpandUrl [core] - 10https://gerrit.wikimedia.org/r/838883 (https://phabricator.wikimedia.org/T319340) (owner: 10Umherirrender) [18:15:55] (03CR) 10Reedy: [C: 03+2] Inject services into hook handler [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/826976 (owner: 10Umherirrender) [18:20:13] 10MediaWiki-Parser: Add a parser option to do preSaveTransform within certain tag extensions - https://phabricator.wikimedia.org/T319221 (10Push-f) I managed to come up with a workaround for my extension using the `ParserPreSaveTransformComplete` hook: https://git.push-f.com/mw-vote/commit/?id=166d0fbe2f0355d816... [18:26:11] (03Merged) 10jenkins-bot: Fix MediaWiki.WhiteSpace.EmptyLinesBetweenUse.Found [core] - 10https://gerrit.wikimedia.org/r/840326 (owner: 10Reedy) [18:30:11] (03Merged) 10jenkins-bot: filerepo: Replace deprecated wfExpandUrl [core] - 10https://gerrit.wikimedia.org/r/838883 (https://phabricator.wikimedia.org/T319340) (owner: 10Umherirrender) [18:30:44] (03PS51) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [18:31:50] (03CR) 10CI reject: [V: 04-1] Inject services into hook handler [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/826976 (owner: 10Umherirrender) [18:32:12] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [18:34:28] 10Wikispore: Find (compensated) maintainer(s) and developer(s) for Wikispore for 2022-2023 - https://phabricator.wikimedia.org/T315879 (10Zblace) [18:37:32] (03CR) 10D3r1ck01: [C: 03+2] Inject services [extensions/EditAccount] - 10https://gerrit.wikimedia.org/r/832733 (owner: 10Fomafix) [18:39:38] (03Merged) 10jenkins-bot: Inject services [extensions/EditAccount] - 10https://gerrit.wikimedia.org/r/832733 (owner: 10Fomafix) [18:42:37] (03PS1) 10Bartosz Dziewoński: Add test case for T313100 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840328 [18:42:39] (03PS1) 10Bartosz Dziewoński: Place replies outside transclusions, disallow replying to transcluded comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840329 (https://phabricator.wikimedia.org/T313100) [18:42:41] (03PS1) 10Bartosz Dziewoński: Add test cases for T313093 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 [18:42:44] (03PS1) 10Bartosz Dziewoński: Allow replying to some comments with accidental complex transclusions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840331 (https://phabricator.wikimedia.org/T313093) [18:49:10] 10Campaign-Tools, 10CampaignEvents, 10Wikimedia-Site-requests, 10Campaign-Registration: Configure the P&E Dashboard integration in beta - https://phabricator.wikimedia.org/T320258 (10Aklapper) [18:49:13] 10Campaign-Tools, 10CampaignEvents, 10Wikimedia-Site-requests, 10Campaign-Registration: Configure the P&E Dashboard integration in prod - https://phabricator.wikimedia.org/T320260 (10Aklapper) [18:49:19] (03CR) 10CI reject: [V: 04-1] Add test case for T313100 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840328 (owner: 10Bartosz Dziewoński) [18:49:23] (03CR) 10CI reject: [V: 04-1] Place replies outside transclusions, disallow replying to transcluded comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840329 (https://phabricator.wikimedia.org/T313100) (owner: 10Bartosz Dziewoński) [18:49:43] (03CR) 10CI reject: [V: 04-1] Add test cases for T313093 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 (owner: 10Bartosz Dziewoński) [18:50:04] (03CR) 10CI reject: [V: 04-1] Allow replying to some comments with accidental complex transclusions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840331 (https://phabricator.wikimedia.org/T313093) (owner: 10Bartosz Dziewoński) [18:57:36] (03PS1) 10Bartosz Dziewoński: Add 'wpTextbox1' to parameters that disable new topic tool [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840332 (https://phabricator.wikimedia.org/T316333) [18:57:54] 10mwcli: Try to recover LocalSettings.php.mwdd.bak files if LocalSettings.php is not found - https://phabricator.wikimedia.org/T320324 (10Addshore) [18:59:43] (03PS52) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [18:59:45] 10mwcli: Make use of group runners in some situations for mwcli - https://phabricator.wikimedia.org/T296750 (10Addshore) 05Open→03Resolved [18:59:47] (03PS2) 10Bartosz Dziewoński: preferences: Show errors about invalid timezone instead of silently correcting [core] - 10https://gerrit.wikimedia.org/r/840309 (https://phabricator.wikimedia.org/T320296) [18:59:59] (03PS2) 10Bartosz Dziewoński: UserTimeCorrection: Validate time offsets in 'Offset|…' format [core] - 10https://gerrit.wikimedia.org/r/840310 [19:00:00] 10mwcli: [mwcli mwdd] Speed up `mw docker restart` - https://phabricator.wikimedia.org/T314894 (10Addshore) 05Open→03Resolved In v0.17.0 [19:00:31] 10mwcli: Use an image with composer v2 by default - https://phabricator.wikimedia.org/T311821 (10Addshore) 05Open→03Resolved In v0.16.0 [19:00:32] 10mwcli, 10Wikibase Product Platform (Summer 2022 Not A Sprint), 10Wikimedia-Hackathon-2022: Exec commands always have a 0 exit code - https://phabricator.wikimedia.org/T307583 (10Addshore) 05Open→03Resolved In v0.16.0 [19:01:26] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [19:01:47] 10DiscussionTools, 10Editing-team (FY2021-22 Kanban Board), 10Patch-For-Review: Reply tool corruption involving {{Desbloqueo revisado}} on es.wp - https://phabricator.wikimedia.org/T313100 (10matmarex) a:03matmarex [19:01:55] 10DiscussionTools, 10Editing-team (FY2021-22 Kanban Board), 10Patch-For-Review: Reply tool can't be used for comments that start with {{od}}{{re|…}} etc. ("The "reply" link cannot be used to reply to this comment") - https://phabricator.wikimedia.org/T313093 (10matmarex) a:03matmarex [19:02:18] 10mwcli: Implement a changelog command that shows what has changed - https://phabricator.wikimedia.org/T320325 (10Addshore) [19:03:24] 10mwcli: Add ability to mark some commands as beta - https://phabricator.wikimedia.org/T320326 (10Addshore) [19:03:51] (03CR) 10CI reject: [V: 04-1] Add 'wpTextbox1' to parameters that disable new topic tool [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840332 (https://phabricator.wikimedia.org/T316333) (owner: 10Bartosz Dziewoński) [19:04:44] 10mwcli: Add a way to view the URL of an installed Mediawiki instance - https://phabricator.wikimedia.org/T301698 (10Addshore) 05Open→03Resolved a:03Addshore Going to mark this as initially resolved, there is something like this in v0.17.0 though not perfect ` ~/go/src/gitlab.wikimedia.org/repos/releng/cl... [19:06:14] (03PS53) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [19:07:14] 10Wikispore: Apply for funding (Wikidata 10th birthday call) - https://phabricator.wikimedia.org/T320327 (10Zblace) [19:07:16] 10mwcli: `sudo mw update` failed on Mac "panic: user: unknown userid 502" - https://phabricator.wikimedia.org/T319499 (10Addshore) @Lens0021 Could you please confirm this also happens while updating to 0.17.0 which is now out? [19:07:23] 10Wikispore: Apply for funding (Wikidata 10th birthday call) - https://phabricator.wikimedia.org/T320327 (10Zblace) 05Open→03Resolved a:03Zblace [19:07:38] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [19:10:03] (03PS54) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [19:10:47] 10Wikispore: Apply for #1 Wikispore funding support (Wikidata 10th birthday call) - https://phabricator.wikimedia.org/T320327 (10Zblace) [19:11:46] (03CR) 10CI reject: [V: 04-1] Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [19:16:44] 10Wikispore: Apply for #1 Wikispore funding support (Wikidata 10th birthday call) - https://phabricator.wikimedia.org/T320327 (10Zblace) 05Resolved→03In progress [19:17:21] (03PS2) 10Bartosz Dziewoński: Add test case for T313100 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840328 [19:17:23] (03PS2) 10Bartosz Dziewoński: Place replies outside transclusions, disallow replying to transcluded comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840329 (https://phabricator.wikimedia.org/T313100) [19:17:25] (03PS2) 10Bartosz Dziewoński: Add test cases for T313093 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 [19:17:27] (03PS2) 10Bartosz Dziewoński: Allow replying to some comments with accidental complex transclusions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840331 (https://phabricator.wikimedia.org/T313093) [19:23:32] (03CR) 10CI reject: [V: 04-1] Add test case for T313100 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840328 (owner: 10Bartosz Dziewoński) [19:24:11] (03CR) 10CI reject: [V: 04-1] Add test cases for T313093 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 (owner: 10Bartosz Dziewoński) [19:24:20] (03CR) 10CI reject: [V: 04-1] Place replies outside transclusions, disallow replying to transcluded comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840329 (https://phabricator.wikimedia.org/T313100) (owner: 10Bartosz Dziewoński) [19:26:10] (03CR) 10CI reject: [V: 04-1] Allow replying to some comments with accidental complex transclusions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840331 (https://phabricator.wikimedia.org/T313093) (owner: 10Bartosz Dziewoński) [19:28:36] (03PS6) 10D3r1ck01: LingoParser: Avoid direct access to Parser::mDoubleUnderscores [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/833348 [19:30:18] (03CR) 10CI reject: [V: 04-1] LingoParser: Avoid direct access to Parser::mDoubleUnderscores [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/833348 (owner: 10D3r1ck01) [19:31:01] (03PS7) 10D3r1ck01: LingoParser: Avoid direct access to Parser::mDoubleUnderscores [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/833348 [19:31:19] (03PS3) 10Bartosz Dziewoński: Place replies outside transclusions, disallow replying to transcluded comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840329 (https://phabricator.wikimedia.org/T313100) [19:31:21] (03PS3) 10Bartosz Dziewoński: Add test cases for T313093 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 [19:31:23] (03PS3) 10Bartosz Dziewoński: Allow replying to some comments with accidental complex transclusions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840331 (https://phabricator.wikimedia.org/T313093) [19:31:46] 10mwcli: CI to check for and create merge requests for new image tags - https://phabricator.wikimedia.org/T320328 (10Addshore) [19:32:24] (03CR) 10CI reject: [V: 04-1] LingoParser: Avoid direct access to Parser::mDoubleUnderscores [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/833348 (owner: 10D3r1ck01) [19:33:42] 10Wikimedia Enterprise: Improve security of IAC solution - checkov integration and IAC improvements, based on checkov analyses - https://phabricator.wikimedia.org/T320329 (10Alex.lep.sp) [19:38:13] (03CR) 10CI reject: [V: 04-1] Allow replying to some comments with accidental complex transclusions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840331 (https://phabricator.wikimedia.org/T313093) (owner: 10Bartosz Dziewoński) [19:38:15] (03CR) 10CI reject: [V: 04-1] Add test cases for T313093 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 (owner: 10Bartosz Dziewoński) [19:38:18] (03CR) 10CI reject: [V: 04-1] Place replies outside transclusions, disallow replying to transcluded comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840329 (https://phabricator.wikimedia.org/T313100) (owner: 10Bartosz Dziewoński) [19:39:43] (03PS5) 10MdsShakil: Fix Bengali translation for NS_MEDIAWIKI_TALK [core] - 10https://gerrit.wikimedia.org/r/840288 [19:40:04] 10MediaWiki-extensions-Scribunto: Test failures on PHPUnit 9.5: "This test does not have a @covers annotation but is expected to have one" - https://phabricator.wikimedia.org/T320330 (10matmarex) [19:40:41] 10MediaWiki-extensions-Scribunto: Test failures on PHPUnit 9.5: "This test does not have a @covers annotation but is expected to have one" - https://phabricator.wikimedia.org/T320330 (10matmarex) p:05Triage→03Unbreak! This is blocking merges in Scribunto, and extensions that depend on it. [19:40:46] 10MediaWiki-extensions-WikimediaEvents: Test failures on PHPUnit 9.5: "Error: Class 'PHPUnit\Framework\Constraint\ArraySubset' not found" - https://phabricator.wikimedia.org/T320331 (10matmarex) [19:40:59] 10MediaWiki-extensions-WikimediaEvents: Test failures on PHPUnit 9.5: "Error: Class 'PHPUnit\Framework\Constraint\ArraySubset' not found" - https://phabricator.wikimedia.org/T320331 (10matmarex) p:05Triage→03Unbreak! This is blocking merges in WikimediaEvents, and extensions that depend on it. [19:41:22] (03CR) 10Bartosz Dziewoński: [C: 03+2] Use OOUI instead of jquery.ui for error popup (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/838283 (https://phabricator.wikimedia.org/T319361) (owner: 10Legoktm) [19:41:36] 10MediaWiki-extensions-Scribunto, 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "This test does not have a @covers annotation but is expected to have one" - https://phabricator.wikimedia.org/T320330 (10taavi) [19:44:37] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Updating grunt-banana-checker to 0.10.0 [extensions/MediaModeration] - 10https://gerrit.wikimedia.org/r/839410 (https://phabricator.wikimedia.org/T320307) (owner: 10Libraryupgrader) [19:45:03] 10MediaWiki-extensions-WikimediaEvents, 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "Error: Class 'PHPUnit\Framework\Constraint\ArraySubset' not found" - https://phabricator.wikimedia.org/T320331 (10matmarex) [19:51:31] (03PS1) 10Reedy: Add more @covers [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840335 (https://phabricator.wikimedia.org/T320330) [19:55:10] (03PS2) 10Reedy: Add more @covers [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840335 (https://phabricator.wikimedia.org/T320330) [19:56:48] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-Scribunto, 10Patch-For-Review, 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "This test does not have a @covers annotation but is expected to have one" - https://phabricator.wikimedia.org/T320330 (10Legoktm) The relevant code in P... [19:57:02] (03CR) 10CI reject: [V: 04-1] Use OOUI instead of jquery.ui for error popup [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/838283 (https://phabricator.wikimedia.org/T319361) (owner: 10Legoktm) [19:59:34] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-Scribunto, 10Patch-For-Review, 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "This test does not have a @covers annotation but is expected to have one" - https://phabricator.wikimedia.org/T320330 (10Reedy) >>! In T320330#8302460,... [19:59:39] (03PS3) 10Reedy: Add more @covers [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840335 (https://phabricator.wikimedia.org/T320330) [19:59:50] (03CR) 10Legoktm: [C: 03+2] "Nice, passes locally now :)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840335 (https://phabricator.wikimedia.org/T320330) (owner: 10Reedy) [20:00:32] (03CR) 10Legoktm: [C: 03+2] Add more @covers [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840335 (https://phabricator.wikimedia.org/T320330) (owner: 10Reedy) [20:00:57] (03CR) 10Reedy: Add more @covers (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840335 (https://phabricator.wikimedia.org/T320330) (owner: 10Reedy) [20:06:27] (03PS8) 10D3r1ck01: LingoParser: Avoid direct access to Parser::mDoubleUnderscores [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/833348 [20:07:47] (03CR) 10CI reject: [V: 04-1] LingoParser: Avoid direct access to Parser::mDoubleUnderscores [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/833348 (owner: 10D3r1ck01) [20:09:03] I expect it should bump coverage, though phpunit-patch-coverage didn't seem to detect any hmm [20:09:13] heh [20:13:49] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-Scribunto, 10Patch-For-Review, 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "This test does not have a @covers annotation but is expected to have one" - https://phabricator.wikimedia.org/T320330 (10Reedy) >>! In T320330#8302465,... [20:15:54] (03Merged) 10jenkins-bot: Add more @covers [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840335 (https://phabricator.wikimedia.org/T320330) (owner: 10Reedy) [20:17:43] (03CR) 10Legoktm: [C: 03+2] "Per Bartosz" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/838283 (https://phabricator.wikimedia.org/T319361) (owner: 10Legoktm) [20:20:13] legoktm: lmao, the coverage is broken completely now [20:20:15] https://doc.wikimedia.org/cover-extensions/Scribunto/includes/index.html [20:20:26] It seems to have done something with MW core... [20:20:38] rip [20:20:48] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-Scribunto, 10Patch-For-Review, 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "This test does not have a @covers annotation but is expected to have one" - https://phabricator.wikimedia.org/T320330 (10Daimona) >>! In T320330#8302460... [20:20:50] * Reedy files a bug [20:21:41] 10MediaWiki-Core-Tests: Extension coverage reports are broken with PHPUnit 9.5; they seem to report MW core not the extension - https://phabricator.wikimedia.org/T320332 (10Reedy) [20:21:54] 10MediaWiki-Core-Tests, 10Test-Coverage: Extension coverage reports are broken with PHPUnit 9.5; they seem to report MW core not the extension - https://phabricator.wikimedia.org/T320332 (10Reedy) p:05Triage→03Unbreak! [20:22:29] 10MediaWiki-Core-Tests, 10Test-Coverage: Extension coverage reports are broken with PHPUnit 9.5; they seem to report MW core not the extension - https://phabricator.wikimedia.org/T320332 (10Reedy) [20:23:08] so we do [20:23:09] + phpunit-suite-edit /workspace/src/tests/phpunit/suite.xml --cover-extension Scribunto [20:23:14] + php -d extension=pcov.so -d pcov.enabled=1 -d pcov.directory=/workspace/src/extensions/Scribunto -d 'pcov.exclude=@(tests|vendor)@' /workspace/src/tests/phpunit/phpunit.php --testsuite extensions --coverage-clover /workspace/log/clover.xml --coverage-html /workspace/cover --log-junit /workspace/log/junit.xml /workspace/src/extensions/Scribunto/tests/phpunit [20:24:06] I think it's phpunit-suite-edit [20:24:11] that needs updating [20:25:19] 10MediaWiki-Core-Tests, 10Continuous-Integration-Config, 10Test-Coverage: Extension coverage reports are broken with PHPUnit 9.5; they seem to report MW core not the extension - https://phabricator.wikimedia.org/T320332 (10Legoktm) a:03Legoktm phpunit-suite-edit needs to be updated [20:28:53] (03CR) 10Zabe: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/840320 (owner: 10Reedy) [20:29:59] (03CR) 10Reedy: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/840320 (owner: 10Reedy) [20:30:34] (03CR) 10Zabe: [C: 03+2] Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [vendor] - 10https://gerrit.wikimedia.org/r/840319 (owner: 10Reedy) [20:30:36] (03CR) 10Zabe: [C: 03+2] Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [core] - 10https://gerrit.wikimedia.org/r/840320 (owner: 10Reedy) [20:32:53] 10MediaWiki-extensions-WikimediaEvents, 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "Error: Class 'PHPUnit\Framework\Constraint\ArraySubset' not found" - https://phabricator.wikimedia.org/T320331 (10Daimona) a:03Daimona [20:33:28] (03Merged) 10jenkins-bot: Use OOUI instead of jquery.ui for error popup [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/838283 (https://phabricator.wikimedia.org/T319361) (owner: 10Legoktm) [20:33:30] (03Abandoned) 10Zabe: Running 'npm audit fix' [core] - 10https://gerrit.wikimedia.org/r/834699 (owner: 10Zabe) [20:34:04] 10MediaWiki-extensions-WikimediaEvents, 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "Error: Class 'PHPUnit\Framework\Constraint\ArraySubset' not found" - https://phabricator.wikimedia.org/T320331 (10Daimona) So, we addressed this a while ago in T244095 because we knew it was com... [20:49:13] 10MediaWiki-extensions-MediaModeration, 10MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), 10ci-test-error: PHP 8.0 test failures for MediaModeration - https://phabricator.wikimedia.org/T320307 (10matmarex) 05Open→03Resolved [20:50:45] (03Merged) 10jenkins-bot: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [vendor] - 10https://gerrit.wikimedia.org/r/840319 (owner: 10Reedy) [20:50:48] (03Merged) 10jenkins-bot: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [core] - 10https://gerrit.wikimedia.org/r/840320 (owner: 10Reedy) [20:51:48] (03PS1) 10Reedy: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [vendor] (REL1_39) - 10https://gerrit.wikimedia.org/r/840338 [20:52:13] (03PS1) 10Reedy: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [core] (REL1_39) - 10https://gerrit.wikimedia.org/r/840289 [20:53:15] 10MediaWiki-Uploading, 10Commons, 10XMPReader, 10PHP 7.4 support, and 3 others: PHP Warning: XMLReader::open(): URI must not contain percent-encoded NUL bytes - https://phabricator.wikimedia.org/T320282 (10Reedy) https://gerrit.wikimedia.org/r/c/mediawiki/libs/XMPReader/+/840214 was included in xmp-reader... [20:56:19] (03PS1) 10Bartosz Dziewoński: Don't insert comment markers inside
[extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840340 (https://phabricator.wikimedia.org/T320285) [20:58:59] (03CR) 10Zabe: [C: 03+2] Update test for core pager changes [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/840251 (owner: 10Legoktm) [20:59:01] (03CR) 10Zabe: [C: 03+2] build: Updating grunt-banana-checker to 0.10.0 [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/839967 (owner: 10Libraryupgrader) [21:01:02] (03Merged) 10jenkins-bot: Update test for core pager changes [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/840251 (owner: 10Legoktm) [21:01:27] 10MediaWiki-extensions-Scribunto, 10MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), 10Patch-For-Review, 10Technical-Debt: Replace usage of jquery.ui in Scribunto - https://phabricator.wikimedia.org/T319361 (10matmarex) 05Open→03Resolved [21:02:12] technical debt: {{resolved}} [21:02:41] (03CR) 10CI reject: [V: 04-1] Don't insert comment markers inside
[extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840340 (https://phabricator.wikimedia.org/T320285) (owner: 10Bartosz Dziewoński) [21:03:02] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-Scribunto, 10MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "This test does not have a @covers annotation but is expected to have one" - https://phabricator.wikimedia.org/T320330 (10matmarex... [21:12:20] 10MediaWiki-extensions-WikimediaEvents, 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "Error: Class 'PHPUnit\Framework\Constraint\ArraySubset' not found" - https://phabricator.wikimedia.org/T320331 (10Daimona) 05Open→03Resolved [21:13:11] 10MediaWiki-extensions-WikimediaEvents, 10ci-test-error (WMF-deployed Build Failure): Test failures on PHPUnit 9.5: "Error: Class 'PHPUnit\Framework\Constraint\ArraySubset' not found" - https://phabricator.wikimedia.org/T320331 (10matmarex) Thanks for the quick fix! [21:14:04] (03CR) 10Bartosz Dziewoński: [C: 03+2] ImmutableRange: Add surroundContents method [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818577 (owner: 10Esanders) [21:14:28] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840332 (https://phabricator.wikimedia.org/T316333) (owner: 10Bartosz Dziewoński) [21:14:30] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840328 (owner: 10Bartosz Dziewoński) [21:14:32] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840331 (https://phabricator.wikimedia.org/T313093) (owner: 10Bartosz Dziewoński) [21:14:34] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 (owner: 10Bartosz Dziewoński) [21:14:36] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840329 (https://phabricator.wikimedia.org/T313100) (owner: 10Bartosz Dziewoński) [21:14:38] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840340 (https://phabricator.wikimedia.org/T320285) (owner: 10Bartosz Dziewoński) [21:19:31] (03PS1) 10Reedy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840343 [21:20:26] (03CR) 10Reedy: [C: 03+2] Restore padding on #mw-scribunto-input to make cursor visible [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/839039 (https://phabricator.wikimedia.org/T272678) (owner: 10Legoktm) [21:21:19] (03PS1) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840344 [21:22:09] (03Merged) 10jenkins-bot: ImmutableRange: Add surroundContents method [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/818577 (owner: 10Esanders) [21:22:38] (03Abandoned) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840344 (owner: 10Daimona Eaytoy) [21:22:55] (03CR) 10Daimona Eaytoy: [C: 03+2] build: Update mediawiki/mediawiki-phan-config to 0.12.0 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840343 (owner: 10Reedy) [21:24:19] (03PS2) 10Bartosz Dziewoński: Don't insert comment markers inside
[extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840340 (https://phabricator.wikimedia.org/T320285) [21:24:45] (03CR) 10Reedy: [C: 03+2] Hide mw.hash.setupInterface from users [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/839035 (https://phabricator.wikimedia.org/T276138) (owner: 10Legoktm) [21:25:15] (03PS4) 10Bartosz Dziewoński: Place replies outside transclusions, disallow replying to transcluded comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840329 (https://phabricator.wikimedia.org/T313100) [21:25:53] (03PS4) 10Bartosz Dziewoński: Add test cases for T313093 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 [21:26:52] (03PS5) 10Bartosz Dziewoński: Add test cases for T313093 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 [21:27:09] (03PS4) 10Bartosz Dziewoński: Allow replying to some comments with accidental complex transclusions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840331 (https://phabricator.wikimedia.org/T313093) [21:31:39] (03CR) 10CI reject: [V: 04-1] Place replies outside transclusions, disallow replying to transcluded comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840329 (https://phabricator.wikimedia.org/T313100) (owner: 10Bartosz Dziewoński) [21:33:27] (03CR) 10CI reject: [V: 04-1] Allow replying to some comments with accidental complex transclusions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840331 (https://phabricator.wikimedia.org/T313093) (owner: 10Bartosz Dziewoński) [21:33:33] (03CR) 10CI reject: [V: 04-1] Add test cases for T313093 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 (owner: 10Bartosz Dziewoński) [21:35:31] (03Merged) 10jenkins-bot: Restore padding on #mw-scribunto-input to make cursor visible [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/839039 (https://phabricator.wikimedia.org/T272678) (owner: 10Legoktm) [21:36:27] (03PS5) 10Bartosz Dziewoński: Place replies outside transclusions, disallow replying to transcluded comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840329 (https://phabricator.wikimedia.org/T313100) [21:36:29] (03PS6) 10Bartosz Dziewoński: Add test cases for T313093 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840330 [21:36:31] (03PS5) 10Bartosz Dziewoński: Allow replying to some comments with accidental complex transclusions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/840331 (https://phabricator.wikimedia.org/T313093) [21:37:40] (03CR) 10Reedy: [V: 03+2 C: 03+2] Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [vendor] (REL1_39) - 10https://gerrit.wikimedia.org/r/840338 (owner: 10Reedy) [21:38:08] (03PS2) 10Reedy: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [core] (REL1_39) - 10https://gerrit.wikimedia.org/r/840289 [21:38:12] (03CR) 10Reedy: [C: 03+2] Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [core] (REL1_39) - 10https://gerrit.wikimedia.org/r/840289 (owner: 10Reedy) [21:38:29] (03Merged) 10jenkins-bot: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/840343 (owner: 10Reedy) [21:38:31] (03CR) 10CI reject: [V: 04-1] Hide mw.hash.setupInterface from users [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/839035 (https://phabricator.wikimedia.org/T276138) (owner: 10Legoktm) [21:38:58] (03CR) 10Jack Phoenix: "Super cool stuff! \o/ 🎉" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [21:41:21] 10MediaWiki-Core-Tests, 10Continuous-Integration-Config, 10Test-Coverage: Extension coverage reports are broken with PHPUnit 9.5; they seem to report MW core not the extension - https://phabricator.wikimedia.org/T320332 (10Reedy) 05Open→03Resolved [21:45:07] (03CR) 10Daimona Eaytoy: [C: 03+2] Upgrading mediawiki/mediawiki-phan-config (0.11.1 => 0.12.0) [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/840323 (owner: 10Reedy) [21:47:43] (03Merged) 10jenkins-bot: Upgrading wikimedia/xmp-reader (0.8.3 => 0.8.4) [core] (REL1_39) - 10https://gerrit.wikimedia.org/r/840289 (owner: 10Reedy) [21:51:19] 10Outreach-Programs-Projects, 10Outreachy (Round 25): Outreachy Application Task (Round 25): Setup Frontend Web App for Toolhub records management - https://phabricator.wikimedia.org/T318921 (10Bukolab99) a:03Bukolab99 [22:00:12] (03PS2) 10Reedy: Inject services into hook handler [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/826976 (owner: 10Umherirrender) [22:00:32] (03CR) 10Reedy: [C: 03+2] Inject services into hook handler [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/826976 (owner: 10Umherirrender) [22:01:00] (03PS3) 10Reedy: Hide mw.hash.setupInterface from users [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/839035 (https://phabricator.wikimedia.org/T276138) (owner: 10Legoktm) [22:01:12] (03CR) 10Reedy: [C: 03+2] "Unrelated failures... Rebase and resubmit" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/839035 (https://phabricator.wikimedia.org/T276138) (owner: 10Legoktm) [22:04:08] 10MediaWiki-extensions-Scribunto, 10Browser-Support-Google-Chrome, 10MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), 10Patch-For-Review: The caret is invisible due to focus outline of the textarea#mw-scribunto-input - https://phabricator.wikimedia.org/T272678 (10Legoktm) 05Open→03Resolved [22:04:10] (03PS1) 10Legoktm: Restore padding on #mw-scribunto-input to make cursor visible [extensions/Scribunto] (REL1_39) - 10https://gerrit.wikimedia.org/r/840290 (https://phabricator.wikimedia.org/T272678) [22:04:15] (03CR) 10Legoktm: [C: 03+2] Restore padding on #mw-scribunto-input to make cursor visible [extensions/Scribunto] (REL1_39) - 10https://gerrit.wikimedia.org/r/840290 (https://phabricator.wikimedia.org/T272678) (owner: 10Legoktm) [22:05:33] (03PS5) 10Thiemo Kreuz (WMDE): Drop unused Survey::isEnabled() feature [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/833091 [22:06:39] (03PS2) 10Thiemo Kreuz (WMDE): Fix broken "survey name must be unique" check [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/833073 (https://phabricator.wikimedia.org/T255427) [22:07:14] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix broken "survey name must be unique" check [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/833073 (https://phabricator.wikimedia.org/T255427) (owner: 10Thiemo Kreuz (WMDE)) [22:07:16] (03Merged) 10jenkins-bot: Restore padding on #mw-scribunto-input to make cursor visible [extensions/Scribunto] (REL1_39) - 10https://gerrit.wikimedia.org/r/840290 (https://phabricator.wikimedia.org/T272678) (owner: 10Legoktm) [22:15:45] (03Merged) 10jenkins-bot: Inject services into hook handler [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/826976 (owner: 10Umherirrender) [22:16:34] (03PS2) 10Reedy: build: Updating grunt-banana-checker to 0.10.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/839040 (owner: 10Libraryupgrader) [22:16:36] (03PS1) 10Reedy: Searcher: Suppress PhanTypeMismatchArgumentNullable [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/840346 [22:18:35] (03Merged) 10jenkins-bot: Hide mw.hash.setupInterface from users [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/839035 (https://phabricator.wikimedia.org/T276138) (owner: 10Legoktm) [22:18:37] (03Merged) 10jenkins-bot: Fix broken "survey name must be unique" check [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/833073 (https://phabricator.wikimedia.org/T255427) (owner: 10Thiemo Kreuz (WMDE)) [22:19:06] 10MediaWiki-extensions-Scribunto, 10Patch-For-Review: mw.hash.setupInterface is not nil - https://phabricator.wikimedia.org/T276138 (10Legoktm) 05Open→03Resolved [22:31:27] (03CR) 10CI reject: [V: 04-1] build: Updating grunt-banana-checker to 0.10.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/839040 (owner: 10Libraryupgrader) [22:33:10] 10Wikidata Lexicographical data, 10ci-test-error: WikibaseLexeme PHPUnit 9 warnings - https://phabricator.wikimedia.org/T320333 (10Reedy) [22:36:01] (03CR) 10CI reject: [V: 04-1] Searcher: Suppress PhanTypeMismatchArgumentNullable [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/840346 (owner: 10Reedy) [22:42:13] (03CR) 10Legoktm: [C: 03+2] Fixes for the phan upgrade, part 1 [core] - 10https://gerrit.wikimedia.org/r/840275 (owner: 10Daimona Eaytoy) [22:43:44] (03CR) 10Legoktm: Fixes for the phan upgrade, part 2 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/840279 (owner: 10Daimona Eaytoy) [22:44:45] 10Technical-Debt: Instances of assertRegExp that need updating - https://phabricator.wikimedia.org/T320334 (10Reedy) [22:45:04] 10Technical-Debt: Instances of assertRegExp that need updating - https://phabricator.wikimedia.org/T320334 (10Reedy) [22:45:06] 10Wikidata Lexicographical data, 10Patch-For-Review, 10ci-test-error: WikibaseLexeme PHPUnit 9 warnings - https://phabricator.wikimedia.org/T320333 (10Reedy) [22:49:13] (03PS1) 10Reedy: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/840350 (https://phabricator.wikimedia.org/T320334) [22:54:26] (03PS1) 10Reedy: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/SimilarEditors] - 10https://gerrit.wikimedia.org/r/840351 (https://phabricator.wikimedia.org/T320334) [22:55:20] (03CR) 10CI reject: [V: 04-1] tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/840350 (https://phabricator.wikimedia.org/T320334) (owner: 10Reedy) [22:55:26] (03PS1) 10Reedy: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/840352 (https://phabricator.wikimedia.org/T320334) [22:57:30] 10Patch-For-Review, 10Technical-Debt: Instances of assertRegExp that need updating (as of 1.40.0-wmf.4) - https://phabricator.wikimedia.org/T320334 (10Reedy) [22:58:56] (03Merged) 10jenkins-bot: Fixes for the phan upgrade, part 1 [core] - 10https://gerrit.wikimedia.org/r/840275 (owner: 10Daimona Eaytoy) [23:02:51] (03PS2) 10Reedy: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/840350 (https://phabricator.wikimedia.org/T320334) [23:02:53] (03PS1) 10Reedy: Add missing @covers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/840354 [23:07:56] (03CR) 10Daimona Eaytoy: Fixes for the phan upgrade, part 2 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/840279 (owner: 10Daimona Eaytoy) [23:08:35] (03CR) 10Daimona Eaytoy: [C: 03+2] tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/840350 (https://phabricator.wikimedia.org/T320334) (owner: 10Reedy) [23:08:41] (03CR) 10CI reject: [V: 04-1] Add missing @covers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/840354 (owner: 10Reedy) [23:08:48] (03CR) 10CI reject: [V: 04-1] tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/840350 (https://phabricator.wikimedia.org/T320334) (owner: 10Reedy) [23:10:51] 10Patch-For-Review, 10Technical-Debt: Instances of assertRegExp that need updating (as of 1.40.0-wmf.4) - https://phabricator.wikimedia.org/T320334 (10Reedy) [23:11:26] 10Patch-For-Review, 10Technical-Debt: Instances of assertRegExp that need updating (as of 1.40.0-wmf.4) - https://phabricator.wikimedia.org/T320334 (10Reedy) [23:12:04] (03CR) 10Reedy: "recheck" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/840346 (owner: 10Reedy) [23:16:49] (03PS2) 10Reedy: Add missing @covers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/840354 [23:17:07] (03PS3) 10Reedy: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/840350 (https://phabricator.wikimedia.org/T320334) [23:22:48] (03CR) 10CI reject: [V: 04-1] Add missing @covers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/840354 (owner: 10Reedy) [23:26:39] 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review, 10Technical-Debt: Instances of assertRegExp that need updating (as of 1.40.0-wmf.4) - https://phabricator.wikimedia.org/T320334 (10Reedy) [23:31:36] (03CR) 10Legoktm: [C: 03+2] Fixes for the phan upgrade, part 2 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/840279 (owner: 10Daimona Eaytoy) [23:32:09] (03CR) 10Reedy: "recheck" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/839040 (owner: 10Libraryupgrader) [23:32:28] (03PS55) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [23:32:33] (03CR) 10Universal Omega: Add support for file backend for avatar, award and gift images (035 comments) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [23:32:41] (03PS56) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [23:35:33] (03CR) 10Legoktm: [C: 03+2] build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 (https://phabricator.wikimedia.org/T298571) (owner: 10Daimona Eaytoy) [23:35:58] (03PS1) 10Lewis Cawte: More RequestContext in the ContributionsToolLinks hook handler [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840293 [23:36:32] (03CR) 10Legoktm: [C: 03+2] tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/840352 (https://phabricator.wikimedia.org/T320334) (owner: 10Reedy) [23:36:46] (03PS1) 10Lewis Cawte: PostgreSQL timestamp fix for eventual PostgreSQL support [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840294 [23:36:48] (03CR) 10Legoktm: [C: 03+2] Searcher: Suppress PhanTypeMismatchArgumentNullable [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/840346 (owner: 10Reedy) [23:36:53] (03CR) 10CI reject: [V: 04-1] More RequestContext in the ContributionsToolLinks hook handler [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840293 (owner: 10Lewis Cawte) [23:37:12] (03CR) 10Legoktm: [C: 03+2] tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/SimilarEditors] - 10https://gerrit.wikimedia.org/r/840351 (https://phabricator.wikimedia.org/T320334) (owner: 10Reedy) [23:37:30] (03PS1) 10Lewis Cawte: Another PostgreSQL timestamp fix [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840295 [23:37:34] (03CR) 10CI reject: [V: 04-1] PostgreSQL timestamp fix for eventual PostgreSQL support [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840294 (owner: 10Lewis Cawte) [23:37:49] (03CR) 10Legoktm: [C: 03+2] HtmlFormatter: Ignore a couple of lines for code coverage [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/840291 (owner: 10Reedy) [23:38:12] (03PS1) 10Reedy: Upgrading mediawiki/mediawiki-phan-config (0.11.1 => 0.12.0) [IPSet] - 10https://gerrit.wikimedia.org/r/840355 [23:38:27] (03CR) 10CI reject: [V: 04-1] Another PostgreSQL timestamp fix [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840295 (owner: 10Lewis Cawte) [23:38:35] (03PS1) 10Lewis Cawte: Convert $wgMemc use to WANObjectCache [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840296 (https://phabricator.wikimedia.org/T243336) [23:38:47] (03Merged) 10jenkins-bot: HtmlFormatter: Ignore a couple of lines for code coverage [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/840291 (owner: 10Reedy) [23:39:58] (03CR) 10CI reject: [V: 04-1] Convert $wgMemc use to WANObjectCache [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840296 (https://phabricator.wikimedia.org/T243336) (owner: 10Lewis Cawte) [23:40:29] legoktm: re https://gerrit.wikimedia.org/r/c/mediawiki/extensions/RegexBlock/+/640702 ... uhh, technically maybe? I'm pretending I know how to do that ;) [23:40:52] heh [23:41:13] (03PS1) 10Reedy: Upgrading mediawiki/mediawiki-phan-config (0.11.1 => 0.12.0) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/840356 [23:41:40] Lcawte: I probably tried and it had too many conflicts that I gave up [23:41:50] but I do think the REL1_35 branch is broken? maybe? [23:42:05] (03PS1) 10Reedy: composer.json: Bump phpunit/phpunit to ^9.5 [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/840357 [23:42:12] (03PS57) 10Universal Omega: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [23:42:17] Yeah, at the very minimum the extension.json doesn't support the latest pathc [23:42:29] (03PS3) 10Daimona Eaytoy: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [extensions/Score] - 10https://gerrit.wikimedia.org/r/840285 (https://phabricator.wikimedia.org/T301079) [23:42:36] I've not tested it much further than that. [23:42:57] (03PS1) 10Reedy: composer.json: Bump phpunit/phpunit to ^9.5 [IPSet] - 10https://gerrit.wikimedia.org/r/840358 [23:44:19] 10IPSet, 10phan, 10PHP 8.0 support, 10Technical-Debt: Rename match() method - https://phabricator.wikimedia.org/T320335 (10Reedy) [23:45:32] (03CR) 10Lewis Cawte: [V: 03+2 C: 03+2] More RequestContext in the ContributionsToolLinks hook handler [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840293 (owner: 10Lewis Cawte) [23:46:24] (03CR) 10CI reject: [V: 04-1] More RequestContext in the ContributionsToolLinks hook handler [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840293 (owner: 10Lewis Cawte) [23:56:07] (03PS2) 10Lewis Cawte: Convert $wgMemc use to WANObjectCache [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840296 (https://phabricator.wikimedia.org/T243336) [23:57:05] (03Merged) 10jenkins-bot: Fixes for the phan upgrade, part 2 [core] - 10https://gerrit.wikimedia.org/r/840279 (owner: 10Daimona Eaytoy) [23:57:14] (03Merged) 10jenkins-bot: build: Update mediawiki/mediawiki-phan-config to 0.12.0 [core] - 10https://gerrit.wikimedia.org/r/840274 (https://phabricator.wikimedia.org/T298571) (owner: 10Daimona Eaytoy) [23:57:19] (03Merged) 10jenkins-bot: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/840352 (https://phabricator.wikimedia.org/T320334) (owner: 10Reedy) [23:57:21] (03Merged) 10jenkins-bot: Searcher: Suppress PhanTypeMismatchArgumentNullable [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/840346 (owner: 10Reedy) [23:57:25] (03Merged) 10jenkins-bot: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/SimilarEditors] - 10https://gerrit.wikimedia.org/r/840351 (https://phabricator.wikimedia.org/T320334) (owner: 10Reedy) [23:57:28] (03CR) 10CI reject: [V: 04-1] Convert $wgMemc use to WANObjectCache [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840296 (https://phabricator.wikimedia.org/T243336) (owner: 10Lewis Cawte) [23:58:00] (03CR) 10Lewis Cawte: [V: 03+2 C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840296 (https://phabricator.wikimedia.org/T243336) (owner: 10Lewis Cawte) [23:59:00] (03CR) 10CI reject: [V: 04-1] Convert $wgMemc use to WANObjectCache [extensions/RegexBlock] (REL1_35) - 10https://gerrit.wikimedia.org/r/840296 (https://phabricator.wikimedia.org/T243336) (owner: 10Lewis Cawte)