[00:02:14] 10PageTriage, 10MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), 10Patch-For-Review: PageTriage should use packageFiles - https://phabricator.wikimedia.org/T339373 (10Jdlrobson) 05Open→03Resolved a:03Jdlrobson [00:08:00] (03PS39) 10HMonroy: diff: Add inline format switch when Wikidiff2 is installed [core] - 10https://gerrit.wikimedia.org/r/902539 (https://phabricator.wikimedia.org/T336712) [00:10:16] 10QuickSurveys: QuickSurveys buttons should use CdxToggleButtonGroup - https://phabricator.wikimedia.org/T339798 (10Catrope) [00:10:47] 10QuickSurveys, 10Design-Systems-Team (Design-Systems-Sprint-1): Migrate QuickSurveys to Vue 3 - https://phabricator.wikimedia.org/T338839 (10Catrope) In the course of working on this I found {T339798} [00:11:41] (03PS1) 10Catrope: Prepare for Vue 3 migration [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/930888 (https://phabricator.wikimedia.org/T338838) [00:15:37] (03CR) 10Jdlrobson: [C: 03+2] Prepare for Vue 3 migration [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/930888 (https://phabricator.wikimedia.org/T338838) (owner: 10Catrope) [00:16:17] 10PageTriage: Get Jest code coverage report added to docs.wikimedia.org - https://phabricator.wikimedia.org/T339799 (10Novem_Linguae) [00:16:19] 10Product-Analytics (Kanban): Migrate to a new developer account - https://phabricator.wikimedia.org/T331950 (10nshahquinn-wmf) Yesterday and today, I: * copied over everything from my old home folder on stat1005 to my new one * verified that I can use Jupyter with the new account and run the Wikistories basic s... [00:17:02] 10PageTriage: Add Jest code coverage report to docs.wikimedia.org - https://phabricator.wikimedia.org/T339799 (10Novem_Linguae) [00:17:04] 10Codex, 10Design-Systems-Team (Design-Systems-Sprint-1): TextArea: Move from WIP components to public components - https://phabricator.wikimedia.org/T331044 (10lwatson) 05Open→03Resolved [00:17:07] 10Design, 10Codex, 10Design-Systems-Team (Design-Systems-Product-Roadmap): TextArea: Add TextArea component to Codex - https://phabricator.wikimedia.org/T284272 (10lwatson) [00:17:32] (03Merged) 10jenkins-bot: Prepare for Vue 3 migration [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/930888 (https://phabricator.wikimedia.org/T338838) (owner: 10Catrope) [00:17:43] 10Product-Analytics (Kanban): Migrate to a new developer account - https://phabricator.wikimedia.org/T331950 (10nshahquinn-wmf) [00:18:16] 10Design, 10Campaign-Tools, 10Codex, 10OOUI, and 3 others: Add the "user-rights" icon to OOUI and Codex - https://phabricator.wikimedia.org/T338344 (10lwatson) 05Open→03In progress [00:18:28] (03CR) 10Catrope: "Whoops I tagged the wrong task, should have been https://phabricator.wikimedia.org/T338839" [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/930888 (https://phabricator.wikimedia.org/T338838) (owner: 10Catrope) [00:19:02] 10Design-Systems-Team, 10Patch-For-Review: Migrate all extension/skin code to Vue 3 - https://phabricator.wikimedia.org/T289020 (10Catrope) [00:19:06] 10QuickSurveys, 10Design-Systems-Team (Design-Systems-Sprint-1): Migrate QuickSurveys to Vue 3 - https://phabricator.wikimedia.org/T338839 (10Catrope) 05Open→03Resolved Merged patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/QuickSurveys/+/930888/ (accidentally tagged it with the wrong task) [00:20:19] 10QuickSurveys: Icon-only dismiss button should have an aria-label - https://phabricator.wikimedia.org/T339800 (10Catrope) [00:21:01] 10QuickSurveys, 10Design-Systems-Team (Design-Systems-Sprint-1): Migrate QuickSurveys to Vue 3 - https://phabricator.wikimedia.org/T338839 (10Catrope) Also filed {T339800} in connection with this task [00:22:42] 10Product-Analytics (Kanban): Migrate to a new developer account - https://phabricator.wikimedia.org/T331950 (10nshahquinn-wmf) [00:27:34] (03PS5) 10Jsn.sherman: remove grunt; define scripts in package.json [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/930781 (https://phabricator.wikimedia.org/T335542) [00:28:18] (03PS6) 10Jsn.sherman: remove grunt; define scripts in package.json [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/930781 (https://phabricator.wikimedia.org/T335542) [00:28:20] (03CR) 10CI reject: [V: 04-1] diff: Add inline format switch when Wikidiff2 is installed [core] - 10https://gerrit.wikimedia.org/r/902539 (https://phabricator.wikimedia.org/T336712) (owner: 10HMonroy) [00:33:53] (03CR) 10CI reject: [V: 04-1] remove grunt; define scripts in package.json [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/930781 (https://phabricator.wikimedia.org/T335542) (owner: 10Jsn.sherman) [00:35:42] (03PS40) 10HMonroy: diff: Add inline format switch when Wikidiff2 is installed [core] - 10https://gerrit.wikimedia.org/r/902539 (https://phabricator.wikimedia.org/T336712) [00:36:48] (03PS5) 10Daimona Eaytoy: [WIP] Add tracking tools [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/930213 [00:38:18] (03PS2) 10LWatson: Icons: Add user rights icon to OOUI and Codex [design/codex] - 10https://gerrit.wikimedia.org/r/930269 (https://phabricator.wikimedia.org/T338344) [00:39:35] (03CR) 10CI reject: [V: 04-1] [WIP] Add tracking tools [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/930213 (owner: 10Daimona Eaytoy) [00:39:43] (03PS1) 10TrainBranchBot: Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/930828 [00:39:45] (03CR) 10TrainBranchBot: [C: 03+2] Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/930828 (owner: 10TrainBranchBot) [00:41:21] (03PS1) 10Cicalese: Add missing doc comment [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930891 [00:43:54] (03CR) 10CI reject: [V: 04-1] Icons: Add user rights icon to OOUI and Codex [design/codex] - 10https://gerrit.wikimedia.org/r/930269 (https://phabricator.wikimedia.org/T338344) (owner: 10LWatson) [00:43:57] (03CR) 10Cicalese: [C: 03+2] Add missing doc comment [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930891 (owner: 10Cicalese) [00:44:22] (03PS7) 10Jsn.sherman: remove grunt; define scripts in package.json [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/930781 (https://phabricator.wikimedia.org/T335542) [00:51:41] (03PS2) 10Arlolra: Catch pageConfig errors in ParsoidOutputAccess [core] - 10https://gerrit.wikimedia.org/r/929777 (https://phabricator.wikimedia.org/T338925) [00:53:49] (03CR) 10Jsn.sherman: "Verified that npm test works happily locally and in ci; it runs the linters as before and now runs jest tests too." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/930781 (https://phabricator.wikimedia.org/T335542) (owner: 10Jsn.sherman) [00:53:56] (03CR) 10CI reject: [V: 04-1] diff: Add inline format switch when Wikidiff2 is installed [core] - 10https://gerrit.wikimedia.org/r/902539 (https://phabricator.wikimedia.org/T336712) (owner: 10HMonroy) [00:55:21] (03PS3) 10Arlolra: Catch pageConfig errors in ParsoidOutputAccess [core] - 10https://gerrit.wikimedia.org/r/929777 (https://phabricator.wikimedia.org/T338925) [01:01:11] (03Merged) 10jenkins-bot: Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/930828 (owner: 10TrainBranchBot) [01:01:12] (03Merged) 10jenkins-bot: Add missing doc comment [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930891 (owner: 10Cicalese) [01:03:53] (03PS4) 10Arlolra: Catch pageConfig errors in ParsoidOutputAccess [core] - 10https://gerrit.wikimedia.org/r/929777 (https://phabricator.wikimedia.org/T338925) [01:04:27] (03CR) 10Arlolra: Catch pageConfig errors in ParsoidOutputAccess (034 comments) [core] - 10https://gerrit.wikimedia.org/r/929777 (https://phabricator.wikimedia.org/T338925) (owner: 10Arlolra) [01:09:26] 10MediaWiki-Language-converter, 10I18n, 10Tracking-Neverending: Languages that need a LanguageConverter implementation (tracking) - https://phabricator.wikimedia.org/T32759 (10H78c67c) [01:09:28] 10MediaWiki-Language-converter, 10I18n, 10MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), 10Patch-For-Review: Implement LanguageConverter for yue (Cantonese) - https://phabricator.wikimedia.org/T59106 (10H78c67c) 05In progress→03Stalled p:05Medium→03Low I believe this new status best reflects the total... [01:25:23] 10Library-Card-Platform, 10The-Wikipedia-Library, 10Moderator-Tools-Team (Kanban): Wikipedia Library - Fold3 images fail to load correctly via EZProxy - https://phabricator.wikimedia.org/T337913 (10jsn.sherman) I did notice that some in-page requests were giving access denied/403 responses if I wasn't logged... [01:27:43] 10Library-Card-Platform, 10The-Wikipedia-Library, 10Moderator-Tools-Team (Kanban): Wikipedia Library - Fold3 images fail to load correctly via EZProxy - https://phabricator.wikimedia.org/T337913 (10jsn.sherman) 05Open→03Stalled [01:36:41] 10Desktop Improvements (Vector 2022): "Add languages" dropdown appearing on deleted revision error page - https://phabricator.wikimedia.org/T339801 (10MusikAnimal) [01:48:23] (03PS1) 10Cicalese: Add year and make time format configurable [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930892 (https://phabricator.wikimedia.org/T326508) [01:49:49] (03CR) 10CI reject: [V: 04-1] Add year and make time format configurable [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930892 (https://phabricator.wikimedia.org/T326508) (owner: 10Cicalese) [01:50:43] (03PS2) 10Cicalese: Add year and make time format configurable [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930892 (https://phabricator.wikimedia.org/T326508) [01:52:20] (03CR) 10CI reject: [V: 04-1] Add year and make time format configurable [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930892 (https://phabricator.wikimedia.org/T326508) (owner: 10Cicalese) [01:57:01] (03PS3) 10Cicalese: Add year and make time format configurable [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930892 (https://phabricator.wikimedia.org/T326508) [01:58:27] (03CR) 10CI reject: [V: 04-1] Add year and make time format configurable [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930892 (https://phabricator.wikimedia.org/T326508) (owner: 10Cicalese) [01:58:43] (03PS4) 10Cicalese: Add year and make time format configurable [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930892 (https://phabricator.wikimedia.org/T326508) [03:07:47] (03PS1) 10Cicalese: Don't fail if comment is saved unchanged [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930893 [03:44:31] 10MediaWiki-Language-converter, 10I18n, 10Tracking-Neverending: Languages that need a LanguageConverter implementation (tracking) - https://phabricator.wikimedia.org/T32759 (10Winston_Sung) [03:44:48] 10MediaWiki-Language-converter, 10Community-consensus-needed, 10I18n, 10MW-1.41-notes (1.41.0-wmf.15; 2023-06-27): Implement LanguageConverter for yue (Cantonese) - https://phabricator.wikimedia.org/T59106 (10Winston_Sung) 05Stalled→03Open [04:31:21] (03CR) 10沈澄心: Use TitleGetEditNotices instead of EditPage::showEditForm:initial, show more details in editnotice (031 comment) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/928128 (owner: 10沈澄心) [04:33:44] 10MediaWiki-Core-Preferences, 10Moderator-Tools-Team (Kanban): The final preference in a section should not have a horizontal grey line on mobile web - https://phabricator.wikimedia.org/T325285 (10Scardenasmolinar) I don't see this error showing up in production or in my local development environment. @Samwalt... [04:49:35] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Failure is unrelated ("ENOSPC: no space left on device")" [core] - 10https://gerrit.wikimedia.org/r/930757 (owner: 10SD0001) [04:49:39] (03CR) 10Bartosz Dziewoński: [C: 03+1] mediawiki.loader: fix JSDoc type for mw.loader.addStyleTag [core] - 10https://gerrit.wikimedia.org/r/930757 (owner: 10SD0001) [04:53:30] 04(no projects): add wikimedia.social to WMF DNS (was: Update DNS records for mastodon.wikimedia.org) - https://phabricator.wikimedia.org/T337586 (10AAlikhan) @Dzahn Thank you. Confirming that wikimedia.social is fine [05:12:22] (03Merged) 10jenkins-bot: mediawiki.loader: fix JSDoc type for mw.loader.addStyleTag [core] - 10https://gerrit.wikimedia.org/r/930757 (owner: 10SD0001) [05:28:13] 10Wikimedia-Site-requests, 10Logos: Change logo of Karakalpak Wikipedia (kaa.wikipedia.org) - https://phabricator.wikimedia.org/T337641 (10Qaraqalpaqpan) >>! In T337641#8915459, @Superpes15 wrote: > @Qaraqalpaqpan It's likely a cache issue! Logo was changed also for legacy (2010) vector - as you can see [[http... [06:16:13] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10Mobile, 10Patch-For-Review: Minerva has no styling for links to pages that do not exist in reference popup - https://phabricator.wikimedia.org/T315120 (10stjn) Since default `#d33` from Codex Tokens is AA compliant with black background (4.6:1), I... [06:17:27] 10Design, 10Codex, 10Design-Systems-Team, 10Desktop Improvements (Vector 2022): New Vector's expanding search icon is confusing and distracting - https://phabricator.wikimedia.org/T314179 (10stjn) While this is mostly nitpicking, I’ve looked at this component again and want to ask: is there anything bad fr... [06:18:54] 10Accessibility, 10MobileFrontend, 10Readers-Web-Backlog (Tracking): Consider moving the "desktop version" button to the toolbar for accessibility - https://phabricator.wikimedia.org/T278004 (10stjn) [06:20:17] 10Accessibility, 10MobileFrontend, 10Readers-Web-Backlog (Tracking): Consider moving the "desktop version" button to the toolbar for accessibility - https://phabricator.wikimedia.org/T278004 (10stjn) 05Declined→03Open Since my task was merged as duplicate to a task with a slightly different intention, I’... [06:28:32] 10Advanced Mobile Contributions, 10Codex, 10Design-Systems-Team, 10Desktop Improvements (Vector 2022), and 2 others: Add red link experience to empty search results for Codex/mobile - https://phabricator.wikimedia.org/T211006 (10stjn) In August 2021, @Jdlrobson wrote: >>! In T287342#7253941, @Jdlrobson wro... [06:53:17] (03PS1) 10Brian Wolff: Mark this as MIT licensed. [tools/cookiecutter-extension] - 10https://gerrit.wikimedia.org/r/930894 [06:53:40] (03CR) 10Brian Wolff: [V: 03+2 C: 03+2] Mark this as MIT licensed. [tools/cookiecutter-extension] - 10https://gerrit.wikimedia.org/r/930894 (owner: 10Brian Wolff) [07:28:34] 10DNS: add wikimedia.social to WMF DNS (was: Update DNS records for mastodon.wikimedia.org) - https://phabricator.wikimedia.org/T337586 (10Legoktm) [07:36:51] 10MediaWiki-Internationalization, 10Language-Team, 10Regression: The display language in idwiki does not change even if a user has changed it - https://phabricator.wikimedia.org/T339272 (10Nikerabbit) This is not an issue with ULS. I can see that the settings change works successfully, and that the selected... [07:41:47] 10I18n: [[MediaWiki:Quiz points/fr]] translation issue - https://phabricator.wikimedia.org/T339804 (10Verdy_p) [07:50:26] 10I18n: [[MediaWiki:Quiz points/fr]] translation issue - https://phabricator.wikimedia.org/T339804 (10Verdy_p) [07:54:14] (03CR) 10Daniel Kinzler: "Why should core have any tests that depnd on extensions? These tests should be in the respective extension..." [core] - 10https://gerrit.wikimedia.org/r/889578 (owner: 10C. Scott Ananian) [07:59:48] (03PS2) 10MPGuy2824: Hide suppressed edits while showing article history [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/921658 (https://phabricator.wikimedia.org/T334458) [08:33:56] (03CR) 10MPGuy2824: Hide suppressed edits while showing article history (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/921658 (https://phabricator.wikimedia.org/T334458) (owner: 10MPGuy2824) [09:35:04] (03CR) 10VolkerE: [C: 03+2] "Nice to get completely rid of `fill`." [design/codex] - 10https://gerrit.wikimedia.org/r/930737 (owner: 10Catrope) [09:44:03] (03Merged) 10jenkins-bot: build: Make svglint rules stricter [design/codex] - 10https://gerrit.wikimedia.org/r/930737 (owner: 10Catrope) [09:54:44] 10MediaWiki-Internationalization: Page starting with letter i should not redirect to İ but to I in Karakalpak Wikipedia - https://phabricator.wikimedia.org/T335175 (10Amire80) I need to verify something. Please tell me if this is correct: - Small `i` must redirect to capital `I`. - Small `ı` must redirect to ca... [10:13:07] (03CR) 10D3r1ck01: WikidataDriver: Use of VirtualRESTService is deprecated (031 comment) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/930853 (https://phabricator.wikimedia.org/T338643) (owner: 10D3r1ck01) [10:23:28] (03CR) 10D3r1ck01: "Thanks for reviewing." [core] - 10https://gerrit.wikimedia.org/r/929677 (https://phabricator.wikimedia.org/T338922) (owner: 10Richika Rana) [10:27:07] 10MediaWiki-Internationalization, 10Performance-Team, 10Scap, 10Patch-For-Review, 10Release-Engineering-Team (Radar): Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Func) [10:27:11] 10MediaWiki-Internationalization: Page starting with letter i should not redirect to İ but to I in Karakalpak Wikipedia - https://phabricator.wikimedia.org/T335175 (10Qaraqalpaqpan) >>! In T335175#8944904, @Amire80 wrote: > I need to verify something. Please tell me if this is correct: > > - Small `i` must redi... [10:50:09] 10MediaWiki-extensions-CommentStreams: Input field of CommentStreams overlaps other elements - https://phabricator.wikimedia.org/T339364 (10CCicalese_WMF) 05Open→03Resolved [10:51:07] 10MediaWiki-extensions-CommentStreams: Title input field of CommentStreams overflows in mobile phones - https://phabricator.wikimedia.org/T339362 (10cicalese) 05Open→03Resolved [10:51:36] 10MediaWiki-extensions-CommentStreams: CommentStreams adds a white background to VisualEditor - https://phabricator.wikimedia.org/T339361 (10cicalese) 05Open→03Resolved [11:10:15] 10mediawiki-extensions-MediaSpoiler, 10Project-Admins: Create project tag for Extension:MediaSpoiler - https://phabricator.wikimedia.org/T339270 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public project #mediawiki-extensions-MediaSpoiler has been created: https://phabricator.wikimedia.org/proj... [11:10:53] 10MediaWiki-extensions-CommentStreams: "Invalid API response" editing any comment - https://phabricator.wikimedia.org/T326382 (10cicalese) 05Open→03Resolved a:03cicalese Thank you for the bug report! This was fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommentStreams/+/889521. [11:22:41] 10MediaWiki-extensions-CommentStreams: Add support for MobileFrontend - https://phabricator.wikimedia.org/T299739 (10cicalese) [11:33:00] 10MediaWiki-extensions-Quiz, 10I18n: [[MediaWiki:Quiz points/fr]] translation issue - https://phabricator.wikimedia.org/T339804 (10Aklapper) [Please add project tags so tasks can be found in that project - thanks!] [11:48:57] (03CR) 10Jack Phoenix: [C: 04-1] "LGTM (but I didn't test), teeny tiny style nitpicks inline. Happy to +2 this once those are resolved." [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/925250 (owner: 10Evelyn Marie) [11:49:09] 10WPCleaner: Check Wikipedia error 81 doesn't fix automatically anymore - https://phabricator.wikimedia.org/T339245 (10NicoV) Hi @Mastrocom For the parameter, it's already possible to have a priority between parameters : `cite web|surname|publisher|title` will first take surname parameter then publisher then t... [12:05:23] (03CR) 10Jack Phoenix: [C: 04-1] "❤️" [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/921113 (https://phabricator.wikimedia.org/T336989) (owner: 10Jayden Bailey) [12:17:16] (03PS2) 10Daimona Eaytoy: build: Make eslint fail on warnings [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/927760 (https://phabricator.wikimedia.org/T323839) [12:17:27] 10WPCleaner: Check Wikipedia error 81 doesn't fix automatically anymore - https://phabricator.wikimedia.org/T339245 (10NicoV) Hi @Mastrocom , I've added a parameter `error_081_name_max_length_itwiki` in the code that can be used to set a hint for the maximum length of the reference name. I'm interested if we c... [12:20:30] 10CampaignEvents, 10Campaign-Registration, 10Campaign-Tools (Campaign-Tools-Current-Sprint), 10Patch-For-Review: Update the date selectors dynamically so that only dates after the start date can be selected as end date - https://phabricator.wikimedia.org/T305706 (10Daimona) [12:22:07] 10MediaWiki-extensions-CommentStreams: CommentStreams Call to a member function offsetForUser() on null - https://phabricator.wikimedia.org/T303310 (10cicalese) I'm finally having a chance to look at this. I'm sorry for the delay. I think the root cause of this is that I made two separate database changes in ve... [12:26:05] 10WPCleaner: Check Wikipedia error 81 doesn't fix automatically anymore - https://phabricator.wikimedia.org/T339245 (10NicoV) 05Open→03In progress [12:39:18] (03PS1) 10Cicalese: Prevent script from running if the columns are already named correctly [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930896 [12:40:49] (03CR) 10CI reject: [V: 04-1] Prevent script from running if the columns are already named correctly [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930896 (owner: 10Cicalese) [12:41:18] (03PS2) 10Cicalese: Prevent script from running if the columns are already named correctly [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930896 [12:54:09] (03PS3) 10Cicalese: Prevent script from running if the columns are already named correctly [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930896 (https://phabricator.wikimedia.org/T303310) [13:14:23] (03PS1) 10Cicalese: Show disabled comment button when logged out [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930897 (https://phabricator.wikimedia.org/T313103) [13:15:48] 10MediaWiki-extensions-CommentStreams, 10Patch-For-Review: No year displayed, old comments indistinguishable from new - https://phabricator.wikimedia.org/T326508 (10cicalese) p:05Triage→03Medium [13:15:53] 10MediaWiki-extensions-CommentStreams, 10Patch-For-Review: Show comment button for non-logged in users. - https://phabricator.wikimedia.org/T313103 (10cicalese) p:05Triage→03Medium [13:16:01] 10MediaWiki-extensions-CommentStreams, 10Patch-For-Review: CommentStreams Call to a member function offsetForUser() on null - https://phabricator.wikimedia.org/T303310 (10cicalese) p:05Triage→03High [13:27:11] 10MediaWiki-extensions-CommentStreams: Comment report functionality - https://phabricator.wikimedia.org/T322375 (10cicalese) p:05Triage→03Medium [13:39:46] (03CR) 10Cicalese: [C: 03+2] "Thank you for your contribution!" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930801 (https://phabricator.wikimedia.org/T339367) (owner: 10沈澄心) [13:41:37] (03CR) 10CI reject: [V: 04-1] Add view history button to comments, add 'cs-link-button' class to permalink button [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930801 (https://phabricator.wikimedia.org/T339367) (owner: 10沈澄心) [13:45:09] (03PS2) 10Cicalese: Add view history button to comments, add 'cs-link-button' class to permalink button [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930801 (https://phabricator.wikimedia.org/T339367) (owner: 10沈澄心) [13:47:06] (03CR) 10Cicalese: [C: 03+2] Add view history button to comments, add 'cs-link-button' class to permalink button [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930801 (https://phabricator.wikimedia.org/T339367) (owner: 10沈澄心) [13:48:59] (03Merged) 10jenkins-bot: Add view history button to comments, add 'cs-link-button' class to permalink button [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930801 (https://phabricator.wikimedia.org/T339367) (owner: 10沈澄心) [13:49:32] (03PS5) 10Cicalese: Add year and make time format configurable [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930892 (https://phabricator.wikimedia.org/T326508) [13:49:38] (03PS2) 10Cicalese: Don't fail if comment is saved unchanged [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930893 [13:49:44] (03PS4) 10Cicalese: Prevent script from running if the columns are already named correctly [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930896 (https://phabricator.wikimedia.org/T303310) [13:49:54] (03PS2) 10Cicalese: Show disabled comment button when logged out [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/930897 (https://phabricator.wikimedia.org/T313103) [13:54:50] 10MediaWiki-extensions-CommentStreams, 10Patch-For-Review: Add 'view history' button to comments in CommentStreams - https://phabricator.wikimedia.org/T339367 (10cicalese) 05Open→03Resolved [14:09:41] (03PS2) 10Jayden Bailey: Convert ProtectSite to use FormSpecialPage [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/921113 (https://phabricator.wikimedia.org/T336989) [14:10:33] (03PS3) 10Jayden Bailey: Convert ProtectSite to use FormSpecialPage [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/921113 (https://phabricator.wikimedia.org/T336989) [14:12:41] (03CR) 10Jayden Bailey: Convert ProtectSite to use FormSpecialPage (034 comments) [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/921113 (https://phabricator.wikimedia.org/T336989) (owner: 10Jayden Bailey) [15:02:50] (03PS1) 10TheDJ: maintenance script to remove orphaned transcode entries [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/930898 [15:03:01] (03CR) 10CI reject: [V: 04-1] maintenance script to remove orphaned transcode entries [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/930898 (owner: 10TheDJ) [15:34:01] (03PS1) 10Jack Phoenix: Fix up UserProfilePage to use the same cache key for quizzes as QuizGame's SpecialQuizGameHome.php [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/930900 [15:36:26] (03CR) 10Jack Phoenix: [C: 03+2] Fix up UserProfilePage to use the same cache key for quizzes as QuizGame's SpecialQuizGameHome.php [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/930900 (owner: 10Jack Phoenix) [15:38:22] (03Merged) 10jenkins-bot: Fix up UserProfilePage to use the same cache key for quizzes as QuizGame's SpecialQuizGameHome.php [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/930900 (owner: 10Jack Phoenix) [16:02:18] 10MediaWiki-Page-editing, 10MW-1.38-notes, 10Performance-Team (Radar), 10Technical-Debt (Deprecation process), 10User-DannyS712: Reduce public variables and methods in EditPage - https://phabricator.wikimedia.org/T252907 (10Daimona) a:05Daimona→03None [16:20:09] (03CR) 10Esanders: [C: 03+2] Use new helpers to show the post-edit message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/928973 (https://phabricator.wikimedia.org/T338003) (owner: 10Bartosz Dziewoński) [16:38:46] 10IPBee (IP-Blocked Editor Experience), 10Stewards-and-global-tools, 10Community-consensus-needed: Set up a registration portal page to automate the IPBE application process for Chinese users - https://phabricator.wikimedia.org/T336882 (10ZauberViolino) Is it possible for this kind of system to allocate admi... [16:42:21] (03PS1) 10Daimona Eaytoy: Update ambox styles so that they also work on divs [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/930901 (https://phabricator.wikimedia.org/T339040) [16:43:22] 10MinervaNeue, 10Patch-For-Review, 10patch-welcome: Minerva handles amboxes not using tables incorrectly - https://phabricator.wikimedia.org/T339040 (10Daimona) a:03Daimona >>! In T339040#8940856, @Jdlrobson wrote: > I think .client-js .ambox > div.mbox-text would be the appropriate selector here alongside... [16:46:23] 10MinervaNeue, 10Patch-For-Review, 10patch-welcome: Minerva handles amboxes not using tables incorrectly - https://phabricator.wikimedia.org/T339040 (10Daimona) @Jdlrobson Well, now I'm wondering if the class should be called `mbox-text` or `ambox-text` (with a leading "a"). There seems to be some inconsiste... [17:00:54] (03CR) 10CI reject: [V: 04-1] Update ambox styles so that they also work on divs [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/930901 (https://phabricator.wikimedia.org/T339040) (owner: 10Daimona Eaytoy) [17:05:42] 10MinervaNeue, 10Patch-For-Review, 10patch-welcome: Minerva handles amboxes not using tables incorrectly - https://phabricator.wikimedia.org/T339040 (10Izno) `mbox-text` was a preexisting class that was hooked into by Minerva's hacks and should be preferred. [17:25:39] 10MediaWiki-General, 10Platform Engineering Code Jam, 10Platform Engineering Roadmap Decision Making, 10RESTBase, and 2 others: Replace usage of VirtualRESTService in non-WMF deployed extensions - https://phabricator.wikimedia.org/T338643 (10DAlangi_WMF) [17:56:55] (03CR) 10Simon Stier: api: add known slot roles to site- and pageinfo (031 comment) [core] - 10https://gerrit.wikimedia.org/r/927324 (https://phabricator.wikimedia.org/T338099) (owner: 10Simon Stier) [18:14:07] (03CR) 10Umherirrender: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/923706 (https://phabricator.wikimedia.org/T255309) (owner: 10Umherirrender) [18:32:39] (03PS5) 10Tbodt: Support ISO 8601 timestamps in the parser [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/926820 [18:36:02] (03PS6) 10Tbodt: Support ISO 8601 timestamps in the parser [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/926820 [18:36:58] (03PS7) 10Tbodt: Support ISO 8601 timestamps in the parser [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/926820 [18:38:20] (03CR) 10Tbodt: Support ISO 8601 timestamps in the parser (034 comments) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/926820 (owner: 10Tbodt) [18:38:24] (03CR) 10Tbodt: "recheck" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/926820 (owner: 10Tbodt) [19:02:05] 10VideoCutTool: Preview button disabled when user tries to preview again after login - https://phabricator.wikimedia.org/T338683 (10Reputation22) Seems to work fine on prod :( maybe upload a video regarding the same [19:08:22] (03PS5) 10SD0001: Add API module for sending notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/928980 (https://phabricator.wikimedia.org/T58362) [19:08:35] (03CR) 10SD0001: Add API module for sending notifications (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/928980 (https://phabricator.wikimedia.org/T58362) (owner: 10SD0001) [19:12:11] (03PS3) 10SD0001: Avoid using EchoGetDefaultNotifiedUsers hook [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/928994 [19:12:19] (03CR) 10SD0001: Avoid using EchoGetDefaultNotifiedUsers hook (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/928994 (owner: 10SD0001) [19:16:16] (03PS3) 10SD0001: Use dependency injection for hooks [extensions/Echo] - 10https://gerrit.wikimedia.org/r/928987 [19:16:25] (03CR) 10SD0001: Use dependency injection for hooks (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/928987 (owner: 10SD0001) [19:20:03] 10MediaWiki-General, 10Platform Engineering, 10RESTbase Sunsetting, 10API Platform (RESTbase Deprecation Roadmap), and 2 others: Introduce maintenance script for warming cache with Parsoid Outputs - https://phabricator.wikimedia.org/T338922 (10DAlangi_WMF) 05Open→03In progress p:05Triage→03Medium a... [19:20:10] 10MediaWiki-General, 10Platform Engineering, 10RESTbase Sunsetting, 10API Platform (RESTbase Deprecation Roadmap), 10Technical-Debt (Deprecation process): Remove VirtualRESTService - https://phabricator.wikimedia.org/T338921 (10DAlangi_WMF) [19:22:13] 10MediaWiki-General, 10Platform Engineering Code Jam, 10Platform Engineering Roadmap Decision Making, 10RESTBase, and 3 others: Deprecate VirtualRESTService - https://phabricator.wikimedia.org/T179680 (10DAlangi_WMF) [19:23:18] 10MediaWiki-General, 10Platform Engineering Code Jam, 10Platform Engineering Roadmap Decision Making, 10RESTBase, and 3 others: Deprecate VirtualRESTService - https://phabricator.wikimedia.org/T179680 (10DAlangi_WMF) [19:23:28] 10MediaWiki-General, 10Platform Engineering Code Jam, 10Platform Engineering Roadmap Decision Making, 10RESTBase, and 2 others: Replace usage of VirtualRESTService in non-WMF deployed extensions - https://phabricator.wikimedia.org/T338643 (10DAlangi_WMF) 05Open→03In progress p:05Triage→03Low [19:28:01] (03CR) 10CI reject: [V: 04-1] Add API module for sending notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/928980 (https://phabricator.wikimedia.org/T58362) (owner: 10SD0001) [19:32:29] (03CR) 10Daniel Kinzler: Populate parser cache with parsoid output. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/929677 (https://phabricator.wikimedia.org/T338922) (owner: 10Richika Rana) [19:33:28] 10Wikidata-WikiProject-Music: Get rid of P31 = "musical performance" - https://phabricator.wikimedia.org/T339807 (10Moebeus) [19:37:45] (03PS3) 10Daniel Kinzler: REST: loop some services through PageRestHelperFactory [core] - 10https://gerrit.wikimedia.org/r/930852 [19:44:29] 10Wikimedia-Site-requests, 10Russian-Sites: Temporarily implement autoconfirmed-account-requirement for new article creation on ru.wiki - https://phabricator.wikimedia.org/T338059 (10SummerKrut) 05Stalled→03Declined https://ru.wikipedia.org/wiki/Википедия:Голосования/Создание_статей_новичками#Итог [19:55:56] (03CR) 10CI reject: [V: 04-1] REST: loop some services through PageRestHelperFactory [core] - 10https://gerrit.wikimedia.org/r/930852 (owner: 10Daniel Kinzler) [20:06:30] (03CR) 10Krinkle: "Why does this add affectedRows calls? Is this what the code does today? Or is there a bug this is meant to fix?" [core] - 10https://gerrit.wikimedia.org/r/930265 (owner: 10Umherirrender) [20:35:07] (03PS4) 10Umherirrender: rdbms: Remove return value from Delete/UpdateQueryBuilder::execute [core] - 10https://gerrit.wikimedia.org/r/930265 [20:35:21] (03CR) 10Umherirrender: rdbms: Remove return value from Delete/UpdateQueryBuilder::execute (031 comment) [core] - 10https://gerrit.wikimedia.org/r/930265 (owner: 10Umherirrender) [21:02:43] (03CR) 10Krinkle: "I've added a new "Feature" drilldown panel to https://grafana.wikimedia.org/d/000000037/mw-js-deprecate, that should make this easy to ver" [core] - 10https://gerrit.wikimedia.org/r/926744 (owner: 10Fomafix) [22:07:34] 04(no projects): ApiUsageException when searching Commons - https://phabricator.wikimedia.org/T339810 (10Snowmanonahoe) [22:14:00] 04(no projects): ApiUsageException when searching Commons - https://phabricator.wikimedia.org/T339810 (10Novem_Linguae) [22:14:44] 10MediaWiki-Search, 10Discovery-Search, 10Wikimedia-production-error: ApiUsageException when searching Commons - https://phabricator.wikimedia.org/T339810 (10Novem_Linguae) [22:23:14] 10MediaWiki-extensions-Translate: Section editing: Off-by-one error and "empty translation unit" - https://phabricator.wikimedia.org/T58838 (10Pols12) I would close this task as Invalid, since that seems impossible to reproduce with a bit cleaner markup: * with recommended syntax, the unit marker is after the he... [22:25:37] (03CR) 10Daniel Kinzler: WikidataDriver: Use of VirtualRESTService is deprecated (031 comment) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/930853 (https://phabricator.wikimedia.org/T338643) (owner: 10D3r1ck01) [22:37:41] (03PS1) 10Ladsgroup: Blocked domains: Fix removing a domain via the special page [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/930903 (https://phabricator.wikimedia.org/T337431) [22:47:02] 10CirrusSearch, 10Discovery-Search, 10Wikimedia-production-error: ApiUsageException when searching Commons - https://phabricator.wikimedia.org/T339810 (10Aklapper) [22:54:00] 10MediaWiki-extensions-Translate, 10Commons: Categories marked for translation don't have anything translatable, page display title available only if there's another string to translate - https://phabricator.wikimedia.org/T46867 (10Pols12) 05Invalid→03Resolved An empty pair of translate tags now allows to... [22:54:35] (03PS4) 10Evelyn Marie: Migrate to wikitable table class for table output [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/925250 [22:54:37] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/925250 (owner: 10Evelyn Marie) [22:56:24] (03CR) 10Evelyn Marie: "I have gone ahead and fixed the style issues. 😊" [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/925250 (owner: 10Evelyn Marie) [23:07:43] (03CR) 10Evelyn Marie: Migrate to wikitable table class for table output (031 comment) [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/925250 (owner: 10Evelyn Marie) [23:11:25] (03CR) 10Krinkle: rdbms: Remove return value from Delete/UpdateQueryBuilder::execute (031 comment) [core] - 10https://gerrit.wikimedia.org/r/930265 (owner: 10Umherirrender) [23:12:11] (03CR) 10Krinkle: [C: 03+2] rdbms: Remove return value from Delete/UpdateQueryBuilder::execute [core] - 10https://gerrit.wikimedia.org/r/930265 (owner: 10Umherirrender) [23:14:23] (03CR) 10Krinkle: [C: 03+2] Merge sequences of `if` that end doing the same thing anyway [core] - 10https://gerrit.wikimedia.org/r/930621 (owner: 10Thiemo Kreuz (WMDE)) [23:14:40] (03PS4) 10Krinkle: BlockedExternalDomains: Minor code clean up and docs improvement [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/930244 [23:15:52] (03PS6) 10Krinkle: BlockedExternalDomains: Optimize host extraction by using parse_url [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/930250 (https://phabricator.wikimedia.org/T337431) [23:16:04] (03CR) 10Krinkle: "Rebased to resolve conflict with strtolower() change." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/930250 (https://phabricator.wikimedia.org/T337431) (owner: 10Krinkle) [23:16:09] (03PS6) 10Krinkle: BlockedExternalDomains: De-duplicate validateDomain logic [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/930710 (https://phabricator.wikimedia.org/T337431) [23:19:42] (03CR) 10Brian Wolff: "When deprecating something, could you please include a code comment telling people what they are supposed to be using instead (or if there" [core] - 10https://gerrit.wikimedia.org/r/808913 (https://phabricator.wikimedia.org/T302116) (owner: 10Clare Ming) [23:23:34] 10MediaWiki-Internationalization, 10Chinese-Sites: zh-hk should not show Taiwanese date format - https://phabricator.wikimedia.org/T339009 (10Aklapper) [23:25:27] (03PS1) 10Krinkle: SpecialMovePage: Minor code clean up [core] - 10https://gerrit.wikimedia.org/r/930904 [23:33:44] (03Merged) 10jenkins-bot: rdbms: Remove return value from Delete/UpdateQueryBuilder::execute [core] - 10https://gerrit.wikimedia.org/r/930265 (owner: 10Umherirrender) [23:34:53] (03Merged) 10jenkins-bot: Merge sequences of `if` that end doing the same thing anyway [core] - 10https://gerrit.wikimedia.org/r/930621 (owner: 10Thiemo Kreuz (WMDE))