[00:01:13] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/967623 [00:02:07] (03CR) 10Umherirrender: "recheck" [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/967622 (owner: 10Umherirrender) [00:12:54] (03CR) 10CI reject: [V: 04-1] Fix links for Codex documentation [wikimedia/developer-portal] - 10https://gerrit.wikimedia.org/r/967490 (https://phabricator.wikimedia.org/T348167) (owner: 10EpicPupper) [00:15:05] (03CR) 10CI reject: [V: 04-1] Fix duplicate links to Scribe [wikimedia/developer-portal] - 10https://gerrit.wikimedia.org/r/967491 (https://phabricator.wikimedia.org/T348172) (owner: 10EpicPupper) [00:30:45] 10Instrument-ClientError: Make original file/method/line information available from Javascript error logs - https://phabricator.wikimedia.org/T349437 (10Tgr) [00:38:49] (03PS1) 10TrainBranchBot: Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/966839 [00:38:55] (03CR) 10TrainBranchBot: [C: 03+2] Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/966839 (owner: 10TrainBranchBot) [00:41:13] 10Instrument-ClientError: Make original file/method/line information available from Javascript error logs - https://phabricator.wikimedia.org/T349437 (10Tgr) I think there are two ways to do this: * JS error logging goes through a service which fetches the source maps and replaces the stack trace * a browser ext... [00:50:36] (03PS3) 10Daimona Eaytoy: Add test for awfully inconsistent code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/967562 [00:50:47] (03CR) 10Daimona Eaytoy: Add test for awfully inconsistent code (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/967562 (owner: 10Daimona Eaytoy) [00:58:43] (03Merged) 10jenkins-bot: Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/966839 (owner: 10TrainBranchBot) [01:01:03] 10Library-Card-Platform, 10The-Wikipedia-Library, 10Moderator-Tools-Team (Kanban): Wikipedia Library - Fold3 images fail to load correctly via EZProxy - https://phabricator.wikimedia.org/T337913 (10Keith_H99) This was a one-off problem on Thursday October 19th. It is working now, so no further action required. [01:14:09] 10Outreach-Programs-Projects, 10Outreachy (Round 27): Multilingual Wikipedia Editor Survey - https://phabricator.wikimedia.org/T346374 (10ChikaOkeukwu) Thank you for the update @MRaishWMF. [01:25:42] 10MediaWiki-Stakeholders-Group, 10MediaWiki-extensions-GettingStarted, 10Growth-Team, 10Projects-Cleanup: Archive the GettingStarted extension - https://phabricator.wikimedia.org/T292654 (10Aklapper) [01:28:49] 10Diff-blog: Diff RSS feed has stopped working - https://phabricator.wikimedia.org/T345512 (10Aklapper) a:03CKoerner_WMF [01:34:02] 10MediaWiki-Core-AuthManager, 10MediaWiki-Platform-Team, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-Performance-recommendation: CentralAuth: Audit autologin procedure for performance and code quality - https://phabricator.wikimedia.org/T68828 (10Tgr) Edge login seems to be triggered more than it shoul... [01:39:58] 10Data Products (Sprint 02): Investigate reasoning behind volume of Data Products tasks triaged as Unbreak Now - https://phabricator.wikimedia.org/T348808 (10Aklapper) @VirginiaPoundstone: To only "approach things first", please use High priority as it sounds like there is nothing to immediately unbreak here. ("... [01:58:47] 10MediaWiki-extensions-Other, 10BlueSpice: OOJSPlus uses inadequate method for determining relative path - https://phabricator.wikimedia.org/T336567 (10Pppery) 05Open→03Resolved a:03Osnard This is either resolved (since that PR was merged) or invalid (since it's about a codebase that doesn't use Wikimedi... [01:59:33] (03CR) 10DannyS712: [C: 03+2] Add test for awfully inconsistent code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/967562 (owner: 10Daimona Eaytoy) [02:00:06] (03PS3) 10Aklapper: Fix links for Codex documentation [wikimedia/developer-portal] - 10https://gerrit.wikimedia.org/r/967490 (https://phabricator.wikimedia.org/T348167) (owner: 10EpicPupper) [02:00:19] (03Merged) 10jenkins-bot: Add test for awfully inconsistent code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/967562 (owner: 10Daimona Eaytoy) [02:00:46] (03CR) 10Aklapper: "Ran "make build" in Docker to also update po files" [wikimedia/developer-portal] - 10https://gerrit.wikimedia.org/r/967490 (https://phabricator.wikimedia.org/T348167) (owner: 10EpicPupper) [02:01:21] 10MediaWiki-extensions-Other: Extension:UserGroups: TypeError: ManualLogEntry::setComment() - https://phabricator.wikimedia.org/T328242 (10Pppery) 05Open→03Resolved Patch was merged months ago. Assuming this is resolved. [02:02:33] 10MediaWiki-extensions-Other, 10User-Kizule: Convert PhpTagsMaps to use extension registration - https://phabricator.wikimedia.org/T327462 (10Pppery) No response in 9 months. I would assume so. [02:04:26] (03CR) 10Aklapper: [C: 03+1] Fix links for Codex documentation [wikimedia/developer-portal] - 10https://gerrit.wikimedia.org/r/967490 (https://phabricator.wikimedia.org/T348167) (owner: 10EpicPupper) [02:04:58] 10MediaWiki-extensions-Other, 10ci-test-error: CI test error for ContentTransfer - https://phabricator.wikimedia.org/T326947 (10Pppery) 05Open→03Resolved Several patches to that extension have been merged since this 9-month-old ticket and passed CI. Closing as obsolete. [02:15:14] 10Desktop Improvements (Vector 2022), 10MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), 10Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1): It should be possible to enable font size and typography prototype overlay through a URL - https://phabricator.wikimedia.org/T347900 (10Edtadros) a:05Edtadros→03None ===... [02:16:29] 10Desktop Improvements (Vector 2022), 10MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), 10Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1): It should be possible to enable font size and typography prototype overlay through a URL - https://phabricator.wikimedia.org/T347900 (10Edtadros) [02:35:26] 10MinT: Broken Markdown link syntax due to added whitespace - https://phabricator.wikimedia.org/T349438 (10Aklapper) [02:37:48] 10Phabricator, 10Wikimedia-Phabricator-Extensions, 10I18n: People search for MediaWiki User is unreliable and can lack results - https://phabricator.wikimedia.org/T349439 (10Aklapper) [02:38:43] 10Wikimedia-Developer-Portal, 10I18n, 10RTL: Issue with Arabic links on the Dev Portal - https://phabricator.wikimedia.org/T349045 (10Aklapper) 05Open→03Resolved a:03Aklapper I *think* I fixed [all issues in Arabic translations](https://translatewiki.net/w/i.php?title=Special%3AContributions&target=AKl... [02:39:52] 10Trust-and-Safety, 10Wikimedia-Site-requests, 10Elections: Carry out 2023 fawiki Supervisory Council elections - https://phabricator.wikimedia.org/T348448 (10Jeeputer) >>! In T348448#9270316, @jrbs wrote: > My browser automatically translated the page to English which led to adding a lot of translated usern... [02:42:25] 10FY2023-24-WE 2.1 Typography and palette customizations, 10MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), 10Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1): Make Vector feature flags compatible with beta features - https://phabricator.wikimedia.org/T347772 (10Edtadros) a:05Edtadros→03None === Test Result -... [02:43:00] 10FY2023-24-WE 2.1 Typography and palette customizations, 10MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), 10Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1): Make Vector feature flags compatible with beta features - https://phabricator.wikimedia.org/T347772 (10Edtadros) [02:48:49] (03CR) 10DannyS712: "code mostly LGTM but I haven't had a chance to test it" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/961249 (https://phabricator.wikimedia.org/T347435) (owner: 10MusikAnimal) [02:51:19] 10Phabricator, 10Wikimedia-Phabricator-Extensions, 10I18n: People search for MediaWiki User is unreliable and can lack results - https://phabricator.wikimedia.org/T349439 (10Peachey88) Potential dup of {T344677}? [02:58:54] 10Trust-and-Safety, 10Wikimedia-Site-requests, 10Elections: Carry out 2023 fawiki Supervisory Council elections - https://phabricator.wikimedia.org/T348448 (10Sunfyre) >>! In T348448#9270566, @Jeeputer wrote: >>>! In T348448#9270316, @jrbs wrote: >> My browser automatically translated the page to English whi... [03:00:33] 10Desktop Improvements (Vector 2022), 10MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), 10Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1): Zebra: No-js pinned TOC on small viewports doesnt work - https://phabricator.wikimedia.org/T340571 (10Edtadros) a:05Edtadros→03None === Test Result - Beta **Status:** ✅... [03:01:12] 10Desktop Improvements (Vector 2022), 10MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), 10Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1): Zebra: No-js pinned TOC on small viewports doesnt work - https://phabricator.wikimedia.org/T340571 (10Edtadros) [03:05:01] 10Library-Card-Platform, 10The-Wikipedia-Library, 10Moderator-Tools-Team (Kanban): Wikipedia Library - Fold3 images fail to load correctly via EZProxy - https://phabricator.wikimedia.org/T337913 (10jsn.sherman) 05Open→03Resolved Thanks for clarifying. I'm closing this out, but feel free to reopen if it s... [03:06:02] 10Phabricator, 10Wikimedia-Phabricator-Extensions, 10I18n: People search for MediaWiki User is unreliable and can lack results - https://phabricator.wikimedia.org/T349439 (10Aklapper) Unlikely: T344677 is fixed by now, the account in this ticket is 10 months old :) [03:19:55] 10Trust-and-Safety, 10Wikimedia-Site-requests, 10Elections: Carry out 2023 fawiki Supervisory Council elections - https://phabricator.wikimedia.org/T348448 (10Jeeputer) >>! In T348448#9270577, @Sunfyre wrote: > Locked and blocked users should not be deleted. If they vote, they will be checked by bureaucrats... [03:32:23] (03PS10) 10Cmelo: Add fluxx api code to validate the grant id [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964628 (https://phabricator.wikimedia.org/T346959) [03:32:52] (03CR) 10jenkins-bot: Add fluxx api code to validate the grant id [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964628 (https://phabricator.wikimedia.org/T346959) (owner: 10Cmelo) [03:33:51] (03CR) 10Cmelo: "This change is ready for review." (0310 comments) [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/967268 (https://phabricator.wikimedia.org/T343449) (owner: 10Cmelo) [03:35:47] (03PS17) 10Cmelo: Add listener for the submit event data hook [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/963982 (https://phabricator.wikimedia.org/T346957) [03:36:03] (03CR) 10CI reject: [V: 04-1] Add listener for the submit event data hook [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/963982 (https://phabricator.wikimedia.org/T346957) (owner: 10Cmelo) [03:36:05] (03PS10) 10Cmelo: Introduce GrantsStore [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964618 (https://phabricator.wikimedia.org/T346957) [03:36:22] (03PS9) 10Cmelo: Show grantID if exist [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964627 (https://phabricator.wikimedia.org/T346956) [03:36:27] (03CR) 10CI reject: [V: 04-1] Introduce GrantsStore [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964618 (https://phabricator.wikimedia.org/T346957) (owner: 10Cmelo) [03:36:34] (03PS11) 10Cmelo: Add fluxx api code to validate the grant id [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964628 (https://phabricator.wikimedia.org/T346959) [03:36:59] (03CR) 10CI reject: [V: 04-1] Show grantID if exist [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964627 (https://phabricator.wikimedia.org/T346956) (owner: 10Cmelo) [03:37:09] (03CR) 10CI reject: [V: 04-1] Add fluxx api code to validate the grant id [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964628 (https://phabricator.wikimedia.org/T346959) (owner: 10Cmelo) [03:37:36] 10Outreach-Programs-Projects, 10Outreachy (Round 27): Multilingual Wikipedia Editor Survey - https://phabricator.wikimedia.org/T346374 (10AdeoyeD) Thank you for the update @MRaishWMF the information is well understood [03:41:53] 10Phabricator, 10Wikimedia-Phabricator-Extensions: People search for MediaWiki User is unreliable and can lack results - https://phabricator.wikimedia.org/T349439 (10Aklapper) I cannot reproduce this problem locally with the same test case [03:41:59] 10Phabricator, 10Wikimedia-Phabricator-Extensions: People search for MediaWiki User is unreliable and can lack results - https://phabricator.wikimedia.org/T349439 (10Aklapper) p:05Triage→03Low [03:42:39] 10Phabricator, 10Gerrit, 10Wikimedia-GitHub, 10Release-Engineering-Team (Social Piranhas 🐟): Automate or create a check of mirrors of WMF Gerrit git repos into Phabricator Diffusion and Github - https://phabricator.wikimedia.org/T251132 (10Aklapper) [03:59:38] (03PS16) 10Cmelo: Add new hook to add the grant ID field [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/964421 (https://phabricator.wikimedia.org/T346953) [04:02:39] (03PS13) 10Cmelo: Add hook for when submitting the registration data [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/964607 (https://phabricator.wikimedia.org/T346955) [04:02:51] (03CR) 10CI reject: [V: 04-1] Add hook for when submitting the registration data [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/964607 (https://phabricator.wikimedia.org/T346955) (owner: 10Cmelo) [04:18:01] (03PS14) 10Cmelo: Add hook for when submitting the registration data [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/964607 (https://phabricator.wikimedia.org/T346955) [04:35:55] 10Trust-and-Safety, 10Wikimedia-Site-requests, 10Elections: Carry out 2023 fawiki Supervisory Council elections - https://phabricator.wikimedia.org/T348448 (10Jeeputer) [04:36:24] (03PS12) 10Cmelo: Add fluxx api code to validate the grant id [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964628 (https://phabricator.wikimedia.org/T346959) [04:38:03] (03CR) 10Vlakoff: Allow specifying page actions in definitions (031 comment) [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/747112 (https://phabricator.wikimedia.org/T204201) (owner: 10SD0001) [04:39:31] (03CR) 10CI reject: [V: 04-1] Add fluxx api code to validate the grant id [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964628 (https://phabricator.wikimedia.org/T346959) (owner: 10Cmelo) [04:45:11] (03CR) 10Physikerwelt: [C: 03+2] "resubmit" [extensions/Math] - 10https://gerrit.wikimedia.org/r/967596 (https://phabricator.wikimedia.org/T337160) (owner: 10Physikerwelt) [04:46:34] (03PS23) 10Cmelo: Add listener for the hook to add the input field [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/963977 (https://phabricator.wikimedia.org/T346956) [04:49:07] (03PS2) 10Physikerwelt: Make dataProvider in EnWikiFormulaeTest static [extensions/Math] - 10https://gerrit.wikimedia.org/r/967597 (https://phabricator.wikimedia.org/T337160) [04:59:42] 10MediaWiki-extensions-Other, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Wikimedia-GitHub, 10translatewiki.net: Archive the PhpTagsMaps extension/skin - https://phabricator.wikimedia.org/T349441 (10Kizule) [04:59:52] (03PS3) 10Physikerwelt: Make dataProvider in EnWikiFormulaeTest static [extensions/Math] - 10https://gerrit.wikimedia.org/r/967597 (https://phabricator.wikimedia.org/T337160) [04:59:55] 10MediaWiki-extensions-Other: Convert PhpTagsMaps to use extension registration - https://phabricator.wikimedia.org/T327462 (10Kizule) 05Stalled→03Declined a:05Kizule→03None >>! In T327462#9270524, @Pppery wrote: > No response in 9 months. I would assume so. Alright then, thanks. I've created {T349441},... [04:59:57] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Kizule) [05:00:07] 10MediaWiki-extensions-PhpTags, 10Test-Coverage: PhpTagsMaps extension is missing @covers tags - https://phabricator.wikimedia.org/T195155 (10Kizule) 05Open→03Declined Per {T349441}. [05:00:12] (03CR) 10Physikerwelt: Make dataProvider in EnWikiFormulaeTest static (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/967597 (https://phabricator.wikimedia.org/T337160) (owner: 10Physikerwelt) [05:00:41] (03PS18) 10Cmelo: Add listener for the submit event data hook [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/963982 (https://phabricator.wikimedia.org/T346957) [05:01:06] (03PS11) 10Cmelo: Introduce GrantsStore [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964618 (https://phabricator.wikimedia.org/T346957) [05:01:20] (03PS10) 10Cmelo: Show grantID if exist [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964627 (https://phabricator.wikimedia.org/T346956) [05:01:31] (03PS13) 10Cmelo: Add fluxx api code to validate the grant id [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964628 (https://phabricator.wikimedia.org/T346959) [05:02:42] (03Merged) 10jenkins-bot: Make dataProvider in PopupTest static [extensions/Math] - 10https://gerrit.wikimedia.org/r/967596 (https://phabricator.wikimedia.org/T337160) (owner: 10Physikerwelt) [05:04:53] (03CR) 10CI reject: [V: 04-1] Add fluxx api code to validate the grant id [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964628 (https://phabricator.wikimedia.org/T346959) (owner: 10Cmelo) [05:05:13] (03CR) 10CI reject: [V: 04-1] Show grantID if exist [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964627 (https://phabricator.wikimedia.org/T346956) (owner: 10Cmelo) [05:07:14] 10MediaWiki-extensions-Other, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Wikimedia-GitHub, and 2 others: Archive the PhpTagsMaps extension - https://phabricator.wikimedia.org/T349441 (10Kizule) a:03Kizule [05:08:04] (03PS11) 10Cmelo: Show grantID if exist [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964627 (https://phabricator.wikimedia.org/T346956) [05:08:34] (03PS14) 10Cmelo: Add fluxx api code to validate the grant id [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964628 (https://phabricator.wikimedia.org/T346959) [05:09:08] 10MediaWiki-Configuration: [Recurring] Migrate an extension to use extension registration (extension.json) - https://phabricator.wikimedia.org/T183763 (10Pppery) 05Open→03Invalid GCI is long-over. There's a separate task (T98668) to track the general goal of converting all extensions, and thus this ticket is... [05:09:55] (03CR) 10jenkins-bot: Add fluxx api code to validate the grant id [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964628 (https://phabricator.wikimedia.org/T346959) (owner: 10Cmelo) [05:11:19] (03CR) 10CI reject: [V: 04-1] Show grantID if exist [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964627 (https://phabricator.wikimedia.org/T346956) (owner: 10Cmelo) [05:11:22] 10MathSearch, 10NFDI: Fix structured search: Only 4 terms at once - https://phabricator.wikimedia.org/T302793 (10Physikerwelt) 05Open→03Resolved [05:12:30] 10MathSearch, 10Patch-For-Review: MathSearch: Activate OnPageSaveHook - https://phabricator.wikimedia.org/T309193 (10Physikerwelt) 05Open→03Resolved [05:16:19] 10Outreach-Programs-Projects, 10Outreachy (Round 27): Multilingual Wikipedia Editor Survey - https://phabricator.wikimedia.org/T346374 (10ShriyaKT) Hello All,I had a query regarding the submission process for "Multilingual Wikipedia Editor Survey." We have already sent the google doc link and recorded our cont... [05:38:40] (03PS1) 10Physikerwelt: Remove utf8 encode / decode [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967624 (https://phabricator.wikimedia.org/T324173) [05:40:42] 10MediaWiki-extensions-DocBookExport, 10MediaWiki-extensions-ExternalData, 10MediaWiki-extensions-LDAPProvider, 10MediaWiki-extensions-Page_Forms, and 4 others: utf8_encode and utf8_decode are deprecated in php8.2 - https://phabricator.wikimedia.org/T324173 (10Physikerwelt) [05:42:29] (03PS1) 10Physikerwelt: Remove utf8 encode / decode [extensions/Math] - 10https://gerrit.wikimedia.org/r/967625 (https://phabricator.wikimedia.org/T324173) [05:46:18] (03CR) 10CI reject: [V: 04-1] Remove utf8 encode / decode [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967624 (https://phabricator.wikimedia.org/T324173) (owner: 10Physikerwelt) [06:33:49] (03PS1) 10Gergő Tisza: Don't autologin to self when cookie domain is not set [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/967626 [06:38:35] (03CR) 10CI reject: [V: 04-1] Don't autologin to self when cookie domain is not set [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/967626 (owner: 10Gergő Tisza) [06:47:10] (03CR) 10Physikerwelt: "FYI, to reduce the maintenance effort of the Math extension I am planning to remove all explicit database access anyhow, cf. https://phabr" [extensions/Math] - 10https://gerrit.wikimedia.org/r/965923 (https://phabricator.wikimedia.org/T311620) (owner: 10Physikerwelt) [06:49:25] (03PS1) 10Unite together: Updated .gitignore [extensions/HotCat] - 10https://gerrit.wikimedia.org/r/967627 [06:51:06] (03CR) 10CI reject: [V: 04-1] Updated .gitignore [extensions/HotCat] - 10https://gerrit.wikimedia.org/r/967627 (owner: 10Unite together) [07:18:14] (03PS2) 10Physikerwelt: Remove utf8 encode / decode [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967624 (https://phabricator.wikimedia.org/T324173) [07:30:40] 10MediaWiki-extensions-ArrayFunctions: Add case insensitive sort options to #af_sort and #af_keysort - https://phabricator.wikimedia.org/T349443 (10Westgrass) [07:31:14] 10MediaWiki-extensions-ArrayFunctions: Add a case insensitive sort option to #af_sort and #af_keysort - https://phabricator.wikimedia.org/T349443 (10Westgrass) [07:31:56] 10MediaWiki-extensions-ArrayFunctions: Add a case insensitive sort option to #af_sort and #af_keysort - https://phabricator.wikimedia.org/T349443 (10Westgrass) [08:09:31] (03CR) 10Ladsgroup: [C: 03+2] SubscriptionStore: Use InsertQueryBuilder for upsert [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/967601 (owner: 10Bartosz Dziewoński) [08:14:35] (03PS3) 10Ladsgroup: Mass migrate simple cases to use expression builder [core] - 10https://gerrit.wikimedia.org/r/967554 (https://phabricator.wikimedia.org/T210206) [08:15:10] (03Merged) 10jenkins-bot: SubscriptionStore: Use InsertQueryBuilder for upsert [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/967601 (owner: 10Bartosz Dziewoński) [08:16:50] 10Docker-Hub-MediaWiki: Recruit new maintainer for Docker Hub "mediawiki" image - https://phabricator.wikimedia.org/T330367 (10Legoktm) https://github.com/docker-library/official-images/pull/15599 to make this official. [08:17:31] 10Docker-Hub-MediaWiki: Recruit new maintainer for Docker Hub "mediawiki" image - https://phabricator.wikimedia.org/T330367 (10Legoktm) @ChristianHeusel you should have an invite to join the wikimedia/mediawiki-docker repository in your inbox! [08:29:41] (03CR) 10CI reject: [V: 04-1] Mass migrate simple cases to use expression builder [core] - 10https://gerrit.wikimedia.org/r/967554 (https://phabricator.wikimedia.org/T210206) (owner: 10Ladsgroup) [08:37:55] 10Docker-Hub-MediaWiki: Recruit new maintainer for Docker Hub "mediawiki" image - https://phabricator.wikimedia.org/T330367 (10ChristianHeusel) I accepted the invitation 😁👍 [08:44:46] (03PS1) 10Ammarpad: PageEditStas: Deprecate passing Wikipage to parseAndCache() [core] - 10https://gerrit.wikimedia.org/r/967630 [08:53:51] (03CR) 10Ammarpad: [C: 03+2] Add missing hasContentModel to MockTitleTrait [core] - 10https://gerrit.wikimedia.org/r/967476 (owner: 10Thiemo Kreuz (WMDE)) [09:00:15] (03PS1) 10Umherirrender: Replace empty() with falsy check [extensions/ImageSuggestions] - 10https://gerrit.wikimedia.org/r/967631 [09:02:33] 10Capacity Exchange, 10Outreach-Programs-Projects, 10Outreachy (Round 27): Assist Capacity Exchange Development - Task 1 - https://phabricator.wikimedia.org/T347253 (10D_Nafeesah) Hello @Ederporto Here is a link to my first task in contribution to the Assist Capacity Exchange Development Project: [[ https:/... [09:02:56] (03PS2) 10Ammarpad: PageEditStash: Deprecate passing Wikipage to parseAndCache() [core] - 10https://gerrit.wikimedia.org/r/967630 [09:11:43] (03PS4) 10Ladsgroup: Mass migrate simple cases to use expression builder [core] - 10https://gerrit.wikimedia.org/r/967554 (https://phabricator.wikimedia.org/T210206) [09:12:44] (03PS1) 10Umherirrender: Replace empty() with falsy check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/967632 [09:13:27] (03PS1) 10Umherirrender: Replace empty() with falsy check [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/967633 [09:15:55] (03PS1) 10Umherirrender: Replace empty() with null coalesce [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/967634 [09:16:15] (03Merged) 10jenkins-bot: Add missing hasContentModel to MockTitleTrait [core] - 10https://gerrit.wikimedia.org/r/967476 (owner: 10Thiemo Kreuz (WMDE)) [09:22:06] (03CR) 10EarlyWarningBot: [V: 04-1] "Failed command: "npm run selenium-test"" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/967632 (owner: 10Umherirrender) [09:23:07] (03PS1) 10Umherirrender: Replace empty() with string compare [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/967635 [09:27:50] (03PS1) 10Umherirrender: Replace empty() with null compare [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967636 [09:37:03] (03CR) 10Physikerwelt: [C: 03+2] Remove utf8 encode / decode [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967624 (https://phabricator.wikimedia.org/T324173) (owner: 10Physikerwelt) [09:37:49] (03CR) 10CI reject: [V: 04-1] Replace empty() with falsy check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/967632 (owner: 10Umherirrender) [09:40:20] (03CR) 10Umherirrender: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/967632 (owner: 10Umherirrender) [09:44:33] (03PS1) 10Physikerwelt: native: Add onMathRenderingResultRetrieved hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/967640 [09:45:46] (03PS1) 10Umherirrender: Replace empty() with falsy check [skins/Vector] - 10https://gerrit.wikimedia.org/r/967642 [09:54:20] (03Merged) 10jenkins-bot: Remove utf8 encode / decode [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967624 (https://phabricator.wikimedia.org/T324173) (owner: 10Physikerwelt) [09:55:49] (03CR) 10CI reject: [V: 04-1] native: Add onMathRenderingResultRetrieved hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/967640 (owner: 10Physikerwelt) [10:02:31] (03CR) 10CI reject: [V: 04-1] Replace empty() with falsy check [skins/Vector] - 10https://gerrit.wikimedia.org/r/967642 (owner: 10Umherirrender) [10:03:20] (03CR) 10Umherirrender: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/967642 (owner: 10Umherirrender) [10:20:58] (03PS2) 10Physikerwelt: native: Add onMathRenderingResultRetrieved hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/967640 [10:21:12] 10Wiki-Loves-Monuments-Database: Known fields for ua_uk - https://phabricator.wikimedia.org/T346681 (10JeanFred) Checked the logs quickly: ` ERROR: Unknown error occurred when processing country ua in lang uk (1048, "Column 'wd_item' cannot be null") ` So, yeah, this is definitely linked to 0a8c490 :-/ [10:22:28] 10Wiki-Loves-Monuments-Database: Known fields for ua_uk - https://phabricator.wikimedia.org/T346681 (10JeanFred) @Lokal_Profil What do you think ? Is there a proper way to map to wd_item and having it nullable somehow ? Or shall we just revert that mapping? [10:23:35] (03PS1) 10Umherirrender: Replace empty() with falsy check [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967644 [10:23:39] 10Wiki-Loves-Monuments-Database: Known fields for ua_uk - https://phabricator.wikimedia.org/T346681 (10JeanFred) I quickly commented out the wd_item part ` # { # "dest": "wd_item", # "source": "wikidata", # "check": "checkWD" # }, ` so that hopefully next harvest do... [10:32:15] (03CR) 10CI reject: [V: 04-1] native: Add onMathRenderingResultRetrieved hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/967640 (owner: 10Physikerwelt) [10:37:45] 10Outreach-Programs-Projects, 10Outreachy (Round 27): Multilingual Wikipedia Editor Survey - https://phabricator.wikimedia.org/T346374 (10ChinexBoroja) Thank you for the update @MRaishWMF [10:45:14] (03CR) 10Reedy: [C: 03+2] Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/967623 (owner: 10SLF bot) [10:48:04] (03Merged) 10jenkins-bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/967623 (owner: 10SLF bot) [11:16:14] (03PS3) 10Physikerwelt: native: Add onMathRenderingResultRetrieved hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/967640 [11:18:47] (03PS1) 10Paladox: Replace deprecated Hooks::run [extensions/BetaFeatures] (REL1_40) - 10https://gerrit.wikimedia.org/r/967492 (https://phabricator.wikimedia.org/T335536) [11:34:01] (03CR) 10CI reject: [V: 04-1] native: Add onMathRenderingResultRetrieved hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/967640 (owner: 10Physikerwelt) [11:42:58] (03PS2) 10Jack Phoenix: Skip certain keypresses when considering whether to enable the "Save draft" button [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/967546 (https://phabricator.wikimedia.org/T21684) [11:44:01] (03PS4) 10Physikerwelt: native: Add onMathRenderingResultRetrieved hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/967640 [11:50:44] (03CR) 10Brian Wolff: [C: 03+2] Reduce code reviewer anxiety by using typecasts and the MW DBAL properly [extensions/WatchAnalytics] - 10https://gerrit.wikimedia.org/r/967549 (owner: 10Jack Phoenix) [11:53:51] (03Merged) 10jenkins-bot: Reduce code reviewer anxiety by using typecasts and the MW DBAL properly [extensions/WatchAnalytics] - 10https://gerrit.wikimedia.org/r/967549 (owner: 10Jack Phoenix) [11:58:46] (03PS1) 10Physikerwelt: Delete references to old math table [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967645 [12:00:56] (03CR) 10CI reject: [V: 04-1] native: Add onMathRenderingResultRetrieved hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/967640 (owner: 10Physikerwelt) [12:12:09] (03PS1) 10Fomafix: Replace global variables by injected MainConfig [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/967646 [12:25:27] (03CR) 10Physikerwelt: [C: 03+2] Delete references to old math table [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967645 (owner: 10Physikerwelt) [12:26:44] (03CR) 10CI reject: [V: 04-1] Replace global variables by injected MainConfig [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/967646 (owner: 10Fomafix) [12:26:51] (03CR) 10Physikerwelt: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/967640 (owner: 10Physikerwelt) [12:27:15] (03PS1) 10Fomafix: Use namespaced classes [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/967647 [12:27:35] (03CR) 10Fomafix: "recheck" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/967646 (owner: 10Fomafix) [12:41:39] (03Merged) 10jenkins-bot: Delete references to old math table [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967645 (owner: 10Physikerwelt) [12:46:08] (03PS2) 10Fomafix: Replace global variables by injected MainConfig [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/967646 [12:49:06] (03PS1) 10Paladox: Handle the htmlform.enhance hook [extensions/BetaFeatures] (REL1_40) - 10https://gerrit.wikimedia.org/r/967493 (https://phabricator.wikimedia.org/T336933) [12:49:33] (03CR) 10Paladox: "I think this fixes "HTMLForm::getField: no field named betafeatures-auto-enroll" that some users get." [extensions/BetaFeatures] (REL1_40) - 10https://gerrit.wikimedia.org/r/967493 (https://phabricator.wikimedia.org/T336933) (owner: 10Paladox) [12:51:56] (03CR) 10Paladox: Handle the htmlform.enhance hook (031 comment) [extensions/BetaFeatures] (REL1_40) - 10https://gerrit.wikimedia.org/r/967493 (https://phabricator.wikimedia.org/T336933) (owner: 10Paladox) [12:58:45] (03CR) 10Paladox: Handle the htmlform.enhance hook (031 comment) [extensions/BetaFeatures] (REL1_40) - 10https://gerrit.wikimedia.org/r/967493 (https://phabricator.wikimedia.org/T336933) (owner: 10Paladox) [13:08:36] (03CR) 10DannyS712: [C: 03+2] Make dataProvider in EnWikiFormulaeTest static [extensions/Math] - 10https://gerrit.wikimedia.org/r/967597 (https://phabricator.wikimedia.org/T337160) (owner: 10Physikerwelt) [13:09:51] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10Patch-For-Review, 10http-client-hints (Release 1 (all production wikis)): Display client hint data in Special:CheckUser's CheckUser helper table - https://phabricator.wikimedia.org/T340990 (10Dreamy_Jazz) [13:10:16] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10Patch-For-Review, 10http-client-hints (Release 1 (all production wikis)): Display client hint data in Special:CheckUser's CheckUser helper table - https://phabricator.wikimedia.org/T340990 (10Dreamy_Jazz) [13:11:43] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for login events - https://phabricator.wikimedia.org/T345818 (10Dreamy_Jazz) [13:11:46] 10Anti-Harassment, 10CheckUser: Enable read new for the event table migration - https://phabricator.wikimedia.org/T341829 (10Dreamy_Jazz) [13:12:17] 10Anti-Harassment, 10CheckUser: Enable read new for the event table migration - https://phabricator.wikimedia.org/T341829 (10Dreamy_Jazz) [13:12:20] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for login events - https://phabricator.wikimedia.org/T345818 (10Dreamy_Jazz) [13:12:22] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:13:20] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for user account creation events - https://phabricator.wikimedia.org/T345817 (10Dreamy_Jazz) [13:13:24] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:13:26] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for logout events - https://phabricator.wikimedia.org/T345819 (10Dreamy_Jazz) [13:13:28] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:14:22] 10Anti-Harassment, 10CheckUser, 10Epic, 10MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), and 3 others: Create separate tables for log events in CheckUser - https://phabricator.wikimedia.org/T324907 (10Dreamy_Jazz) [13:18:59] 10CheckUser, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for user account creations on loginwiki - https://phabricator.wikimedia.org/T347393 (10Dreamy_Jazz) [13:19:04] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:19:41] 10CheckUser, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for user account creations on loginwiki - https://phabricator.wikimedia.org/T347393 (10Dreamy_Jazz) [13:19:46] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:20:09] 10CheckUser, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for user account creations on loginwiki - https://phabricator.wikimedia.org/T347393 (10Dreamy_Jazz) [13:20:13] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for user account creation events - https://phabricator.wikimedia.org/T345817 (10Dreamy_Jazz) [13:20:17] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:20:27] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for user account creation events - https://phabricator.wikimedia.org/T345817 (10Dreamy_Jazz) [13:20:32] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:20:47] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for user account creation events - https://phabricator.wikimedia.org/T345817 (10Dreamy_Jazz) [13:20:50] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:20:56] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for logout events - https://phabricator.wikimedia.org/T345819 (10Dreamy_Jazz) [13:21:01] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:21:06] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for login events - https://phabricator.wikimedia.org/T345818 (10Dreamy_Jazz) [13:21:10] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:21:17] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for logout events - https://phabricator.wikimedia.org/T345819 (10Dreamy_Jazz) [13:21:20] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:21:27] 10Anti-Harassment, 10CheckUser, 10Google-Chrome-User-Agent-Deprecation, 10http-client-hints (Release 2 (iteration, increase data collection coverage)): Store client hint mapping rows for login events - https://phabricator.wikimedia.org/T345818 (10Dreamy_Jazz) [13:21:31] 10CheckUser, 10Anti-Harassment (AHaT Sprint 32 - Baseball Cap), 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Add read new support to Special:CheckUser for event table migration - https://phabricator.wikimedia.org/T328992 (10Dreamy_Jazz) [13:24:30] (03Merged) 10jenkins-bot: Make dataProvider in EnWikiFormulaeTest static [extensions/Math] - 10https://gerrit.wikimedia.org/r/967597 (https://phabricator.wikimedia.org/T337160) (owner: 10Physikerwelt) [13:28:58] (03Abandoned) 10Paladox: Handle the htmlform.enhance hook [extensions/BetaFeatures] (REL1_40) - 10https://gerrit.wikimedia.org/r/967493 (https://phabricator.wikimedia.org/T336933) (owner: 10Paladox) [13:39:44] (03CR) 10DannyS712: [C: 03+2] Replace empty() with falsy check [extensions/ImageSuggestions] - 10https://gerrit.wikimedia.org/r/967631 (owner: 10Umherirrender) [13:40:01] (03CR) 10DannyS712: [C: 03+2] Replace empty() with null coalesce [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/967634 (owner: 10Umherirrender) [13:40:10] 10BetaFeatures: Adding "betafeatures-auto-enroll" to wgHiddenPrefs causes an exception on Special:Preferences for some users - https://phabricator.wikimedia.org/T349444 (10Paladox) [13:40:16] (03CR) 10DannyS712: [C: 03+2] Replace empty() with string compare [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/967635 (owner: 10Umherirrender) [13:41:20] (03CR) 10DannyS712: [C: 03+2] Replace empty() with null compare (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967636 (owner: 10Umherirrender) [13:41:59] (03PS3) 10Fomafix: Replace global variables by injected MainConfig and MainConfigNames [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/967646 [13:42:05] 10MediaWiki-General, 10MW-1.41-notes (1.41.0-wmf.20; 2023-08-01), 10Patch-For-Review: PHPUnit data providers should be simple static functions that return plain data - https://phabricator.wikimedia.org/T332865 (10Physikerwelt) [13:42:14] (03CR) 10Umherirrender: "Why this backport? There are no deprecation warnings in 1.40 emitted by this function - https://gerrit.wikimedia.org/r/plugins/gitiles/med" [extensions/BetaFeatures] (REL1_40) - 10https://gerrit.wikimedia.org/r/967492 (https://phabricator.wikimedia.org/T335536) (owner: 10Paladox) [13:42:17] (03CR) 10DannyS712: "This change is ready for review." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967494 (owner: 10DannyS712) [13:42:30] (03CR) 10DannyS712: [C: 03+2] Replace empty() with falsy check [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/967633 (owner: 10Umherirrender) [13:43:00] (03CR) 10Paladox: Replace deprecated Hooks::run (031 comment) [extensions/BetaFeatures] (REL1_40) - 10https://gerrit.wikimedia.org/r/967492 (https://phabricator.wikimedia.org/T335536) (owner: 10Paladox) [13:43:04] (03Abandoned) 10Paladox: Replace deprecated Hooks::run [extensions/BetaFeatures] (REL1_40) - 10https://gerrit.wikimedia.org/r/967492 (https://phabricator.wikimedia.org/T335536) (owner: 10Paladox) [13:44:21] (03CR) 10DannyS712: [C: 03+2] Replace empty() with falsy check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/967632 (owner: 10Umherirrender) [13:45:11] (03CR) 10DannyS712: [C: 03+2] Replace empty() with falsy check [skins/Vector] - 10https://gerrit.wikimedia.org/r/967642 (owner: 10Umherirrender) [13:46:00] (03CR) 10DannyS712: [C: 03+2] Replace empty() with falsy check [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967644 (owner: 10Umherirrender) [13:46:14] 10MediaWiki-Action-API, 10MediaWiki-extensions-GlobalPreferences, 10User-TheDJ: Resetting a custom global preference via API does not work - https://phabricator.wikimedia.org/T207448 (10Od1n) I have just encountered this issue. A gadget migrated its options schema, and there are a bunch of old items to clean... [13:46:34] (03CR) 10DannyS712: [C: 03+2] Use namespaced classes [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/967647 (owner: 10Fomafix) [13:47:30] (03CR) 10Umherirrender: "Maybe it needs to be restored? It was removed 10 years ago in Id5221b9242044da2d8168a87975d28e24b0275c3" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967494 (owner: 10DannyS712) [13:48:48] 10MediaWiki-Action-API, 10MediaWiki-extensions-GlobalPreferences, 10User-TheDJ: Resetting a custom global preference via API does not work - https://phabricator.wikimedia.org/T207448 (10Od1n) p:05Triage→03High [13:49:26] (03CR) 10DannyS712: [C: 03+1] "LGTM but would prefer some of the others who reviewed the expression builder patch to have a chance to take a look" [core] - 10https://gerrit.wikimedia.org/r/967613 (owner: 10Bartosz Dziewoński) [13:57:51] (03Merged) 10jenkins-bot: Replace empty() with falsy check [extensions/ImageSuggestions] - 10https://gerrit.wikimedia.org/r/967631 (owner: 10Umherirrender) [13:57:53] (03Merged) 10jenkins-bot: Replace empty() with null coalesce [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/967634 (owner: 10Umherirrender) [13:57:55] (03Merged) 10jenkins-bot: Replace empty() with string compare [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/967635 (owner: 10Umherirrender) [13:57:57] (03Merged) 10jenkins-bot: Replace empty() with null compare [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967636 (owner: 10Umherirrender) [13:59:49] (03PS8) 10Func: preferences: Avoid referencing hidden preferences [core] - 10https://gerrit.wikimedia.org/r/937598 (https://phabricator.wikimedia.org/T341435) [14:03:24] (03CR) 10DannyS712: [C: 03+2] Replace global variables by injected MainConfig and MainConfigNames [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/967646 (owner: 10Fomafix) [14:04:52] (03Merged) 10jenkins-bot: Replace empty() with falsy check [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/967633 (owner: 10Umherirrender) [14:04:58] (03PS1) 10Jack Phoenix: Rewrite a few WHERE conds to use the DBAL more properly [extensions/WatchAnalytics] - 10https://gerrit.wikimedia.org/r/967648 [14:06:28] 10PageTriage: Mock up a 100% Codex front end for PageTriage - https://phabricator.wikimedia.org/T347732 (10Soda) I did some exploratory conversion to mediawiki styling using some of the Codex design tokens and here are the results: | Before | After | | {F39387038} | {F39387024} | | {F39387043} | {F39387026} | I... [14:07:53] (03Merged) 10jenkins-bot: Replace empty() with falsy check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/967632 (owner: 10Umherirrender) [14:10:04] (03CR) 10CI reject: [V: 04-1] Replace empty() with falsy check [skins/Vector] - 10https://gerrit.wikimedia.org/r/967642 (owner: 10Umherirrender) [14:10:42] (03Merged) 10jenkins-bot: Replace empty() with falsy check [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967644 (owner: 10Umherirrender) [14:10:44] (03Merged) 10jenkins-bot: Use namespaced classes [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/967647 (owner: 10Fomafix) [14:13:17] (03PS1) 10Jack Phoenix: Fix bug with the isDiff param passed to ReviewHandler constructor [extensions/WatchAnalytics] - 10https://gerrit.wikimedia.org/r/967649 [14:16:23] (03PS1) 10Jack Phoenix: Make phan almost fully pass [extensions/WatchAnalytics] - 10https://gerrit.wikimedia.org/r/967652 [14:20:01] (03Merged) 10jenkins-bot: Replace global variables by injected MainConfig and MainConfigNames [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/967646 (owner: 10Fomafix) [14:21:36] (03PS2) 10Jack Phoenix: Make phan almost fully pass [extensions/WatchAnalytics] - 10https://gerrit.wikimedia.org/r/967652 [14:23:32] 10MinT: unclosed [[$1 at the end of message to translate - https://phabricator.wikimedia.org/T349445 (10Wladek92) [14:26:50] (03PS1) 10Umherirrender: Replace empty() with string compare [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967654 [14:27:51] (03PS1) 10Umherirrender: Replace empty() with falsy check [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967655 [14:28:25] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [skins/Vector] - 10https://gerrit.wikimedia.org/r/967642 (owner: 10Umherirrender) [14:31:18] 10PageTriage: Mock up a 100% Codex front end for PageTriage - https://phabricator.wikimedia.org/T347732 (10Novem_Linguae) [14:32:04] (03PS1) 10Umherirrender: Replace empty() with bool cast [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/967656 [14:32:30] (03CR) 10DannyS712: [C: 03+2] Replace empty() with falsy check [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967655 (owner: 10Umherirrender) [14:34:39] 10PageTriage: Mock up a 100% Codex front end for PageTriage - https://phabricator.wikimedia.org/T347732 (10Novem_Linguae) Thanks Soda. I like all those changes too, except the blue information icon, which hopefully we can change to a blue exclamation mark. [14:35:21] (03CR) 10DannyS712: ThreadHistoryPager::getFieldNames(): remove dead code (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967494 (owner: 10DannyS712) [14:36:20] (03PS1) 10Umherirrender: Replace empty() with null compare [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/967657 [14:38:21] (03CR) 10CI reject: [V: 04-1] Replace empty() with string compare [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967654 (owner: 10Umherirrender) [14:38:35] (03PS2) 10Umherirrender: Replace empty() with string/null compare [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967654 [14:43:00] (03PS3) 10Umherirrender: Replace empty() with string/null compare [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967654 [14:47:33] (03Merged) 10jenkins-bot: Replace empty() with falsy check [skins/Vector] - 10https://gerrit.wikimedia.org/r/967642 (owner: 10Umherirrender) [14:48:17] (03CR) 10CI reject: [V: 04-1] Replace empty() with bool cast [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/967656 (owner: 10Umherirrender) [14:49:02] (03Merged) 10jenkins-bot: Replace empty() with falsy check [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967655 (owner: 10Umherirrender) [14:50:25] (03PS1) 10Umherirrender: Simplify SkinVector22::isTocAvailable [skins/Vector] - 10https://gerrit.wikimedia.org/r/967658 [14:51:10] (03CR) 10CI reject: [V: 04-1] Replace empty() with null compare [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/967657 (owner: 10Umherirrender) [14:51:50] (03PS1) 10Umherirrender: Remove unneeded empty() call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967659 [14:55:15] (03CR) 10CI reject: [V: 04-1] Replace empty() with string/null compare [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967654 (owner: 10Umherirrender) [14:56:33] 10CheckUser: Re-enable paging for the Get IPs results - https://phabricator.wikimedia.org/T315612 (10Dreamy_Jazz) This may be made easier by T328998. [14:56:51] (03PS4) 10Umherirrender: Replace empty() with string/null compare [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967654 [14:58:50] (03PS1) 10Umherirrender: Remove unneeded empty() after explode() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967660 [14:59:02] (03CR) 10DannyS712: [C: 03+2] Remove unneeded empty() call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967659 (owner: 10Umherirrender) [15:01:58] 10PageTriage: Mock up a 100% Codex front end for PageTriage - https://phabricator.wikimedia.org/T347732 (10Soda) >>! In T347732#9270793, @Novem_Linguae wrote: > Thanks Soda. I like all those changes too, except the blue information icon, which hopefully we can change to a blue exclamation mark. Definitely, I do... [15:02:26] (03Merged) 10jenkins-bot: Remove unneeded empty() call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/967659 (owner: 10Umherirrender) [15:06:58] 10phan: NoEmptyIfDefinedPlugin does not report use of empty() on function call to check the return value - https://phabricator.wikimedia.org/T349446 (10Umherirrender) [15:07:26] 10MinT: unclosed [[$1 at the end of message to translate - https://phabricator.wikimedia.org/T349445 (10Wladek92) [15:10:01] 10PageTriage: Mock up a 100% Codex front end for PageTriage - https://phabricator.wikimedia.org/T347732 (10Novem_Linguae) Seems like a good compromise. Looks good to me. Feel free to code it up. [15:11:41] (03CR) 10DannyS712: [C: 04-1] "aren't we trying to move away from using empty() though? I think its easier to replace the usage in the old code than in the new code" [skins/Vector] - 10https://gerrit.wikimedia.org/r/967658 (owner: 10Umherirrender) [15:14:06] (03CR) 10DannyS712: [C: 04-1] Introduce GrantsStore (033 comments) [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/964618 (https://phabricator.wikimedia.org/T346957) (owner: 10Cmelo) [15:17:21] (03CR) 10DannyS712: [C: 04-1] Add DB schema to store grant ID (035 comments) [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/963981 (https://phabricator.wikimedia.org/T348444) (owner: 10Cmelo) [15:18:53] (03CR) 10DannyS712: [C: 03+2] Replace empty() with string/null compare [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967654 (owner: 10Umherirrender) [15:19:56] (03PS2) 10DannyS712: Remove unneeded empty() after explode() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967660 (owner: 10Umherirrender) [15:20:24] (03CR) 10DannyS712: [C: 03+2] "Technically explode() can return an empty array, just not in this case" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967660 (owner: 10Umherirrender) [15:21:43] (03CR) 10DannyS712: [C: 03+2] Rewrite a few WHERE conds to use the DBAL more properly [extensions/WatchAnalytics] - 10https://gerrit.wikimedia.org/r/967648 (owner: 10Jack Phoenix) [15:37:26] (03Merged) 10jenkins-bot: Replace empty() with string/null compare [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967654 (owner: 10Umherirrender) [15:39:17] (03Merged) 10jenkins-bot: Remove unneeded empty() after explode() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/967660 (owner: 10Umherirrender) [15:39:19] (03Merged) 10jenkins-bot: Rewrite a few WHERE conds to use the DBAL more properly [extensions/WatchAnalytics] - 10https://gerrit.wikimedia.org/r/967648 (owner: 10Jack Phoenix) [15:49:10] (03PS9) 10Func: preferences: Avoid referencing hidden prefs in hide-if or disable-if [core] - 10https://gerrit.wikimedia.org/r/937598 (https://phabricator.wikimedia.org/T341435) [15:51:10] (03CR) 10Func: preferences: Avoid referencing hidden prefs in hide-if or disable-if (031 comment) [core] - 10https://gerrit.wikimedia.org/r/937598 (https://phabricator.wikimedia.org/T341435) (owner: 10Func) [16:01:03] 10UploadWizard: Commons uploads upside-down despite right-side up previews - https://phabricator.wikimedia.org/T338086 (10Jidanni) Yes, as you see on https://commons.wikimedia.org/wiki/File:Aquino_Assassination_Plaque_151054.jpg#filehistory I had to upload a second version. [16:08:56] 10Spike, 10Wikimedia Enterprise (Sprint 49): R&D: investigate use case how to extract or group certain data right now - https://phabricator.wikimedia.org/T346237 (10ROdonnell-WMF) https://arxiv.org/pdf/1707.02459.pdf This is example research on entity type identification from Wikipedia articles. They get abou... [16:32:14] (03PS1) 10Sohom Datta: [WIP] Bring NewPagesFeed inline with Codex/Wikimedia styling [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/967661 (https://phabricator.wikimedia.org/T347732) [16:50:46] (03PS1) 10Daimona Eaytoy: [WIP] Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 [16:50:49] 10MediaWiki-Action-API: API issue - https://phabricator.wikimedia.org/T349447 (10AlexisJazz) [16:53:02] (03PS1) 10Daimona Eaytoy: [WIP] Fix tests [tools/phan] - 10https://gerrit.wikimedia.org/r/967664 [16:53:13] (03CR) 10CI reject: [V: 04-1] [WIP] Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (owner: 10Daimona Eaytoy) [16:53:20] (03PS2) 10Daimona Eaytoy: [WIP] Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 [16:55:25] (03CR) 10CI reject: [V: 04-1] [WIP] Fix tests [tools/phan] - 10https://gerrit.wikimedia.org/r/967664 (owner: 10Daimona Eaytoy) [16:55:58] (03CR) 10CI reject: [V: 04-1] [WIP] Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (owner: 10Daimona Eaytoy) [17:00:16] 10Social-Tools, 10SocialProfile, 10Patch-Needs-Improvement, 10Technical-Debt: Convert SocialProfile to use extension registration - https://phabricator.wikimedia.org/T152865 (10MacFan4000) Noting that if this is not done by the time MW 1.41 releases, then compatibly with scripts such as mergeMessageFileLis... [17:02:13] 10PageTriage, 10Patch-For-Review: Mark as reviewed log entry should mention if it's an article or redirect - https://phabricator.wikimedia.org/T349048 (10Novem_Linguae) Looks like this would also help with tallying points for the NPP backlog drive. Since articles and redirects sometimes have different point va... [17:16:43] 10MediaViewer: MediaViewer displays each image twice when using left/right navigation - https://phabricator.wikimedia.org/T349448 (10Msz2001) [17:21:00] 10All-and-every-Wiktionary, 10Product-Analytics, 10WMF-Communications, 10SEO: Google displays “Wikipedia” as site title for some Wiktionary pages - https://phabricator.wikimedia.org/T348203 (10Msz2001) It's worth noting that mediawiki.org is also labeled as Wikipedia: {F39387735} [17:34:20] (03PS2) 10Daimona Eaytoy: Make PHPUnit tests more robust [tools/phan] - 10https://gerrit.wikimedia.org/r/967664 [17:34:31] (03PS3) 10Daimona Eaytoy: [WIP] Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 [17:36:53] (03CR) 10CI reject: [V: 04-1] [WIP] Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (owner: 10Daimona Eaytoy) [17:49:07] 10Social-Tools, 10SocialProfile, 10Patch-Needs-Improvement, 10Technical-Debt: Convert SocialProfile to use extension registration - https://phabricator.wikimedia.org/T152865 (10ashley) >>! In T152865#9270832, @MacFan4000 wrote: > Noting that if this is not done by the time MW 1.41 releases, then compatibly... [17:53:48] 10WMF-Communications, 10SEO: plwiki has no favicon in Google - https://phabricator.wikimedia.org/T349361 (10Arian_Ar) The same thing has happened with mwwiki, fawiki, and frwiki, as stated on T348203 (I've also sent feedback to Google for fawiki). [18:00:53] (03CR) 10Umherirrender: Simplify SkinVector22::isTocAvailable (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/967658 (owner: 10Umherirrender) [18:04:07] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: Incorrect text positioning in SVG with tspan element and text-anchor attribute - https://phabricator.wikimedia.org/T97233 (10Glrx) >>! In T97233#9249205, @hnowlan wrote: >>>! In T97233#9248038, @Glrx wrote: >> I see fixing this issue as a high priority. It is... [18:04:45] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: Incorrect text positioning in SVG with tspan element and text-anchor attribute - https://phabricator.wikimedia.org/T97233 (10Glrx) 05Stalled→03Open [18:04:48] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: Incorrect text positioning/kerning in SVG rendering (text/tspan x/y, dx/dy attribute; upstream) - https://phabricator.wikimedia.org/T35245 (10Glrx) [18:05:37] 10phan: NoEmptyIfDefinedPlugin treats properties of classes with AllowDynamicProperties as always set - https://phabricator.wikimedia.org/T349432 (10Daimona) a:03Daimona [18:05:40] (03PS4) 10Daimona Eaytoy: Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (https://phabricator.wikimedia.org/T349432) [18:08:07] (03CR) 10CI reject: [V: 04-1] Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (https://phabricator.wikimedia.org/T349432) (owner: 10Daimona Eaytoy) [18:08:49] (03PS2) 10Gergő Tisza: Don't autologin to self when cookie domain is not set [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/967626 [18:11:10] (03CR) 10DannyS712: [C: 03+2] Simplify SkinVector22::isTocAvailable (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/967658 (owner: 10Umherirrender) [18:12:16] (03CR) 10DannyS712: [C: 03+2] Make PHPUnit tests more robust [tools/phan] - 10https://gerrit.wikimedia.org/r/967664 (owner: 10Daimona Eaytoy) [18:12:35] 10Wikimedia-SVG-rendering, 10Upstream: librsvg filter using FillPaint referencing a gradient fill does not work. - https://phabricator.wikimedia.org/T316962 (10Glrx) [18:12:37] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: SVG text-anchor=end confused by tspan with following #text - https://phabricator.wikimedia.org/T200443 (10Glrx) [18:12:43] (03PS5) 10Daimona Eaytoy: Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (https://phabricator.wikimedia.org/T349432) [18:12:44] 10Wikimedia-SVG-rendering: librsvg does not support fallback font set (more than one font family) - https://phabricator.wikimedia.org/T64986 (10Glrx) [18:12:48] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: rsvg does not support the font shorthand style property - https://phabricator.wikimedia.org/T43425 (10Glrx) [18:12:52] 10Structured Data Engineering, 10Structured-Data-Backlog, 10Wikimedia-SVG-rendering: Colorable SVG - https://phabricator.wikimedia.org/T106240 (10Glrx) [18:12:54] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: CSS child selector not supported by rsvg - https://phabricator.wikimedia.org/T43423 (10Glrx) [18:12:57] (03Merged) 10jenkins-bot: Make PHPUnit tests more robust [tools/phan] - 10https://gerrit.wikimedia.org/r/967664 (owner: 10Daimona Eaytoy) [18:12:58] 10Wikimedia-SVG-rendering, 10Chinese-Sites, 10I18n, 10Upstream, 10Vertical-Writing: Han characters in SVG files misplaced and clustered - https://phabricator.wikimedia.org/T65236 (10Glrx) [18:13:00] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: rsvg does not render baseline-shift correctly ( and ) - https://phabricator.wikimedia.org/T7792 (10Glrx) [18:13:02] 10Thumbor, 10Wikimedia-SVG-rendering, 10I18n, 10Upstream: rsvg cannot handle classes/ids with cyrillic alphabet when styling - https://phabricator.wikimedia.org/T43422 (10Glrx) [18:18:18] (03PS6) 10Daimona Eaytoy: Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (https://phabricator.wikimedia.org/T349432) [18:29:38] (03Merged) 10jenkins-bot: Simplify SkinVector22::isTocAvailable [skins/Vector] - 10https://gerrit.wikimedia.org/r/967658 (owner: 10Umherirrender) [18:30:18] 10MediaWiki-extensions-CLDR, 10Internet-Archive, 10MW-1.42-notes (1.42.0-wmf.1; 2023-10-17): Language codes sr-ec and sr-el no longer have English names - https://phabricator.wikimedia.org/T348366 (10Raymond) 05Open→03Resolved a:03Raymond Patch is live [18:30:26] (03PS1) 10Physikerwelt: SWH generalize to non cran use [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967665 [18:38:01] 10MediaWiki-extensions-OAuth: Clarify use of non-confidential OAuth 2.0 clients - https://phabricator.wikimedia.org/T323867 (10Tgr) I would go with #2. The client secret can still be somewhat confidential (e.g. if the app has obfuscated source code), so it can have some value as defense in depth. We can reevalua... [18:41:06] (03PS2) 10Thiemo Kreuz (WMDE): parser: Replace exception with /J modifier in MagicWordArray [core] - 10https://gerrit.wikimedia.org/r/967285 [18:49:13] (03PS1) 10Seb35: Avoid backtracking limit issues from preg_replace [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/967666 (https://phabricator.wikimedia.org/T345319) [18:54:06] (03CR) 10Mainframe98: Use Codex design tokens instead of bundling 'wikimedia-ui-base.less' (031 comment) [skins/Mirage] - 10https://gerrit.wikimedia.org/r/909743 (https://phabricator.wikimedia.org/T272217) (owner: 10Mainframe98) [18:59:17] 10PageTriage, 10MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), 10Moderator-Tools-Team (Kanban): Tagging a redirect for RFD deletion writes the RFD log entry incorrectly - https://phabricator.wikimedia.org/T345485 (10PatchDemoBot) Test wiki on [[ https://patchdemo.wmflabs.org | Patch demo ]] by Sohom Datta using... [19:01:12] 10MediaWiki-Parser, 10CirrusSearch, 10Discovery-Search, 10HtmlFormatter, and 2 others: TypeError: Argument 1 passed to HtmlFormatter\HtmlFormatter::onHtmlReady() must be of the type string, null given, called in /srv/mediawiki/php-1.41.0-wmf.24/vendor/wikimedia/htm... - https://phabricator.wikimedia.org/T345319 [19:11:45] (03CR) 10Seb35: "Accordingly this code is uglier than the preg_repace, but it is not subject to pcre.backtrack_limit." [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/967666 (https://phabricator.wikimedia.org/T345319) (owner: 10Seb35) [19:25:30] 10All-and-every-Wiktionary, 10Product-Analytics, 10WMF-Communications, 10SEO: Google displays “Wikipedia” as site title for some Wiktionary and MediaWiki.org pages - https://phabricator.wikimedia.org/T348203 (10R4356th) [19:31:26] 10All-and-every-Wiktionary, 10Product-Analytics, 10WMF-Communications, 10SEO: Google displays “Wikipedia” as site title for some Wiktionary and MediaWiki.org pages - https://phabricator.wikimedia.org/T348203 (10R4356th) @SCherukuwada, seeing T302625 and that you are working on T325607, could you please tak... [19:32:47] (03PS16) 10Gergő Tisza: exception: Add suppressed errors to "error" channel as level=DEBUG [core] - 10https://gerrit.wikimedia.org/r/338901 (https://phabricator.wikimedia.org/T193472) [19:34:52] 10MediaWiki-extensions-OAuth: Create a refresh token mechanism for owner-only OAuth 2.0 tokens - https://phabricator.wikimedia.org/T268284 (10Tgr) 05Open→03Declined I'll be bold and decline this. Not having to know what OAuth is / to use an OAuth library and explicit authorization flow, and being able to jus... [19:42:11] 10MediaWiki-extensions-OAuth: Add more information to the /identify OAuth endpoint for viewmyprivateinfo / authonlyprivate grants - https://phabricator.wikimedia.org/T151922 (10Tgr) See also the [[https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims|list of standard OIDC claims]]. Most of that in... [19:49:17] 10MediaWiki-Platform-Team, 10MediaWiki-extensions-OAuth, 10CheckUser, 10Voice & Tone: Add warning to OAuth consumer registration form about excessive grants - https://phabricator.wikimedia.org/T288791 (10Tgr) [19:49:37] 10MediaWiki-extensions-OAuth, 10CheckUser, 10Voice & Tone: Add warning to OAuth consumer registration form about excessive grants - https://phabricator.wikimedia.org/T288791 (10Tgr) [19:52:19] 10MediaWiki-Core-AuthManager, 10MediaWiki-Platform-Team, 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Group OAuth grants by riskiness - https://phabricator.wikimedia.org/T290790 (10Tgr) Somehow indicating to app authors which grants they shouldn't request unless they are sure they need them is one of... [19:53:24] 10MediaWiki-extensions-OAuth, 10Patch-Needs-Improvement: Add "under development" stage before "proposed" stage for OAuth consumers - https://phabricator.wikimedia.org/T60937 (10Tgr) [19:54:31] 10MediaWiki-Platform-Team, 10MediaWiki-extensions-OAuth, 10Patch-Needs-Improvement: Owner-only consumers should not expose the user's email address - https://phabricator.wikimedia.org/T142275 (10Tgr) This is a pretty bad privacy leak and easy to fix. [19:56:51] (03CR) 10Physikerwelt: [C: 03+2] SWH generalize to non cran use [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967665 (owner: 10Physikerwelt) [19:57:57] 10MediaWiki-extensions-OAuth, 10MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), 10User-notice: Low-risk OAuth consumers should be automatically approved - https://phabricator.wikimedia.org/T67750 (10Tgr) Although apps with a localhost URL will mostly be covered by {T60937}, I think. [20:00:23] 10FY2023-24-WE 2.1 Typography and palette customizations, 10MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), 10MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), 10Patch-For-Review, and 2 others: Launch Community Prototype - https://phabricator.wikimedia.org/T347208 (10Edtadros) [20:05:26] 10MediaWiki-Stakeholders-Group, 10MediaWiki-extensions-GettingStarted, 10Diffusion-Repository-Administrators, 10Growth-Team, and 3 others: Archive the GettingStarted extension - https://phabricator.wikimedia.org/T292654 (10Pppery) [20:13:19] (03Merged) 10jenkins-bot: SWH generalize to non cran use [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/967665 (owner: 10Physikerwelt) [20:13:45] 10MediaWiki-Platform-Team, 10MediaWiki-extensions-OAuth, 10Privacy Engineering, 10Patch-Needs-Improvement: Owner-only consumers should not expose the user's email address - https://phabricator.wikimedia.org/T142275 (10Aklapper) [20:16:31] 10Desktop Improvements (Vector 2022), 10Web-Team-Backlog: [EPIC] Vector 2022 post-deployment work - https://phabricator.wikimedia.org/T317884 (10Edtadros) [20:18:22] 10Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1): Verify 1.42.0-wmf.1 deployment - https://phabricator.wikimedia.org/T348357 (10Edtadros) [20:23:52] 10Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1): Verify 1.42.0-wmf.1 deployment - https://phabricator.wikimedia.org/T348357 (10Edtadros) [20:31:09] 10Research: Research Showcase: October 2023 - https://phabricator.wikimedia.org/T344824 (10KinneretG) [20:44:43] 10Outreach-Programs-Projects, 10Outreachy (Round 27): Addressing the Lusophone technological wishlist proposals - Task 1 - https://phabricator.wikimedia.org/T347737 (10Anne) Hello I am Anne Machinda and I am interested in contributing to this task. You can find my task 1 link below [[ https://github.com/Lukong... [21:08:04] (03PS1) 10Daimona Eaytoy: Run phan's bootstrap in PHP [tools/phan] - 10https://gerrit.wikimedia.org/r/967667 [21:08:24] (03PS2) 10Daimona Eaytoy: Run phan's bootstrap in PHP [tools/phan] - 10https://gerrit.wikimedia.org/r/967667 [21:16:43] 10Infrastructure-Foundations: Version one feedback - https://phabricator.wikimedia.org/T349450 (10jhathaway) [21:31:49] (03PS1) 10Gergő Tisza: Linker: Split userToolLinks() so it's easier to add extra tools [core] - 10https://gerrit.wikimedia.org/r/967668 [21:32:19] (03PS1) 10Gergő Tisza: Link to user's global accounts in consumer proposal log [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/967669 [21:33:26] (03PS2) 10Gergő Tisza: Linker: Split userToolLinks() so it's easier to add extra tools [core] - 10https://gerrit.wikimedia.org/r/967668 [21:33:32] (03CR) 10CI reject: [V: 04-1] Link to user's global accounts in consumer proposal log [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/967669 (owner: 10Gergő Tisza) [21:33:53] 10Content-Transform-Team, 10Data Products: Follow up on remaining requests to pageviews endpoints - https://phabricator.wikimedia.org/T348731 (10BPirkle) Here is a summary of the current code/config flow discussed above, staring in the [[ https://www.mediawiki.org/wiki/Extension:PageViewInfo | PageViewInfo ext... [21:34:17] (03CR) 10Gergő Tisza: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/967669 (owner: 10Gergő Tisza) [21:40:43] (03PS1) 10Daimona Eaytoy: Make NoEmptyIfDefinedPlugin check all node types except AST_DIM [tools/phan] - 10https://gerrit.wikimedia.org/r/967670 (https://phabricator.wikimedia.org/T349446) [21:41:06] (03PS1) 10MarkAHershberger: Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 [21:41:08] (03PS1) 10MarkAHershberger: Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 [21:41:47] 10phan, 10Patch-For-Review: NoEmptyIfDefinedPlugin does not report use of empty() on function call to check the return value - https://phabricator.wikimedia.org/T349446 (10Daimona) a:03Daimona This was a deliberate choice to try and start with something simple. With the patch above we will check all node typ... [21:41:48] (03PS3) 10Daimona Eaytoy: Run phan's bootstrap in PHPUnit tests [tools/phan] - 10https://gerrit.wikimedia.org/r/967667 [21:42:43] (03CR) 10CI reject: [V: 04-1] Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 (owner: 10MarkAHershberger) [21:42:49] (03CR) 10CI reject: [V: 04-1] Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 (owner: 10MarkAHershberger) [21:45:54] (03PS2) 10MarkAHershberger: Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 [21:45:56] (03PS2) 10MarkAHershberger: Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 [21:46:47] (03CR) 10DannyS712: [C: 03+2] Make NoEmptyIfDefinedPlugin check all node types except AST_DIM [tools/phan] - 10https://gerrit.wikimedia.org/r/967670 (https://phabricator.wikimedia.org/T349446) (owner: 10Daimona Eaytoy) [21:47:30] (03PS3) 10MarkAHershberger: Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 [21:47:35] (03CR) 10CI reject: [V: 04-1] Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 (owner: 10MarkAHershberger) [21:47:37] (03CR) 10CI reject: [V: 04-1] Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 (owner: 10MarkAHershberger) [21:49:06] (03CR) 10CI reject: [V: 04-1] Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 (owner: 10MarkAHershberger) [21:50:11] (03PS4) 10MarkAHershberger: Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 [21:51:03] (03CR) 10Gergő Tisza: [C: 03+2] "This doesn't seem to work (anymore?):" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/797146 (owner: 10Awight) [21:51:49] (03CR) 10CI reject: [V: 04-1] Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 (owner: 10MarkAHershberger) [21:52:21] (03PS3) 10MarkAHershberger: Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 [21:52:23] (03PS5) 10MarkAHershberger: Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 [21:53:59] (03CR) 10CI reject: [V: 04-1] Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 (owner: 10MarkAHershberger) [21:54:03] (03CR) 10CI reject: [V: 04-1] Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 (owner: 10MarkAHershberger) [21:54:06] (03CR) 10DannyS712: Fix NoEmptyIfDefined behaviour with dynamic properties (032 comments) [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (https://phabricator.wikimedia.org/T349432) (owner: 10Daimona Eaytoy) [21:56:02] (03CR) 10DannyS712: [C: 04-1] Linker: Split userToolLinks() so it's easier to add extra tools (031 comment) [core] - 10https://gerrit.wikimedia.org/r/967668 (owner: 10Gergő Tisza) [21:56:33] (03CR) 10Gergő Tisza: [C: 03+2] Allow ES6 syntax in Gruntfile (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/797146 (owner: 10Awight) [21:56:42] (03PS4) 10MarkAHershberger: Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 [21:56:44] (03PS6) 10MarkAHershberger: Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 [21:58:14] (03CR) 10CI reject: [V: 04-1] Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 (owner: 10MarkAHershberger) [21:58:28] (03CR) 10CI reject: [V: 04-1] Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 (owner: 10MarkAHershberger) [22:01:04] 10MediaWiki-Page-history: Visually merge consecutive edits from the same user in histories - https://phabricator.wikimedia.org/T9904 (10waldyrious) Quoting my comment from T35943, for convenience: >>! In T35943#377648, @waldyrious wrote: > There's already a very nice script to accomplish this: https://en.wikipe... [22:03:09] (03PS7) 10Daimona Eaytoy: Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (https://phabricator.wikimedia.org/T349432) [22:03:18] (03CR) 10Daimona Eaytoy: Fix NoEmptyIfDefined behaviour with dynamic properties (031 comment) [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (https://phabricator.wikimedia.org/T349432) (owner: 10Daimona Eaytoy) [22:03:23] (03PS2) 10Gergő Tisza: Link to user's global accounts in consumer proposal log [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/967669 [22:03:25] (03PS1) 10Gergő Tisza: Show links in OAuth management form [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/967673 [22:05:06] 10PageTriage, 10Patch-For-Review: Mock up a 100% Codex front end for PageTriage - https://phabricator.wikimedia.org/T347732 (10PatchDemoBot) Test wiki **created** on [[ https://patchdemo.wmflabs.org | Patch demo ]] by Sohom Datta using patch(es) linked to this task: [[ https://patchdemo.wmflabs.org/wikis/d624f... [22:05:13] (03PS5) 10MarkAHershberger: Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 [22:05:15] (03PS7) 10MarkAHershberger: Change test of `!empty( $value )` to just `$value` [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 [22:07:35] (03CR) 10CI reject: [V: 04-1] Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 (owner: 10MarkAHershberger) [22:09:49] (03PS8) 10MarkAHershberger: Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 [22:10:52] (03Abandoned) 10MarkAHershberger: Some maintenance on master branch [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967671 (owner: 10MarkAHershberger) [22:13:08] (03CR) 10MarkAHershberger: "Instance of phan error: https://integration.wikimedia.org/ci/job/mwext-php74-phan-docker/76755/console" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/967672 (owner: 10MarkAHershberger) [22:22:14] (03CR) 10Gergő Tisza: Linker: Split userToolLinks() so it's easier to add extra tools (031 comment) [core] - 10https://gerrit.wikimedia.org/r/967668 (owner: 10Gergő Tisza) [22:26:09] 10Wikipedia-Android-App-Backlog: Feature Request: Enhancing Android App Translation: Real-Time Message Display in Alpha Version - https://phabricator.wikimedia.org/T348245 (10Seddon) Ah I get you, my apologies. So I think it entirely depends on when the features finally get merged into main as translations can b... [22:39:53] (03CR) 10DannyS712: [C: 04-1] Linker: Split userToolLinks() so it's easier to add extra tools (031 comment) [core] - 10https://gerrit.wikimedia.org/r/967668 (owner: 10Gergő Tisza) [22:41:20] (03CR) 10DannyS712: [C: 03+2] Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (https://phabricator.wikimedia.org/T349432) (owner: 10Daimona Eaytoy) [22:41:50] (03Merged) 10jenkins-bot: Fix NoEmptyIfDefined behaviour with dynamic properties [tools/phan] - 10https://gerrit.wikimedia.org/r/967663 (https://phabricator.wikimedia.org/T349432) (owner: 10Daimona Eaytoy) [23:32:46] 10MediaWiki-Blocks, 10Multiblocks: Split user suppression/hiding (ipb_deleted) out of the ipblocks table - https://phabricator.wikimedia.org/T346716 (10tstarling)